196667 2019-04-05 19:52:50 -0700 REGRESSION(r237196): Web Inspector: Computed panel shouldn't update when it isn't visible 2019-04-06 19:55:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1524956 0 nvasilyev 2019-04-05 19:52:50 -0700 Currently, Computed panel gets updated even when another panel, such as Styles, is selected. There's a lot of unnecessary work happening. This doesn't appear to be a regression. 1524957 1 webkit-bug-importer 2019-04-05 19:54:17 -0700 <rdar://problem/49664912> 1524962 2 nvasilyev 2019-04-05 20:08:20 -0700 It seems like there's logic in-place. However, it has been broken for years and maybe never even worked. GeneralStyleDetailsSidebarPanel.js: visibilityDidChange() { super.visibilityDidChange(); if (!this._panel) return; if (!this.visible) { // <-- NEVER PASSES! this._panel.hidden(); return; } this._updateNoForcedPseudoClassesScrollOffset(); this._panel.shown(); this._panel.markAsNeedsRefresh(this.domNode); } So, what is this `visible` property and why is it always false there. SidebarPanel.js: get visible() { return this.selected && this.parentSidebar && !this.parentSidebar.collapsed; } Okay, the sidebar panel has to be selected to be visible. Sidebar.js: set selectedSidebarPanel(sidebarPanelOrIdentifierOrIndex) { var sidebarPanel = this.findSidebarPanel(sidebarPanelOrIdentifierOrIndex); if (this._selectedSidebarPanel === sidebarPanel) return; if (this._selectedSidebarPanel) { if (this._selectedSidebarPanel.visible) { this._selectedSidebarPanel.hidden(); this._selectedSidebarPanel.visibilityDidChange(); // <-- `visible` is true because `selected` hasn't been set to false yet! } this._selectedSidebarPanel.selected = false; } 1525044 3 nvasilyev 2019-04-06 18:12:51 -0700 Actually, this regressed 6 months ago in https://trac.webkit.org/changeset/237196/webkit. 1525045 4 366895 nvasilyev 2019-04-06 18:23:45 -0700 Created attachment 366895 Patch 1525055 5 366895 commit-queue 2019-04-06 19:55:03 -0700 Comment on attachment 366895 Patch Clearing flags on attachment: 366895 Committed r243964: <https://trac.webkit.org/changeset/243964> 1525056 6 commit-queue 2019-04-06 19:55:05 -0700 All reviewed patches have been landed. Closing bug. 366895 2019-04-06 18:23:45 -0700 2019-04-06 19:55:03 -0700 Patch patch.txt text/plain 2204 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzZDQ4YWJhZWM4Li44ZjYwMmViMGQ5YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDQtMDYgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjM3MTk2KTogV2ViIEluc3BlY3RvcjogQ29tcHV0ZWQgcGFuZWwgc2hvdWxkbid0IHVwZGF0ZSB3 aGVuIGl0IGlzbid0IHZpc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NjY2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk2NjQ5MTI+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwbGljaXRs eSBkZWZpbmUgYGhpZGRlbmAgYW5kIGBzaG93bmAgbWV0aG9kcyBpbnN0ZWFkIG9mIHJlbHlpbmcg b24gU2lkZWJhclBhbmVsJ3MgYHZpc2libGVgIGdldHRlci4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAg KFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnZpc2liaWxpdHlE aWRDaGFuZ2UpOiBEZWxldGVkLgorICAgICAgICAoV0kuR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGVi YXJQYW5lbC5wcm90b3R5cGUuaGlkZGVuKTogQWRkZWQuCisgICAgICAgIChXSS5HZW5lcmFsU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5zaG93bik6IEFkZGVkLgorCiAyMDE5LTAz LTE2ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IENoYW5nZXM6IHN0eWxlIGF0dHJpYnV0ZSBjaGFuZ2VzIGFyZW4ndCBiZWlu ZyB0cmFja2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQ YW5lbC5qcwppbmRleCBkOWIxNjVlMjI0Mi4uZjA5YTk1YzA0OTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNT aWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtNDUsMjAgKzQ1LDI0 IEBAIFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBHZW5lcmFsU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVuCiAgICAgICAgIHJldHVybiBub2RlVG9JbnNwZWN0 Lm5vZGVUeXBlKCkgPT09IE5vZGUuRUxFTUVOVF9OT0RFOwogICAgIH0KIAotICAgIHZpc2liaWxp dHlEaWRDaGFuZ2UoKQorICAgIGhpZGRlbigpCiAgICAgewotICAgICAgICBzdXBlci52aXNpYmls aXR5RGlkQ2hhbmdlKCk7CisgICAgICAgIHN1cGVyLmhpZGRlbigpOworCisgICAgICAgIGlmICh0 aGlzLl9wYW5lbCkKKyAgICAgICAgICAgIHRoaXMuX3BhbmVsLmhpZGRlbigpOworICAgIH0KKwor ICAgIHNob3duKCkKKyAgICB7CisgICAgICAgIHN1cGVyLnNob3duKCk7CiAKICAgICAgICAgaWYg KCF0aGlzLl9wYW5lbCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAoIXRoaXMu dmlzaWJsZSkgewotICAgICAgICAgICAgdGhpcy5fcGFuZWwuaGlkZGVuKCk7Ci0gICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgIH0KKyAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy52aXNpYmxl LCBgU2hvd24gcGFuZWwgJHt0aGlzLl9pZGVudGlmaWVyfSBtdXN0IGJlIHZpc2libGUuYCk7CiAK ICAgICAgICAgdGhpcy5fdXBkYXRlTm9Gb3JjZWRQc2V1ZG9DbGFzc2VzU2Nyb2xsT2Zmc2V0KCk7 Ci0KICAgICAgICAgdGhpcy5fcGFuZWwuc2hvd24oKTsKICAgICAgICAgdGhpcy5fcGFuZWwubWFy a0FzTmVlZHNSZWZyZXNoKHRoaXMuZG9tTm9kZSk7CiAgICAgfQo=