<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196642</bug_id>
          
          <creation_ts>2019-04-05 02:39:54 -0700</creation_ts>
          <short_desc>[GTK][WPE] outlook.live.com displays old-fashioned UI</short_desc>
          <delta_ts>2019-04-25 03:11:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Sergio Villar Senin">svillar</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1524649</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-05 02:39:54 -0700</bug_when>
    <thetext>Outlook email (former hotmail.com) displays a very old interface whenever logging in with WebKitGtk browsers. It isn&apos;t a matter of configuration on the server side because with the very same credentials I can see the new look and feel in any other browser.

Looks like we need to adjust the UA for those domains.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1524652</commentid>
    <comment_count>1</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-05 03:22:54 -0700</bug_when>
    <thetext>Indeed adding a Chrome string just before Safari, for example &quot;Chrome/72.0.3626.81&quot; makes it show the new UI instead of the clunky old one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1524654</commentid>
    <comment_count>2</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-05 03:46:31 -0700</bug_when>
    <thetext>Patch coming soon...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1524657</commentid>
    <comment_count>3</comment_count>
      <attachid>366808</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-05 04:26:54 -0700</bug_when>
    <thetext>Created attachment 366808
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1524703</commentid>
    <comment_count>4</comment_count>
      <attachid>366808</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-04-05 08:28:22 -0700</bug_when>
    <thetext>Comment on attachment 366808
Patch

Can&apos;t you use the Mac platform quirk instead?

    // Microsoft Outlook Web App forces users with WebKitGTK+&apos;s standard user
    // agent to use the light version. Earlier versions even blocks users from
    // accessing the calendar.
    if (domain == &quot;outlook.live.com&quot; || domain == &quot;mail.ntu.edu.tw&quot;)
        return true;

Sadly there are a bazillion hosts running this service and we can&apos;t whitelist them all, but we can whitelist the main one at least.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525092</commentid>
    <comment_count>5</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-07 12:24:42 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #4)
&gt; Comment on attachment 366808 [details]
&gt; Patch
&gt; 
&gt; Can&apos;t you use the Mac platform quirk instead?
&gt; 
&gt;     // Microsoft Outlook Web App forces users with WebKitGTK+&apos;s standard user
&gt;     // agent to use the light version. Earlier versions even blocks users
&gt; from
&gt;     // accessing the calendar.
&gt;     if (domain == &quot;outlook.live.com&quot; || domain == &quot;mail.ntu.edu.tw&quot;)
&gt;         return true;
&gt; 
&gt; Sadly there are a bazillion hosts running this service and we can&apos;t
&gt; whitelist them all, but we can whitelist the main one at least.

Any reason in particular why we prefer to use a different arch instead of adding the Chrome UA? Is it just because we want the server to identify us as a WebKit browser instead of a Chromium one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525095</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-04-07 12:41:19 -0700</bug_when>
    <thetext>It&apos;s a safer quirk, yes. With a Chrome quirk there&apos;s greater risk of breakage if the site starts using Chrome-specific JS in the future, so the macOS quirk should be preferred whenever possible. The Chrome quirk has caused several problems in the past so it should only be used if there are no better options.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525097</commentid>
    <comment_count>7</comment_count>
      <attachid>366908</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-07 15:47:39 -0700</bug_when>
    <thetext>Created attachment 366908
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525140</commentid>
    <comment_count>8</comment_count>
      <attachid>366908</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2019-04-08 01:13:14 -0700</bug_when>
    <thetext>Comment on attachment 366908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366908&amp;action=review

&gt; Source/WebCore/platform/UserAgentQuirks.cpp:64
&gt;  {
&gt; -    String baseDomain = topPrivatelyControlledDomain(url.host().toString());
&gt; +    String domain = url.host().toString();
&gt; +    String baseDomain = topPrivatelyControlledDomain(domain);

This is not needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525147</commentid>
    <comment_count>9</comment_count>
      <attachid>366908</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-08 02:04:04 -0700</bug_when>
    <thetext>Comment on attachment 366908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366908&amp;action=review

&gt;&gt; Source/WebCore/platform/UserAgentQuirks.cpp:64
&gt;&gt; +    String baseDomain = topPrivatelyControlledDomain(domain);
&gt; 
&gt; This is not needed.

Right, forgot to delete it</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525148</commentid>
    <comment_count>10</comment_count>
      <attachid>366922</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-08 02:06:46 -0700</bug_when>
    <thetext>Created attachment 366922
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525149</commentid>
    <comment_count>11</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-08 02:09:09 -0700</bug_when>
    <thetext>Committed r243971: &lt;https://trac.webkit.org/changeset/243971&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1530343</commentid>
    <comment_count>12</comment_count>
      <attachid>366922</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2019-04-25 03:11:17 -0700</bug_when>
    <thetext>Comment on attachment 366922
Patch

Removing r? as the patch already landed</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>366808</attachid>
            <date>2019-04-05 04:26:54 -0700</date>
            <delta_ts>2019-04-07 15:46:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196642-20190405132653.patch</filename>
            <type>text/plain</type>
            <size>3291</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEyMzI2MTc1NTIwNDlm
ZTI2OTdjZDRmM2M0NzFlNDMwM2ZkMmQ1OS4uNmQwZGZkNTg5ZDU1M2IzNmI5NjFlY2YzM2JhMGQx
YzFmNmVlZDllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTA1ICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQ
RV0gb3V0bG9vay5saXZlLmNvbSBkaXNwbGF5cyBvbGQtZmFzaGlvbmVkIFVJCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2NDIKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbmV3IGdvb2QgbG9va2lu
ZyBVSSBpcyBzaG93biBhcyBsb25nIGFzIHdlIGluY2x1ZGUgYSBDaHJvbWUgc3RyaW5nIGluIHRo
ZSBVQS4KKworICAgICAgICAqIHBsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAg
IChXZWJDb3JlOjp1cmxSZXF1aXJlc0Nocm9tZUJyb3dzZXIpOgorCiAyMDE5LTA0LTA1ICBSeW9z
dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV2Vha1B0cjxFbGVt
ZW50PiBwb3NzaWJsZSBhbmQgZGVwbG95IGl0IGluIGZvcm0gYXNzb2NpYXRlZCBlbGVtZW50cyBj
b2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3Mu
Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAppbmRleCBk
YmNiNWY3OTdmYjBmNWI0NmI5N2RlOTA5YzcxZWQwMzdiYjA3ZGJkLi5jYjQ5MjM3MzRiZDdkOTE4
NTI5OGI3Y2YwYjA5ZGM5ZDk5ZDg4NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Vz
ZXJBZ2VudFF1aXJrcy5jcHAKQEAgLTYwLDEzICs2MCwxOCBAQCBzdGF0aWMgYm9vbCBpc0dvb2ds
ZShjb25zdCBVUkwmIHVybCkKIC8vIHRoYXQgd29ya3MgaW4gQ2hyb21lIHRoYXQgV2ViS2l0IGNh
bm5vdCBoYW5kbGUuIFByZWZlciBvdGhlciBxdWlya3MgaW5zdGVhZC4KIHN0YXRpYyBib29sIHVy
bFJlcXVpcmVzQ2hyb21lQnJvd3Nlcihjb25zdCBVUkwmIHVybCkKIHsKLSAgICBTdHJpbmcgYmFz
ZURvbWFpbiA9IHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4odXJsLmhvc3QoKS50b1N0cmlu
ZygpKTsKKyAgICBTdHJpbmcgZG9tYWluID0gdXJsLmhvc3QoKS50b1N0cmluZygpOworICAgIFN0
cmluZyBiYXNlRG9tYWluID0gdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbihkb21haW4pOwog
CiAgICAgLy8gTmVlZGVkIGZvciBmb250cyBvbiBtYW55IHNpdGVzIHRvIHdvcmsgd2l0aCBXZWJL
aXQuCiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI5
NgogICAgIGlmIChiYXNlRG9tYWluID09ICJ0eXBla2l0Lm5ldCIgfHwgYmFzZURvbWFpbiA9PSAi
dHlwZWtpdC5jb20iKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIC8vIE91dGxvb2sgbWFp
bCAoZm9ybWVybHkga25vd24gYXMgaG90bWFpbC5jb20pIGRvZXMgbm90IGRpc3BsYXkgdGhlIG5l
dyBVSS4KKyAgICBpZiAoZG9tYWluID09ICJvdXRsb29rLmxpdmUuY29tIikKKyAgICAgICAgcmV0
dXJuIHRydWU7CisKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0No
YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMTVhN2VkNmE3NzUzNDUzOGE1YzBhNzFh
ZTcyNDBkYWY5OGYyZTgyLi4xMmUzNTcxM2M0NGRmMmU4Y2UxYTZiZDhiNzIzNDg3YzY5MTRjNzM4
IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTMgQEAKKzIwMTktMDQtMDUgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln
YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBvdXRsb29rLmxpdmUuY29tIGRpc3BsYXlz
IG9sZC1mYXNoaW9uZWQgVUkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE5NjY0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5j
cHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOS0wNC0wNCAgU2ltb24g
RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGUgaWZyYW1l
IHNjcm9sbGluZyB0ZXN0IGZhaWxzIHRvIGdldCBhIGNvbXBvc2l0ZWQgc2Nyb2xsaW5nIGZyYW1l
IGluIFdlYktpdFRlc3RSdW5uZXJBcHAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv
VGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U
ZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggZmE0MzIyZTdlZmVkZTBiYzA5
ZjJlMDUyMDExMmNhYjc2MjU4MjliOS4uMDg2OGI4ODE4YjBlNmY1YzhhYjQ3MGU5YThiOTc3YjEy
ZjhiODQxMCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1Vz
ZXJBZ2VudFF1aXJrcy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3Jl
L1VzZXJBZ2VudFF1aXJrcy5jcHAKQEAgLTgwLDYgKzgwLDcgQEAgVEVTVChVc2VyQWdlbnRUZXN0
LCBRdWlya3MpCiAKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNDaHJvbWVCcm93c2VyUXVp
cmsoImh0dHA6Ly90eXBla2l0LmNvbS8iKTsKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXND
aHJvbWVCcm93c2VyUXVpcmsoImh0dHA6Ly90eXBla2l0Lm5ldC8iKTsKKyAgICBhc3NlcnRVc2Vy
QWdlbnRGb3JVUkxIYXNDaHJvbWVCcm93c2VyUXVpcmsoImh0dHA6Ly9vdXRsb29rLmxpdmUuY29t
LyIpOwogCiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGludXhQbGF0Zm9ybVF1aXJrKCJo
dHRwOi8vd3d3Lmdvb2dsZS5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGlu
dXhQbGF0Zm9ybVF1aXJrKCJodHRwOi8vd3d3Lmdvb2dsZS5lcy8iKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>366908</attachid>
            <date>2019-04-07 15:47:39 -0700</date>
            <delta_ts>2019-04-08 02:06:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196642-20190408004719.patch</filename>
            <type>text/plain</type>
            <size>3433</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM4YmJiMjYzNWU5NjA5
NGMxMTQwMzViY2ZjM2NmN2FlMTg0ZWVlYy4uMTM5M2I3ODMwZDc2NWRlODM5YTg3YmNmMTZiNjQ2
ZjQ3ODQwZTlhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTA1ICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQ
RV0gb3V0bG9vay5saXZlLmNvbSBkaXNwbGF5cyBvbGQtZmFzaGlvbmVkIFVJCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2NDIKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbmV3IGdvb2QgbG9va2lu
ZyBVSSBpcyBzaG93biBhcyBsb25nIGFzIHByZXRlbmQgd2UncmUgYSBNYWMgaW4gdGhlIFVBLgor
CisgICAgICAgICogcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OnVybFJlcXVpcmVzQ2hyb21lQnJvd3Nlcik6CisKIDIwMTktMDQtMDYgIEFudHRpIEtvaXZp
c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENvbWJpbmUgZXZlbnQgYW5kIHRvdWNo
IGFjdGlvbiByZWdpb25zIGludG8gYSBzaW5nbGUgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCmluZGV4IGRiY2I1Zjc5N2ZiMGY1YjQ2Yjk3ZGU5MDlj
NzFlZDAzN2JiMDdkYmQuLmFiNDVjY2RlYWU0MWEwMWI1YjMwMDNmMzZmNmNhMjhjNjc4MjNhY2Mg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcApAQCAtNjAs
NyArNjAsOCBAQCBzdGF0aWMgYm9vbCBpc0dvb2dsZShjb25zdCBVUkwmIHVybCkKIC8vIHRoYXQg
d29ya3MgaW4gQ2hyb21lIHRoYXQgV2ViS2l0IGNhbm5vdCBoYW5kbGUuIFByZWZlciBvdGhlciBx
dWlya3MgaW5zdGVhZC4KIHN0YXRpYyBib29sIHVybFJlcXVpcmVzQ2hyb21lQnJvd3Nlcihjb25z
dCBVUkwmIHVybCkKIHsKLSAgICBTdHJpbmcgYmFzZURvbWFpbiA9IHRvcFByaXZhdGVseUNvbnRy
b2xsZWREb21haW4odXJsLmhvc3QoKS50b1N0cmluZygpKTsKKyAgICBTdHJpbmcgZG9tYWluID0g
dXJsLmhvc3QoKS50b1N0cmluZygpOworICAgIFN0cmluZyBiYXNlRG9tYWluID0gdG9wUHJpdmF0
ZWx5Q29udHJvbGxlZERvbWFpbihkb21haW4pOwogCiAgICAgLy8gTmVlZGVkIGZvciBmb250cyBv
biBtYW55IHNpdGVzIHRvIHdvcmsgd2l0aCBXZWJLaXQuCiAgICAgLy8gaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzI5NgpAQCAtOTksNyArMTAwLDcgQEAgc3RhdGlj
IGJvb2wgdXJsUmVxdWlyZXNNYWNpbnRvc2hQbGF0Zm9ybShjb25zdCBVUkwmIHVybCkKICAgICAv
LyBNaWNyb3NvZnQgT3V0bG9vayBXZWIgQXBwIGZvcmNlcyB1c2VycyB3aXRoIFdlYktpdEdUSysn
cyBzdGFuZGFyZCB1c2VyCiAgICAgLy8gYWdlbnQgdG8gdXNlIHRoZSBsaWdodCB2ZXJzaW9uLiBF
YXJsaWVyIHZlcnNpb25zIGV2ZW4gYmxvY2tzIHVzZXJzIGZyb20KICAgICAvLyBhY2Nlc3Npbmcg
dGhlIGNhbGVuZGFyLgotICAgIGlmIChkb21haW4gPT0gIm1haWwubnR1LmVkdS50dyIpCisgICAg
aWYgKGRvbWFpbiA9PSAib3V0bG9vay5saXZlLmNvbSIgfHwgZG9tYWluID09ICJtYWlsLm50dS5l
ZHUudHciKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIEdvb2dsZSBEb2NzIHNob3dz
IGEgc2NhcnkgdW5zdXBwb3J0ZWQgYnJvd3NlciB3YXJuaW5nIHdpdGggV2ViS2l0R1RLKydzCmRp
ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDZjYWJl
N2EyNTRmMTA2NzZiYzk3OTZlNzZmZTI1ZTQ2YjgyMTU3Mi4uYTcyMmI5ZjIzOTkyOGVjNTc3NmQx
NjY5OTJiYmM4MzE3ZDJhNzVmOSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv
b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA0LTA1ICBTZXJnaW8gVmlsbGFy
IFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gb3V0bG9v
ay5saXZlLmNvbSBkaXNwbGF5cyBvbGQtZmFzaGlvbmVkIFVJCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2NDIKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y
ZS9Vc2VyQWdlbnRRdWlya3MuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6IE5l
dyBNYWMgcGxhdGZvcm0gcXVpcmsgdGVzdC4KKwogMjAxOS0wNC0wNiAgUnlvc3VrZSBOaXdhICA8
cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGRlZCB0ZXN0cyBmb3IgV2Vha0hhc2hTZXQ6
OmNvbXB1dGVzRW1wdHkgYW5kIFdlYWtIYXNoU2V0Ojpjb21wdXRlU2l6ZQpkaWZmIC0tZ2l0IGEv
VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAgYi9U
b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcAppbmRl
eCBmYTQzMjJlN2VmZWRlMGJjMDlmMmUwNTIwMTEyY2FiNzYyNTgyOWI5Li4zYTVjNjcyMTM5ODJi
MDBlMGMzN2NjMzgwNzcxMjU2NzM2YzBjYjkwIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0
QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcAorKysgYi9Ub29scy9UZXN0V2Vi
S2l0QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcApAQCAtOTQsNiArOTQsNyBA
QCBURVNUKFVzZXJBZ2VudFRlc3QsIFF1aXJrcykKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxI
YXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vd3d3LmNoYXNlLmNvbS8iKTsKICAgICBhc3NlcnRV
c2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vZG9jcy5nb29nbGUuY29t
LyIpOwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3JtUXVpcmsoImh0dHA6
Ly9wYXlwYWwuY29tLyIpOworICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3Jt
UXVpcmsoImh0dHA6Ly9vdXRsb29rLmxpdmUuY29tLyIpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBU
ZXN0V2ViS2l0QVBJCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>366922</attachid>
            <date>2019-04-08 02:06:46 -0700</date>
            <delta_ts>2019-04-25 03:11:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196642-20190408110645.patch</filename>
            <type>text/plain</type>
            <size>2937</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM4YmJiMjYzNWU5NjA5
NGMxMTQwMzViY2ZjM2NmN2FlMTg0ZWVlYy4uMTM5M2I3ODMwZDc2NWRlODM5YTg3YmNmMTZiNjQ2
ZjQ3ODQwZTlhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTA1ICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQ
RV0gb3V0bG9vay5saXZlLmNvbSBkaXNwbGF5cyBvbGQtZmFzaGlvbmVkIFVJCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2NDIKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbmV3IGdvb2QgbG9va2lu
ZyBVSSBpcyBzaG93biBhcyBsb25nIGFzIHByZXRlbmQgd2UncmUgYSBNYWMgaW4gdGhlIFVBLgor
CisgICAgICAgICogcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OnVybFJlcXVpcmVzQ2hyb21lQnJvd3Nlcik6CisKIDIwMTktMDQtMDYgIEFudHRpIEtvaXZp
c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENvbWJpbmUgZXZlbnQgYW5kIHRvdWNo
IGFjdGlvbiByZWdpb25zIGludG8gYSBzaW5nbGUgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCmluZGV4IGRiY2I1Zjc5N2ZiMGY1YjQ2Yjk3ZGU5MDlj
NzFlZDAzN2JiMDdkYmQuLjA0ZTA2YWY2MzljYzNiZmQzNmE2Y2FiYzBhMmU3YmVjMWFlODJjZTkg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcApAQCAtOTks
NyArOTksNyBAQCBzdGF0aWMgYm9vbCB1cmxSZXF1aXJlc01hY2ludG9zaFBsYXRmb3JtKGNvbnN0
IFVSTCYgdXJsKQogICAgIC8vIE1pY3Jvc29mdCBPdXRsb29rIFdlYiBBcHAgZm9yY2VzIHVzZXJz
IHdpdGggV2ViS2l0R1RLKydzIHN0YW5kYXJkIHVzZXIKICAgICAvLyBhZ2VudCB0byB1c2UgdGhl
IGxpZ2h0IHZlcnNpb24uIEVhcmxpZXIgdmVyc2lvbnMgZXZlbiBibG9ja3MgdXNlcnMgZnJvbQog
ICAgIC8vIGFjY2Vzc2luZyB0aGUgY2FsZW5kYXIuCi0gICAgaWYgKGRvbWFpbiA9PSAibWFpbC5u
dHUuZWR1LnR3IikKKyAgICBpZiAoZG9tYWluID09ICJvdXRsb29rLmxpdmUuY29tIiB8fCBkb21h
aW4gPT0gIm1haWwubnR1LmVkdS50dyIpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8g
R29vZ2xlIERvY3Mgc2hvd3MgYSBzY2FyeSB1bnN1cHBvcnRlZCBicm93c2VyIHdhcm5pbmcgd2l0
aCBXZWJLaXRHVEsrJ3MKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n
ZUxvZwppbmRleCA0NmNhYmU3YTI1NGYxMDY3NmJjOTc5NmU3NmZlMjVlNDZiODIxNTcyLi5hNzIy
YjlmMjM5OTI4ZWM1Nzc2ZDE2Njk5MmJiYzgzMTdkMmE3NWY5IDEwMDY0NAotLS0gYS9Ub29scy9D
aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDQt
MDUgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAg
W0dUS11bV1BFXSBvdXRsb29rLmxpdmUuY29tIGRpc3BsYXlzIG9sZC1mYXNoaW9uZWQgVUkKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjY0MgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktp
dEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHA6CisgICAgICAgIChUZXN0V2Vi
S2l0QVBJOjpURVNUKTogTmV3IE1hYyBwbGF0Zm9ybSBxdWlyayB0ZXN0LgorCiAyMDE5LTA0LTA2
ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZGVkIHRlc3Rz
IGZvciBXZWFrSGFzaFNldDo6Y29tcHV0ZXNFbXB0eSBhbmQgV2Vha0hhc2hTZXQ6OmNvbXB1dGVT
aXplCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFn
ZW50UXVpcmtzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdl
bnRRdWlya3MuY3BwCmluZGV4IGZhNDMyMmU3ZWZlZGUwYmMwOWYyZTA1MjAxMTJjYWI3NjI1ODI5
YjkuLjNhNWM2NzIxMzk4MmIwMGUwYzM3Y2MzODA3NzEyNTY3MzZjMGNiOTAgMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCisr
KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3Bw
CkBAIC05NCw2ICs5NCw3IEBAIFRFU1QoVXNlckFnZW50VGVzdCwgUXVpcmtzKQogICAgIGFzc2Vy
dFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3JtUXVpcmsoImh0dHA6Ly93d3cuY2hhc2UuY29t
LyIpOwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc01hY1BsYXRmb3JtUXVpcmsoImh0dHA6
Ly9kb2NzLmdvb2dsZS5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTWFjUGxh
dGZvcm1RdWlyaygiaHR0cDovL3BheXBhbC5jb20vIik7CisgICAgYXNzZXJ0VXNlckFnZW50Rm9y
VVJMSGFzTWFjUGxhdGZvcm1RdWlyaygiaHR0cDovL291dGxvb2subGl2ZS5jb20vIik7CiB9CiAK
IH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK
</data>

          </attachment>
      

    </bug>

</bugzilla>