196634 2019-04-04 16:46:27 -0700 Element::isFocusable() debug asserts too frequently 2019-04-04 18:09:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez cmarcelo commit-queue conrad_shultz dbates esprehn+autocc ews-watchlist ggaren kangil.han koivisto simon.fraser oldest_to_newest 1524510 0 rniwa 2019-04-04 16:46:27 -0700 Element::isFocusable() debug asserts too frequently 1524511 1 366770 rniwa 2019-04-04 16:47:12 -0700 Created attachment 366770 Disables the assertion 1524515 2 366770 ggaren 2019-04-04 16:52:10 -0700 Comment on attachment 366770 Disables the assertion View in context: https://bugs.webkit.org/attachment.cgi?id=366770&action=review Can you cite a bug report with steps to reproduce in this FIXME? If we just keep an abstract FIXME, we're preventing future developers from adding that assertion back. > Source/WebCore/dom/Element.cpp:556 > + // FIXME: We should be ablet to assert !needsStyleRecalc() || !document().childNeedsStyleRecalc(). able 1524517 3 rniwa 2019-04-04 16:54:58 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 366770 [details] > Disables the assertion > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366770&action=review > > Can you cite a bug report with steps to reproduce in this FIXME? Apparently this happens on Gmail and Microsoft Exchange (website). I can add that to FIXME. 1524518 4 conrad_shultz 2019-04-04 16:55:07 -0700 rdar://problem/45729622 1524520 5 366773 rniwa 2019-04-04 16:56:23 -0700 Created attachment 366773 Updated the comment 1524521 6 366773 ggaren 2019-04-04 16:58:16 -0700 Comment on attachment 366773 Updated the comment r=me 1524560 7 366773 rniwa 2019-04-04 18:09:45 -0700 Comment on attachment 366773 Updated the comment Clearing flags on attachment: 366773 Committed r243923: <https://trac.webkit.org/changeset/243923> 1524561 8 rniwa 2019-04-04 18:09:47 -0700 All reviewed patches have been landed. Closing bug. 366770 2019-04-04 16:47:12 -0700 2019-04-04 16:56:21 -0700 Disables the assertion bug-196634-20190404164712.patch text/plain 1415 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTA0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVsZW1lbnQ6OmlzRm9jdXNhYmxl KCkgZGVidWcgYXNzZXJ0cyB0b28gZnJlcXVlbnRseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBkZWJ1ZyBhc3NlcnRpb24gZm9yIG5v dy4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1l bnQ6OmlzRm9jdXNhYmxlIGNvbnN0KToKKwogMjAxOS0wNC0wNCAgU2hhd24gUm9iZXJ0cyAgPHNy b2JlcnRzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQz ODY4LgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMjQzOTE3KQorKysgU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NTMsNyArNTUz LDcgQEAgYm9vbCBFbGVtZW50Ojppc0ZvY3VzYWJsZSgpIGNvbnN0CiAgICAgaWYgKCFyZW5kZXJl cigpKSB7CiAgICAgICAgIC8vIElmIHRoZSBub2RlIGlzIGluIGEgZGlzcGxheTpub25lIHRyZWUg aXQgbWlnaHQgc2F5IGl0IG5lZWRzIHN0eWxlIHJlY2FsYyBidXQKICAgICAgICAgLy8gdGhlIHdo b2xlIGRvY3VtZW50IGlzIGFjdHVhbGx5IHVwIHRvIGRhdGUuCi0gICAgICAgIEFTU0VSVCghbmVl ZHNTdHlsZVJlY2FsYygpIHx8ICFkb2N1bWVudCgpLmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpKTsK KyAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBiZSBhYmxldCB0byBhc3NlcnQgIW5lZWRzU3R5 bGVSZWNhbGMoKSB8fCAhZG9jdW1lbnQoKS5jaGlsZE5lZWRzU3R5bGVSZWNhbGMoKS4KIAogICAg ICAgICAvLyBFbGVtZW50cyBpbiBjYW52YXMgZmFsbGJhY2sgY29udGVudCBhcmUgbm90IHJlbmRl cmVkLCBidXQgdGhleSBhcmUgYWxsb3dlZCB0byBiZQogICAgICAgICAvLyBmb2N1c2FibGUgYXMg bG9uZyBhcyB0aGVpciBjYW52YXMgaXMgZGlzcGxheWVkIGFuZCB2aXNpYmxlLgo= 366773 2019-04-04 16:56:23 -0700 2019-04-04 18:09:45 -0700 Updated the comment bug-196634-20190404165622.patch text/plain 1499 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTA0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEVsZW1lbnQ6OmlzRm9jdXNhYmxl KCkgZGVidWcgYXNzZXJ0cyB0b28gZnJlcXVlbnRseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBkZWJ1ZyBhc3NlcnRpb24gZm9yIG5v dy4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1l bnQ6OmlzRm9jdXNhYmxlIGNvbnN0KToKKwogMjAxOS0wNC0wNCAgU2hhd24gUm9iZXJ0cyAgPHNy b2JlcnRzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQz ODY4LgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMjQzOTE3KQorKysgU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NTMsNyArNTUz LDggQEAgYm9vbCBFbGVtZW50Ojppc0ZvY3VzYWJsZSgpIGNvbnN0CiAgICAgaWYgKCFyZW5kZXJl cigpKSB7CiAgICAgICAgIC8vIElmIHRoZSBub2RlIGlzIGluIGEgZGlzcGxheTpub25lIHRyZWUg aXQgbWlnaHQgc2F5IGl0IG5lZWRzIHN0eWxlIHJlY2FsYyBidXQKICAgICAgICAgLy8gdGhlIHdo b2xlIGRvY3VtZW50IGlzIGFjdHVhbGx5IHVwIHRvIGRhdGUuCi0gICAgICAgIEFTU0VSVCghbmVl ZHNTdHlsZVJlY2FsYygpIHx8ICFkb2N1bWVudCgpLmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpKTsK KyAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBiZSBhYmxlIHRvIGFzc2VydCAhbmVlZHNTdHls ZVJlY2FsYygpIHx8ICFkb2N1bWVudCgpLmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpCisgICAgICAg IC8vIGJ1dCBpdCBoaXRzIHRvbyBmcmVxdWVudGx5IG9uIHdlYnNpdGVzIGxpa2UgR21haWwgYW5k IE1pY3Jvc29mdCBFeGNoYW5nZS4KIAogICAgICAgICAvLyBFbGVtZW50cyBpbiBjYW52YXMgZmFs bGJhY2sgY29udGVudCBhcmUgbm90IHJlbmRlcmVkLCBidXQgdGhleSBhcmUgYWxsb3dlZCB0byBi ZQogICAgICAgICAvLyBmb2N1c2FibGUgYXMgbG9uZyBhcyB0aGVpciBjYW52YXMgaXMgZGlzcGxh eWVkIGFuZCB2aXNpYmxlLgo=