196618 2019-04-04 12:16:08 -0700 [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue 2019-08-01 04:49:01 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200333 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1524353 0 aakash_jain 2019-04-04 12:16:08 -0700 In the new EWS, we have separated builders and testers. A build is done by a builder queue, and then it triggers the tester queue. While a patch is waiting in the testers queue (e.g.: api-mac), instead of showing 'waiting in queue', the status-bubble for 'api-mac' should display the build information from the corresponding builder queue 'mac'. For e.g.: while the patch is waiting on api-mac queue, it's status-bubble should show the information from 'mac' queue. It would let the user know that the patch has been compiled successfully and is waiting for API tests, or the patch failed to compile (and so API tests won't be run on it). 1524358 1 366738 aakash_jain 2019-04-04 12:25:40 -0700 Created attachment 366738 Patch 1524377 2 366738 lforschler 2019-04-04 13:11:30 -0700 Comment on attachment 366738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366738&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:155 > + return (None, None) would it make sense to re-arrange this if statement above the other? then you don't need to check for 'builds' twice. So it would read like: if not builds: return (None, None) if parent_queue: builds = self.get_builds_for_queue(patch, parent_queue) is_parent_build = True 1524382 3 366738 aakash_jain 2019-04-04 13:17:53 -0700 Comment on attachment 366738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366738&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:155 >> + return (None, None) > > would it make sense to re-arrange this if statement above the other? then you don't need to check for 'builds' twice. So it would read like: > > if not builds: > return (None, None) > if parent_queue: > builds = self.get_builds_for_queue(patch, parent_queue) > is_parent_build = True That would change the logic and parent_queue would never be checked. The logic I want to implement is: - get_builds_for_queue 'api-mac' - if no builds found and parent_queue is passed, then get_builds_for_queue parent (e.g.: mac) - if parent queue also doesn't have any build, then return None - if builds found in any of above step, use that 1524483 4 366738 commit-queue 2019-04-04 15:44:43 -0700 Comment on attachment 366738 Patch Clearing flags on attachment: 366738 Committed r243914: <https://trac.webkit.org/changeset/243914> 1524484 5 commit-queue 2019-04-04 15:44:45 -0700 All reviewed patches have been landed. Closing bug. 1524485 6 webkit-bug-importer 2019-04-04 15:45:26 -0700 <rdar://problem/49626216> 366738 2019-04-04 12:25:40 -0700 2019-04-04 15:44:43 -0700 Patch bug-196618-20190404152635.patch text/plain 4310 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzg4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gd2hpbGUgd2FpdGluZyBpbiBxdWV1ZSBzdGF0dXMtYnVi YmxlIGZvciB0ZXN0ZXJzIHF1ZXVlcyBzaG91bGQgZGlzcGxheSBidWlsZCBpbmZvcm1hdGlvbiBm cm9tIGJ1aWxkZXIgcXVldWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NjYxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnVi YmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlKTogQWRkZWQgUVVFVUVfVFJJR0dFUlMuCisg ICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6IEdldCB0aGUgYnVpbGQgZnJvbSBi dWlsZGVyIGlmIHRlc3RlciBoYXMgbm90IHN0YXJ0ZWQgdGhlIGJ1aWxkIHlldC4KKyAgICAgICAg KFN0YXR1c0J1YmJsZS5fZ2V0X3BhcmVudF9xdWV1ZSk6IEdldCB0aGUgbmFtZSBvZiB0aGUgcGFy ZW50IChidWlsZGVyKSBxdWV1ZS4KKyAgICAgICAgKFN0YXR1c0J1YmJsZS5nZXRfbGF0ZXN0X2J1 aWxkX2Zvcl9xdWV1ZSk6IElmIHRoZSBxdWV1ZSBkb2Vzbid0IGhhdmUgYW55IGJ1aWxkIHlldCwg cmV0dXJuIGJ1aWxkIGluZm9ybWF0aW9uIGZyb20KKyAgICAgICAgaXRzIHBhcmVudChidWlsZGVy KS4KKwogMjAxOS0wNC0wNCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbl0gRHVtcFJlbmRlclRyZWVXYXRjaERvZy5weSBpcyBub3QgY2hlY2tlZCBp bnRvIHNvdXJjZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmll d3Mvc3RhdHVzYnViYmxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkocmV2aXNpb24gMjQzODg4KQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCwxMSBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmll dyk6CiAgICAgQUxMX1FVRVVFUyA9IFsnYXBpLWlvcycsICdhcGktbWFjJywgJ2JpbmRpbmdzJywg J2d0aycsICdpb3MnLCAnaW9zLXNpbScsICdpb3Mtd2syJywgJ2pzYycsICdtYWMnLCAnbWFjLTMy Yml0JywgJ21hYy0zMmJpdC13azInLAogICAgICAgICAgICAgICAgICAgICAnbWFjLWRlYnVnJywg J21hYy1kZWJ1Zy13azEnLCAnbWFjLXdrMScsICdtYWMtd2syJywgJ3N0eWxlJywgJ3dlYmtpdHBl cmwnLCAnd2Via2l0cHknLCAnd2luJywgJ3dpbmNhaXJvJywgJ3dwZSddCiAgICAgRU5BQkxFRF9R VUVVRVMgPSBbJ2FwaS1pb3MnLCAnYXBpLW1hYycsICd3ZWJraXRwZXJsJ10KKyAgICAjIEZJWE1F OiBBdXRvLWdlbmVyYXRlIHRoZSBxdWV1ZSdzIHRyaWdnZXIgcmVsYXRpb25zaGlwCisgICAgUVVF VUVfVFJJR0dFUlMgPSB7CisgICAgICAgICdhcGktaW9zJzogJ2lvcy1zaW0nLAorICAgICAgICAn YXBpLW1hYyc6ICdtYWMnLAorICAgIH0KIAogICAgIFNURVBTX1RPX0hJREUgPSBbJ0tpbGxlZCBv bGQgcHJvY2Vzc2VzJywgJ0NvbmZpZ3VyZWQgYnVpbGQnLCAnXk9TOi4qWGNvZGU6J10KIApAQCAt NDcsNyArNTIsNyBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgIGJ1YmJsZSA9 IHsKICAgICAgICAgICAgICduYW1lJzogcXVldWUsCiAgICAgICAgIH0KLSAgICAgICAgYnVpbGQg PSBzZWxmLmdldF9sYXRlc3RfYnVpbGRfZm9yX3F1ZXVlKHBhdGNoLCBxdWV1ZSkKKyAgICAgICAg YnVpbGQsIGlzX3BhcmVudF9idWlsZCA9IHNlbGYuZ2V0X2xhdGVzdF9idWlsZF9mb3JfcXVldWUo cGF0Y2gsIHF1ZXVlLCBzZWxmLl9nZXRfcGFyZW50X3F1ZXVlKHF1ZXVlKSkKICAgICAgICAgaWYg bm90IHNlbGYuX3Nob3VsZF9zaG93X2J1YmJsZV9mb3JfYnVpbGQoYnVpbGQpOgogICAgICAgICAg ICAgcmV0dXJuIE5vbmUKIApAQCAtNjMsOCArNjgsMTIgQEAgY2xhc3MgU3RhdHVzQnViYmxlKFZp ZXcpOgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ3N0YXJ0ZWQnCiAgICAgICAgICAg ICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ0J1aWxkIGlzIGluLXByb2dyZXNzLiBSZWNl bnQgbWVzc2FnZXM6XG5cbicgKyBzZWxmLl9zdGVwc19tZXNzYWdlcyhidWlsZCkKICAgICAgICAg ZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuU1VDQ0VTUzoKLSAgICAgICAgICAgIGJ1YmJs ZVsnc3RhdGUnXSA9ICdwYXNzJwotICAgICAgICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2Un XSA9ICdQYXNzJworICAgICAgICAgICAgaWYgaXNfcGFyZW50X2J1aWxkOgorICAgICAgICAgICAg ICAgIGJ1YmJsZVsnc3RhdGUnXSA9ICdzdGFydGVkJworICAgICAgICAgICAgICAgIGJ1YmJsZVsn ZGV0YWlsc19tZXNzYWdlJ10gPSAnQnVpbGQgaXMgaW4tcHJvZ3Jlc3MuIFJlY2VudCBtZXNzYWdl czpcblxuJyArIHNlbGYuX3N0ZXBzX21lc3NhZ2VzKGJ1aWxkKSArICdcblxuV2FpdGluZyB0byBy dW4gdGVzdHMuJworICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICBidWJibGVbJ3N0 YXRlJ10gPSAncGFzcycKKyAgICAgICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSdd ID0gJ1Bhc3MnCiAgICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IEJ1aWxkYm90LldBUk5JTkdT OgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ3Bhc3MnCiAgICAgICAgICAgICBidWJi bGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhcm5pbmdcblxuJyArIHNlbGYuX3N0ZXBzX21lc3Nh Z2VzKGJ1aWxkKQpAQCAtMTA3LDYgKzExNiw5IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToK IAogICAgICAgICByZXR1cm4gYnViYmxlCiAKKyAgICBkZWYgX2dldF9wYXJlbnRfcXVldWUoc2Vs ZiwgcXVldWUpOgorICAgICAgICByZXR1cm4gU3RhdHVzQnViYmxlLlFVRVVFX1RSSUdHRVJTLmdl dChxdWV1ZSkKKwogICAgIGRlZiBnZXRfb3NfZGV0YWlscyhzZWxmLCBidWlsZCk6CiAgICAgICAg IGZvciBzdGVwIGluIGJ1aWxkLnN0ZXBfc2V0LmFsbCgpOgogICAgICAgICAgICAgaWYgc3RlcC5z dGF0ZV9zdHJpbmcuc3RhcnRzd2l0aCgnT1M6Jyk6CkBAIC0xMzMsMTIgKzE0NSwxNiBAQCBjbGFz cyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgICAgICByZXR1cm4gJycKICAgICAgICAgcmV0 dXJuIHJlY2VudF9zdGVwLnN0YXRlX3N0cmluZwogCi0gICAgZGVmIGdldF9sYXRlc3RfYnVpbGRf Zm9yX3F1ZXVlKHNlbGYsIHBhdGNoLCBxdWV1ZSk6CisgICAgZGVmIGdldF9sYXRlc3RfYnVpbGRf Zm9yX3F1ZXVlKHNlbGYsIHBhdGNoLCBxdWV1ZSwgcGFyZW50X3F1ZXVlPU5vbmUpOgogICAgICAg ICBidWlsZHMgPSBzZWxmLmdldF9idWlsZHNfZm9yX3F1ZXVlKHBhdGNoLCBxdWV1ZSkKKyAgICAg ICAgaXNfcGFyZW50X2J1aWxkID0gRmFsc2UKKyAgICAgICAgaWYgbm90IGJ1aWxkcyBhbmQgcGFy ZW50X3F1ZXVlOgorICAgICAgICAgICAgYnVpbGRzID0gc2VsZi5nZXRfYnVpbGRzX2Zvcl9xdWV1 ZShwYXRjaCwgcGFyZW50X3F1ZXVlKQorICAgICAgICAgICAgaXNfcGFyZW50X2J1aWxkID0gVHJ1 ZQogICAgICAgICBpZiBub3QgYnVpbGRzOgotICAgICAgICAgICAgcmV0dXJuIE5vbmUKKyAgICAg ICAgICAgIHJldHVybiAoTm9uZSwgTm9uZSkKICAgICAgICAgYnVpbGRzLnNvcnQoa2V5PWxhbWJk YSBidWlsZDogYnVpbGQuc3RhcnRlZF9hdCwgcmV2ZXJzZT1UcnVlKQotICAgICAgICByZXR1cm4g YnVpbGRzWzBdCisgICAgICAgIHJldHVybiAoYnVpbGRzWzBdLCBpc19wYXJlbnRfYnVpbGQpCiAK ICAgICBkZWYgZ2V0X2J1aWxkc19mb3JfcXVldWUoc2VsZiwgcGF0Y2gsIHF1ZXVlKToKICAgICAg ICAgcmV0dXJuIFtidWlsZCBmb3IgYnVpbGQgaW4gcGF0Y2guYnVpbGRfc2V0LmFsbCgpIGlmIGJ1 aWxkLmJ1aWxkZXJfZGlzcGxheV9uYW1lID09IHF1ZXVlXQo=