196613 2019-04-04 10:47:03 -0700 [macOS][iOS] Add filter to syscall sandbox rule 2019-04-04 15:51:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue ryanhaddad webkit-bug-importer oldest_to_newest 1524308 0 pvollan 2019-04-04 10:47:03 -0700 This will restrict the existing sandbox rule for the syscall. 1524309 1 pvollan 2019-04-04 10:47:27 -0700 rdar://problem/49531420 1524312 2 366727 pvollan 2019-04-04 10:50:20 -0700 Created attachment 366727 Patch 1524321 3 366728 pvollan 2019-04-04 11:08:38 -0700 Created attachment 366728 Patch 1524327 4 366728 bfulgham 2019-04-04 11:17:40 -0700 Comment on attachment 366728 Patch Yes! R=me! 1524337 5 366728 pvollan 2019-04-04 11:44:05 -0700 Comment on attachment 366728 Patch Thanks for reviewing! 1524351 6 366728 commit-queue 2019-04-04 12:13:44 -0700 Comment on attachment 366728 Patch Clearing flags on attachment: 366728 Committed r243888: <https://trac.webkit.org/changeset/243888> 1524352 7 commit-queue 2019-04-04 12:13:45 -0700 All reviewed patches have been landed. Closing bug. 1524492 8 ryanhaddad 2019-04-04 15:51:32 -0700 Reverted r243888 for reason: Introduced layout test crashes. Committed r243916: <https://trac.webkit.org/changeset/243916> 1524493 9 ryanhaddad 2019-04-04 15:51:58 -0700 (In reply to Ryan Haddad from comment #8) > Reverted r243888 for reason: > > Introduced layout test crashes. > > Committed r243916: <https://trac.webkit.org/changeset/243916> Details in radar. 366727 2019-04-04 10:50:20 -0700 2019-04-04 11:08:37 -0700 Patch bug-196613-20190404105019.patch text/plain 2485 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM4ODApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTA0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdW2lPU10gQWRkIGZp bHRlciB0byBzeXNjYWxsIHNhbmRib3ggcnVsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NjEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTUz MTQyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHdpbGwgcmVzdHJpY3QgdGhlIGV4aXN0aW5nIHNhbmRib3ggcnVsZSBmb3IgdGhlIHN5c2Nh bGwuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2I6CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2Vi UHJvY2Vzcy5zYi5pbjoKKwogMjAxOS0wNC0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgU2VydmljZSBXb3JrZXIgUHJvY2VzcyBkb2VzIG5vdCBoYXZlIHRo ZSByaWdodCBkb21haW4gbmFtZQpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJv eFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDI0Mzg3MykKKysrIFNvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LnNiCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNiArNjAwLDggQEAKICAgICAgICAgKHN5c2NhbGwt bnVtYmVyIFNZU19vcGVuX2Rwcm90ZWN0ZWRfbnApCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfcHJlYWRfbm9jYW5jZWwpCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfX19zZW13YWl0 X3NpZ25hbF9ub2NhbmNlbCkKLSAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19rZGVidWdfdHJh Y2Vfc3RyaW5nKSA7OyBOZWVkZWQgZm9yIHBlcmZvcm1hbmNlIHNhbXBsaW5nLCBzZWUgPHJkYXI6 Ly9wcm9ibGVtLzQ4ODI5NjU1Pi4KKyAgICApCisgICAgKHdpdGgtZmlsdGVyIChzeXN0ZW0tYXR0 cmlidXRlIGFwcGxlLWludGVybmFsKQorICAgICAgICAoYWxsb3cgc3lzY2FsbC11bml4IChzeXNj YWxsLW51bWJlciBTWVNfa2RlYnVnX3RyYWNlX3N0cmluZykgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5 NTMxNDIwPgogICAgICkKICkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBw bGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDI0Mzg3MykKKysrIFNvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2luZyBj b3B5KQpAQCAtOTYzLDggKzk2MywxMCBAQAogICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2tk ZWJ1Z190eXBlZmlsdGVyKQogICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHRpZCkgOzsg TmVlZGVkIGZvciBiYXNlIHN5c3RlbSwgc2VlIDxyZGFyOi8vcHJvYmxlbS80ODY1MTI1NT4KICAg ICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19tZW1vcnlzdGF0dXNfY29udHJvbCkgOzsgTmVlZGVk IGZvciBtZW1vcnkgbWVhc3VyZW1lbnQgaW5mcmFzdHJ1Y3R1cmUsIHNlZSA8cmRhcjovL3Byb2Js ZW0vNDg2NDcyNjM+Ci0gICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfa2RlYnVnX3RyYWNlX3N0 cmluZykgOzsgTmVlZGVkIGZvciBwZXJmb3JtYW5jZSBzYW1wbGluZywgc2VlIDxyZGFyOi8vcHJv YmxlbS80ODgyOTY1NT4uCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfcHN5bmNoX3J3X3Jk bG9jaykgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5MDYwMzU5PgogICAgICkKKyAgICAod2l0aC1maWx0 ZXIgKHN5c3RlbS1hdHRyaWJ1dGUgYXBwbGUtaW50ZXJuYWwpCisgICAgICAgIChhbGxvdyBzeXNj YWxsLXVuaXggKHN5c2NhbGwtbnVtYmVyIFNZU19rZGVidWdfdHJhY2Vfc3RyaW5nKSA7OyA8cmRh cjovL3Byb2JsZW0vNDk1MzE0MjA+CisgICAgKQogKQogCg== 366728 2019-04-04 11:08:38 -0700 2019-04-04 12:13:44 -0700 Patch bug-196613-20190404110837.patch text/plain 2487 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM4ODMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTA0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdW2lPU10gQWRkIGZp bHRlciB0byBzeXNjYWxsIHNhbmRib3ggcnVsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NjEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTUz MTQyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHdpbGwgcmVzdHJpY3QgdGhlIGV4aXN0aW5nIHNhbmRib3ggcnVsZSBmb3IgdGhlIHN5c2Nh bGwuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2I6CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2Vi UHJvY2Vzcy5zYi5pbjoKKwogMjAxOS0wNC0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgU2VydmljZSBXb3JrZXIgUHJvY2VzcyBkb2VzIG5vdCBoYXZlIHRo ZSByaWdodCBkb21haW4gbmFtZQpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJv eFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDI0Mzg4MykKKysrIFNvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LnNiCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNiArNjAwLDggQEAKICAgICAgICAgKHN5c2NhbGwt bnVtYmVyIFNZU19vcGVuX2Rwcm90ZWN0ZWRfbnApCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfcHJlYWRfbm9jYW5jZWwpCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfX19zZW13YWl0 X3NpZ25hbF9ub2NhbmNlbCkKLSAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19rZGVidWdfdHJh Y2Vfc3RyaW5nKSA7OyBOZWVkZWQgZm9yIHBlcmZvcm1hbmNlIHNhbXBsaW5nLCBzZWUgPHJkYXI6 Ly9wcm9ibGVtLzQ4ODI5NjU1Pi4KKyAgICApCisgICAgKHdpdGgtZmlsdGVyIChzeXN0ZW0tYXR0 cmlidXRlIGFwcGxlLWludGVybmFsKQorICAgICAgICAoYWxsb3cgc3lzY2FsbC11bml4IChzeXNj YWxsLW51bWJlciBTWVNfa2RlYnVnX3RyYWNlX3N0cmluZykpIDs7IDxyZGFyOi8vcHJvYmxlbS80 OTUzMTQyMD4KICAgICApCiApCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyNDM4ODMpCisrKyBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTk2Myw4ICs5NjMsMTAgQEAKICAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19r ZGVidWdfdHlwZWZpbHRlcikKICAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19nZXR0aWQpIDs7 IE5lZWRlZCBmb3IgYmFzZSBzeXN0ZW0sIHNlZSA8cmRhcjovL3Byb2JsZW0vNDg2NTEyNTU+CiAg ICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfbWVtb3J5c3RhdHVzX2NvbnRyb2wpIDs7IE5lZWRl ZCBmb3IgbWVtb3J5IG1lYXN1cmVtZW50IGluZnJhc3RydWN0dXJlLCBzZWUgPHJkYXI6Ly9wcm9i bGVtLzQ4NjQ3MjYzPgotICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2tkZWJ1Z190cmFjZV9z dHJpbmcpIDs7IE5lZWRlZCBmb3IgcGVyZm9ybWFuY2Ugc2FtcGxpbmcsIHNlZSA8cmRhcjovL3By b2JsZW0vNDg4Mjk2NTU+LgogICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3BzeW5jaF9yd19y ZGxvY2spIDs7IDxyZGFyOi8vcHJvYmxlbS80OTA2MDM1OT4KICAgICApCisgICAgKHdpdGgtZmls dGVyIChzeXN0ZW0tYXR0cmlidXRlIGFwcGxlLWludGVybmFsKQorICAgICAgICAoYWxsb3cgc3lz Y2FsbC11bml4IChzeXNjYWxsLW51bWJlciBTWVNfa2RlYnVnX3RyYWNlX3N0cmluZykpIDs7IDxy ZGFyOi8vcHJvYmxlbS80OTUzMTQyMD4KKyAgICApCiApCiAK