196612 2019-04-04 10:43:24 -0700 [iOS Sim] Layout Test scrollingcoordinator/ios/ui-scroll-fixed.html is a flaky failure 2019-10-17 12:06:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195521 InRadar P2 Normal --- 1 sroberts simon.fraser commit-queue fred.wang koivisto lforschler sam simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1524303 0 sroberts 2019-04-04 10:43:24 -0700 The following layout test is flaky on iOS Simulator Release WK2 scrollingcoordinator/ios/ui-scroll-fixed.html Probable cause: Test was added in https://trac.webkit.org/changeset/242683/webkit A note was made on previous bug, but a fix does not appear to have been made. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=scrollingcoordinator%2Fios%2Fui-scroll-fixed.html Diff: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r243869%20(3458)/scrollingcoordinator/ios/ui-scroll-fixed-diff.png 1524304 1 webkit-bug-importer 2019-04-04 10:44:17 -0700 <rdar://problem/49612867> 1524313 2 sroberts 2019-04-04 10:50:25 -0700 Marked flaky in https://trac.webkit.org/changeset/243881/webkit while waiting for a fix 1580674 3 simon.fraser 2019-10-16 14:23:23 -0700 I can reproduce. This only seems to happen if amount scrolled (50px) is identical to the top of #container, so we must have an early return in code somewhere. 1580812 4 381146 simon.fraser 2019-10-16 18:50:53 -0700 Created attachment 381146 Patch 1580878 5 381146 koivisto 2019-10-16 22:54:32 -0700 Comment on attachment 381146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381146&action=review > LayoutTests/ChangeLog:14 > + This test hit a really obscure bug where a combination of an immediate scroll, and > + an ancestor reposition left the layer position of a position:fixed layer unchanged. > + The position of this layer in the UI process had been previously modified by > + the scrolling tree for the scroll, but because the WebContent-side mutations left > + the actual position unchanged, we'd never apply a new position via a commit, so left > + the layer in the wrong location. Would this be fixed by a web->ui message that that signals we did a compositing layer update but nothing changed, so we are skipping the commit? This would just call applyLayerPositionsAfterCommit() to check for m_wasScrolledByDelegatedScrollingSincePreviousCommit bit. > LayoutTests/ChangeLog:19 > + Since this is so hard to hit with noisy user scrolling, just change the test to avoid > + the perfect storm of scrolls and offsets. Since we have managed to make a test for this it bit sad to let it go waste. 1581048 6 simon.fraser 2019-10-17 10:51:47 -0700 I filed bug 203112 to cover the underlying bug. 1581087 7 commit-queue 2019-10-17 12:05:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 381146: imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-fallback.html bug 203076 (authors: fred.wang@free.fr and rwlbuis@gmail.com) imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1581088 8 381146 commit-queue 2019-10-17 12:06:29 -0700 Comment on attachment 381146 Patch Clearing flags on attachment: 381146 Committed r251251: <https://trac.webkit.org/changeset/251251> 1581089 9 commit-queue 2019-10-17 12:06:31 -0700 All reviewed patches have been landed. Closing bug. 381146 2019-10-16 18:50:53 -0700 2019-10-17 12:06:29 -0700 Patch bug-196612-20191016185052.patch text/plain 4049 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMTk2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2Q5ZTFjOGNhNTI4Mjk0YjgyMjkz NjI3NGM4NzljODhkY2E0OTMwZS4uMWQ4OWZkNjViM2EwZGExNGJmMGIxMmY2OWZkYzIxOWMyYjFk ZmQxZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTEwLTE2ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgU2ltXSBMYXlvdXQgVGVzdCBz Y3JvbGxpbmdjb29yZGluYXRvci9pb3MvdWktc2Nyb2xsLWZpeGVkLmh0bWwgaXMgYSBmbGFreSBm YWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTY2MTIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDk2MTI4NjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgdGVzdCBoaXQgYSBy ZWFsbHkgb2JzY3VyZSBidWcgd2hlcmUgYSBjb21iaW5hdGlvbiBvZiBhbiBpbW1lZGlhdGUgc2Ny b2xsLCBhbmQKKyAgICAgICAgYW4gYW5jZXN0b3IgcmVwb3NpdGlvbiBsZWZ0IHRoZSBsYXllciBw b3NpdGlvbiBvZiBhIHBvc2l0aW9uOmZpeGVkIGxheWVyIHVuY2hhbmdlZC4KKyAgICAgICAgVGhl IHBvc2l0aW9uIG9mIHRoaXMgbGF5ZXIgaW4gdGhlIFVJIHByb2Nlc3MgaGFkIGJlZW4gcHJldmlv dXNseSBtb2RpZmllZCBieQorICAgICAgICB0aGUgc2Nyb2xsaW5nIHRyZWUgZm9yIHRoZSBzY3Jv bGwsIGJ1dCBiZWNhdXNlIHRoZSBXZWJDb250ZW50LXNpZGUgbXV0YXRpb25zIGxlZnQKKyAgICAg ICAgdGhlIGFjdHVhbCBwb3NpdGlvbiB1bmNoYW5nZWQsIHdlJ2QgbmV2ZXIgYXBwbHkgYSBuZXcg cG9zaXRpb24gdmlhIGEgY29tbWl0LCBzbyBsZWZ0CisgICAgICAgIHRoZSBsYXllciBpbiB0aGUg d3JvbmcgbG9jYXRpb24uCisgICAgICAgIAorICAgICAgICBSZW1vdmluZyB0aGUgbV93YXNTY3Jv bGxlZEJ5RGVsZWdhdGVkU2Nyb2xsaW5nU2luY2VQcmV2aW91c0NvbW1pdCBjaGVjayBpbiBTY3Jv bGxpbmdUcmVlOjphcHBseUxheWVyUG9zaXRpb25zQWZ0ZXJDb21taXQoKQorICAgICAgICBmaXhl cyB0aGlzLCBidXQgaGFzIHBlcmYgaW1wbGljYXRpb25zLiBBbHRlcm5hdGl2ZSBmaXhlcyByZXF1 aXJlIGNvbXBsZXggc3RhdGUgdHJhY2tpbmcuCisgICAgICAgIFNpbmNlIHRoaXMgaXMgc28gaGFy ZCB0byBoaXQgd2l0aCBub2lzeSB1c2VyIHNjcm9sbGluZywganVzdCBjaGFuZ2UgdGhlIHRlc3Qg dG8gYXZvaWQKKyAgICAgICAgdGhlIHBlcmZlY3Qgc3Rvcm0gb2Ygc2Nyb2xscyBhbmQgb2Zmc2V0 cy4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlv bnM6CisgICAgICAgICogc2Nyb2xsaW5nY29vcmRpbmF0b3IvaW9zL3VpLXNjcm9sbC1maXhlZC1l eHBlY3RlZC5odG1sOgorICAgICAgICAqIHNjcm9sbGluZ2Nvb3JkaW5hdG9yL2lvcy91aS1zY3Jv bGwtZml4ZWQuaHRtbDoKKwogMjAxOS0xMC0xNiAgUnVzc2VsbCBFcHN0ZWluICA8cmVwc3RlaW5A YXBwbGUuY29tPgogCiAgICAgICAgIENvcnJlY3QgVGVzdEV4cGVjdGF0aW9ucyBmcm9tIHIyNTEx MTkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9U ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVsYXRvci13azIv VGVzdEV4cGVjdGF0aW9ucwppbmRleCA4OGExZjdmNDMwMTdjYTljZjM3NGQ5MGRkYjIwNGIwZjZj ODMxZWY2Li5iOTI3MjRmOTI2MDY3OGM3ZjU5NjhlNDQ0MWQwOGY0ZmNmMjgzMTBjIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2syL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTcwLDggKzcwLDYgQEAgd2Via2l0Lm9yZy9iLzE5NjQwMyBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhY2FwdHVyZS1yZWNvcmQvTWVkaWFSZWMKIAogd2Vi a2l0Lm9yZy9iLzE5NTM0MSBmYXN0L3ZpZXdwb3J0L2lvcy9jb25zdGFudC13aWR0aC12aWV3cG9y dC1hZnRlci1jaGFuZ2luZy12aWV3LXNjYWxlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJr aXQub3JnL2IvMTk2NjEyIHNjcm9sbGluZ2Nvb3JkaW5hdG9yL2lvcy91aS1zY3JvbGwtZml4ZWQu aHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xODY1ODEgWyBE ZWJ1ZyBdIGZhc3QvcGFyc2VyL3htbC1lcnJvci1hZG9wdGVkLnhtbCBbIFBhc3MgVGltZW91dCBd CiAKIHdlYmtpdC5vcmcvYi8xOTY5NDQgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9o ci10aW1lL3Rlc3RfY3Jvc3NfZnJhbWVfc3RhcnQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9pb3MvdWktc2Nyb2xsLWZp eGVkLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9pb3Mv dWktc2Nyb2xsLWZpeGVkLWV4cGVjdGVkLmh0bWwKaW5kZXggNjQwOTYyNTE1MDcyY2U0Y2VjZjYy NWQxNTY1YjNjNWYyNWI1NDdhYi4uMzE4ZWI0NWZjZTk5MzZlOGM4N2UzMTQ4OWMxOGMxZDliODIx MjI4OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc2Nyb2xsaW5nY29vcmRpbmF0b3IvaW9zL3Vp LXNjcm9sbC1maXhlZC1leHBlY3RlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL3Njcm9sbGluZ2Nv b3JkaW5hdG9yL2lvcy91aS1zY3JvbGwtZml4ZWQtZXhwZWN0ZWQuaHRtbApAQCAtNDEsNyArNDEs NyBAQAogICAgICAgICAgICAgICAgIHJldHVybgogCiAgICAgICAgICAgICBhd2FpdCBVSUhlbHBl ci5kZWxheUZvcigwKTsKLSAgICAgICAgICAgIGF3YWl0IFVJSGVscGVyLmltbWVkaWF0ZVVuc3Rh YmxlU2Nyb2xsVG8oMCwgNTApOworICAgICAgICAgICAgYXdhaXQgVUlIZWxwZXIuaW1tZWRpYXRl VW5zdGFibGVTY3JvbGxUbygwLCA1NSk7CiAgICAgICAgICAgICBhd2FpdCBVSUhlbHBlci5kZWxh eUZvcigxMjApOyAvLyBXYWl0IGZvciBzY3JvbGxiYXJzIHRvIGRpc2FwcGVhci4KICAgICAgICAg ICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwogICAgICAgICB9CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9pb3MvdWktc2Nyb2xsLWZpeGVkLmh0bWwgYi9M YXlvdXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9pb3MvdWktc2Nyb2xsLWZpeGVkLmh0bWwK aW5kZXggOWUzY2Y5MTBjMGU5YjFkYzc4ZTQwNWY1ZWNkMDdhMDViZjFmZTkwYS4uZjA1MzIxNDk5 ZTQ5YTIwOTBmODJjY2ExNzUwMWY0OTE0NjM2ZDFkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv c2Nyb2xsaW5nY29vcmRpbmF0b3IvaW9zL3VpLXNjcm9sbC1maXhlZC5odG1sCisrKyBiL0xheW91 dFRlc3RzL3Njcm9sbGluZ2Nvb3JkaW5hdG9yL2lvcy91aS1zY3JvbGwtZml4ZWQuaHRtbApAQCAt NDUsNyArNDUsNyBAQAogICAgICAgICAgICAgICAgIHJldHVybgogCiAgICAgICAgICAgICBhd2Fp dCBVSUhlbHBlci5kZWxheUZvcigwKTsKLSAgICAgICAgICAgIGF3YWl0IFVJSGVscGVyLmltbWVk aWF0ZVVuc3RhYmxlU2Nyb2xsVG8oMCwgNTApOworICAgICAgICAgICAgYXdhaXQgVUlIZWxwZXIu aW1tZWRpYXRlVW5zdGFibGVTY3JvbGxUbygwLCA1NSk7CiAgICAgICAgICAgICBhd2FpdCBVSUhl bHBlci5kZWxheUZvcigoMTIwKSk7IC8vIFdhaXQgZm9yIHNjcm9sbGJhcnMgdG8gZGlzYXBwZWFy LgogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpLmNsYXNz TGlzdC5hZGQoJ2NoYW5nZWQnKTsKICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp Owo=