196607 2019-04-04 08:59:41 -0700 [ews-app] status-bubble should display position in queue 2019-04-15 13:19:26 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1524250 0 aakash_jain 2019-04-04 08:59:41 -0700 While a patch is waiting in queue, ews-app's status-bubble should display its position in queue. 1526109 1 367158 aakash_jain 2019-04-10 13:51:51 -0700 Created attachment 367158 WIP 1526819 2 367158 kocsen_chung 2019-04-12 10:51:17 -0700 Comment on attachment 367158 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=367158&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:64 > + bubble["queue_position"] = queue_position nit: inconsistent use of `"` and `'`. Seems like most of it is `'` so we can stick to that. > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:178 > + previously_sent_patches = set(Patch.objects.filter(modified__gte=from_timestamp).filter(sent_to_buildbot=True).filter(obsolete=False).filter(modified__lt=patch.modified)) nit: I think it would be more readable if the filters are above one another. ```python Patch.objects .filter(x) .filter(y) [...] ``` 1527035 3 367386 aakash_jain 2019-04-13 05:58:47 -0700 Created attachment 367386 Proposed patch Incorporated review comments. 1527344 4 367386 lforschler 2019-04-15 13:04:59 -0700 Comment on attachment 367386 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=367386&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:194 > + processed_patch = set([build.patch for build in recent_builds]) should this be "processed_patches" ? 1527355 5 aakash_jain 2019-04-15 13:18:38 -0700 > should this be "processed_patches" ? Yes, changed. 1527356 6 aakash_jain 2019-04-15 13:18:51 -0700 Committed r244284: <https://trac.webkit.org/changeset/244284> 1527357 7 webkit-bug-importer 2019-04-15 13:19:26 -0700 <rdar://problem/49914755> 367158 2019-04-10 13:51:51 -0700 2019-04-13 05:58:47 -0700 WIP position_in_queue.patch text/plain 3316 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDE0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gc3RhdHVzLWJ1YmJsZSBzaG91bGQgZGlzcGxheSBwb3Np dGlvbiBpbiBxdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUu cHk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6CisgICAgICAgIChTdGF0 dXNCdWJibGUuX3F1ZXVlX3Bvc2l0aW9uKTogTWV0aG9kIHRvIGNhbGN1bGF0ZSBwYXRjaCdzIHBv c2l0aW9uIGluIHF1ZXVlLgorCiAyMDE5LTA0LTEwICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9A YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBpbmNyZW1lbnRhbCBieXRlY29k ZSBjYWNoZSB1cGRhdGVzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3 cy92aWV3cy9zdGF0dXNidWJibGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CShyZXZpc2lvbiAyNDQwOTkp CisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJi bGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTI3LDkgKzI3LDExIEBAIGltcG9ydCByZQogCiBmcm9t IGRqYW5nby5odHRwIGltcG9ydCBIdHRwUmVzcG9uc2UKIGZyb20gZGphbmdvLnNob3J0Y3V0cyBp bXBvcnQgcmVuZGVyCitmcm9tIGRqYW5nby51dGlscyBpbXBvcnQgdGltZXpvbmUKIGZyb20gZGph bmdvLnZpZXdzIGltcG9ydCBWaWV3CiBmcm9tIGRqYW5nby52aWV3cy5kZWNvcmF0b3JzLmNsaWNr amFja2luZyBpbXBvcnQgeGZyYW1lX29wdGlvbnNfZXhlbXB0CiBmcm9tIGV3cy5jb21tb24uYnVp bGRib3QgaW1wb3J0IEJ1aWxkYm90Citmcm9tIGV3cy5tb2RlbHMuYnVpbGQgaW1wb3J0IEJ1aWxk CiBmcm9tIGV3cy5tb2RlbHMucGF0Y2ggaW1wb3J0IFBhdGNoCiBpbXBvcnQgZXdzLmNvbmZpZyBh cyBjb25maWcKIApAQCAtNTgsNyArNjAsOSBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAK ICAgICAgICAgaWYgbm90IGJ1aWxkOgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ25v bmUnCi0gICAgICAgICAgICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhaXRpbmcgaW4g cXVldWUsIHByb2Nlc3NpbmcgaGFzIG5vdCBzdGFydGVkIHlldC4nCisgICAgICAgICAgICBxdWV1 ZV9wb3NpdGlvbiA9IHNlbGYuX3F1ZXVlX3Bvc2l0aW9uKHBhdGNoLCBxdWV1ZSwgc2VsZi5fZ2V0 X3BhcmVudF9xdWV1ZShxdWV1ZSkpCisgICAgICAgICAgICBidWJibGVbInF1ZXVlX3Bvc2l0aW9u Il0gPSBxdWV1ZV9wb3NpdGlvbgorICAgICAgICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2Un XSA9ICdXYWl0aW5nIGluIHF1ZXVlLCBwcm9jZXNzaW5nIGhhcyBub3Qgc3RhcnRlZCB5ZXQuXG5c blBvc2l0aW9uIGluIHF1ZXVlOiB7fScuZm9ybWF0KHF1ZXVlX3Bvc2l0aW9uKQogICAgICAgICAg ICAgcmV0dXJuIGJ1YmJsZQogCiAgICAgICAgIGJ1YmJsZVsndXJsJ10gPSAnaHR0cHM6Ly97fS8j L2J1aWxkZXJzL3t9L2J1aWxkcy97fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9TRVJWRVJfSE9T VCwgYnVpbGQuYnVpbGRlcl9pZCwgYnVpbGQubnVtYmVyKQpAQCAtMTY3LDYgKzE3MSwyMCBAQCBj bGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgZGVmIF9zaG91bGRfc2hvd19idWJibGVfZm9y X3F1ZXVlKHNlbGYsIHF1ZXVlKToKICAgICAgICAgcmV0dXJuIHF1ZXVlIGluIFN0YXR1c0J1YmJs ZS5FTkFCTEVEX1FVRVVFUwogCisgICAgZGVmIF9xdWV1ZV9wb3NpdGlvbihzZWxmLCBwYXRjaCwg cXVldWUsIHBhcmVudF9xdWV1ZT1Ob25lKToKKyAgICAgICAgREFZU19UT19DSEVDSyA9IDIKKyAg ICAgICAgZnJvbV90aW1lc3RhbXAgPSB0aW1lem9uZS5ub3coKSAtIGRhdGV0aW1lLnRpbWVkZWx0 YShkYXlzPURBWVNfVE9fQ0hFQ0spCisKKyAgICAgICAgcHJldmlvdXNseV9zZW50X3BhdGNoZXMg PSBzZXQoUGF0Y2gub2JqZWN0cy5maWx0ZXIobW9kaWZpZWRfX2d0ZT1mcm9tX3RpbWVzdGFtcCku ZmlsdGVyKHNlbnRfdG9fYnVpbGRib3Q9VHJ1ZSkuZmlsdGVyKG9ic29sZXRlPUZhbHNlKS5maWx0 ZXIobW9kaWZpZWRfX2x0PXBhdGNoLm1vZGlmaWVkKSkKKyAgICAgICAgaWYgcGFyZW50X3F1ZXVl OgorICAgICAgICAgICAgcmVjZW50X2J1aWxkc19wYXJlbnRfcXVldWUgPSBCdWlsZC5vYmplY3Rz LmZpbHRlcihtb2RpZmllZF9fZ3RlPWZyb21fdGltZXN0YW1wKS5maWx0ZXIoYnVpbGRlcl9kaXNw bGF5X25hbWU9cGFyZW50X3F1ZXVlKQorICAgICAgICAgICAgcHJvY2Vzc2VkX3BhdGNoX3BhcmVu dF9xdWV1ZSA9IHNldChbYnVpbGQucGF0Y2ggZm9yIGJ1aWxkIGluIHJlY2VudF9idWlsZHNfcGFy ZW50X3F1ZXVlXSkKKyAgICAgICAgICAgIHJldHVybiBsZW4ocHJldmlvdXNseV9zZW50X3BhdGNo ZXMgLSBwcm9jZXNzZWRfcGF0Y2hfcGFyZW50X3F1ZXVlKSArIDEKKworICAgICAgICByZWNlbnRf YnVpbGRzID0gQnVpbGQub2JqZWN0cy5maWx0ZXIobW9kaWZpZWRfX2d0ZT1mcm9tX3RpbWVzdGFt cCkuZmlsdGVyKGJ1aWxkZXJfZGlzcGxheV9uYW1lPXF1ZXVlKQorICAgICAgICBwcm9jZXNzZWRf cGF0Y2ggPSBzZXQoW2J1aWxkLnBhdGNoIGZvciBidWlsZCBpbiByZWNlbnRfYnVpbGRzXSkKKyAg ICAgICAgcmV0dXJuIGxlbihwcmV2aW91c2x5X3NlbnRfcGF0Y2hlcyAtIHByb2Nlc3NlZF9wYXRj aCkgKyAxCisKICAgICBkZWYgX2J1aWxkX2J1YmJsZXNfZm9yX3BhdGNoKHNlbGYsIHBhdGNoKToK ICAgICAgICAgc2hvd19zdWJtaXRfdG9fZXdzID0gVHJ1ZQogICAgICAgICBmYWlsZWRfdG9fYXBw bHkgPSBGYWxzZSAgIyBUT0RPOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0NTk4Cg== 367386 2019-04-13 05:58:47 -0700 2019-04-15 13:04:59 -0700 Proposed patch position_in_queue_v2.patch text/plain 3774 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDI0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gc3RhdHVzLWJ1YmJsZSBzaG91bGQgZGlzcGxheSBwb3Np dGlvbiBpbiBxdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUu cHk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6CisgICAgICAgIChTdGF0 dXNCdWJibGUuX3F1ZXVlX3Bvc2l0aW9uKTogTWV0aG9kIHRvIGNhbGN1bGF0ZSBwYXRjaCdzIHBv c2l0aW9uIGluIHF1ZXVlLgorCiAyMDE5LTA0LTEzICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9A YXBwbGUuY29tPgogCiAgICAgICAgIENvZGVDYWNoZSBzaG91bGQgY2hlY2sgdGhhdCB0aGUgVW5s aW5rZWRDb2RlQmxvY2sgd2FzIHN1Y2Nlc3NmdWxseSBjcmVhdGVkIGJlZm9yZSBjYWNoaW5nIGl0 CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNi dWJibGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5CShyZXZpc2lvbiAyNDQyNDEpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHdvcmtpbmcg Y29weSkKQEAgLTI3LDkgKzI3LDExIEBAIGltcG9ydCByZQogCiBmcm9tIGRqYW5nby5odHRwIGlt cG9ydCBIdHRwUmVzcG9uc2UKIGZyb20gZGphbmdvLnNob3J0Y3V0cyBpbXBvcnQgcmVuZGVyCitm cm9tIGRqYW5nby51dGlscyBpbXBvcnQgdGltZXpvbmUKIGZyb20gZGphbmdvLnZpZXdzIGltcG9y dCBWaWV3CiBmcm9tIGRqYW5nby52aWV3cy5kZWNvcmF0b3JzLmNsaWNramFja2luZyBpbXBvcnQg eGZyYW1lX29wdGlvbnNfZXhlbXB0CiBmcm9tIGV3cy5jb21tb24uYnVpbGRib3QgaW1wb3J0IEJ1 aWxkYm90Citmcm9tIGV3cy5tb2RlbHMuYnVpbGQgaW1wb3J0IEJ1aWxkCiBmcm9tIGV3cy5tb2Rl bHMucGF0Y2ggaW1wb3J0IFBhdGNoCiBpbXBvcnQgZXdzLmNvbmZpZyBhcyBjb25maWcKIApAQCAt NTgsNyArNjAsOSBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAKICAgICAgICAgaWYgbm90 IGJ1aWxkOgogICAgICAgICAgICAgYnViYmxlWydzdGF0ZSddID0gJ25vbmUnCi0gICAgICAgICAg ICBidWJibGVbJ2RldGFpbHNfbWVzc2FnZSddID0gJ1dhaXRpbmcgaW4gcXVldWUsIHByb2Nlc3Np bmcgaGFzIG5vdCBzdGFydGVkIHlldC4nCisgICAgICAgICAgICBxdWV1ZV9wb3NpdGlvbiA9IHNl bGYuX3F1ZXVlX3Bvc2l0aW9uKHBhdGNoLCBxdWV1ZSwgc2VsZi5fZ2V0X3BhcmVudF9xdWV1ZShx dWV1ZSkpCisgICAgICAgICAgICBidWJibGVbJ3F1ZXVlX3Bvc2l0aW9uJ10gPSBxdWV1ZV9wb3Np dGlvbgorICAgICAgICAgICAgYnViYmxlWydkZXRhaWxzX21lc3NhZ2UnXSA9ICdXYWl0aW5nIGlu IHF1ZXVlLCBwcm9jZXNzaW5nIGhhcyBub3Qgc3RhcnRlZCB5ZXQuXG5cblBvc2l0aW9uIGluIHF1 ZXVlOiB7fScuZm9ybWF0KHF1ZXVlX3Bvc2l0aW9uKQogICAgICAgICAgICAgcmV0dXJuIGJ1YmJs ZQogCiAgICAgICAgIGJ1YmJsZVsndXJsJ10gPSAnaHR0cHM6Ly97fS8jL2J1aWxkZXJzL3t9L2J1 aWxkcy97fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9TRVJWRVJfSE9TVCwgYnVpbGQuYnVpbGRl cl9pZCwgYnVpbGQubnVtYmVyKQpAQCAtMTY3LDYgKzE3MSwyOSBAQCBjbGFzcyBTdGF0dXNCdWJi bGUoVmlldyk6CiAgICAgZGVmIF9zaG91bGRfc2hvd19idWJibGVfZm9yX3F1ZXVlKHNlbGYsIHF1 ZXVlKToKICAgICAgICAgcmV0dXJuIHF1ZXVlIGluIFN0YXR1c0J1YmJsZS5FTkFCTEVEX1FVRVVF UwogCisgICAgZGVmIF9xdWV1ZV9wb3NpdGlvbihzZWxmLCBwYXRjaCwgcXVldWUsIHBhcmVudF9x dWV1ZT1Ob25lKToKKyAgICAgICAgIyBGSVhNRTogSGFuZGxlIHJldHJpZWQgYnVpbGRzIGFuZCBj YW5jZWxsZWQgYnVpbGQtcmVxdWVzdHMgYXMgd2VsbC4KKyAgICAgICAgREFZU19UT19DSEVDSyA9 IDMKKyAgICAgICAgZnJvbV90aW1lc3RhbXAgPSB0aW1lem9uZS5ub3coKSAtIGRhdGV0aW1lLnRp bWVkZWx0YShkYXlzPURBWVNfVE9fQ0hFQ0spCisKKyAgICAgICAgcHJldmlvdXNseV9zZW50X3Bh dGNoZXMgPSBzZXQoUGF0Y2gub2JqZWN0cworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLmZpbHRlcihtb2RpZmllZF9fZ3RlPWZyb21fdGltZXN0YW1wKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLmZpbHRlcihzZW50X3RvX2J1aWxk Ym90PVRydWUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuZmls dGVyKG9ic29sZXRlPUZhbHNlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLmZpbHRlcihtb2RpZmllZF9fbHQ9cGF0Y2gubW9kaWZpZWQpKQorICAgICAgICBpZiBw YXJlbnRfcXVldWU6CisgICAgICAgICAgICByZWNlbnRfYnVpbGRzX3BhcmVudF9xdWV1ZSA9IEJ1 aWxkLm9iamVjdHMgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLmZpbHRlcihtb2RpZmllZF9fZ3RlPWZyb21fdGltZXN0YW1wKSBcCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuZmlsdGVyKGJ1aWxkZXJfZGlzcGxheV9u YW1lPXBhcmVudF9xdWV1ZSkKKyAgICAgICAgICAgIHByb2Nlc3NlZF9wYXRjaF9wYXJlbnRfcXVl dWUgPSBzZXQoW2J1aWxkLnBhdGNoIGZvciBidWlsZCBpbiByZWNlbnRfYnVpbGRzX3BhcmVudF9x dWV1ZV0pCisgICAgICAgICAgICByZXR1cm4gbGVuKHByZXZpb3VzbHlfc2VudF9wYXRjaGVzIC0g cHJvY2Vzc2VkX3BhdGNoX3BhcmVudF9xdWV1ZSkgKyAxCisKKyAgICAgICAgcmVjZW50X2J1aWxk cyA9IEJ1aWxkLm9iamVjdHMgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIC5maWx0ZXIo bW9kaWZpZWRfX2d0ZT1mcm9tX3RpbWVzdGFtcCkgXAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC5maWx0ZXIoYnVpbGRlcl9kaXNwbGF5X25hbWU9cXVldWUpCisgICAgICAgIHByb2Nlc3Nl ZF9wYXRjaCA9IHNldChbYnVpbGQucGF0Y2ggZm9yIGJ1aWxkIGluIHJlY2VudF9idWlsZHNdKQor ICAgICAgICByZXR1cm4gbGVuKHByZXZpb3VzbHlfc2VudF9wYXRjaGVzIC0gcHJvY2Vzc2VkX3Bh dGNoKSArIDEKKwogICAgIGRlZiBfYnVpbGRfYnViYmxlc19mb3JfcGF0Y2goc2VsZiwgcGF0Y2gp OgogICAgICAgICBzaG93X3N1Ym1pdF90b19ld3MgPSBUcnVlCiAgICAgICAgIGZhaWxlZF90b19h cHBseSA9IEZhbHNlICAjIFRPRE86IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTQ1OTgK