196590 2019-04-03 22:51:23 -0700 [JSC] Pass CodeOrigin to FuzzerAgent 2019-04-04 11:59:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1524168 0 ysuzuki 2019-04-03 22:51:23 -0700 [JSC] Pass CodeOrigin to FuzzerAgent 1524172 1 366701 ysuzuki 2019-04-03 22:54:18 -0700 Created attachment 366701 Patch 1524173 2 ews-watchlist 2019-04-03 22:56:44 -0700 Attachment 366701 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer, fuzzer, fuzzer, fuzzer, fuzzer, fuzzer, fuzzer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1524330 3 366701 ysuzuki 2019-04-04 11:25:48 -0700 Comment on attachment 366701 Patch Thanks! 1524339 4 366701 commit-queue 2019-04-04 11:53:13 -0700 Comment on attachment 366701 Patch Clearing flags on attachment: 366701 Committed r243885: <https://trac.webkit.org/changeset/243885> 1524340 5 commit-queue 2019-04-04 11:53:15 -0700 All reviewed patches have been landed. Closing bug. 1524346 6 webkit-bug-importer 2019-04-04 11:59:18 -0700 <rdar://problem/49616392> 366701 2019-04-03 22:54:18 -0700 2019-04-04 11:53:13 -0700 Patch bug-196590-20190403225417.patch text/plain 7220 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MDlkNDU2ZWU4NzU4NWZiMjBmOGI4ZWIyMGZlNjFkYzc1MGQ5ZDA2Li4yNmZkMjBhMjJmNjMyZDAy ODA1NzFkMDRjYWY5NjlkM2E4YmMwYWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOS0wNC0wMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFBhc3MgQ29kZU9yaWdpbiB0byBGdXp6ZXJBZ2VudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NTkwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyBDb2RlT3JpZ2lu IGluc3RlYWQgb2YgYnl0ZWNvZGVJbmRleC4gQ29kZU9yaWdpbiBpbmNsdWRlcyByaWNoZXIgaW5m b3JtYXRpb24gKElubGluZUNhbGxGcmFtZSopLgorICAgICAgICBXZSBhbHNvIG1hc2sgcHJlZGlj dGlvbiB3aXRoIFNwZWNCeXRlY29kZVRvcCBpbiBERkdCeXRlQ29kZVBhcnNlci4gVGhlIGZ1enpl ciBjYW4gcHJvZHVjZSBhbnkgU3BlY3VsYXRlZFR5cGVzLAorICAgICAgICBidXQgREZHQnl0ZUNv ZGVQYXJzZXIgc2hvdWxkIG9ubHkgc2VlIHByZWRpY3Rpb25zIHRoYXQgY2FuIGJlIGFjdHVhbGx5 IHByb2R1Y2VkIGZyb20gdGhlIGJ5dGVjb2RlIGV4ZWN1dGlvbi4KKworICAgICAgICAqIGRmZy9E RkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6 OmdldFByZWRpY3Rpb25XaXRob3V0T1NSRXhpdCk6CisgICAgICAgICogcnVudGltZS9GdXp6ZXJB Z2VudC5jcHA6CisgICAgICAgIChKU0M6OkZ1enplckFnZW50OjpnZXRQcmVkaWN0aW9uKToKKyAg ICAgICAgKiBydW50aW1lL0Z1enplckFnZW50Lmg6CisgICAgICAgICogcnVudGltZS9SYW5kb21p emluZ0Z1enplckFnZW50LmNwcDoKKyAgICAgICAgKEpTQzo6UmFuZG9taXppbmdGdXp6ZXJBZ2Vu dDo6Z2V0UHJlZGljdGlvbik6CisgICAgICAgICogcnVudGltZS9SYW5kb21pemluZ0Z1enplckFn ZW50Lmg6CisKIDIwMTktMDQtMDMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIGluIHIyNDM4NDMgd2l0aCB0aGUgYnVpbGQg Zml4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFy c2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3Bw CmluZGV4IDNlNWM0YjZmOWQ4YzJjMjk2OWY5ZTlhMzI5NzFjMTFiOGIwNmUzNjkuLjA2MjZlNzk1 Yzc3NDcxNzEwNzNkMDQ3ZDVkMGEwZTQ1YmFmMGU5NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCkBAIC04MzIsMjAgKzgzMiwyMCBAQCBj bGFzcyBCeXRlQ29kZVBhcnNlciB7CiAgICAgCiAgICAgU3BlY3VsYXRlZFR5cGUgZ2V0UHJlZGlj dGlvbldpdGhvdXRPU1JFeGl0KHVuc2lnbmVkIGJ5dGVjb2RlSW5kZXgpCiAgICAgewotICAgICAg ICBhdXRvIGdldFZhbHVlUHJvZmlsZVByZWRpY3Rpb25Gcm9tRm9yQ29kZUJsb2NrQW5kQnl0ZWNv ZGVPZmZzZXQgPSBbJl0gKENvZGVCbG9jayogY29kZUJsb2NrLCBpbnQgYnl0ZWNvZGVJbmRleCkK KyAgICAgICAgYXV0byBnZXRWYWx1ZVByb2ZpbGVQcmVkaWN0aW9uRnJvbUZvckNvZGVCbG9ja0Fu ZEJ5dGVjb2RlT2Zmc2V0ID0gWyZdIChDb2RlQmxvY2sqIGNvZGVCbG9jaywgY29uc3QgQ29kZU9y aWdpbiYgY29kZU9yaWdpbikKICAgICAgICAgewogICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUg cHJlZGljdGlvbjsKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBDb25jdXJyZW50SlNM b2NrZXIgbG9ja2VyKGNvZGVCbG9jay0+bV9sb2NrKTsKLSAgICAgICAgICAgICAgICBwcmVkaWN0 aW9uID0gY29kZUJsb2NrLT52YWx1ZVByb2ZpbGVQcmVkaWN0aW9uRm9yQnl0ZWNvZGVPZmZzZXQo bG9ja2VyLCBieXRlY29kZUluZGV4KTsKKyAgICAgICAgICAgICAgICBwcmVkaWN0aW9uID0gY29k ZUJsb2NrLT52YWx1ZVByb2ZpbGVQcmVkaWN0aW9uRm9yQnl0ZWNvZGVPZmZzZXQobG9ja2VyLCBj b2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgoKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBh dXRvKiBmdXp6ZXJBZ2VudCA9IG1fdm0tPmZ1enplckFnZW50KCk7CiAgICAgICAgICAgICBpZiAo VU5MSUtFTFkoZnV6emVyQWdlbnQpKQotICAgICAgICAgICAgICAgIHJldHVybiBmdXp6ZXJBZ2Vu dC0+Z2V0UHJlZGljdGlvbihjb2RlQmxvY2ssIGJ5dGVjb2RlSW5kZXgsIHByZWRpY3Rpb24pOwor ICAgICAgICAgICAgICAgIHJldHVybiBmdXp6ZXJBZ2VudC0+Z2V0UHJlZGljdGlvbihjb2RlQmxv Y2ssIGNvZGVPcmlnaW4sIHByZWRpY3Rpb24pICYgU3BlY0J5dGVjb2RlVG9wOwogICAgICAgICAg ICAgcmV0dXJuIHByZWRpY3Rpb247CiAgICAgICAgIH07CiAKLSAgICAgICAgU3BlY3VsYXRlZFR5 cGUgcHJlZGljdGlvbiA9IGdldFZhbHVlUHJvZmlsZVByZWRpY3Rpb25Gcm9tRm9yQ29kZUJsb2Nr QW5kQnl0ZWNvZGVPZmZzZXQobV9pbmxpbmVTdGFja1RvcC0+bV9wcm9maWxlZEJsb2NrLCBieXRl Y29kZUluZGV4KTsKKyAgICAgICAgU3BlY3VsYXRlZFR5cGUgcHJlZGljdGlvbiA9IGdldFZhbHVl UHJvZmlsZVByZWRpY3Rpb25Gcm9tRm9yQ29kZUJsb2NrQW5kQnl0ZWNvZGVPZmZzZXQobV9pbmxp bmVTdGFja1RvcC0+bV9wcm9maWxlZEJsb2NrLCBDb2RlT3JpZ2luKGJ5dGVjb2RlSW5kZXgsIGlu bGluZUNhbGxGcmFtZSgpKSk7CiAgICAgICAgIGlmIChwcmVkaWN0aW9uICE9IFNwZWNOb25lKQog ICAgICAgICAgICAgcmV0dXJuIHByZWRpY3Rpb247CiAKQEAgLTg3OSw3ICs4NzksNyBAQCBjbGFz cyBCeXRlQ29kZVBhcnNlciB7CiAgICAgICAgICAgICB3aGlsZSAoc3RhY2stPm1faW5saW5lQ2Fs bEZyYW1lICE9IGNvZGVPcmlnaW4tPmlubGluZUNhbGxGcmFtZSgpKQogICAgICAgICAgICAgICAg IHN0YWNrID0gc3RhY2stPm1fY2FsbGVyOwogCi0gICAgICAgICAgICByZXR1cm4gZ2V0VmFsdWVQ cm9maWxlUHJlZGljdGlvbkZyb21Gb3JDb2RlQmxvY2tBbmRCeXRlY29kZU9mZnNldChzdGFjay0+ bV9wcm9maWxlZEJsb2NrLCBjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpOworICAgICAgICAg ICAgcmV0dXJuIGdldFZhbHVlUHJvZmlsZVByZWRpY3Rpb25Gcm9tRm9yQ29kZUJsb2NrQW5kQnl0 ZWNvZGVPZmZzZXQoc3RhY2stPm1fcHJvZmlsZWRCbG9jaywgKmNvZGVPcmlnaW4pOwogICAgICAg ICB9CiAKICAgICAgICAgZGVmYXVsdDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0Z1enplckFnZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0Z1enplckFnZW50LmNwcAppbmRleCA4YWE3MzIyZGQwMWI2NTdjNzIxMTJjZTQ5MWYyNThiOGI5 MWVjNTJkLi5kZjcwOGY3ODk4MGVjZmFiMDBiY2JhOTY5YTE3M2MyY2EzMGFkZDdmIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9GdXp6ZXJBZ2VudC5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRnV6emVyQWdlbnQuY3BwCkBAIC0zMiw3ICsz Miw3IEBAIEZ1enplckFnZW50Ojp+RnV6emVyQWdlbnQoKQogewogfQogCi1TcGVjdWxhdGVkVHlw ZSBGdXp6ZXJBZ2VudDo6Z2V0UHJlZGljdGlvbihDb2RlQmxvY2sqLCBpbnQsIFNwZWN1bGF0ZWRU eXBlIHJlc3VsdCkKK1NwZWN1bGF0ZWRUeXBlIEZ1enplckFnZW50OjpnZXRQcmVkaWN0aW9uKENv ZGVCbG9jayosIGNvbnN0IENvZGVPcmlnaW4mLCBTcGVjdWxhdGVkVHlwZSByZXN1bHQpCiB7CiAg ICAgcmV0dXJuIHJlc3VsdDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0Z1enplckFnZW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9GdXp6 ZXJBZ2VudC5oCmluZGV4IDk5OWU3ZTNmMzIxMjY0MDllNjhlOWIzM2VhZDE4NTI2ODQ5ZjExZmYu LjA2MDMyZGIyNTM1ZGNkYTE4ZDlmYTdlOGU3Y2M2ZDJhMDllN2MyMTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Z1enplckFnZW50LmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRnV6emVyQWdlbnQuaApAQCAtMjUsOCArMjUsOCBAQAogCiAj cHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgIkNvZGVPcmlnaW4uaCIKICNpbmNsdWRlICJTcGVjdWxh dGVkVHlwZS5oIgotI2luY2x1ZGUgPHd0Zi9Mb2NrZXIuaD4KIAogbmFtZXNwYWNlIEpTQyB7CiAK QEAgLTM2LDcgKzM2LDcgQEAgY2xhc3MgRnV6emVyQWdlbnQgewogcHVibGljOgogICAgIEpTX0VY UE9SVF9QUklWQVRFIHZpcnR1YWwgfkZ1enplckFnZW50KCk7CiAKLSAgICBKU19FWFBPUlRfUFJJ VkFURSB2aXJ0dWFsIFNwZWN1bGF0ZWRUeXBlIGdldFByZWRpY3Rpb24oQ29kZUJsb2NrKiwgaW50 IGJ5dGVjb2RlT2Zmc2V0LCBTcGVjdWxhdGVkVHlwZSk7CisgICAgSlNfRVhQT1JUX1BSSVZBVEUg dmlydHVhbCBTcGVjdWxhdGVkVHlwZSBnZXRQcmVkaWN0aW9uKENvZGVCbG9jayosIGNvbnN0IENv ZGVPcmlnaW4mLCBTcGVjdWxhdGVkVHlwZSk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JhbmRvbWl6aW5nRnV6emVy QWdlbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmFuZG9taXppbmdGdXp6 ZXJBZ2VudC5jcHAKaW5kZXggY2ZkYTEwYjYzNjBhMjY3YTQzMzBjMzA5ZDNlNjIzZDljNzJiOTA4 NS4uM2QyMjU5NTFiMjkxNTE0N2RmNzFkNTViYWM2ZWNhMTdiYTY1NmYxNiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmFuZG9taXppbmdGdXp6ZXJBZ2VudC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmFuZG9taXppbmdGdXp6ZXJBZ2Vu dC5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJSYW5kb21pemluZ0Z1enplckFnZW50 LmgiCiAKICNpbmNsdWRlICJDb2RlQmxvY2suaCIKKyNpbmNsdWRlIDx3dGYvTG9ja2VyLmg+CiAK IG5hbWVzcGFjZSBKU0MgewogCkBAIC0zNSwxNCArMzYsMTQgQEAgUmFuZG9taXppbmdGdXp6ZXJB Z2VudDo6UmFuZG9taXppbmdGdXp6ZXJBZ2VudChWTSYpCiB7CiB9CiAKLVNwZWN1bGF0ZWRUeXBl IFJhbmRvbWl6aW5nRnV6emVyQWdlbnQ6OmdldFByZWRpY3Rpb24oQ29kZUJsb2NrKiBjb2RlQmxv Y2ssIGludCBieXRlY29kZUluZGV4LCBTcGVjdWxhdGVkVHlwZSBvcmlnaW5hbCkKK1NwZWN1bGF0 ZWRUeXBlIFJhbmRvbWl6aW5nRnV6emVyQWdlbnQ6OmdldFByZWRpY3Rpb24oQ29kZUJsb2NrKiBj b2RlQmxvY2ssIGNvbnN0IENvZGVPcmlnaW4mIGNvZGVPcmlnaW4sIFNwZWN1bGF0ZWRUeXBlIG9y aWdpbmFsKQogewogICAgIGF1dG8gbG9ja2VyID0gaG9sZExvY2sobV9sb2NrKTsKICAgICB1aW50 MzJfdCBoaWdoID0gbV9yYW5kb20uZ2V0VWludDMyKCk7CiAgICAgdWludDMyX3QgbG93ID0gbV9y YW5kb20uZ2V0VWludDMyKCk7CiAgICAgU3BlY3VsYXRlZFR5cGUgZ2VuZXJhdGVkID0gc3RhdGlj X2Nhc3Q8U3BlY3VsYXRlZFR5cGU+KChzdGF0aWNfY2FzdDx1aW50NjRfdD4oaGlnaCkgPDwgMzIp IHwgbG93KSAmIFNwZWNGdWxsVG9wOwogICAgIGlmIChPcHRpb25zOjpkdW1wUmFuZG9taXppbmdG dXp6ZXJBZ2VudFByZWRpY3Rpb25zKCkpCi0gICAgICAgIGRhdGFMb2dMbigiZ2V0UHJlZGljdGlv biBuYW1lOigiLCBjb2RlQmxvY2stPmluZmVycmVkTmFtZSgpLCAiIyIsIGNvZGVCbG9jay0+aGFz aEFzU3RyaW5nSWZQb3NzaWJsZSgpLCAiKSxieXRlY29kZUluZGV4OigiLCBieXRlY29kZUluZGV4 LCAiKSxvcmlnaW5hbDooIiwgU3BlY3VsYXRpb25EdW1wKG9yaWdpbmFsKSwgIiksZ2VuZXJhdGVk OigiLCBTcGVjdWxhdGlvbkR1bXAoZ2VuZXJhdGVkKSwgIikiKTsKKyAgICAgICAgZGF0YUxvZ0xu KCJnZXRQcmVkaWN0aW9uIG5hbWU6KCIsIGNvZGVCbG9jay0+aW5mZXJyZWROYW1lKCksICIjIiwg Y29kZUJsb2NrLT5oYXNoQXNTdHJpbmdJZlBvc3NpYmxlKCksICIpLGJ5dGVjb2RlSW5kZXg6KCIs IGNvZGVPcmlnaW4uYnl0ZWNvZGVJbmRleCgpLCAiKSxvcmlnaW5hbDooIiwgU3BlY3VsYXRpb25E dW1wKG9yaWdpbmFsKSwgIiksZ2VuZXJhdGVkOigiLCBTcGVjdWxhdGlvbkR1bXAoZ2VuZXJhdGVk KSwgIikiKTsKICAgICByZXR1cm4gZ2VuZXJhdGVkOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SYW5kb21pemluZ0Z1enplckFnZW50LmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SYW5kb21pemluZ0Z1enplckFnZW50LmgKaW5kZXggNzU1 MjNkNTI2NWQzNGRkMGFlNTRkOGYyZGNlZGI4OGJjZTIwZjk2Ni4uNDcyMjc3YWE2NGYzZTFkZjVm NTM2NTA3MDlmYzk1NGVhYzNmY2RiNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmFuZG9taXppbmdGdXp6ZXJBZ2VudC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1JhbmRvbWl6aW5nRnV6emVyQWdlbnQuaApAQCAtMzcsNyArMzcsNyBAQCBj bGFzcyBSYW5kb21pemluZ0Z1enplckFnZW50IGZpbmFsIDogcHVibGljIEZ1enplckFnZW50IHsK IHB1YmxpYzoKICAgICBSYW5kb21pemluZ0Z1enplckFnZW50KFZNJik7CiAKLSAgICBTcGVjdWxh dGVkVHlwZSBnZXRQcmVkaWN0aW9uKENvZGVCbG9jayosIGludCBieXRlY29kZU9mZnNldCwgU3Bl Y3VsYXRlZFR5cGUpIG92ZXJyaWRlOworICAgIFNwZWN1bGF0ZWRUeXBlIGdldFByZWRpY3Rpb24o Q29kZUJsb2NrKiwgY29uc3QgQ29kZU9yaWdpbiYsIFNwZWN1bGF0ZWRUeXBlKSBvdmVycmlkZTsK IAogcHJpdmF0ZToKICAgICBXZWFrUmFuZG9tIG1fcmFuZG9tOwo=