196588 2019-04-03 19:18:37 -0700 The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash 2019-04-04 08:45:34 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue darin fujii ggaren rniwa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1524111 0 cdumez 2019-04-03 19:18:37 -0700 The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash. 1524112 1 cdumez 2019-04-03 19:19:27 -0700 <rdar://problem/49365787> 1524114 2 366693 cdumez 2019-04-03 19:22:11 -0700 Created attachment 366693 Patch 1524129 3 366693 simon.fraser 2019-04-03 20:08:46 -0700 Comment on attachment 366693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366693&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:6779 > m_mainFrame = nullptr; > + m_focusedFrame = nullptr; > + m_frameSetLargestFrame = nullptr; It would be nice to move all the data members which come from a specific web process into a struct, and clear the struct rather than doing it this more fragile way. 1524131 4 366693 commit-queue 2019-04-03 20:09:54 -0700 Comment on attachment 366693 Patch Clearing flags on attachment: 366693 Committed r243848: <https://trac.webkit.org/changeset/243848> 1524132 5 commit-queue 2019-04-03 20:09:56 -0700 All reviewed patches have been landed. Closing bug. 1524133 6 366693 darin 2019-04-03 20:17:35 -0700 Comment on attachment 366693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366693&action=review > Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:141 > +TEST(WebKit, FrameSetLargestFramAfterCrash) Fram 1524136 7 cdumez 2019-04-03 20:23:34 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 366693 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366693&action=review > > > Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:141 > > +TEST(WebKit, FrameSetLargestFramAfterCrash) > > Fram Fixed in <https://trac.webkit.org/changeset/243849>, thank you. 1524158 8 fujii 2019-04-03 22:19:36 -0700 Windows port can't compile. > ..\..\Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(136): error C3861: 'kill': identifier not found Should I replace 'kill' with WKPageTerminate? 1524161 9 rniwa 2019-04-03 22:38:44 -0700 (In reply to Fujii Hironori from comment #8) > Windows port can't compile. > > > ..\..\Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(136): error C3861: 'kill': identifier not found > > Should I replace 'kill' with WKPageTerminate? Yes! 1524162 10 fujii 2019-04-03 22:45:15 -0700 Committed r243858: <https://trac.webkit.org/changeset/243858> 1524203 11 cdumez 2019-04-04 06:57:28 -0700 (In reply to Fujii Hironori from comment #8) > Windows port can't compile. > > > ..\..\Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(136): error C3861: 'kill': identifier not found > > Should I replace 'kill' with WKPageTerminate? I seem to remember the crash handler was not called with wkpageterminate and the test would time out, which is why I used kill. 1524205 12 cdumez 2019-04-04 07:05:05 -0700 (In reply to Chris Dumez from comment #11) > (In reply to Fujii Hironori from comment #8) > > Windows port can't compile. > > > > > ..\..\Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(136): error C3861: 'kill': identifier not found > > > > Should I replace 'kill' with WKPageTerminate? > > I seem to remember the crash handler was not called with wkpageterminate and > the test would time out, which is why I used kill. Look at the bots, your follow up change made the tests time out on all platforms... please fix. 1524206 13 cdumez 2019-04-04 07:05:28 -0700 (In reply to Ryosuke Niwa from comment #9) > (In reply to Fujii Hironori from comment #8) > > Windows port can't compile. > > > > > ..\..\Tools\TestWebKitAPI\Tests\WebKit\ReloadPageAfterCrash.cpp(136): error C3861: 'kill': identifier not found > > > > Should I replace 'kill' with WKPageTerminate? > > Yes! No :’( 1524239 14 cdumez 2019-04-04 08:45:34 -0700 Rolled out Fujii's r243858 in <https://trac.webkit.org/changeset/243870> and disabled the new tests on Windows instead for now. 366693 2019-04-03 19:22:11 -0700 2019-04-03 20:09:54 -0700 Patch bug-196588-20190403192210.patch text/plain 6012 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZkYTNmNjE3NTM1YzEzMzkz Zjk0MmNhOTQ5MzQ1MzdkYTc3ODJjOTcuLjcyM2EzYjBlMDE3OGJlMDA3NDVjNGU0ZWJhYzFmNjVh ZWY4NGQzNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgcGFnZSdzIGZvY3VzZWRGcmFt ZSAvIGZyYW1lU2V0TGFyZ2VzdEZyYW1lIGRvIG5vdCBnZXQgY2xlYXJlZCBvbiBwcm9jZXNzIHN3 YXAgb3IgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjU4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkzNjU3ODc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBhZ2UncyBmb2N1c2Vk RnJhbWUgLyBmcmFtZVNldExhcmdlc3RGcmFtZSBkbyBub3QgZ2V0IGNsZWFyZWQgb24gcHJvY2Vz cyBzd2FwIG9yIGNyYXNoLgorICAgICAgICBUaGlzIGNhbiBsZWFkIHRvIHJldHVybmluZyBzdGFs ZSBmcmFtZXMgdG8gdGhlIGNsaWVudCBpZiBpdCBhc2tzIGZvciB0aG9zZS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJv eHk6OnJlc2V0U3RhdGUpOgorCiAyMDE5LTA0LTAzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9yIC1hcHBsZS10cmFp bGluZy13b3JkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAx MmMzMzQ0ZDIyYjRjMzI4MjE0YzdmMzM1NzBmMjE3MjdiNDU3ZDYwLi5lYTQxMWJhMzUwYWNmYjJj MDI5MGFmOGI2ZDI3MjBkZTU0NDM2MmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKQEAgLTY3NzUsNiArNjc3NSw4IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpwcm9j ZXNzV2lsbEJlY29tZUZvcmVncm91bmQoKQogdm9pZCBXZWJQYWdlUHJveHk6OnJlc2V0U3RhdGUo UmVzZXRTdGF0ZVJlYXNvbiByZXNldFN0YXRlUmVhc29uKQogewogICAgIG1fbWFpbkZyYW1lID0g bnVsbHB0cjsKKyAgICBtX2ZvY3VzZWRGcmFtZSA9IG51bGxwdHI7CisgICAgbV9mcmFtZVNldExh cmdlc3RGcmFtZSA9IG51bGxwdHI7CiAKICNpZiBQTEFURk9STShDT0NPQSkKICAgICBtX3Njcm9s bGluZ1BlcmZvcm1hbmNlRGF0YSA9IG51bGxwdHI7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDE0MzM0ZmU4NjI2ZjVkY2I4ODRiZjRlYmEwYjZi ZmVjNDBlZTI0Yi4uMWQ1M2M1MWJhODAzNjU5NTdhMjZhM2U1YjY2ZGFhMDY4MzdhMGE2YiAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE5LTA0LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAg ICAgICAgVGhlIHBhZ2UncyBmb2N1c2VkRnJhbWUgLyBmcmFtZVNldExhcmdlc3RGcmFtZSBkbyBu b3QgZ2V0IGNsZWFyZWQgb24gcHJvY2VzcyBzd2FwIG9yIGNyYXNoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY1ODgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ5MzY1Nzg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBBUEkgdGVzdCBjb3ZlcmFnZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0L1JlbG9hZFBhZ2VBZnRlckNyYXNoLmNwcDoKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6Om51bGxKYXZhU2NyaXB0Q2FsbGJhY2spOgorICAgICAgICAoVGVzdFdlYktpdEFQ STo6ZGlkQ3Jhc2hDaGVja0ZyYW1lcyk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KwogMjAxOS0wNC0wMyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2V3cy1hcHBdIFN0YXR1cyBidWJibGUgc2hvdWxkIG5vdCBkaXNwbGF5IGNlcnRhaW4g aW5mcmFzdHJ1Y3R1cmUgc3RhdHVzIG1lc3NhZ2VzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdC9SZWxvYWRQYWdlQWZ0ZXJDcmFzaC5jcHAgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9SZWxvYWRQYWdlQWZ0ZXJDcmFzaC5jcHAKaW5kZXggNDcx MDUyNzUzMTM2NTc0ODYzN2FkNzc5MzliZDhkY2ZhNTZmMDdkYS4uMWU3YjM3M2I4YjEyNmNhZTRk NmQwYWQzM2NiNGIzZTNlMzNmYmNjOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQvUmVsb2FkUGFnZUFmdGVyQ3Jhc2guY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0L1JlbG9hZFBhZ2VBZnRlckNyYXNoLmNwcApAQCAtMzAsMTIgKzMw LDE1IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbmNsdWRlICJQbGF0Zm9y bVdlYlZpZXcuaCIKICNpbmNsdWRlICJUZXN0LmgiCisjaW5jbHVkZSA8V2ViS2l0L1dLUGFnZVBy aXZhdGUuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tSZXRhaW5QdHIuaD4KKyNpbmNsdWRlIDxzaWdu YWwuaD4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewogCiBzdGF0aWMgYm9vbCBsb2FkQmVm b3JlQ3Jhc2ggPSBmYWxzZTsKIHN0YXRpYyBib29sIGxvYWRBZnRlckNyYXNoID0gZmFsc2U7Citz dGF0aWMgYm9vbCBjYWxsZWRDcmFzaEhhbmRsZXIgPSBmYWxzZTsKIAogc3RhdGljIHZvaWQgZGlk RmluaXNoTG9hZChXS1BhZ2VSZWYgcGFnZSwgV0tOYXZpZ2F0aW9uUmVmLCBXS1R5cGVSZWYgdXNl ckRhdGEsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CkBAIC04OCw2ICs5MSw4MyBAQCBURVNU KFdlYktpdCwgUmVsb2FkUGFnZUFmdGVyQ3Jhc2gpCiAgICAgVXRpbDo6cnVuKCZsb2FkQWZ0ZXJD cmFzaCk7CiB9CiAKK3N0YXRpYyB2b2lkIG51bGxKYXZhU2NyaXB0Q2FsbGJhY2soV0tTZXJpYWxp emVkU2NyaXB0VmFsdWVSZWYsIFdLRXJyb3JSZWYsIHZvaWQqKQoreworfQorCitzdGF0aWMgdm9p ZCBkaWRDcmFzaENoZWNrRnJhbWVzKFdLUGFnZVJlZiBwYWdlLCBjb25zdCB2b2lkKikKK3sKKyAg ICAvLyBUZXN0IGlmIGZpcnN0IGxvYWQgYWN0dWFsbHkgd29ya2VkLgorICAgIEVYUEVDVF9UUlVF KGxvYWRCZWZvcmVDcmFzaCk7CisKKyAgICBFWFBFQ1RfVFJVRSghV0tQYWdlR2V0TWFpbkZyYW1l KHBhZ2UpKTsKKyAgICBFWFBFQ1RfVFJVRSghV0tQYWdlR2V0Rm9jdXNlZEZyYW1lKHBhZ2UpKTsK KyAgICBFWFBFQ1RfVFJVRSghV0tQYWdlR2V0RnJhbWVTZXRMYXJnZXN0RnJhbWUocGFnZSkpOwor CisgICAgY2FsbGVkQ3Jhc2hIYW5kbGVyID0gdHJ1ZTsKK30KKworVEVTVChXZWJLaXQsIEZvY3Vz ZWRGcmFtZUFmdGVyQ3Jhc2gpCit7CisgICAgV0tSZXRhaW5QdHI8V0tDb250ZXh0UmVmPiBjb250 ZXh0KEFkb3B0V0ssIFdLQ29udGV4dENyZWF0ZVdpdGhDb25maWd1cmF0aW9uKG51bGxwdHIpKTsK KyAgICBQbGF0Zm9ybVdlYlZpZXcgd2ViVmlldyhjb250ZXh0LmdldCgpKTsKKworICAgIFdLUGFn ZU5hdmlnYXRpb25DbGllbnRWMCBsb2FkZXJDbGllbnQ7CisgICAgbWVtc2V0KCZsb2FkZXJDbGll bnQsIDAsIHNpemVvZihsb2FkZXJDbGllbnQpKTsKKworICAgIGxvYWRlckNsaWVudC5iYXNlLnZl cnNpb24gPSAwOworICAgIGxvYWRlckNsaWVudC5kaWRGaW5pc2hOYXZpZ2F0aW9uID0gZGlkRmlu aXNoTG9hZDsKKyAgICBsb2FkZXJDbGllbnQud2ViUHJvY2Vzc0RpZENyYXNoID0gZGlkQ3Jhc2hD aGVja0ZyYW1lczsKKworICAgIFdLUGFnZVNldFBhZ2VOYXZpZ2F0aW9uQ2xpZW50KHdlYlZpZXcu cGFnZSgpLCAmbG9hZGVyQ2xpZW50LmJhc2UpOworCisgICAgV0tSZXRhaW5QdHI8V0tVUkxSZWY+ IHVybCA9IGFkb3B0V0soVXRpbDo6Y3JlYXRlVVJMRm9yUmVzb3VyY2UoIm1hbnktaWZyYW1lcyIs ICJodG1sIikpOworICAgIFdLUGFnZUxvYWRVUkwod2ViVmlldy5wYWdlKCksIHVybC5nZXQoKSk7 CisgICAgVXRpbDo6cnVuKCZsb2FkQmVmb3JlQ3Jhc2gpOworCisgICAgRVhQRUNUX0ZBTFNFKCFX S1BhZ2VHZXRNYWluRnJhbWUod2ViVmlldy5wYWdlKCkpKTsKKworICAgIFdLUmV0YWluUHRyPFdL U3RyaW5nUmVmPiBqYXZhU2NyaXB0U3RyaW5nKEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVU RjhDU3RyaW5nKCJmcmFtZXNbMl0uZm9jdXMoKSIpKTsKKyAgICBXS1BhZ2VSdW5KYXZhU2NyaXB0 SW5NYWluRnJhbWUod2ViVmlldy5wYWdlKCksIGphdmFTY3JpcHRTdHJpbmcuZ2V0KCksIDAsIG51 bGxKYXZhU2NyaXB0Q2FsbGJhY2spOworCisgICAgd2hpbGUgKCFXS1BhZ2VHZXRGb2N1c2VkRnJh bWUod2ViVmlldy5wYWdlKCkpKQorICAgICAgICBVdGlsOjpzcGluUnVuTG9vcCgxMCk7CisKKyAg ICBraWxsKFdLUGFnZUdldFByb2Nlc3NJZGVudGlmaWVyKHdlYlZpZXcucGFnZSgpKSwgOSk7CisK KyAgICBVdGlsOjpydW4oJmNhbGxlZENyYXNoSGFuZGxlcik7Cit9CisKK1RFU1QoV2ViS2l0LCBG cmFtZVNldExhcmdlc3RGcmFtQWZ0ZXJDcmFzaCkKK3sKKyAgICBXS1JldGFpblB0cjxXS0NvbnRl eHRSZWY+IGNvbnRleHQoQWRvcHRXSywgV0tDb250ZXh0Q3JlYXRlV2l0aENvbmZpZ3VyYXRpb24o bnVsbHB0cikpOworICAgIFBsYXRmb3JtV2ViVmlldyB3ZWJWaWV3KGNvbnRleHQuZ2V0KCkpOwor CisgICAgV0tQYWdlTmF2aWdhdGlvbkNsaWVudFYwIGxvYWRlckNsaWVudDsKKyAgICBtZW1zZXQo JmxvYWRlckNsaWVudCwgMCwgc2l6ZW9mKGxvYWRlckNsaWVudCkpOworCisgICAgbG9hZGVyQ2xp ZW50LmJhc2UudmVyc2lvbiA9IDA7CisgICAgbG9hZGVyQ2xpZW50LmRpZEZpbmlzaE5hdmlnYXRp b24gPSBkaWRGaW5pc2hMb2FkOworICAgIGxvYWRlckNsaWVudC53ZWJQcm9jZXNzRGlkQ3Jhc2gg PSBkaWRDcmFzaENoZWNrRnJhbWVzOworCisgICAgV0tQYWdlU2V0UGFnZU5hdmlnYXRpb25DbGll bnQod2ViVmlldy5wYWdlKCksICZsb2FkZXJDbGllbnQuYmFzZSk7CisKKyAgICBXS1JldGFpblB0 cjxXS1VSTFJlZj4gYmFzZVVSTCA9IGFkb3B0V0soV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJpbmco ImFib3V0OmJsYW5rIikpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBodG1sU3RyaW5n ID0gVXRpbDo6dG9XSygiPGZyYW1lc2V0IGNvbHM9JzI1JSwqLDI1JSc+PGZyYW1lIHNyYz0nYWJv dXQ6YmxhbmsnPjxmcmFtZSBzcmM9J2Fib3V0OmJsYW5rJz48ZnJhbWUgc3JjPSdhYm91dDpibGFu ayc+PC9mcmFtZXNldD4iKTsKKworICAgIFdLUGFnZUxvYWRIVE1MU3RyaW5nKHdlYlZpZXcucGFn ZSgpLCBodG1sU3RyaW5nLmdldCgpLCBiYXNlVVJMLmdldCgpKTsKKyAgICBVdGlsOjpydW4oJmxv YWRCZWZvcmVDcmFzaCk7CisKKyAgICBFWFBFQ1RfRkFMU0UoIVdLUGFnZUdldE1haW5GcmFtZSh3 ZWJWaWV3LnBhZ2UoKSkpOworCisgICAgd2hpbGUgKCFXS1BhZ2VHZXRGcmFtZVNldExhcmdlc3RG cmFtZSh3ZWJWaWV3LnBhZ2UoKSkpCisgICAgICAgIFV0aWw6OnNwaW5SdW5Mb29wKDEwKTsKKwor ICAgIGtpbGwoV0tQYWdlR2V0UHJvY2Vzc0lkZW50aWZpZXIod2ViVmlldy5wYWdlKCkpLCA5KTsK KworICAgIFV0aWw6OnJ1bigmY2FsbGVkQ3Jhc2hIYW5kbGVyKTsKK30KKwogfSAvLyBuYW1lc3Bh Y2UgVGVzdFdlYktpdEFQSQogCiAjZW5kaWYK