196586 2019-04-03 18:10:10 -0700 [JSC] Add dump feature for RandomizingFuzzerAgent 2019-04-03 22:27:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ryanhaddad saam webkit-bug-importer oldest_to_newest 1524089 0 ysuzuki 2019-04-03 18:10:10 -0700 [JSC] Add dump feature for RandomizingFuzzerAgent 1524091 1 366685 ysuzuki 2019-04-03 18:12:31 -0700 Created attachment 366685 Patch 1524092 2 ews-watchlist 2019-04-03 18:14:20 -0700 Attachment 366685 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer, fuzzer, fuzzer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1524095 3 ysuzuki 2019-04-03 18:28:55 -0700 Committed r243843: <https://trac.webkit.org/changeset/243843> 1524096 4 webkit-bug-importer 2019-04-03 18:33:36 -0700 <rdar://problem/49585901> 1524134 5 ryanhaddad 2019-04-03 20:22:34 -0700 This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3414 c:\cygwin\home\buildbot\worker\win10-release\build\source\javascriptcore\runtime\randomizingfuzzeragent.cpp(43): error C2027: use of undefined type 'JSC::CodeBlock' (compiling source file C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-27.cpp) [C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] 1524135 6 ryanhaddad 2019-04-03 20:23:30 -0700 It also broke the CLoop build: https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/13372 ./runtime/RandomizingFuzzerAgent.cpp:43:52: error: member access into incomplete type 'JSC::CodeBlock' ./runtime/RandomizingFuzzerAgent.cpp:43:84: error: member access into incomplete type 'JSC::CodeBlock' 1524148 7 ryanhaddad 2019-04-03 20:44:25 -0700 Reverted r243843 for reason: Broke CLoop and Windows builds. Committed r243853: <https://trac.webkit.org/changeset/243853> 1524159 8 ysuzuki 2019-04-03 22:27:39 -0700 Committed r243857: <https://trac.webkit.org/changeset/243857> 366685 2019-04-03 18:12:31 -0700 2019-04-03 18:20:00 -0700 Patch bug-196586-20190403181230.patch text/plain 4147 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDI0ODY0NjFkZmYyNWQwMDVjYjJlNzA3ZDE2OWY2NDliNTkwZWFlLi44Y2RjMmMzMDk2N2JkYWM1 YjIwOTMyOTIzYzYwODQyOTZlZjUxMzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wNC0wMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBkdW1wIGZlYXR1cmUgZm9yIFJhbmRvbWl6aW5nRnV6emVy QWdlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NjU4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRv d2FyZHMgZGV0ZXJtaW5pc3RpYyB0ZXN0cyBmb3IgdGhlIHJlc3VsdHMgZnJvbSByYW5kb21pemlu ZyBmdXp6ZXIgYWdlbnQsIHRoaXMgcGF0Y2ggYWRkcyBPcHRpb25zOjpkdW1wUmFuZG9taXppbmdG dXp6ZXJBZ2VudFByZWRpY3Rpb25zLCB3aGljaCBkdW1wcyB0aGUgZ2VuZXJhdGVkIHR5cGVzLgor ICAgICAgICBUaGUgcmVzdWx0cyBpcyBsaWtlIHRoaXMuCisKKyAgICAgICAgICAgIGdldFByZWRp Y3Rpb24gbmFtZTooI0MycTl4RCksYnl0ZWNvZGVJbmRleDooMjIpLG9yaWdpbmFsOihBcnJheSks Z2VuZXJhdGVkOihPdGhlck9ianxBcnJheXxGbG9hdDY0QXJyYXl8QmlnSW50fE5vbkludEFzRG91 YmxlKQorICAgICAgICAgICAgZ2V0UHJlZGljdGlvbiBuYW1lOihtYWtlVW53cml0ZWFibGVVbmNv bmZpZ3VyYWJsZU9iamVjdCNBaUVKdjEpLGJ5dGVjb2RlSW5kZXg6KDE0KSxvcmlnaW5hbDooT3Ro ZXJPYmopLGdlbmVyYXRlZDooRmluYWx8VWludDhBcnJheXxGbG9hdDY0QXJyYXl8U2V0T2JqZWN0 fFdlYWtTZXRPYmplY3R8QmlnSW50fE5vbkludEFzRG91YmxlKQorCisgICAgICAgICogcnVudGlt ZS9PcHRpb25zLmNwcDoKKyAgICAgICAgKEpTQzo6cmVjb21wdXRlRGVwZW5kZW50T3B0aW9ucyk6 CisgICAgICAgICogcnVudGltZS9PcHRpb25zLmg6CisgICAgICAgICogcnVudGltZS9SYW5kb21p emluZ0Z1enplckFnZW50LmNwcDoKKyAgICAgICAgKEpTQzo6UmFuZG9taXppbmdGdXp6ZXJBZ2Vu dDo6Z2V0UHJlZGljdGlvbik6CisKIDIwMTktMDQtMDMgIE15bGVzIEMuIE1heGZpZWxkICA8bW1h eGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICAtYXBwbGUtdHJhaWxpbmctd29yZCBpcyBuZWVk ZWQgZm9yIGJyb3dzZXIgZGV0ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PcHRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnMuY3BwCmluZGV4IGVhOGI5MGFiYmIxN2FlZWZmNmEwOGIwN2RmM2VkZmM5YjdiNTZiZjku LjhlOGQzYWVmNWQxOGU0NjE1NTllYjg4NzI5MWNiNGQyOTM2MzY4YmMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCkBAIC00NTEsNyArNDUxLDggQEAgc3RhdGlj IHZvaWQgcmVjb21wdXRlRGVwZW5kZW50T3B0aW9ucygpCiAgICAgICAgIHx8IE9wdGlvbnM6Omxv Z1BoYXNlVGltZXMoKQogICAgICAgICB8fCBPcHRpb25zOjp2ZXJib3NlQ0ZBKCkKICAgICAgICAg fHwgT3B0aW9uczo6dmVyYm9zZURGR0ZhaWx1cmUoKQotICAgICAgICB8fCBPcHRpb25zOjp2ZXJi b3NlRlRMRmFpbHVyZSgpKQorICAgICAgICB8fCBPcHRpb25zOjp2ZXJib3NlRlRMRmFpbHVyZSgp CisgICAgICAgIHx8IE9wdGlvbnM6OmR1bXBSYW5kb21pemluZ0Z1enplckFnZW50UHJlZGljdGlv bnMoKSkKICAgICAgICAgT3B0aW9uczo6YWx3YXlzQ29tcHV0ZUhhc2goKSA9IHRydWU7CiAgICAg CiAgICAgaWYgKCFPcHRpb25zOjp1c2VDb25jdXJyZW50R0MoKSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wdGlvbnMuaAppbmRleCA5ODM3OTg5MmJmNzM5Yjg4MmYyYzIwYTY5ODJkYTQx YTUyNWQ5ZWM2Li4yNDIwNmU0ODc5OGM0OWUwOTI1NjhmYjRiZmQ4NzA3MmVkZWNjMjgxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCkBAIC00MzYsNiArNDM2LDcgQEAg Y29uc3RleHByIGJvb2wgZW5hYmxlV2ViQXNzZW1ibHlTdHJlYW1pbmdBcGkgPSBmYWxzZTsKICAg ICBcCiAgICAgdihib29sLCB1c2VSYW5kb21pemluZ0Z1enplckFnZW50LCBmYWxzZSwgTm9ybWFs LCBudWxscHRyKSBcCiAgICAgdih1bnNpZ25lZCwgc2VlZE9mUmFuZG9taXppbmdGdXp6ZXJBZ2Vu dCwgMSwgTm9ybWFsLCBudWxscHRyKSBcCisgICAgdihib29sLCBkdW1wUmFuZG9taXppbmdGdXp6 ZXJBZ2VudFByZWRpY3Rpb25zLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgXAogICAg IHYoYm9vbCwgbG9nUGhhc2VUaW1lcywgZmFsc2UsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYo ZG91YmxlLCByYXJlQmxvY2tQZW5hbHR5LCAwLjAwMSwgTm9ybWFsLCBudWxscHRyKSBcCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SYW5kb21pemluZ0Z1enplckFn ZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JhbmRvbWl6aW5nRnV6emVy QWdlbnQuY3BwCmluZGV4IDc0N2FkNmEyMzg5ZGQwODAwODZiN2ZjZjMxYThjMDAwMTIwMzE5MTYu LjgzZTVjNTA0YzFmNWQyZjViNzc2MThjZDU4ZDMwYjMxMjgzNTYxOWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JhbmRvbWl6aW5nRnV6emVyQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JhbmRvbWl6aW5nRnV6emVyQWdlbnQu Y3BwCkBAIC0zMywxMyArMzMsMTUgQEAgUmFuZG9taXppbmdGdXp6ZXJBZ2VudDo6UmFuZG9taXpp bmdGdXp6ZXJBZ2VudChWTSYpCiB7CiB9CiAKLVNwZWN1bGF0ZWRUeXBlIFJhbmRvbWl6aW5nRnV6 emVyQWdlbnQ6OmdldFByZWRpY3Rpb24oQ29kZUJsb2NrKiwgaW50LCBTcGVjdWxhdGVkVHlwZSkK K1NwZWN1bGF0ZWRUeXBlIFJhbmRvbWl6aW5nRnV6emVyQWdlbnQ6OmdldFByZWRpY3Rpb24oQ29k ZUJsb2NrKiBjb2RlQmxvY2ssIGludCBieXRlY29kZUluZGV4LCBTcGVjdWxhdGVkVHlwZSBvcmln aW5hbCkKIHsKICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fbG9jayk7CiAgICAgdWludDMy X3QgaGlnaCA9IG1fcmFuZG9tLmdldFVpbnQzMigpOwogICAgIHVpbnQzMl90IGxvdyA9IG1fcmFu ZG9tLmdldFVpbnQzMigpOwotICAgIHVpbnQ2NF90IHJlc3VsdCA9IChzdGF0aWNfY2FzdDx1aW50 NjRfdD4oaGlnaCkgPDwgMzIpIHwgbG93OwotICAgIHJldHVybiBzdGF0aWNfY2FzdDxTcGVjdWxh dGVkVHlwZT4ocmVzdWx0KSAmIFNwZWNGdWxsVG9wOworICAgIFNwZWN1bGF0ZWRUeXBlIGdlbmVy YXRlZCA9IHN0YXRpY19jYXN0PFNwZWN1bGF0ZWRUeXBlPigoc3RhdGljX2Nhc3Q8dWludDY0X3Q+ KGhpZ2gpIDw8IDMyKSB8IGxvdykgJiBTcGVjRnVsbFRvcDsKKyAgICBpZiAoT3B0aW9uczo6ZHVt cFJhbmRvbWl6aW5nRnV6emVyQWdlbnRQcmVkaWN0aW9ucygpKQorICAgICAgICBkYXRhTG9nTG4o ImdldFByZWRpY3Rpb24gbmFtZTooIiwgY29kZUJsb2NrLT5pbmZlcnJlZE5hbWUoKSwgIiMiLCBj b2RlQmxvY2stPmhhc2hBc1N0cmluZ0lmUG9zc2libGUoKSwgIiksYnl0ZWNvZGVJbmRleDooIiwg Ynl0ZWNvZGVJbmRleCwgIiksb3JpZ2luYWw6KCIsIFNwZWN1bGF0aW9uRHVtcChvcmlnaW5hbCks ICIpLGdlbmVyYXRlZDooIiwgU3BlY3VsYXRpb25EdW1wKGdlbmVyYXRlZCksICIpIik7CisgICAg cmV0dXJuIGdlbmVyYXRlZDsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==