196573 2019-04-03 15:54:27 -0700 Add logging and ASSERTs to investigate issue with VPModuleInitialize 2019-04-03 20:36:17 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1524008 0 youennf 2019-04-03 15:54:27 -0700 Add logging and ASSERTs to investigate issue with VPModuleInitialize 1524017 1 366663 youennf 2019-04-03 16:12:54 -0700 Created attachment 366663 Patch 1524097 2 366688 youennf 2019-04-03 18:38:52 -0700 Created attachment 366688 Patch 1524116 3 366688 eric.carlson 2019-04-03 19:49:41 -0700 Comment on attachment 366688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366688&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:81 > + if (!library) > + fprintf(stderr, "Cannot find VideoProcessingLibrary: %s\n", dlerror()); > + softLinkVideoProcessingVPModuleInitialize = (void (*)()) dlsym(library, "VPModuleInitialize"); > + if (!softLinkVideoProcessingVPModuleInitialize) > + fprintf(stderr, "Cannot find function VPModuleInitialize: %s\n", dlerror()); Is it OK that we will crash after logging either of these errors? Is it possible to fall back to use an alternative library if this fails? 1524128 4 youennf 2019-04-03 20:07:50 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 366688 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366688&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:81 > > + if (!library) > > + fprintf(stderr, "Cannot find VideoProcessingLibrary: %s\n", dlerror()); > > + softLinkVideoProcessingVPModuleInitialize = (void (*)()) dlsym(library, "VPModuleInitialize"); > > + if (!softLinkVideoProcessingVPModuleInitialize) > > + fprintf(stderr, "Cannot find function VPModuleInitialize: %s\n", dlerror()); > > Is it OK that we will crash after logging either of these errors? Is it > possible to fall back to use an alternative library if this fails? This patch is merely trying to investigate things and it is good to continue crashing to further investigate. If we do not find a solution, we could try to skip calling VPModuleInitialize. It might be that encoding would fail or would fallback to the regular VTB encoder. 1524138 5 366688 commit-queue 2019-04-03 20:34:58 -0700 Comment on attachment 366688 Patch Clearing flags on attachment: 366688 Committed r243850: <https://trac.webkit.org/changeset/243850> 1524139 6 commit-queue 2019-04-03 20:35:00 -0700 All reviewed patches have been landed. Closing bug. 1524140 7 webkit-bug-importer 2019-04-03 20:36:17 -0700 <rdar://problem/49590120> 366663 2019-04-03 16:12:54 -0700 2019-04-03 18:38:51 -0700 Patch bug-196573-20190403161253.patch text/plain 5101 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAyNmI2NjQyMzk2NTk3MGRkMDQ1NTZkN2M4MTAxMThhZDE5N2NhNGY0Li5lZjI0 ZTRiNjc0ZjExNTE0M2U3YmQ3OTk5NDYzMWFlMGZiODNhMjkxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wNC0wMyAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dpbmcgYW5kIEFTU0VS VHMgdG8gaW52ZXN0aWdhdGUgaXNzdWUgd2l0aCBWUE1vZHVsZUluaXRpYWxpemUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjU3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGFuZCBtYWNyb3MgZGly ZWN0bHkgdG8gYWRkIHNvbWUgbG9nZ2luZy4KKyAgICAgICAgUmVtb3ZlZCB0aGUgZGlzcGF0Y2hf b25jZSBzaW5jZSBWUE1vZHVsZUluaXRpYWxpemUgaXMgYWxyZWFkeSBjYWxsZWQgaW4gb25lLgor CisgICAgICAgICogU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1ZpZGVvUHJvY2Vzc2luZ1NvZnRM aW5rLmNwcDoKKyAgICAgICAgKHdlYnJ0Yzo6aW5pdFZpZGVvUHJvY2Vzc2luZ1ZQTW9kdWxlSW5p dGlhbGl6ZSk6CisKIDIwMTktMDQtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBsaWJ3ZWJydGMgZmlsZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBmY2I4ODA2ODgzNWRhMGMwMmViNWMxOTI0YmY5MjgwNjIwYzg1MGUzLi5hNjZkMzExYWI3NjMx N2U5ZTI3NzY0MTU5NWVjNTc1NTM4YjIxYTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTktMDQtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBsb2dnaW5nIGFuZCBBU1NFUlRzIHRvIGludmVzdGlnYXRlIGlzc3VlIHdpdGggVlBNb2R1 bGVJbml0aWFsaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTY1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgc29tZSBBU1NFUlRzLgorICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlk ZXJDb2NvYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENQcm92aWRlckNvY29hOjpj cmVhdGVEZWNvZGVyRmFjdG9yeSk6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENQcm92aWRl ckNvY29hOjpjcmVhdGVFbmNvZGVyRmFjdG9yeSk6CisKIDIwMTktMDQtMDIgIFlvdWVubiBGYWJs ZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBtYWtlUGVuZGluZ0FjdGl2aXR5 IGluIERPTUNhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291 cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1ZpZGVvUHJvY2Vzc2luZ1NvZnRMaW5rLmNwcCBiL1NvdXJj ZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvVmlkZW9Qcm9j ZXNzaW5nU29mdExpbmsuY3BwCmluZGV4IDEwMWU4N2M2Njc3NzA0NGExZWE1NTdkMmE1ODYwZTUw YTlmMTMzNmEuLjk5OTdlZGRhN2E4MGQzYTEzZDAxZmYxMjVmN2JiNDQ4OTVhOWFmNjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJL aXQvVmlkZW9Qcm9jZXNzaW5nU29mdExpbmsuY3BwCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvVmlkZW9Qcm9jZXNzaW5nU29mdExpbmsu Y3BwCkBAIC03Myw2ICs3MywyMSBAQCBTT0ZUX0xJTktfRlVOQ1RJT05fRk9SX1NPVVJDRSh3ZWJy dGMsIFZpZGVvUHJvY2Vzc2luZywgVkNQQ29tcHJlc3Npb25TZXNzaW9uR2V0UAogU09GVF9MSU5L X0ZVTkNUSU9OX0ZPUl9TT1VSQ0Uod2VicnRjLCBWaWRlb1Byb2Nlc3NpbmcsIFZDUENvbXByZXNz aW9uU2Vzc2lvbkVuY29kZUZyYW1lLCBPU1N0YXR1cywgKFZDUENvbXByZXNzaW9uU2Vzc2lvblJl ZiBzZXNzaW9uLCBDVkltYWdlQnVmZmVyUmVmIGJ1ZmZlciwgQ01UaW1lIHRpbWVzdGFtcCwgQ01U aW1lIHRpbWUsIENGRGljdGlvbmFyeVJlZiBkaWN0aW9uYXJ5LCB2b2lkKiBkYXRhLCBWVEVuY29k ZUluZm9GbGFncyogZmxhZ3MpLCAoc2Vzc2lvbiwgYnVmZmVyLCB0aW1lc3RhbXAsIHRpbWUsIGRp Y3Rpb25hcnksIGRhdGEsIGZsYWdzKSkKIFNPRlRfTElOS19GVU5DVElPTl9GT1JfU09VUkNFKHdl YnJ0YywgVmlkZW9Qcm9jZXNzaW5nLCBWQ1BDb21wcmVzc2lvblNlc3Npb25DcmVhdGUsIE9TU3Rh dHVzLCAoQ0ZBbGxvY2F0b3JSZWYgYWxsb2NhdG9yMSwgaW50MzJfdCB2YWx1ZTEgLCBpbnQzMl90 IHZhbHVlMiwgQ01WaWRlb0NvZGVjVHlwZSB0eXBlLCBDRkRpY3Rpb25hcnlSZWYgZGljdGlvbmFy eTEsIENGRGljdGlvbmFyeVJlZiBkaWN0aW9uYXJ5MiwgQ0ZBbGxvY2F0b3JSZWYgYWxsb2NhdG9y MywgVlRDb21wcmVzc2lvbk91dHB1dENhbGxiYWNrIGNhbGxiYWNrLCB2b2lkKiBkYXRhLCBWQ1BD b21wcmVzc2lvblNlc3Npb25SZWYqIHNlc3Npb24pLCAoYWxsb2NhdG9yMSwgdmFsdWUxLCB2YWx1 ZTIsIHR5cGUsIGRpY3Rpb25hcnkxLCBkaWN0aW9uYXJ5MiwgYWxsb2NhdG9yMywgY2FsbGJhY2ss IGRhdGEsIHNlc3Npb24pKQogU09GVF9MSU5LX0ZVTkNUSU9OX0ZPUl9TT1VSQ0Uod2VicnRjLCBW aWRlb1Byb2Nlc3NpbmcsIFZDUENvbXByZXNzaW9uU2Vzc2lvbkludmFsaWRhdGUsIHZvaWQsIChW Q1BDb21wcmVzc2lvblNlc3Npb25SZWYgc2Vzc2lvbiksIChzZXNzaW9uKSkKLVNPRlRfTElOS19G VU5DVElPTl9GT1JfU09VUkNFKHdlYnJ0YywgVmlkZW9Qcm9jZXNzaW5nLCBWUE1vZHVsZUluaXRp YWxpemUsIHZvaWQsICgpLCAoKSkKKworbmFtZXNwYWNlIHdlYnJ0YyB7CitzdGF0aWMgdm9pZCBp bml0VmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXplKCk7Cit2b2lkICgqc29mdExpbmtW aWRlb1Byb2Nlc3NpbmdWUE1vZHVsZUluaXRpYWxpemUpICgpID0gaW5pdFZpZGVvUHJvY2Vzc2lu Z1ZQTW9kdWxlSW5pdGlhbGl6ZTsKK3N0YXRpYyB2b2lkIGluaXRWaWRlb1Byb2Nlc3NpbmdWUE1v ZHVsZUluaXRpYWxpemUoKQoreworICAgIGF1dG8qIGxpYnJhcnkgPSBWaWRlb1Byb2Nlc3NpbmdM aWJyYXJ5KCk7CisgICAgaWYgKCFsaWJyYXJ5KQorICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkNh bm5vdCBmaW5kIFZpZGVvUHJvY2Vzc2luZ0xpYnJhcnk6ICVzXG4iLCBkbGVycm9yKCkpOworICAg IHNvZnRMaW5rVmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXplID0gKHZvaWQgKCopKCkp IGRsc3ltKGxpYnJhcnksICJWUE1vZHVsZUluaXRpYWxpemUiKTsKKyAgICBpZiAoIXNvZnRMaW5r VmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXplKQorICAgICAgICBmcHJpbnRmKHN0ZGVy ciwgIkNhbm5vdCBmaW5kIGZ1bmN0aW9uIFZQTW9kdWxlSW5pdGlhbGl6ZTogJXNcbiIsIGRsZXJy b3IoKSk7CisgICAgc29mdExpbmtWaWRlb1Byb2Nlc3NpbmdWUE1vZHVsZUluaXRpYWxpemUoKTsK K30KKworfQogCiAjZW5kaWYgLy8gRU5BQkxFX1ZDUF9FTkNPREVSCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlk ZXJDb2NvYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJy dGMvTGliV2ViUlRDUHJvdmlkZXJDb2NvYS5jcHAKaW5kZXggMWE0ZDNlNjRlNTUzNjVlY2VlNWI4 NDg0NDc5MzM0ZjQxNjQzNWQyOS4uZTc4NGMzNTViYTA0YTFlYjMzNjBiNzc4ZmE5MzM2NDdiYTY4 MTY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyQ29jb2EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNwcApA QCAtNTEsMTIgKzUxLDE2IEBAIHZvaWQgTGliV2ViUlRDUHJvdmlkZXJDb2NvYTo6c2V0SDI2NEhh cmR3YXJlRW5jb2RlckFsbG93ZWQoYm9vbCBhbGxvd2VkKQogCiBzdGQ6OnVuaXF1ZV9wdHI8d2Vi cnRjOjpWaWRlb0RlY29kZXJGYWN0b3J5PiBMaWJXZWJSVENQcm92aWRlckNvY29hOjpjcmVhdGVE ZWNvZGVyRmFjdG9yeSgpCiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKwogICAgIGF1 dG8gY29kZWNTdXBwb3J0ID0gbV9zdXBwb3J0c1ZQOCA/IHdlYnJ0Yzo6V2ViS2l0Q29kZWNTdXBw b3J0OjpIMjY0QW5kVlA4IDogd2VicnRjOjpXZWJLaXRDb2RlY1N1cHBvcnQ6OkgyNjQ7CiAgICAg cmV0dXJuIHdlYnJ0Yzo6Y3JlYXRlV2ViS2l0RGVjb2RlckZhY3RvcnkoY29kZWNTdXBwb3J0KTsK IH0KIAogc3RkOjp1bmlxdWVfcHRyPHdlYnJ0Yzo6VmlkZW9FbmNvZGVyRmFjdG9yeT4gTGliV2Vi UlRDUHJvdmlkZXJDb2NvYTo6Y3JlYXRlRW5jb2RlckZhY3RvcnkoKQogeworICAgIEFTU0VSVChp c01haW5UaHJlYWQoKSk7CisKICAgICBhdXRvIGNvZGVjU3VwcG9ydCA9IG1fc3VwcG9ydHNWUDgg PyB3ZWJydGM6OldlYktpdENvZGVjU3VwcG9ydDo6SDI2NEFuZFZQOCA6IHdlYnJ0Yzo6V2ViS2l0 Q29kZWNTdXBwb3J0OjpIMjY0OwogICAgIHJldHVybiB3ZWJydGM6OmNyZWF0ZVdlYktpdEVuY29k ZXJGYWN0b3J5KGNvZGVjU3VwcG9ydCk7CiB9Cg== 366688 2019-04-03 18:38:52 -0700 2019-04-03 20:34:58 -0700 Patch bug-196573-20190403183851.patch text/plain 4184 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA0MjA0NTJmMjMzOTM3M2M4NGE3OTk3MGI4MWYyMDAwMThlNjFkMzFhLi4yZjUw OGU5ZTFmYTI0MWI3ZjdhMjVmOGU1NGMzYjkzMzU5ZTdmMmY5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wNC0wMyAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dpbmcgYW5kIEFTU0VS VHMgdG8gaW52ZXN0aWdhdGUgaXNzdWUgd2l0aCBWUE1vZHVsZUluaXRpYWxpemUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjU3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGFuZCBtYWNyb3MgZGly ZWN0bHkgdG8gYWRkIHNvbWUgbG9nZ2luZy4KKyAgICAgICAgUmVtb3ZlZCB0aGUgZGlzcGF0Y2hf b25jZSBzaW5jZSBWUE1vZHVsZUluaXRpYWxpemUgaXMgYWxyZWFkeSBjYWxsZWQgaW4gb25lLgor CisgICAgICAgICogU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1ZpZGVvUHJvY2Vzc2luZ1NvZnRM aW5rLmNwcDoKKyAgICAgICAgKHdlYnJ0Yzo6aW5pdFZpZGVvUHJvY2Vzc2luZ1ZQTW9kdWxlSW5p dGlhbGl6ZSk6CisKIDIwMTktMDQtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBsaWJ3ZWJydGMgZmlsZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBkNWZkMGEyOTZkYTk5MmRlYjQ3ZDYxYTczNjM5Y2RjNWZhNWU3NzZmLi5jZGFhNGY3ZGFmNDY2 NGU4OGE1OGRkNDlmNWNiMDVkN2VkMDU4OTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTktMDQtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBsb2dnaW5nIGFuZCBBU1NFUlRzIHRvIGludmVzdGlnYXRlIGlzc3VlIHdpdGggVlBNb2R1 bGVJbml0aWFsaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTY1NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgc29tZSBBU1NFUlRzLgorICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlk ZXJDb2NvYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENQcm92aWRlckNvY29hOjpj cmVhdGVEZWNvZGVyRmFjdG9yeSk6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENQcm92aWRl ckNvY29hOjpjcmVhdGVFbmNvZGVyRmFjdG9yeSk6CisKIDIwMTktMDQtMDMgIE15bGVzIEMuIE1h eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICAtYXBwbGUtdHJhaWxpbmct d29yZCBpcyBuZWVkZWQgZm9yIGJyb3dzZXIgZGV0ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1ZpZGVvUHJvY2Vz c2luZ1NvZnRMaW5rLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2Vi cnRjL3Nkay9XZWJLaXQvVmlkZW9Qcm9jZXNzaW5nU29mdExpbmsuY3BwCmluZGV4IDcyMjg4MTBj ODQ2OTZhMGRmNzY5MjNjM2Q5NTQwM2ZhY2YxOTBiM2IuLjliMTJiZTYzODMzNzRlMDU3MjRjODY3 NmZkNzcwMTcwYmU5ZjAwYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0 Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvVmlkZW9Qcm9jZXNzaW5nU29mdExpbmsuY3BwCisr KyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQv VmlkZW9Qcm9jZXNzaW5nU29mdExpbmsuY3BwCkBAIC02Nyw3ICs2NywyMiBAQAogfQogCiBTT0ZU X0xJTktfUFJJVkFURV9GUkFNRVdPUktfRk9SX1NPVVJDRSh3ZWJydGMsIFZpZGVvUHJvY2Vzc2lu ZykKLVNPRlRfTElOS19GVU5DVElPTl9GT1JfU09VUkNFKHdlYnJ0YywgVmlkZW9Qcm9jZXNzaW5n LCBWUE1vZHVsZUluaXRpYWxpemUsIHZvaWQsICgpLCAoKSkKKworbmFtZXNwYWNlIHdlYnJ0YyB7 CitzdGF0aWMgdm9pZCBpbml0VmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXplKCk7Cit2 b2lkICgqc29mdExpbmtWaWRlb1Byb2Nlc3NpbmdWUE1vZHVsZUluaXRpYWxpemUpICgpID0gaW5p dFZpZGVvUHJvY2Vzc2luZ1ZQTW9kdWxlSW5pdGlhbGl6ZTsKK3N0YXRpYyB2b2lkIGluaXRWaWRl b1Byb2Nlc3NpbmdWUE1vZHVsZUluaXRpYWxpemUoKQoreworICAgIGF1dG8qIGxpYnJhcnkgPSBW aWRlb1Byb2Nlc3NpbmdMaWJyYXJ5KCk7CisgICAgaWYgKCFsaWJyYXJ5KQorICAgICAgICBmcHJp bnRmKHN0ZGVyciwgIkNhbm5vdCBmaW5kIFZpZGVvUHJvY2Vzc2luZ0xpYnJhcnk6ICVzXG4iLCBk bGVycm9yKCkpOworICAgIHNvZnRMaW5rVmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXpl ID0gKHZvaWQgKCopKCkpIGRsc3ltKGxpYnJhcnksICJWUE1vZHVsZUluaXRpYWxpemUiKTsKKyAg ICBpZiAoIXNvZnRMaW5rVmlkZW9Qcm9jZXNzaW5nVlBNb2R1bGVJbml0aWFsaXplKQorICAgICAg ICBmcHJpbnRmKHN0ZGVyciwgIkNhbm5vdCBmaW5kIGZ1bmN0aW9uIFZQTW9kdWxlSW5pdGlhbGl6 ZTogJXNcbiIsIGRsZXJyb3IoKSk7CisgICAgc29mdExpbmtWaWRlb1Byb2Nlc3NpbmdWUE1vZHVs ZUluaXRpYWxpemUoKTsKK30KKworfQogCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyQ29j b2EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ1Byb3ZpZGVyQ29jb2EuY3BwCmluZGV4IDFhNGQzZTY0ZTU1MzY1ZWNlZTViODQ4NDQ3 OTMzNGY0MTY0MzVkMjkuLmU3ODRjMzU1YmEwNGExZWIzMzYwYjc3OGZhOTMzNjQ3YmE2ODE2ODAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0 Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXJDb2NvYS5jcHAKQEAgLTUx LDEyICs1MSwxNiBAQCB2b2lkIExpYldlYlJUQ1Byb3ZpZGVyQ29jb2E6OnNldEgyNjRIYXJkd2Fy ZUVuY29kZXJBbGxvd2VkKGJvb2wgYWxsb3dlZCkKIAogc3RkOjp1bmlxdWVfcHRyPHdlYnJ0Yzo6 VmlkZW9EZWNvZGVyRmFjdG9yeT4gTGliV2ViUlRDUHJvdmlkZXJDb2NvYTo6Y3JlYXRlRGVjb2Rl ckZhY3RvcnkoKQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisKICAgICBhdXRvIGNv ZGVjU3VwcG9ydCA9IG1fc3VwcG9ydHNWUDggPyB3ZWJydGM6OldlYktpdENvZGVjU3VwcG9ydDo6 SDI2NEFuZFZQOCA6IHdlYnJ0Yzo6V2ViS2l0Q29kZWNTdXBwb3J0OjpIMjY0OwogICAgIHJldHVy biB3ZWJydGM6OmNyZWF0ZVdlYktpdERlY29kZXJGYWN0b3J5KGNvZGVjU3VwcG9ydCk7CiB9CiAK IHN0ZDo6dW5pcXVlX3B0cjx3ZWJydGM6OlZpZGVvRW5jb2RlckZhY3Rvcnk+IExpYldlYlJUQ1By b3ZpZGVyQ29jb2E6OmNyZWF0ZUVuY29kZXJGYWN0b3J5KCkKIHsKKyAgICBBU1NFUlQoaXNNYWlu VGhyZWFkKCkpOworCiAgICAgYXV0byBjb2RlY1N1cHBvcnQgPSBtX3N1cHBvcnRzVlA4ID8gd2Vi cnRjOjpXZWJLaXRDb2RlY1N1cHBvcnQ6OkgyNjRBbmRWUDggOiB3ZWJydGM6OldlYktpdENvZGVj U3VwcG9ydDo6SDI2NDsKICAgICByZXR1cm4gd2VicnRjOjpjcmVhdGVXZWJLaXRFbmNvZGVyRmFj dG9yeShjb2RlY1N1cHBvcnQpOwogfQo=