196567 2019-04-03 15:07:44 -0700 [Win] DumpRenderTreeWatchDog.py is not checked into source 2020-07-13 08:19:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214257 InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue lforschler webkit-bug-importer oldest_to_newest 1523968 0 pvollan 2019-04-03 15:07:44 -0700 This script should be checked in. Tools/EWSTools is possibly an appropriate location for it. 1523971 1 pvollan 2019-04-03 15:08:11 -0700 rdar://problem/49525901 1523986 2 366654 pvollan 2019-04-03 15:18:47 -0700 Created attachment 366654 Patch 1524022 3 366654 lforschler 2019-04-03 16:21:37 -0700 Comment on attachment 366654 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366654&action=review > Tools/EWSTools/dumprendertreewatchdog.py:29 > + these should be alphabetized > Tools/EWSTools/dumprendertreewatchdog.py:37 > + proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,) I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself. > Tools/EWSTools/dumprendertreewatchdog.py:47 > + # If the active and current PID are the and an hour has elapsed, kill DumpRenderTree and reset the active PID to 0 I think this comment is missing a word between "the" and "and" 1524024 4 366654 lforschler 2019-04-03 16:28:57 -0700 Comment on attachment 366654 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366654&action=review >> Tools/EWSTools/dumprendertreewatchdog.py:37 >> + proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,) > > I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself. Also, would this be better named pid_fetch? (I just tested on Windows and it appears the functionality of ps does not output the ps process itself... so maybe this is ok) 1524059 5 366673 pvollan 2019-04-03 17:05:06 -0700 Created attachment 366673 Patch 1524061 6 pvollan 2019-04-03 17:09:55 -0700 (In reply to Lucas Forschler from comment #4) > Comment on attachment 366654 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366654&action=review > > >> Tools/EWSTools/dumprendertreewatchdog.py:37 > >> + proc_fetch = subprocess.Popen("ps -e | grep \"DumpRenderTree\" | awk '{print $1}'", shell=True, stdout=subprocess.PIPE,) > > > > I think this will also capture the ps process itself, right? On my machine with no DumpRenderTree processes running, this command will always return one pid, itself. > > Also, would this be better named pid_fetch? > > (I just tested on Windows and it appears the functionality of ps does not > output the ps process itself... so maybe this is ok) Thanks for reviewing! I have updated the patch. 1524301 7 366673 commit-queue 2019-04-04 10:39:59 -0700 Comment on attachment 366673 Patch Clearing flags on attachment: 366673 Committed r243879: <https://trac.webkit.org/changeset/243879> 1524302 8 commit-queue 2019-04-04 10:40:00 -0700 All reviewed patches have been landed. Closing bug. 366654 2019-04-03 15:18:47 -0700 2019-04-03 17:05:04 -0700 Patch bug-196567-20190403151846.patch text/plain 3352 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzgzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA0LTAzICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBEdW1wUmVuZGVyVHJlZVdhdGNoRG9nLnB5IGlzIG5vdCBjaGVj a2VkIGludG8gc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTY1NjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NTI1OTAxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2NyaXB0IGlz IHVzZWQgb24gV2luIEVXUyBib3RzIHRvIHRlcm1pbmF0ZSBoYW5naW5nIERSVCBwcm9jZXNzZXMu CisKKyAgICAgICAgKiBFV1NUb29scy9kdW1wcmVuZGVydHJlZXdhdGNoZG9nLnB5OiBBZGRlZC4K KwogMjAxOS0wNC0wMyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2V3cy1hcHBdIFN0YXR1cyBidWJibGUgc2hvdWxkIG5vdCBkaXNwbGF5IGNlcnRhaW4g aW5mcmFzdHJ1Y3R1cmUgc3RhdHVzIG1lc3NhZ2VzCkluZGV4OiBUb29scy9FV1NUb29scy9kdW1w cmVuZGVydHJlZXdhdGNoZG9nLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0VXU1Rvb2xzL2R1bXBy ZW5kZXJ0cmVld2F0Y2hkb2cucHkJKG5vbmV4aXN0ZW50KQorKysgVG9vbHMvRVdTVG9vbHMvZHVt cHJlbmRlcnRyZWV3YXRjaGRvZy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUzIEBACisj IENvcHlyaWdodCAoQykgMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisj IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1 Y2UgdGhlIGFib3ZlCisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5k L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisj CisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFO RCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hU CisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0 IHN1YnByb2Nlc3MKK2ltcG9ydCBvcworaW1wb3J0IHRpbWUKKworRFVNUF9QSUQgPSAwCitEVU1Q X1NUQVJUX1RJTUUgPSAwCisKK3doaWxlKDEpOgorICAgIHRpbWUuc2xlZXAoMTApCisgICAgQ1VS X1RJTUUgPSBpbnQodGltZS50aW1lKCkpCisKKyAgICBwcm9jX2ZldGNoID0gc3VicHJvY2Vzcy5Q b3BlbigicHMgLWUgfCBncmVwIFwiRHVtcFJlbmRlclRyZWVcIiB8IGF3ayAne3ByaW50ICQxfSci LCBzaGVsbD1UcnVlLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFLCkKKyAgICBDVVJSRU5UX1BJRCA9 IHByb2NfZmV0Y2guY29tbXVuaWNhdGUoKVswXS5zcGxpdCgnXG4nKVswXQorICAgIENIRUNLRUQg PSAxCisgICAgI1dlIG9ubHkgY2FyZSBhYm91dCBkb2luZyBhbnl0aGluZyBpZiB0aGVyZSBpcyBh IER1bXBSZW5kZXJUcmVlIHJ1bm5pbmcKKyAgICBpZiAoQ1VSUkVOVF9QSUQpOgorICAgICAgICAj IElmIHRoZSBQSUQgaGFzIGNoYW5nZWQsIHJlc2V0IHRoZSB0aW1lciBhbmQgdGhlIGFjdGl2ZSBw aWQKKyAgICAgICAgaWYgKERVTVBfUElEICE9IENVUlJFTlRfUElEKToKKyAgICAgICAgICAgIERV TVBfUElEID0gQ1VSUkVOVF9QSUQKKyAgICAgICAgICAgIERVTVBfU1RBUlRfVElNRSA9IHRpbWUu dGltZSgpCisgICAgICAgIGVsc2U6CisgICAgICAgICMgSWYgdGhlIGFjdGl2ZSBhbmQgY3VycmVu dCBQSUQgYXJlIHRoZSBhbmQgYW4gaG91ciBoYXMgZWxhcHNlZCwga2lsbCBEdW1wUmVuZGVyVHJl ZSBhbmQgcmVzZXQgdGhlIGFjdGl2ZSBQSUQgdG8gMAorICAgICAgICAgICAgaWYgKENVUl9USU1F IC0gRFVNUF9TVEFSVF9USU1FID49IDM2MDApOgorICAgICAgICAgICAgICAgIG9zLnN5c3RlbSgi dGFza2tpbGwgL0YgL0lNIER1bXBSZW5kZXJUcmVlLmV4ZSIpCisgICAgICAgICAgICAgICAgb3Mu c3lzdGVtKCJ0YXNra2lsbCAvRiAvSU0gSW1hZ2VEaWZmLmV4ZSIpCisgICAgICAgICAgICAgICAg RFVNUF9QSUQgPSAwCisgICAgZWxzZToKKyAgICAgICAgRFVNUF9QSUQgPSAwCg== 366673 2019-04-03 17:05:06 -0700 2019-04-04 10:39:59 -0700 Patch bug-196567-20190403170505.patch text/plain 3356 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzgzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA0LTAzICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBEdW1wUmVuZGVyVHJlZVdhdGNoRG9nLnB5IGlzIG5vdCBjaGVj a2VkIGludG8gc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTY1NjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NTI1OTAxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2NyaXB0IGlz IHVzZWQgb24gV2luIEVXUyBib3RzIHRvIHRlcm1pbmF0ZSBoYW5naW5nIERSVCBwcm9jZXNzZXMu CisKKyAgICAgICAgKiBFV1NUb29scy9kdW1wcmVuZGVydHJlZXdhdGNoZG9nLnB5OiBBZGRlZC4K KwogMjAxOS0wNC0wMyAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2V3cy1hcHBdIFN0YXR1cyBidWJibGUgc2hvdWxkIG5vdCBkaXNwbGF5IGNlcnRhaW4g aW5mcmFzdHJ1Y3R1cmUgc3RhdHVzIG1lc3NhZ2VzCkluZGV4OiBUb29scy9FV1NUb29scy9kdW1w cmVuZGVydHJlZXdhdGNoZG9nLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0VXU1Rvb2xzL2R1bXBy ZW5kZXJ0cmVld2F0Y2hkb2cucHkJKG5vbmV4aXN0ZW50KQorKysgVG9vbHMvRVdTVG9vbHMvZHVt cHJlbmRlcnRyZWV3YXRjaGRvZy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUzIEBACisj IENvcHlyaWdodCAoQykgMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisj IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1 Y2UgdGhlIGFib3ZlCisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5k L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisj CisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFO RCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hU CisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0 IG9zCitpbXBvcnQgc3VicHJvY2VzcworaW1wb3J0IHRpbWUKKworRFVNUF9QSUQgPSAwCitEVU1Q X1NUQVJUX1RJTUUgPSAwCisKK3doaWxlKDEpOgorICAgIHRpbWUuc2xlZXAoMTApCisgICAgQ1VS X1RJTUUgPSBpbnQodGltZS50aW1lKCkpCisKKyAgICBwaWRfZmV0Y2ggPSBzdWJwcm9jZXNzLlBv cGVuKCJwcyAtZSB8IGdyZXAgXCJEdW1wUmVuZGVyVHJlZVwiIHwgYXdrICd7cHJpbnQgJDF9JyIs IHNoZWxsPVRydWUsIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsKQorICAgIENVUlJFTlRfUElEID0g cGlkX2ZldGNoLmNvbW11bmljYXRlKClbMF0uc3BsaXQoJ1xuJylbMF0KKyAgICBDSEVDS0VEID0g MQorICAgICMgV2Ugb25seSBjYXJlIGFib3V0IGRvaW5nIGFueXRoaW5nIGlmIHRoZXJlIGlzIGEg RHVtcFJlbmRlclRyZWUgcnVubmluZworICAgIGlmIChDVVJSRU5UX1BJRCk6CisgICAgICAgICMg SWYgdGhlIFBJRCBoYXMgY2hhbmdlZCwgcmVzZXQgdGhlIHRpbWVyIGFuZCB0aGUgYWN0aXZlIHBp ZAorICAgICAgICBpZiAoRFVNUF9QSUQgIT0gQ1VSUkVOVF9QSUQpOgorICAgICAgICAgICAgRFVN UF9QSUQgPSBDVVJSRU5UX1BJRAorICAgICAgICAgICAgRFVNUF9TVEFSVF9USU1FID0gdGltZS50 aW1lKCkKKyAgICAgICAgZWxzZToKKyAgICAgICAgIyBJZiB0aGUgYWN0aXZlIGFuZCBjdXJyZW50 IFBJRCBhcmUgdGhlIHNhbWUgYW5kIGFuIGhvdXIgaGFzIGVsYXBzZWQsIGtpbGwgRHVtcFJlbmRl clRyZWUgYW5kIHJlc2V0IHRoZSBhY3RpdmUgUElEIHRvIDAKKyAgICAgICAgICAgIGlmIChDVVJf VElNRSAtIERVTVBfU1RBUlRfVElNRSA+PSAzNjAwKToKKyAgICAgICAgICAgICAgICBvcy5zeXN0 ZW0oInRhc2traWxsIC9GIC9JTSBEdW1wUmVuZGVyVHJlZS5leGUiKQorICAgICAgICAgICAgICAg IG9zLnN5c3RlbSgidGFza2tpbGwgL0YgL0lNIEltYWdlRGlmZi5leGUiKQorICAgICAgICAgICAg ICAgIERVTVBfUElEID0gMAorICAgIGVsc2U6CisgICAgICAgIERVTVBfUElEID0gMAo=