196566 2019-04-03 14:49:08 -0700 Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h 2019-04-03 15:18:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ews-watchlist timothy webkit-bug-importer oldest_to_newest 1523954 0 rniwa 2019-04-03 14:49:08 -0700 Avoid the use of WTF_EXTERN_C_BEGIN in NSMenuSPI.h 1523955 1 366647 rniwa 2019-04-03 14:49:30 -0700 Created attachment 366647 Remove Extern C around NSMenu_Private.h 1523960 2 ews-watchlist 2019-04-03 14:51:39 -0700 Attachment 366647 did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/NSMenuSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1523982 3 rniwa 2019-04-03 15:16:59 -0700 Committed r243831: <https://trac.webkit.org/changeset/243831> 1523985 4 webkit-bug-importer 2019-04-03 15:18:01 -0700 <rdar://problem/49576483> 366647 2019-04-03 14:49:30 -0700 2019-04-03 14:52:35 -0700 Remove Extern C around NSMenu_Private.h bug-196566-20190403144930.patch text/plain 1085 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjQzODI4KQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0 LTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEF2b2lkIHRo ZSB1c2Ugb2YgV1RGX0VYVEVSTl9DX0JFR0lOIGluIE5TTWVudVNQSS5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY1NjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvbWFjL05TTWVudVNQ SS5oOgorCiAyMDE5LTA0LTAzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHN1cHBvcnQgZm9yIC1hcHBsZS10cmFpbGluZy13b3JkCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNNZW51U1BJLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TTWVudVNQSS5oCShyZXZpc2lv biAyNDM4MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNNZW51U1BJLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDExIEBACiAKICNpZiBQTEFURk9STShNQUMpCiAK LSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREsp ICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCisKKyNpbXBvcnQg PEFwcEtpdC9OU01lbnVfUHJpdmF0ZS5oPgorCisjZWxpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KQogCiBXVEZfRVhURVJOX0NfQkVHSU4KICNpbXBvcnQgPEFwcEtpdC9OU01lbnVfUHJpdmF0ZS5o Pgo=