196550 2019-04-03 11:56:31 -0700 [ews-app] Status bubble should not display certain infrastructure status messages 2021-04-26 14:26:11 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196584 https://bugs.webkit.org/show_bug.cgi?id=201308 https://bugs.webkit.org/show_bug.cgi?id=225076 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard lforschler webkit-bug-importer oldest_to_newest 1523823 0 aakash_jain 2019-04-03 11:56:31 -0700 [ews-app] Status bubble should not display certain infrastructure status messages, e.g.: There is no need to display 'Killed old processes' or 'Configured build' in the status-bubble hover over message. 1523826 1 366627 aakash_jain 2019-04-03 12:06:52 -0700 Created attachment 366627 Patch 1523854 2 366627 lforschler 2019-04-03 12:58:38 -0700 Comment on attachment 366627 Patch This looks fine to me...but I'm not sure why we need to hide the steps? Can you add more information to change log about why we would want to hide these? Are they ugly? un-needed? does hiding them make it harder to debug? 1523872 3 aakash_jain 2019-04-03 13:27:15 -0700 Committed r243823: <https://trac.webkit.org/changeset/243823> 1523873 4 webkit-bug-importer 2019-04-03 13:28:21 -0700 <rdar://problem/49570722> 1523875 5 aakash_jain 2019-04-03 13:30:17 -0700 > This looks fine to me...but I'm not sure why we need to hide the steps? Can > you add more information to change log about why we would want to hide > these? Are they ugly? un-needed? does hiding them make it harder to debug? Updated ChangeLog before landing. They are simply un-needed from end user perspective. This information is still available in the Buildbot build page, if the user click on the status-bubble. 366627 2019-04-03 12:06:52 -0700 2019-04-03 12:58:47 -0700 Patch bug-196550-20190403150745.patch text/plain 2088 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzgxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTAzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU3RhdHVzIGJ1YmJsZSBzaG91bGQgbm90IGRpc3BsYXkg Y2VydGFpbiBpbmZyYXN0cnVjdHVyZSBzdGF0dXMgbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjU1MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlLl9zdGVw c19tZXNzYWdlcyk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX3Nob3VsZF9kaXNwbGF5X3N0ZXAp OiBNZXRob2QgdG8gZGVjaWRlIHdoZXRoZXIgdG8gZGlzcGxheSB0aGUgc3RlcCBvciBub3QuCisK IDIwMTktMDQtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBhIHRlc3QgZm9yIERPTUNhY2hlIG9uIG11bHRpcGxlIGJyb3dzaW5nIGluIGNhc2Ugb2Yg cHJpdmF0ZSBicm93c2luZwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkocmV2aXNpb24gMjQzODE2 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3RhdHVzYnVi YmxlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0MSw4IEBAIGNsYXNzIFN0YXR1c0J1YmJs ZShWaWV3KToKICAgICAgICAgICAgICAgICAgICAgJ21hYy1kZWJ1ZycsICdtYWMtZGVidWctd2sx JywgJ21hYy13azEnLCAnbWFjLXdrMicsICdzdHlsZScsICd3ZWJraXRwZXJsJywgJ3dlYmtpdHB5 JywgJ3dpbicsICd3aW5jYWlybycsICd3cGUnXQogICAgIEVOQUJMRURfUVVFVUVTID0gWydhcGkt aW9zJywgJ2FwaS1tYWMnLCAnd2Via2l0cGVybCddCiAKKyAgICBTVEVQU19UT19ISURFID0gWydL aWxsZWQgb2xkIHByb2Nlc3NlcycsICdDb25maWd1cmVkIGJ1aWxkJywgJ15PUzouKlhjb2RlOidd CisKICAgICBkZWYgX2J1aWxkX2J1YmJsZShzZWxmLCBwYXRjaCwgcXVldWUpOgogICAgICAgICBi dWJibGUgPSB7CiAgICAgICAgICAgICAnbmFtZSc6IHF1ZXVlLApAQCAtMTIwLDcgKzEyMiwxMCBA QCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgIHJldHVybiAnW1snICsgZGF0ZXRp bWUuZGF0ZXRpbWUuZnJvbXRpbWVzdGFtcCh0aW1lKS5pc29mb3JtYXQoKSArICdaXV0nCiAKICAg ICBkZWYgX3N0ZXBzX21lc3NhZ2VzKHNlbGYsIGJ1aWxkKToKLSAgICAgICAgcmV0dXJuICdcbicu am9pbihbc3RlcC5zdGF0ZV9zdHJpbmcgZm9yIHN0ZXAgaW4gYnVpbGQuc3RlcF9zZXQuYWxsKCld KQorICAgICAgICByZXR1cm4gJ1xuJy5qb2luKFtzdGVwLnN0YXRlX3N0cmluZyBmb3Igc3RlcCBp biBidWlsZC5zdGVwX3NldC5hbGwoKSBpZiBzZWxmLl9zaG91bGRfZGlzcGxheV9zdGVwKHN0ZXAp XSkKKworICAgIGRlZiBfc2hvdWxkX2Rpc3BsYXlfc3RlcChzZWxmLCBzdGVwKToKKyAgICAgICAg cmV0dXJuIG5vdCBmaWx0ZXIobGFtYmRhIHN0ZXBfdG9faGlkZTogcmUuc2VhcmNoKHN0ZXBfdG9f aGlkZSwgc3RlcC5zdGF0ZV9zdHJpbmcpLCBTdGF0dXNCdWJibGUuU1RFUFNfVE9fSElERSkKIAog ICAgIGRlZiBfbW9zdF9yZWNlbnRfc3RlcF9tZXNzYWdlKHNlbGYsIGJ1aWxkKToKICAgICAgICAg cmVjZW50X3N0ZXAgPSBidWlsZC5zdGVwX3NldC5sYXN0KCkK