196547 2019-04-03 11:10:48 -0700 Follow up fix for r243807: Use MarkedArgumentBuffer instead of Vector for JSValue 2019-04-11 08:04:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 196611 1 sihui_liu sihui_liu alecflett beidson commit-queue ews-watchlist ggaren jsbell webkit-bug-importer oldest_to_newest 1523797 0 sihui_liu 2019-04-03 11:10:48 -0700 As suggested in https://bugs.webkit.org/show_bug.cgi?id=196128#c17. 1523803 1 366625 sihui_liu 2019-04-03 11:20:57 -0700 Created attachment 366625 Patch 1523806 2 366625 ggaren 2019-04-03 11:24:27 -0700 Comment on attachment 366625 Patch r=me 1523853 3 366633 sihui_liu 2019-04-03 12:56:54 -0700 Created attachment 366633 Patch for landing 1523883 4 366633 commit-queue 2019-04-03 13:37:28 -0700 Comment on attachment 366633 Patch for landing Clearing flags on attachment: 366633 Committed r243824: <https://trac.webkit.org/changeset/243824> 1523884 5 commit-queue 2019-04-03 13:37:29 -0700 All reviewed patches have been landed. Closing bug. 1523889 6 webkit-bug-importer 2019-04-03 13:41:15 -0700 <rdar://problem/49571234> 1524283 7 commit-queue 2019-04-04 10:14:31 -0700 Re-opened since this is blocked by bug 196611 1526374 8 sihui_liu 2019-04-11 08:04:02 -0700 r243807 and r243824 got rolled out for timeouts and I am going to re-land r243807, so I will merge this change to the re-landed patch. 366625 2019-04-03 11:20:57 -0700 2019-04-03 12:56:53 -0700 Patch bug-196547-20190403112057.patch text/plain 2479 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VjY2FjYTYwMGVmYmVi NWFjZjQyMmQ2ZjlkYjE0ZmFhM2I1ZThhNC4uMTU2ZWZkYjU3YTI4MzhhMWYwNWI3NDhmYWMwZTQx Y2U3MzNkODAxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEZvbGxvdyB1cCBmaXggZm9y IHIyNDM4MDc6IFVzZSBNYXJrZWRBcmd1bWVudEJ1ZmZlciBpbnN0ZWFkIG9mIFZlY3RvciBmb3Ig SlNWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk2NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SlNWYWx1ZSBpbiBWZWN0b3IgY291bGQgYmUgZ2FyYmFyZ2UgY29sbGVjdGVkIGJlY2F1c2UgR0Mg ZG9lc24ndCBrbm93IFZlY3RvciBtZW1vcnkgb24gQysrIGhlYXAuCisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU0lEQlJlcXVlc3RDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNJREJS ZXF1ZXN0OjpyZXN1bHQgY29uc3QpOgorCiAyMDE5LTA0LTAzICBTaWh1aSBMaXUgIDxzaWh1aV9s aXVAYXBwbGUuY29tPgogCiAgICAgICAgIEJsb2IgdHlwZSBjYW5ub3QgYmUgc3RvcmVkIGNvcnJl Y3RseSBpbiBJREIgd2hlbiBJREJPYmplY3RTdG9yZSBoYXMgYXV0b0luY3JlbWVudCBhbmQga2V5 UGF0aCBvcHRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lE QlJlcXVlc3RDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJREJSZXF1 ZXN0Q3VzdG9tLmNwcAppbmRleCAwNjhiMWRlZjNhMzViYzFkMGVmYmUwYjdkNmNmMDMyOWFlNWQx MmJkLi41MTkwMmUyYjY4NTMyOTRiOTk5ZTQxMmVkMjU3Zjc2MjkyYWFiZGFmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQlJlcXVlc3RDdXN0b20uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCUmVxdWVzdEN1c3RvbS5jcHAKQEAgLTY0 LDE0ICs2NCwxOSBAQCBKU0M6OkpTVmFsdWUgSlNJREJSZXF1ZXN0OjpyZXN1bHQoSlNDOjpFeGVj U3RhdGUmIHN0YXRlKSBjb25zdAogICAgICAgICAgICAgYXV0byYga2V5cyA9IGdldEFsbFJlc3Vs dC5rZXlzKCk7CiAgICAgICAgICAgICBhdXRvJiB2YWx1ZXMgPSBnZXRBbGxSZXN1bHQudmFsdWVz KCk7CiAgICAgICAgICAgICBhdXRvJiBrZXlQYXRoID0gZ2V0QWxsUmVzdWx0LmtleVBhdGgoKTsK LSAgICAgICAgICAgIFZlY3RvcjxKU0M6OkpTVmFsdWU+IHJlc3VsdHM7CisgICAgICAgICAgICBh dXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRShzdGF0ZS52bSgpKTsKKyAgICAgICAgICAg IEpTQzo6TWFya2VkQXJndW1lbnRCdWZmZXIgbGlzdDsKICAgICAgICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCB2YWx1ZXMuc2l6ZSgpOyBpICsrKSB7CiAgICAgICAgICAgICAgICAgYXV0 byByZXN1bHQgPSBkZXNlcmlhbGl6ZUlEQlZhbHVlV2l0aEtleUluamVjdGlvbihzdGF0ZSwgdmFs dWVzW2ldLCBrZXlzW2ldLCBrZXlQYXRoKTsKICAgICAgICAgICAgICAgICBpZiAoIXJlc3VsdCkK ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGpzTnVsbCgpOwotICAgICAgICAgICAgICAgIHJl c3VsdHMuYXBwZW5kKHJlc3VsdC52YWx1ZSgpKTsKKyAgICAgICAgICAgICAgICBsaXN0LmFwcGVu ZChyZXN1bHQudmFsdWUoKSk7CisgICAgICAgICAgICAgICAgaWYgKFVOTElLRUxZKGxpc3QuaGFz T3ZlcmZsb3dlZCgpKSkgeworICAgICAgICAgICAgICAgICAgICBwcm9wYWdhdGVFeGNlcHRpb24o c3RhdGUsIHNjb3BlLCBFeGNlcHRpb24oVW5rbm93bkVycm9yKSk7CisgICAgICAgICAgICAgICAg ICAgIHJldHVybiBqc051bGwoKTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Ci0g ICAgICAgICAgICByZXR1cm4gSlNWYWx1ZShKU0M6OmNvbnN0cnVjdEFycmF5KCZzdGF0ZSwgbnVs bHB0ciwgc3RhdGUubGV4aWNhbEdsb2JhbE9iamVjdCgpLCByZXN1bHRzLmRhdGEoKSwgcmVzdWx0 cy5zaXplKCkpKTsKKyAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlKEpTQzo6Y29uc3RydWN0QXJy YXkoJnN0YXRlLCBudWxscHRyLCBzdGF0ZS5sZXhpY2FsR2xvYmFsT2JqZWN0KCksIGxpc3QpKTsK ICAgICAgICAgfSwgW10gKHVpbnQ2NF90IG51bWJlcikgewogICAgICAgICAgICAgcmV0dXJuIHRv SlM8SURMVW5zaWduZWRMb25nTG9uZz4obnVtYmVyKTsKICAgICAgICAgfSwgW10gKElEQlJlcXVl c3Q6Ok51bGxSZXN1bHRUeXBlIG90aGVyKSB7Cg== 366633 2019-04-03 12:56:54 -0700 2019-04-03 13:37:28 -0700 Patch for landing bug-196547-20190403125653.patch text/plain 2424 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY5YmEzYzJjMzRhM2Uw NjIzNTQyZGQ1YmI5ZGVkNGM2MDA5Y2U1NC4uOGU0ODE4NDZjNTExODQ5NjQ3NDhlN2FmMDBlOTFm M2E3ZTIxYmY4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEZvbGxvdyB1cCBmaXggZm9y IHIyNDM4MDc6IFVzZSBNYXJrZWRBcmd1bWVudEJ1ZmZlciBpbnN0ZWFkIG9mIFZlY3RvciBmb3Ig SlNWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk2NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCisKKyAgICAgICAg SlNWYWx1ZSBpbiBWZWN0b3IgY291bGQgYmUgZ2FyYmFnZSBjb2xsZWN0ZWQgYmVjYXVzZSBHQyBk b2Vzbid0IGtub3cgVmVjdG9yIG1lbW9yeSBvbiBDKysgaGVhcC4KKworICAgICAgICAqIGJpbmRp bmdzL2pzL0pTSURCUmVxdWVzdEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0lEQlJl cXVlc3Q6OnJlc3VsdCBjb25zdCk6CisKIDIwMTktMDQtMDMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgc3VwcG9ydCBmb3IgLWFwcGxl LXRyYWlsaW5nLXdvcmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT SURCUmVxdWVzdEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQlJl cXVlc3RDdXN0b20uY3BwCmluZGV4IDA2OGIxZGVmM2EzNWJjMWQwZWZiZTBiN2Q2Y2YwMzI5YWU1 ZDEyYmQuLjUxOTAyZTJiNjg1MzI5NGI5OTllNDEyZWQyNTdmNzYyOTJhYWJkYWYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCUmVxdWVzdEN1c3RvbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJREJSZXF1ZXN0Q3VzdG9tLmNwcApAQCAt NjQsMTQgKzY0LDE5IEBAIEpTQzo6SlNWYWx1ZSBKU0lEQlJlcXVlc3Q6OnJlc3VsdChKU0M6OkV4 ZWNTdGF0ZSYgc3RhdGUpIGNvbnN0CiAgICAgICAgICAgICBhdXRvJiBrZXlzID0gZ2V0QWxsUmVz dWx0LmtleXMoKTsKICAgICAgICAgICAgIGF1dG8mIHZhbHVlcyA9IGdldEFsbFJlc3VsdC52YWx1 ZXMoKTsKICAgICAgICAgICAgIGF1dG8mIGtleVBhdGggPSBnZXRBbGxSZXN1bHQua2V5UGF0aCgp OwotICAgICAgICAgICAgVmVjdG9yPEpTQzo6SlNWYWx1ZT4gcmVzdWx0czsKKyAgICAgICAgICAg IGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHN0YXRlLnZtKCkpOworICAgICAgICAg ICAgSlNDOjpNYXJrZWRBcmd1bWVudEJ1ZmZlciBsaXN0OwogICAgICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IHZhbHVlcy5zaXplKCk7IGkgKyspIHsKICAgICAgICAgICAgICAgICBh dXRvIHJlc3VsdCA9IGRlc2VyaWFsaXplSURCVmFsdWVXaXRoS2V5SW5qZWN0aW9uKHN0YXRlLCB2 YWx1ZXNbaV0sIGtleXNbaV0sIGtleVBhdGgpOwogICAgICAgICAgICAgICAgIGlmICghcmVzdWx0 KQogICAgICAgICAgICAgICAgICAgICByZXR1cm4ganNOdWxsKCk7Ci0gICAgICAgICAgICAgICAg cmVzdWx0cy5hcHBlbmQocmVzdWx0LnZhbHVlKCkpOworICAgICAgICAgICAgICAgIGxpc3QuYXBw ZW5kKHJlc3VsdC52YWx1ZSgpKTsKKyAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkobGlzdC5o YXNPdmVyZmxvd2VkKCkpKSB7CisgICAgICAgICAgICAgICAgICAgIHByb3BhZ2F0ZUV4Y2VwdGlv bihzdGF0ZSwgc2NvcGUsIEV4Y2VwdGlvbihVbmtub3duRXJyb3IpKTsKKyAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIGpzTnVsbCgpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0K LSAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlKEpTQzo6Y29uc3RydWN0QXJyYXkoJnN0YXRlLCBu dWxscHRyLCBzdGF0ZS5sZXhpY2FsR2xvYmFsT2JqZWN0KCksIHJlc3VsdHMuZGF0YSgpLCByZXN1 bHRzLnNpemUoKSkpOworICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWUoSlNDOjpjb25zdHJ1Y3RB cnJheSgmc3RhdGUsIG51bGxwdHIsIHN0YXRlLmxleGljYWxHbG9iYWxPYmplY3QoKSwgbGlzdCkp OwogICAgICAgICB9LCBbXSAodWludDY0X3QgbnVtYmVyKSB7CiAgICAgICAgICAgICByZXR1cm4g dG9KUzxJRExVbnNpZ25lZExvbmdMb25nPihudW1iZXIpOwogICAgICAgICB9LCBbXSAoSURCUmVx dWVzdDo6TnVsbFJlc3VsdFR5cGUgb3RoZXIpIHsK