196538 2019-04-03 07:25:57 -0700 [ATK] Wrong index passed to AtkObject::children-changed::add signal in AXObjectCache::attachWrapper() 2019-04-05 01:43:45 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned aboxhall apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs mario mcatanzaro samuel_white webkit-bug-importer oldest_to_newest 1523687 0 cgarcia 2019-04-03 07:25:57 -0700 In most of the cases the parent is not found, probably because the child is not a direct descendant of the parent returned by parentObjectUnignored(). We need to handle the case of find() returning notFound. 1523688 1 webkit-bug-importer 2019-04-03 07:26:16 -0700 <rdar://problem/49557794> 1523689 2 366601 cgarcia 2019-04-03 07:27:54 -0700 Created attachment 366601 Patch 1524171 3 cgarcia 2019-04-03 22:53:36 -0700 Committed r243864: <https://trac.webkit.org/changeset/243864> 1524647 4 mario 2019-04-05 01:43:45 -0700 Returning -1 when the parent is not known seems consistent with the docs at https://developer.gnome.org/atk/stable/AtkObject.html, so another (late) lgtm 366601 2019-04-03 07:27:54 -0700 2019-04-03 08:08:51 -0700 Patch wcore-atk-children-add-index.diff text/plain 1699 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZWJiYjFiZDU0MC4uOTlkYmM3MWJkNTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0FUS10gV3JvbmcgaW5kZXggcGFzc2VkIHRvIEF0a09iamVj dDo6Y2hpbGRyZW4tY2hhbmdlZDo6YWRkIHNpZ25hbCBpbiBBWE9iamVjdENhY2hlOjphdHRhY2hX cmFwcGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NjUzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIG1vc3Qgb2YgdGhlIGNhc2VzIHRoZSBwYXJlbnQgaXMgbm90IGZvdW5kLCBwcm9iYWJseSBi ZWNhdXNlIHRoZSBjaGlsZCBpcyBub3QgYSBkaXJlY3QgZGVzY2VuZGFudCBvZiB0aGUKKyAgICAg ICAgcGFyZW50IHJldHVybmVkIGJ5IHBhcmVudE9iamVjdFVuaWdub3JlZCgpLiBXZSBuZWVkIHRv IGhhbmRsZSB0aGUgY2FzZSBvZiBmaW5kKCkgcmV0dXJuaW5nIG5vdEZvdW5kLgorCisgICAgICAg ICogYWNjZXNzaWJpbGl0eS9hdGsvQVhPYmplY3RDYWNoZUF0ay5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBWE9iamVjdENhY2hlOjphdHRhY2hXcmFwcGVyKTogVXNlIC0xIGFzIHRoZSBpbmRleCB3 aGVuIGZpbmQoKSByZXR1cm5zIG5vdEZvdW5kLgorCiAyMDE5LTA0LTAyICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMzgyNjYp OiBFeGNoYW5nZSAyMDEzIE91dGxvb2sgV2ViIEFjY2VzcyBkaXNwbGF5cyBwYXJ0aWFsbHkgYmxh bmsgcGFnZSB3aGVuIGNyZWF0aW5nIG5ldyBlLW1haWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvYXRrL0FYT2JqZWN0Q2FjaGVBdGsuY3BwIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdGsvQVhPYmplY3RDYWNoZUF0ay5jcHAKaW5kZXggZjdjZDNhYThh ZGQuLjNhYzAyMjg2MDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2F0ay9BWE9iamVjdENhY2hlQXRrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0ay9BWE9iamVjdENhY2hlQXRrLmNwcApAQCAtOTksNyArOTksNyBAQCB2b2lkIEFYT2Jq ZWN0Q2FjaGU6OmF0dGFjaFdyYXBwZXIoQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqKQogICAgICAg ICByZXR1cm47CiAKICAgICBzaXplX3QgaW5kZXggPSBjb3JlUGFyZW50LT5jaGlsZHJlbihmYWxz ZSkuZmluZChvYmopOwotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZShhdGtQYXJlbnQsICJjaGls ZHJlbi1jaGFuZ2VkOjphZGQiLCBpbmRleCwgYXRrT2JqKTsKKyAgICBnX3NpZ25hbF9lbWl0X2J5 X25hbWUoYXRrUGFyZW50LCAiY2hpbGRyZW4tY2hhbmdlZDo6YWRkIiwgaW5kZXggIT0gbm90Rm91 bmQgPyBpbmRleCA6IC0xLCBhdGtPYmopOwogfQogCiBzdGF0aWMgQWNjZXNzaWJpbGl0eU9iamVj dCogZ2V0TGlzdE9iamVjdChBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmplY3QpCg==