196535 2019-04-03 05:54:25 -0700 [ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded 2019-04-05 01:39:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 196534 1 cgarcia webkit-unassigned bugs-noreply jdiggs mario mcatanzaro oldest_to_newest 1523670 0 cgarcia 2019-04-03 05:54:25 -0700 This way the properties are not cached. Right now, if number of children is queried before the socket is embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded. 1523671 1 366593 cgarcia 2019-04-03 05:56:50 -0700 Created attachment 366593 Patch 1524169 2 cgarcia 2019-04-03 22:51:44 -0700 Committed r243862: <https://trac.webkit.org/changeset/243862> 1524643 3 mario 2019-04-05 01:39:11 -0700 Another late drive-by review: lgtm 366593 2019-04-03 05:56:50 -0700 2019-04-03 08:07:40 -0700 Patch wk2-atk-transient.diff text/plain 2662 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTZlMGJhMDk3MmMuLjljODIwNDcxYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE5LTA0LTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbQVRLXSBTZXQgQVRLX1NUQVRFX1RSQU5TSUVOVCBvbiB0aGUgYXRr IHNvY2tldCB1bnRpbCBpdCdzIGVtYmVkZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHdheSB0aGUgcHJvcGVydGllcyBhcmUgbm90IGNhY2hl ZC4gUmlnaHQgbm93LCBpZiBudW1iZXIgb2YgY2hpbGRyZW4gaXMgcXVlcmllZCBiZWZvcmUgdGhl IHNvY2tldCBpcworICAgICAgICBlbWJlZGRlZCwgMCBpcyByZXR1cm5lZCBhbmQgY2FjaGVkLCBz byBBVHMgZG9uJ3Qgc2VlIHRoZSBjaGlsZCBldmVuIGFmdGVyIHRoZSBzb2NrZXQgaGFzIGJlZW4g ZW1iZWRkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZUFjY2Vzc2libGUuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VBY2Nlc3NpYmxlUmVm U3RhdGVTZXQpOiBTZXQgQVRLX1NUQVRFX1RSQU5TSUVOVCBpcyB0aGUgc29ja2V0IGlzIG5vdCBv Y2N1cGllZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYlBhZ2VQcm94eUd0ay5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6YmluZEFjY2Vzc2liaWxpdHlUcmVlKTogVW5z ZXQgQVRLX1NUQVRFX1RSQU5TSUVOVC4KKwogMjAxOS0wNC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0FUS10gRW1iZWQgdGhlIEF0a1Nv Y2tldCBhcyBzb29uIGFzIHdlIHJlY2VpdmUgdGhlIHBsdWcgSUQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VBY2Nlc3NpYmxlLmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VBY2Nl c3NpYmxlLmNwcAppbmRleCAwY2JlOTU1ZTA3ZS4uN2ExMzk2NTc3NDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VBY2Nlc3NpYmxl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdC YXNlQWNjZXNzaWJsZS5jcHAKQEAgLTU5LDYgKzU5LDggQEAgc3RhdGljIEF0a1N0YXRlU2V0KiB3 ZWJraXRXZWJWaWV3QmFzZUFjY2Vzc2libGVSZWZTdGF0ZVNldChBdGtPYmplY3QqIGF0a09iamVj dCkKICAgICBpZiAoYWNjZXNzaWJsZS0+cHJpdi0+d2lkZ2V0KSB7CiAgICAgICAgIC8vIFVzZSB0 aGUgaW1wbGVtZW50YXRpb24gb2YgQXRrU29ja2V0IGlmIHRoZSB3aWRnZXQgaXMgc3RpbGwgYWxp dmUuCiAgICAgICAgIHN0YXRlU2V0ID0gQVRLX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdf YmFzZV9hY2Nlc3NpYmxlX3BhcmVudF9jbGFzcyktPnJlZl9zdGF0ZV9zZXQoYXRrT2JqZWN0KTsK KyAgICAgICAgaWYgKCFhdGtfc29ja2V0X2lzX29jY3VwaWVkKEFUS19TT0NLRVQoYXRrT2JqZWN0 KSkpCisgICAgICAgICAgICBhdGtfc3RhdGVfc2V0X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NU QVRFX1RSQU5TSUVOVCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8gSWYgdGhlIHdpZGdldCBp cyBubyBsb25nZXIgYWxpdmUsIHNhdmUgc29tZSByZW1vdGUgY2FsbHMKICAgICAgICAgLy8gKGJl Y2F1c2Ugb2YgQXRrU29ja2V0J3MgaW1wbGVtZW50YXRpb24gb2YgcmVmX3N0YXRlX3NldCgpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYlBhZ2VQcm94eUd0ay5j cHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViUGFnZVByb3h5R3RrLmNwcAppbmRl eCA5YTAyMWZlNjA4Ny4uM2JkOWE2OTJlYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2d0ay9XZWJQYWdlUHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2d0ay9XZWJQYWdlUHJveHlHdGsuY3BwCkBAIC01OSw2ICs1OSw3IEBAIHZvaWQgV2ViUGFn ZVByb3h5OjpiaW5kQWNjZXNzaWJpbGl0eVRyZWUoY29uc3QgU3RyaW5nJiBwbHVnSUQpCiB7CiAg ICAgYXV0byogYWNjZXNzaWJsZSA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUodmlld1dpZGdl dCgpKTsKICAgICBhdGtfc29ja2V0X2VtYmVkKEFUS19TT0NLRVQoYWNjZXNzaWJsZSksIGNvbnN0 X2Nhc3Q8Y2hhcio+KHBsdWdJRC51dGY4KCkuZGF0YSgpKSk7CisgICAgYXRrX29iamVjdF9ub3Rp Znlfc3RhdGVfY2hhbmdlKGFjY2Vzc2libGUsIEFUS19TVEFURV9UUkFOU0lFTlQsIEZBTFNFKTsK IH0KIAogdm9pZCBXZWJQYWdlUHJveHk6OnNhdmVSZWNlbnRTZWFyY2hlcyhjb25zdCBTdHJpbmcm LCBjb25zdCBWZWN0b3I8V2ViQ29yZTo6UmVjZW50U2VhcmNoPiYpCg==