196526 2019-04-02 22:10:05 -0700 Add a WebKit internal feature flag to always enable modern compatibility mode by default 2019-04-03 16:30:57 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue dino graouts thorton webkit-bug-importer oldest_to_newest 1523611 0 wenson_hsieh 2019-04-02 22:10:05 -0700 <rdar://problem/49532923> 1523703 1 366604 wenson_hsieh 2019-04-03 08:10:45 -0700 Created attachment 366604 Patch 1523723 2 366604 commit-queue 2019-04-03 09:02:13 -0700 Comment on attachment 366604 Patch Clearing flags on attachment: 366604 Committed r243800: <https://trac.webkit.org/changeset/243800> 1523724 3 commit-queue 2019-04-03 09:02:14 -0700 All reviewed patches have been landed. Closing bug. 1523937 4 wenson_hsieh 2019-04-03 14:35:05 -0700 After hooking this up to internal code, I realized that it actually needs to be in the debug category, as opposed to internal :/ 1523956 5 366648 wenson_hsieh 2019-04-03 14:49:59 -0700 Created attachment 366648 Patch 1523987 6 366648 thorton 2019-04-03 15:24:07 -0700 Comment on attachment 366648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1199 > +UseModernCompatibilityModeByDefault: Is there not a debug section? 1523988 7 366648 thorton 2019-04-03 15:24:43 -0700 Comment on attachment 366648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review > Source/WebKit/Shared/WebPreferences.yaml:1203 > + humanReadableDescription: "Use modern compatibility mode everywhere by default" "everywhere" is not a property of the pref, should be left out of the description 1523995 8 366648 wenson_hsieh 2019-04-03 15:31:44 -0700 Comment on attachment 366648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366648&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1199 >> +UseModernCompatibilityModeByDefault: > > Is there not a debug section? I *think* this is the debug section (the closest comment moving up this place in the file is "# Debug Preferences"). But there are some debug prefs further up that I can put this next to, so I'll move it there. >> Source/WebKit/Shared/WebPreferences.yaml:1203 >> + humanReadableDescription: "Use modern compatibility mode everywhere by default" > > "everywhere" is not a property of the pref, should be left out of the description 👍🏻 1523997 9 366658 wenson_hsieh 2019-04-03 15:38:08 -0700 Created attachment 366658 Patch for landing 1524027 10 commit-queue 2019-04-03 16:29:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 366658: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1524030 11 366658 commit-queue 2019-04-03 16:30:20 -0700 Comment on attachment 366658 Patch for landing Clearing flags on attachment: 366658 Committed r243836: <https://trac.webkit.org/changeset/243836> 366604 2019-04-03 08:10:45 -0700 2019-04-03 14:49:57 -0700 Patch bug-196526-20190403081044.patch text/plain 1433 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFiN2Q4M2NjYzI0OTA2MmEx NDY5ZGRhNmNiZjhmYjEwNGJkZTNmMDguLjAwMTVkYWU1OTA1YjViZmNhODQwOWJiZjZiYTQ2MWJl YTc4Nzk2MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDQtMDMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgV2ViS2l0IGlu dGVybmFsIGZlYXR1cmUgZmxhZyB0byBhbHdheXMgZW5hYmxlIG1vZGVybiBjb21wYXRpYmlsaXR5 IG1vZGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2NTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTUzMjkyMz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQ cmVmZXJlbmNlcy55YW1sOgorCiAyMDE5LTAzLTI5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNp ZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEludHJvZHVjZSBhbmQgYWRkIHBsdW1iaW5nIGZvciBh IHdlYnNpdGUgcG9saWN5IGZvciBtZXRhIHZpZXdwb3J0IHRhZyBoYW5kbGluZwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggOWYwZjFhY2M2NDE1NDRkNGI1NmFj MWNjOWIyOWMxNTdkNDBlNjdkNi4uNjM0ZmYzOTQ1MzBlZjg0YWY2YTY2ZGYxYmU4NTA0YTg4ZWQ4 NTQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFt bAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xNjMw LDYgKzE2MzAsMTQgQEAgQXBwbGVQYXlSZW1vdGVVSUVuYWJsZWQ6CiAgIGh1bWFuUmVhZGFibGVO YW1lOiAiQXBwbGUgUGF5IFJlbW90ZSBVSSIKICAgdHlwZTogYm9vbAogCitVc2VNb2Rlcm5Db21w YXRpYmlsaXR5TW9kZUJ5RGVmYXVsdDoKKyAgY2F0ZWdvcnk6IGludGVybmFsCisgIGRlZmF1bHRW YWx1ZTogZmFsc2UKKyAgaHVtYW5SZWFkYWJsZU5hbWU6ICJVc2UgTW9kZXJuIENvbXBhdGliaWxp dHkgTW9kZSIKKyAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiVXNlIG1vZGVybiBjb21wYXRp YmlsaXR5IG1vZGUgZXZlcnl3aGVyZSBieSBkZWZhdWx0IgorICB3ZWJjb3JlQmluZGluZzogbm9u ZQorICB0eXBlOiBib29sCisKICMgRGVwcmVjYXRlZAogCiBJQ0VDYW5kaWRhdGVGaWx0ZXJpbmdF bmFibGVkOgo= 366648 2019-04-03 14:49:59 -0700 2019-04-03 15:25:22 -0700 Patch bug-196526-20190403144958.patch text/plain 2145 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk2ZDJmMmEwYWE4Nzk3OTNh NmNmMzhkNjIwMWQ0YjBlOTZjYmYxOTMuLjAyZjAzNTJmYjE0YzIxNzdhYzg0MmU4MjcxOWNhNzJh NjFmNjgwYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDQtMDMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgV2ViS2l0IGlu dGVybmFsIGZlYXR1cmUgZmxhZyB0byBhbHdheXMgZW5hYmxlIG1vZGVybiBjb21wYXRpYmlsaXR5 IG1vZGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2NTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTUzMjkyMz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgVXNlTW9k ZXJuQ29tcGF0aWJpbGl0eU1vZGVCeURlZmF1bHQgZnJvbSBhbiBpbnRlcm5hbCBwcmVmZXJlbmNl IHRvIGEgZGVidWcgcHJlZmVyZW5jZSwgc28gdGhhdCBpdCBtYXkgYmUKKyAgICAgICAgZW5hYmxl ZCBmb3IgYWxsIGFwcHMgb24gdGhlIHN5c3RlbS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVm ZXJlbmNlcy55YW1sOgorCiAyMDE5LTA0LTAzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIFdlYktpdCBpbnRlcm5hbCBmZWF0dXJlIGZsYWcg dG8gYWx3YXlzIGVuYWJsZSBtb2Rlcm4gY29tcGF0aWJpbGl0eSBtb2RlIGJ5IGRlZmF1bHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IDYzNGZmMzk0NTMwZWY4 NGFmNmE2NmRmMWJlODUwNGE4OGVkODU0OWMuLjdiZDk4ZWFmMTQ5MjhmN2I3N2Y3Njg5Mzc4NDgz Njk5MWI1ODc0NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVu Y2VzLnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApA QCAtMTE5Niw2ICsxMTk2LDE0IEBAIFNob3VsZERlY2lkZVBvbGljeUJlZm9yZUxvYWRpbmdRdWlj a0xvb2tQcmV2aWV3OgogICBkZWZhdWx0VmFsdWU6IGZhbHNlCiAgIHR5cGU6IGJvb2wKIAorVXNl TW9kZXJuQ29tcGF0aWJpbGl0eU1vZGVCeURlZmF1bHQ6CisgIGNhdGVnb3J5OiBkZWJ1ZworICBk ZWZhdWx0VmFsdWU6IGZhbHNlCisgIGh1bWFuUmVhZGFibGVOYW1lOiAiVXNlIE1vZGVybiBDb21w YXRpYmlsaXR5IE1vZGUiCisgIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIlVzZSBtb2Rlcm4g Y29tcGF0aWJpbGl0eSBtb2RlIGV2ZXJ5d2hlcmUgYnkgZGVmYXVsdCIKKyAgd2ViY29yZUJpbmRp bmc6IG5vbmUKKyAgdHlwZTogYm9vbAorCiAjIEZvciBleHBlcmltZW50YWwgZmVhdHVyZXM6CiAj IFRoZSB0eXBlIHNob3VsZCBiZSBib29sZWFuLgogIyBZb3UgbXVzdCBwcm92aWRlIGEgaHVtYW5S ZWFkYWJsZU5hbWUgYW5kIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbiBmb3IgYWxsIGV4cGVyaW1l bnRhbCBmZWF0dXJlcy4gVGhleQpAQCAtMTYzMCwxNCArMTYzOCw2IEBAIEFwcGxlUGF5UmVtb3Rl VUlFbmFibGVkOgogICBodW1hblJlYWRhYmxlTmFtZTogIkFwcGxlIFBheSBSZW1vdGUgVUkiCiAg IHR5cGU6IGJvb2wKIAotVXNlTW9kZXJuQ29tcGF0aWJpbGl0eU1vZGVCeURlZmF1bHQ6Ci0gIGNh dGVnb3J5OiBpbnRlcm5hbAotICBkZWZhdWx0VmFsdWU6IGZhbHNlCi0gIGh1bWFuUmVhZGFibGVO YW1lOiAiVXNlIE1vZGVybiBDb21wYXRpYmlsaXR5IE1vZGUiCi0gIGh1bWFuUmVhZGFibGVEZXNj cmlwdGlvbjogIlVzZSBtb2Rlcm4gY29tcGF0aWJpbGl0eSBtb2RlIGV2ZXJ5d2hlcmUgYnkgZGVm YXVsdCIKLSAgd2ViY29yZUJpbmRpbmc6IG5vbmUKLSAgdHlwZTogYm9vbAotCiAjIERlcHJlY2F0 ZWQKIAogSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZDoK 366658 2019-04-03 15:38:08 -0700 2019-04-03 16:30:20 -0700 Patch for landing bug-196526-20190403153808.patch text/plain 2034 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk2ZDJmMmEwYWE4Nzk3OTNh NmNmMzhkNjIwMWQ0YjBlOTZjYmYxOTMuLjdlNGE4NDI4MTFmYzUzOWY1NGY0YTAzMTUzMzljM2U4 NjczOGVjMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDQtMDMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgV2ViS2l0IGlu dGVybmFsIGZlYXR1cmUgZmxhZyB0byBhbHdheXMgZW5hYmxlIG1vZGVybiBjb21wYXRpYmlsaXR5 IG1vZGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2NTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTUzMjkyMz4KKworICAg ICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIENoYW5nZSBVc2VNb2Rlcm5D b21wYXRpYmlsaXR5TW9kZUJ5RGVmYXVsdCBmcm9tIGFuIGludGVybmFsIHByZWZlcmVuY2UgdG8g YSBkZWJ1ZyBwcmVmZXJlbmNlLCBzbyB0aGF0IGl0IG1heSBiZQorICAgICAgICBlbmFibGVkIGZv ciBhbGwgYXBwcyBvbiB0aGUgc3lzdGVtLgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVu Y2VzLnlhbWw6CisKIDIwMTktMDQtMDMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGEgV2ViS2l0IGludGVybmFsIGZlYXR1cmUgZmxhZyB0byBh bHdheXMgZW5hYmxlIG1vZGVybiBjb21wYXRpYmlsaXR5IG1vZGUgYnkgZGVmYXVsdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKaW5kZXggNjM0ZmYzOTQ1MzBlZjg0YWY2 YTY2ZGYxYmU4NTA0YTg4ZWQ4NTQ5Yy4uMzVkNzFjZDBjNmRkZDQ0ZDEzOTM1NDM4OTA4NTNhZTgz MDY1MGI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMu eWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0x MDYwLDYgKzEwNjAsMTQgQEAgRGlzYWJsZVNjcmVlblNpemVPdmVycmlkZToKICAgY2F0ZWdvcnk6 IGRlYnVnCiAgIGNvbmRpdGlvbjogUExBVEZPUk0oSU9TX0ZBTUlMWSkKIAorVXNlTW9kZXJuQ29t cGF0aWJpbGl0eU1vZGVCeURlZmF1bHQ6CisgIHR5cGU6IGJvb2wKKyAgZGVmYXVsdFZhbHVlOiBm YWxzZQorICBodW1hblJlYWRhYmxlTmFtZTogIlVzZSBNb2Rlcm4gQ29tcGF0aWJpbGl0eSBNb2Rl IgorICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJVc2UgbW9kZXJuIGNvbXBhdGliaWxpdHkg bW9kZSBieSBkZWZhdWx0IgorICB3ZWJjb3JlQmluZGluZzogbm9uZQorICBjYXRlZ29yeTogZGVi dWcKKwogU2ltcGxlTGluZUxheW91dERlYnVnQm9yZGVyc0VuYWJsZWQ6CiAgIHR5cGU6IGJvb2wK ICAgZGVmYXVsdFZhbHVlOiBmYWxzZQpAQCAtMTYzMCwxNCArMTYzOCw2IEBAIEFwcGxlUGF5UmVt b3RlVUlFbmFibGVkOgogICBodW1hblJlYWRhYmxlTmFtZTogIkFwcGxlIFBheSBSZW1vdGUgVUki CiAgIHR5cGU6IGJvb2wKIAotVXNlTW9kZXJuQ29tcGF0aWJpbGl0eU1vZGVCeURlZmF1bHQ6Ci0g IGNhdGVnb3J5OiBpbnRlcm5hbAotICBkZWZhdWx0VmFsdWU6IGZhbHNlCi0gIGh1bWFuUmVhZGFi bGVOYW1lOiAiVXNlIE1vZGVybiBDb21wYXRpYmlsaXR5IE1vZGUiCi0gIGh1bWFuUmVhZGFibGVE ZXNjcmlwdGlvbjogIlVzZSBtb2Rlcm4gY29tcGF0aWJpbGl0eSBtb2RlIGV2ZXJ5d2hlcmUgYnkg ZGVmYXVsdCIKLSAgd2ViY29yZUJpbmRpbmc6IG5vbmUKLSAgdHlwZTogYm9vbAotCiAjIERlcHJl Y2F0ZWQKIAogSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZDoK