196520 2019-04-02 17:44:36 -0700 [ews-build] Cancel build and similar operations should have authentication 2021-01-27 11:24:52 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221052 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1523549 0 aakash_jain 2019-04-02 17:44:36 -0700 Currently there is no authentication on ews-build webpages. Anyone can press 'cancel' button and cancel all the running builds and all the pending buildrequests. Similarly anyone can pause/shutdown the workers. These operations should not be allowed without authentication. 1523553 1 366562 aakash_jain 2019-04-02 17:48:49 -0700 Created attachment 366562 Patch 1523561 2 366562 dewei_zhu 2019-04-02 18:38:23 -0700 Comment on attachment 366562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366562&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:4 > +from buildbot.plugins import * I would prefer to import exactly the models those will be used in this file so that it would be much easier to locate certain module / function. > Tools/BuildSlaveSupport/ews-build/master.cfg:22 > +admin_username = os.getenv('EWS_ADMIN_USERNAME') > +admin_password = os.getenv('EWS_ADMIN_PASSWORD') Does it work when neither environment is set? What happens if only either of them is set? 1523682 3 366598 aakash_jain 2019-04-03 06:57:03 -0700 Created attachment 366598 Patch 1523683 4 aakash_jain 2019-04-03 07:00:42 -0700 > I would prefer to import exactly the models those will be used in this file so that it would be much easier to locate certain module / function. Done. > Does it work when neither environment is set? Yes, in that case it will work without authentication. 'if admin_username and admin_password:' condition wouldn't be met and we won't set any authentication, this might be useful for local testing. > What happens if only either of them is set? Same as above, we won't configure the authentication since the 'if' condition won't be met. 1523856 5 366598 lforschler 2019-04-03 13:01:28 -0700 Comment on attachment 366598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366598&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:32 > + I'm concerned that if we have no environment variable set, the default state of the server is to not require auth... I think if we fail to find an environment variable, we should probably not continue. 1523867 6 kocsen_chung 2019-04-03 13:22:17 -0700 Agree with Lucas, we probably want to check if there is no username and password and fail. 1524073 7 366677 aakash_jain 2019-04-03 17:34:19 -0700 Created attachment 366677 Patch 1524074 8 aakash_jain 2019-04-03 17:35:55 -0700 > I think if we fail to find an environment variable, we should probably not continue. Done. 1524150 9 366677 commit-queue 2019-04-03 20:57:16 -0700 Comment on attachment 366677 Patch Clearing flags on attachment: 366677 Committed r243854: <https://trac.webkit.org/changeset/243854> 1524151 10 commit-queue 2019-04-03 20:57:18 -0700 All reviewed patches have been landed. Closing bug. 1524155 11 webkit-bug-importer 2019-04-03 20:58:23 -0700 <rdar://problem/49590783> 366562 2019-04-02 17:48:49 -0700 2019-04-03 06:57:01 -0700 Patch bug-196520-20190402204941.patch text/plain 1749 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzc4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBDYW5jZWwgYnVpbGQgYW5kIHNpbWlsYXIgb3BlcmF0 aW9ucyBzaG91bGQgaGF2ZSBhdXRoZW50aWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbWFz dGVyLmNmZzogQ29uZmlndXJlIGF1dGhlbnRpY2F0aW9uIGlmIGFkbWluJ3MgdXNlcm5hbWUgYW5k IHBhc3N3b3JkIGlzIHByZXNlbnQKKyAgICAgICAgaW4gZW52aXJvbm1lbnQgdmFyaWFibGVzLgor CiAyMDE5LTA0LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBbZXdzLWJ1aWxkXSBSZWFzc2lnbiBib3RzIHRvIHF1ZXVlcwpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcJKHJldmlzaW9uIDI0Mzc4MCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnCSh3b3JraW5n IGNvcHkpCkBAIC0xLDYgKzEsOCBAQAogaW1wb3J0IG9zCiBpbXBvcnQgc29ja2V0CiAKK2Zyb20g YnVpbGRib3QucGx1Z2lucyBpbXBvcnQgKgorCiBpbXBvcnQgbG9hZENvbmZpZwogZnJvbSBldmVu dHMgaW1wb3J0IEV2ZW50cwogCkBAIC0xNiw2ICsxOCwxOCBAQCBjWyd3d3cnXVsndWlfZGVmYXVs dF9jb25maWcnXSA9IHsgCiAgICAgJ1dvcmtlcnMuc2hvd1dvcmtlckJ1aWxkZXJzJzogVHJ1ZSwK IH0KIAorYWRtaW5fdXNlcm5hbWUgPSBvcy5nZXRlbnYoJ0VXU19BRE1JTl9VU0VSTkFNRScpCith ZG1pbl9wYXNzd29yZCA9IG9zLmdldGVudignRVdTX0FETUlOX1BBU1NXT1JEJykKK2lmIGFkbWlu X3VzZXJuYW1lIGFuZCBhZG1pbl9wYXNzd29yZDoKKyAgICAjIFNlZSBodHRwczovL2RvY3MuYnVp bGRib3QubmV0L2N1cnJlbnQvbWFudWFsL2NvbmZpZ3VyYXRpb24vd3d3Lmh0bWwjZXhhbXBsZS1j b25maWdzCisgICAgYXV0aHogPSB1dGlsLkF1dGh6KAorICAgICAgICBhbGxvd1J1bGVzPVt1dGls LkFueUNvbnRyb2xFbmRwb2ludE1hdGNoZXIocm9sZT0iYWRtaW4iKV0sCisgICAgICAgIHJvbGVN YXRjaGVycz1bdXRpbC5Sb2xlc0Zyb21FbWFpbHMoYWRtaW49W2FkbWluX3VzZXJuYW1lXSldCisg ICAgKQorICAgIGF1dGg9dXRpbC5Vc2VyUGFzc3dvcmRBdXRoKHthZG1pbl91c2VybmFtZTogYWRt aW5fcGFzc3dvcmR9KQorICAgIGNbJ3d3dyddWydhdXRoJ10gPSBhdXRoCisgICAgY1snd3d3J11b J2F1dGh6J10gPSBhdXRoegorCiBjWydwcm90b2NvbHMnXSA9IHsncGInOiB7J3BvcnQnOiAxNzAw MH19CiAKIGNbJ3Byb2plY3ROYW1lJ10gPSAnV2ViS2l0IEVXUycK 366598 2019-04-03 06:57:03 -0700 2019-04-03 17:34:17 -0700 Patch bug-196520-20190403095756.patch text/plain 1754 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzc4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBDYW5jZWwgYnVpbGQgYW5kIHNpbWlsYXIgb3BlcmF0 aW9ucyBzaG91bGQgaGF2ZSBhdXRoZW50aWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbWFz dGVyLmNmZzogQ29uZmlndXJlIGF1dGhlbnRpY2F0aW9uIGlmIGFkbWluJ3MgdXNlcm5hbWUgYW5k IHBhc3N3b3JkIGlzIHByZXNlbnQKKyAgICAgICAgaW4gZW52aXJvbm1lbnQgdmFyaWFibGVzLgor CiAyMDE5LTA0LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBbZXdzLWJ1aWxkXSBSZWFzc2lnbiBib3RzIHRvIHF1ZXVlcwpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcJKHJldmlzaW9uIDI0Mzc4MCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnCSh3b3JraW5n IGNvcHkpCkBAIC0xLDYgKzEsOCBAQAogaW1wb3J0IG9zCiBpbXBvcnQgc29ja2V0CiAKK2Zyb20g YnVpbGRib3QucGx1Z2lucyBpbXBvcnQgdXRpbAorCiBpbXBvcnQgbG9hZENvbmZpZwogZnJvbSBl dmVudHMgaW1wb3J0IEV2ZW50cwogCkBAIC0xNiw2ICsxOCwxOCBAQCBjWyd3d3cnXVsndWlfZGVm YXVsdF9jb25maWcnXSA9IHsgCiAgICAgJ1dvcmtlcnMuc2hvd1dvcmtlckJ1aWxkZXJzJzogVHJ1 ZSwKIH0KIAorYWRtaW5fdXNlcm5hbWUgPSBvcy5nZXRlbnYoJ0VXU19BRE1JTl9VU0VSTkFNRScp CithZG1pbl9wYXNzd29yZCA9IG9zLmdldGVudignRVdTX0FETUlOX1BBU1NXT1JEJykKK2lmIGFk bWluX3VzZXJuYW1lIGFuZCBhZG1pbl9wYXNzd29yZDoKKyAgICAjIFNlZSBodHRwczovL2RvY3Mu YnVpbGRib3QubmV0L2N1cnJlbnQvbWFudWFsL2NvbmZpZ3VyYXRpb24vd3d3Lmh0bWwjZXhhbXBs ZS1jb25maWdzCisgICAgYXV0aHogPSB1dGlsLkF1dGh6KAorICAgICAgICBhbGxvd1J1bGVzPVt1 dGlsLkFueUNvbnRyb2xFbmRwb2ludE1hdGNoZXIocm9sZT0iYWRtaW4iKV0sCisgICAgICAgIHJv bGVNYXRjaGVycz1bdXRpbC5Sb2xlc0Zyb21FbWFpbHMoYWRtaW49W2FkbWluX3VzZXJuYW1lXSld CisgICAgKQorICAgIGF1dGggPSB1dGlsLlVzZXJQYXNzd29yZEF1dGgoe2FkbWluX3VzZXJuYW1l OiBhZG1pbl9wYXNzd29yZH0pCisgICAgY1snd3d3J11bJ2F1dGgnXSA9IGF1dGgKKyAgICBjWyd3 d3cnXVsnYXV0aHonXSA9IGF1dGh6CisKIGNbJ3Byb3RvY29scyddID0geydwYic6IHsncG9ydCc6 IDE3MDAwfX0KIAogY1sncHJvamVjdE5hbWUnXSA9ICdXZWJLaXQgRVdTJwo= 366677 2019-04-03 17:34:19 -0700 2019-04-03 20:57:16 -0700 Patch bug-196520-20190403203513.patch text/plain 1967 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzg0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTAzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBDYW5jZWwgYnVpbGQgYW5kIHNpbWlsYXIgb3BlcmF0 aW9ucyBzaG91bGQgaGF2ZSBhdXRoZW50aWNhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbWFz dGVyLmNmZzogQ29uZmlndXJlIGF1dGhlbnRpY2F0aW9uIHVzaW5nIGFkbWluJ3MgdXNlcm5hbWUg YW5kIHBhc3N3b3JkIGZyb20KKyAgICAgICAgZW52aXJvbm1lbnQgdmFyaWFibGVzLgorCiAyMDE5 LTA0LTAzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg ICAgLWFwcGxlLXRyYWlsaW5nLXdvcmQgaXMgbmVlZGVkIGZvciBicm93c2VyIGRldGVjdGlvbgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcJKHJl dmlzaW9uIDI0Mzg0MSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0 ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsOCBAQAogaW1wb3J0IG9zCiBpbXBvcnQg c29ja2V0CitpbXBvcnQgc3lzCisKK2Zyb20gYnVpbGRib3QucGx1Z2lucyBpbXBvcnQgdXRpbAog CiBpbXBvcnQgbG9hZENvbmZpZwogZnJvbSBldmVudHMgaW1wb3J0IEV2ZW50cwpAQCAtMTYsNiAr MTksMjEgQEAgY1snd3d3J11bJ3VpX2RlZmF1bHRfY29uZmlnJ10gPSB7IAogICAgICdXb3JrZXJz LnNob3dXb3JrZXJCdWlsZGVycyc6IFRydWUsCiB9CiAKK2lmIG5vdCBpc190ZXN0X21vZGVfZW5h YmxlZDoKKyAgICBhZG1pbl91c2VybmFtZSA9IG9zLmdldGVudignRVdTX0FETUlOX1VTRVJOQU1F JykKKyAgICBhZG1pbl9wYXNzd29yZCA9IG9zLmdldGVudignRVdTX0FETUlOX1BBU1NXT1JEJykK KyAgICBpZiBub3QgYWRtaW5fdXNlcm5hbWUgb3Igbm90IGFkbWluX3Bhc3N3b3JkOgorICAgICAg ICBwcmludCgnRW52aXJvbm1lbnQgdmFyaWFibGVzIGZvciBhZG1pbiB1c2VybmFtZS9wYXNzd29y ZCBub3QgZm91bmQuIFBsZWFzZSBlbnN1cmUgdGhlc2UgdmFyaWFibGVzIGFyZSBzZXQuJykKKyAg ICAgICAgc3lzLmV4aXQoMSkKKyAgICAjIFNlZSBodHRwczovL2RvY3MuYnVpbGRib3QubmV0L2N1 cnJlbnQvbWFudWFsL2NvbmZpZ3VyYXRpb24vd3d3Lmh0bWwjZXhhbXBsZS1jb25maWdzCisgICAg YXV0aHogPSB1dGlsLkF1dGh6KAorICAgICAgICBhbGxvd1J1bGVzPVt1dGlsLkFueUNvbnRyb2xF bmRwb2ludE1hdGNoZXIocm9sZT0iYWRtaW4iKV0sCisgICAgICAgIHJvbGVNYXRjaGVycz1bdXRp bC5Sb2xlc0Zyb21FbWFpbHMoYWRtaW49W2FkbWluX3VzZXJuYW1lXSldCisgICAgKQorICAgIGF1 dGggPSB1dGlsLlVzZXJQYXNzd29yZEF1dGgoe2FkbWluX3VzZXJuYW1lOiBhZG1pbl9wYXNzd29y ZH0pCisgICAgY1snd3d3J11bJ2F1dGgnXSA9IGF1dGgKKyAgICBjWyd3d3cnXVsnYXV0aHonXSA9 IGF1dGh6CisKIGNbJ3Byb3RvY29scyddID0geydwYic6IHsncG9ydCc6IDE3MDAwfX0KIAogY1sn cHJvamVjdE5hbWUnXSA9ICdXZWJLaXQgRVdTJwo=