196517 2019-04-02 16:57:41 -0700 [ Mac ] REGRESSION (r243033) Assertion failed: m_logger Layout Test imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html is a flaky crash 2019-10-14 10:39:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195823 InRadar P2 Normal --- 1 sroberts eric.carlson commit-queue eric.carlson lforschler webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1523532 0 sroberts 2019-04-02 16:57:41 -0700 The following layout test is flaky on Mac Release WK2, Mac Debug WK1 & WK2 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html Probable cause: Test started showing up recently on dashboard as a flaky crash. Through local testing found crashes began with https://trac.webkit.org/changeset/243033/webkit . Testing prior to this revision yield all passes. Crashes the most in WK1 Debug, but I can repro locally in every build listed on the dashboard. Reproduced with: run-webkit-tests imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html --iterations 500 -f --debug -1 --exit-after-n-failures=2 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmst-content-hint%2FMediaStreamTrack-contentHint.html Crash Log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r243759%20(2880)/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-crash-log.txt ASSERTION FAILED: m_logger /Volumes/Data/slave/mojave-debug/build/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h(121) : virtual const WTF::Logger &WebCore::MediaStreamTrackPrivate::logger() const 1 0x104d9fdb9 WTFCrash 2 0x1139d655b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x116de6b07 WebCore::MediaStreamTrackPrivate::logger() const 4 0x116de6259 WebCore::MediaStreamTrackPrivate::updateReadyState() 5 0x116de6a0e WebCore::MediaStreamTrackPrivate::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) 1523533 1 webkit-bug-importer 2019-04-02 16:58:29 -0700 <rdar://problem/49540704> 1523535 2 sroberts 2019-04-02 17:05:26 -0700 Skipping test in https://trac.webkit.org/changeset/243779/webkit while waiting for a fix. 1579662 3 380888 eric.carlson 2019-10-14 09:52:42 -0700 Created attachment 380888 Patch 1579663 4 eric.carlson 2019-10-14 09:54:11 -0700 This crash was fixed by the changes for https://bugs.webkit.org/show_bug.cgi?id=198844/rdar://51729128 1579686 5 380888 commit-queue 2019-10-14 10:39:25 -0700 Comment on attachment 380888 Patch Clearing flags on attachment: 380888 Committed r251083: <https://trac.webkit.org/changeset/251083> 1579687 6 commit-queue 2019-10-14 10:39:27 -0700 All reviewed patches have been landed. Closing bug. 380888 2019-10-14 09:52:42 -0700 2019-10-14 10:39:25 -0700 Patch bug-196517-20191014095241.patch text/plain 1705 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxMDczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGNmNGJmYTdhZjEyNjNmMzdhYmUx ZjQ5OTQxYWEyMDhkNjU4ZmExMy4uZDk4MWJjNjI0MDc3NTc0NjBlOTE2YzIyNWExM2JmOGI5OTY4 NTEyMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTEwLTE0ICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFsgTWFjIF0gUkVHUkVTU0lPTiAocjI0 MzAzMykgQXNzZXJ0aW9uIGZhaWxlZDogbV9sb2dnZXIgTGF5b3V0IFRlc3QgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9tc3QtY29udGVudC1oaW50L01lZGlhU3RyZWFtVHJhY2stY29u dGVudEhpbnQuaHRtbCBpcyBhIGZsYWt5IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY1MTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5 NTQwNzA0PgorCisgICAgICAgIFVucmV2aWV3ZWQsIHVuc2tpcHBpbmcgYSBwYXNzaW5nIHRlc3Qu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9uczogVW5za2lwIE1lZGlh U3RyZWFtVHJhY2stY29udGVudEhpbnQuaHRtbC4KKwogMjAxOS0xMC0xNCAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlcGxhY2UgcmVmdGVzdCBzY3JpcHRzLWhlaWdo dC5odG1sIHdpdGggc2NyaXB0IHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGYzMTJhNWI5OGQ5OGY1NWFhYzdjZmYzMzc3MTQwNTQxMDVhNGMxMTMu LjJhNWQ4MWI0NGMxYTU4MjZlYjgxNzM2MGMzYzVmNmYzNjNkZDQ2OGUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xODEwLDggKzE4MTAsNiBAQCBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24tbWFya3VwL3Nj cmlwdHMvY3JhbXBlZC0wMDEuaAogCiB3ZWJraXQub3JnL2IvMTk2NTAgWyBIaWdoU2llcnJhKyBd IGFjY2Vzc2liaWxpdHkvbWFjL3ByZXNzLW5vdC13b3JrLWZvci1kaXNhYmxlZC1tZW51LWxpc3Qu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xOTY1MTcgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9tc3QtY29udGVudC1oaW50L01lZGlhU3RyZWFtVHJhY2stY29u dGVudEhpbnQuaHRtbCBbIFNraXAgXQotCiAjIFNraXAgaU9TLXNwZWNpZmljIFBvaW50ZXIgRXZl bnRzIFdQVCB0ZXN0cy4KIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2 ZW50cy9wb2ludGVyZXZlbnRfY2hhbmdlLXRvdWNoLWFjdGlvbi1vbnBvaW50ZXJkb3duX3RvdWNo Lmh0bWwgWyBTa2lwIF0KIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcG9pbnRlcmV2 ZW50cy9wb2ludGVyZXZlbnRfcG9pbnRlcmNhbmNlbF90b3VjaC5odG1sIFsgU2tpcCBdCg==