196514 2019-04-02 16:41:19 -0700 HTML Parser: Remove conditional parsing of <noembed> content 2019-04-02 18:56:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed InRadar P2 Normal --- 1 cdumez cdumez commit-queue esprehn+autocc ews-watchlist ggaren gyuyoung.kim rniwa webkit-bug-importer youennf oldest_to_newest 1523517 0 cdumez 2019-04-02 16:41:19 -0700 Our HTML Parser has raw text handling for <noembed> content only if plugins are runnable. However, the HTML specification doesn't ask such behavior [1], and it doesn't match to our HTML serializer. We should always handle it as raw text. Blink already made this change in https://chromium-review.googlesource.com/c/1477556. [1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed 1523524 1 366551 cdumez 2019-04-02 16:45:40 -0700 Created attachment 366551 Patch 1523534 2 366551 ggaren 2019-04-02 16:59:57 -0700 Comment on attachment 366551 Patch r=me 1523572 3 366551 commit-queue 2019-04-02 18:55:43 -0700 Comment on attachment 366551 Patch Clearing flags on attachment: 366551 Committed r243782: <https://trac.webkit.org/changeset/243782> 1523573 4 commit-queue 2019-04-02 18:55:45 -0700 All reviewed patches have been landed. Closing bug. 1523574 5 webkit-bug-importer 2019-04-02 18:56:21 -0700 <rdar://problem/49544147> 366551 2019-04-02 16:45:40 -0700 2019-04-02 18:55:43 -0700 Patch bug-196514-20190402164540.patch text/plain 7195 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk4YTBjMjkzYjE4ODkw MDgwZDMzYmNjZWJkMTllYzY1NTMyN2RjYS4uMTdiNmRmOWU2NTc1Zjc5YWMzNDljMDI1OGExYTY2 YTZkMDJhYmM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTA0LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTCBQYXJzZXI6IFJlbW92 ZSBjb25kaXRpb25hbCBwYXJzaW5nIG9mIDxub2VtYmVkPiBjb250ZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY1MTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgSFRNTCBQYXJzZXIgaGFzIHJh dyB0ZXh0IGhhbmRsaW5nIGZvciA8bm9lbWJlZD4gY29udGVudCBvbmx5IGlmIHBsdWdpbnMgYXJl IHJ1bm5hYmxlLgorICAgICAgICBIb3dldmVyLCB0aGUgSFRNTCBzcGVjaWZpY2F0aW9uIGRvZXNu J3QgYXNrIHN1Y2ggYmVoYXZpb3IgWzFdLCBhbmQgaXQgZG9lc24ndCBtYXRjaCB0bworICAgICAg ICBvdXIgSFRNTCBzZXJpYWxpemVyLiBXZSBzaG91bGQgYWx3YXlzIGhhbmRsZSBpdCBhcyByYXcg dGV4dC4KKworICAgICAgICBCbGluayBhbHJlYWR5IG1hZGUgdGhpcyBjaGFuZ2UgaW4gaHR0cHM6 Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS9jLzE0Nzc1NTYuCisKKyAgICAgICAg WzFdIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL3BhcnNpbmcuaHRtbCNw YXJzaW5nLWh0bWwtZnJhZ21lbnRzOm5vZW1iZWQKKworICAgICAgICBObyBuZXcgdGVzdHMsIHVw ZGF0ZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxQYXJzZXJP cHRpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQYXJzZXJPcHRpb25zOjpIVE1MUGFy c2VyT3B0aW9ucyk6CisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFBhcnNlck9wdGlvbnMuaDoK KyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxUb2tlbml6ZXI6OnVwZGF0ZVN0YXRlRm9yKToKKyAgICAgICAgKiBodG1sL3BhcnNl ci9IVE1MVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVy Ojpwcm9jZXNzU3RhcnRUYWdGb3JJbkJvZHkpOgorCiAyMDE5LTA0LTAyICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgWE1MSHR0cFJlcXVlc3RVcGxvYWQncyBsb2Fk c3RhcnQgZXZlbnQgbm90IGNvcnJlY3QgaW5pdGlhbGl6ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQYXJzZXJPcHRpb25zLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxQYXJzZXJPcHRpb25zLmNwcAppbmRleCA4YmM0MTQ3MDFhNzZhMDQ5 MGNiOTY2MTIwY2NmZGU0YzQ3NTczMjFkLi5mODJlYjBhM2E0MWRhODlkZDFlYjJmYjYwMDJkYTkw MDY4ZTUzNzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUGFy c2VyT3B0aW9ucy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNl ck9wdGlvbnMuY3BwCkBAIC0zNyw3ICszNyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogSFRN TFBhcnNlck9wdGlvbnM6OkhUTUxQYXJzZXJPcHRpb25zKCkKICAgICA6IHNjcmlwdEVuYWJsZWQo ZmFsc2UpCi0gICAgLCBwbHVnaW5zRW5hYmxlZChmYWxzZSkKICAgICAsIHVzZVByZUhUTUw1UGFy c2VyUXVpcmtzKGZhbHNlKQogICAgICwgbWF4aW11bURPTVRyZWVEZXB0aChTZXR0aW5nczo6ZGVm YXVsdE1heGltdW1IVE1MUGFyc2VyRE9NVHJlZURlcHRoKQogewpAQCAtNDcsNyArNDYsNiBAQCBI VE1MUGFyc2VyT3B0aW9uczo6SFRNTFBhcnNlck9wdGlvbnMoRG9jdW1lbnQmIGRvY3VtZW50KQog ewogICAgIFJlZlB0cjxGcmFtZT4gZnJhbWUgPSBkb2N1bWVudC5mcmFtZSgpOwogICAgIHNjcmlw dEVuYWJsZWQgPSBmcmFtZSAmJiBmcmFtZS0+c2NyaXB0KCkuY2FuRXhlY3V0ZVNjcmlwdHMoTm90 QWJvdXRUb0V4ZWN1dGVTY3JpcHQpOwotICAgIHBsdWdpbnNFbmFibGVkID0gZnJhbWUgJiYgZnJh bWUtPmxvYWRlcigpLnN1YmZyYW1lTG9hZGVyKCkuYWxsb3dQbHVnaW5zKCk7CiAKICAgICB1c2VQ cmVIVE1MNVBhcnNlclF1aXJrcyA9IGRvY3VtZW50LnNldHRpbmdzKCkudXNlUHJlSFRNTDVQYXJz ZXJRdWlya3MoKTsKICAgICBtYXhpbXVtRE9NVHJlZURlcHRoID0gZG9jdW1lbnQuc2V0dGluZ3Mo KS5tYXhpbXVtSFRNTFBhcnNlckRPTVRyZWVEZXB0aCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNlck9wdGlvbnMuaCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxQYXJzZXJPcHRpb25zLmgKaW5kZXggZjQ2OGQ4Nzk3ZmExNWE1MmJjYjQ3 NDYxMmI3ZjAyYzRlMTJkZDAyZi4uZjIwNTUyNjY5YzQ4YmZiYjkwYTIyMTNlOWIxM2NkNTlkMzE1 NGRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNlck9w dGlvbnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUGFyc2VyT3B0aW9u cy5oCkBAIC0zNSw3ICszNSw2IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBIVE1MUGFyc2VyT3B0 aW9ucyhEb2N1bWVudCYpOwogCiAgICAgYm9vbCBzY3JpcHRFbmFibGVkOwotICAgIGJvb2wgcGx1 Z2luc0VuYWJsZWQ7CiAgICAgYm9vbCB1c2VQcmVIVE1MNVBhcnNlclF1aXJrczsKICAgICB1bnNp Z25lZCBtYXhpbXVtRE9NVHJlZURlcHRoOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxUb2tlbml6ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTFRva2VuaXplci5jcHAKaW5kZXggMTU0ZGVjZTE1NGMxYmMwMGI0OWQ5YTJmMGUxZDJh MDkwMDExMThmNC4uZjUzN2NmMWI0ZDkzZjAzZjczOTMxNjEzNmNlMDNhMTZkZmMzZTBjZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRva2VuaXplci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRva2VuaXplci5jcHAKQEAgLTE0MTYs NyArMTQxNiw3IEBAIHZvaWQgSFRNTFRva2VuaXplcjo6dXBkYXRlU3RhdGVGb3IoY29uc3QgQXRv bWljU3RyaW5nJiB0YWdOYW1lKQogICAgIGVsc2UgaWYgKHRhZ05hbWUgPT0gc3R5bGVUYWcKICAg ICAgICAgfHwgdGFnTmFtZSA9PSBpZnJhbWVUYWcKICAgICAgICAgfHwgdGFnTmFtZSA9PSB4bXBU YWcKLSAgICAgICAgfHwgKHRhZ05hbWUgPT0gbm9lbWJlZFRhZyAmJiBtX29wdGlvbnMucGx1Z2lu c0VuYWJsZWQpCisgICAgICAgIHx8ICh0YWdOYW1lID09IG5vZW1iZWRUYWcpCiAgICAgICAgIHx8 IHRhZ05hbWUgPT0gbm9mcmFtZXNUYWcKICAgICAgICAgfHwgKHRhZ05hbWUgPT0gbm9zY3JpcHRU YWcgJiYgbV9vcHRpb25zLnNjcmlwdEVuYWJsZWQpKQogICAgICAgICBtX3N0YXRlID0gUkFXVEVY VFN0YXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVC dWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5j cHAKaW5kZXggNTI0NGIyNWNiYzdjOWU4YjUwOTc5MDg5MjhlYzFhMTcwMWRmOTFjZC4uZGVkYjhh NTlkZTVmNjZiZDE2NTc1NzAxY2U2Y2Q3OWY0YmZhNTBjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC03ODcsNyArNzg3LDcgQEAgdm9p ZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZ0ZvckluQm9keShBdG9taWNIVE1MVG9r ZW4mJiB0b2tlbikKICAgICAgICAgcHJvY2Vzc0dlbmVyaWNSYXdUZXh0U3RhcnRUYWcoV1RGTW92 ZSh0b2tlbikpOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIGlmICh0b2tlbi5uYW1lKCkg PT0gbm9lbWJlZFRhZyAmJiBtX29wdGlvbnMucGx1Z2luc0VuYWJsZWQpIHsKKyAgICBpZiAodG9r ZW4ubmFtZSgpID09IG5vZW1iZWRUYWcpIHsKICAgICAgICAgcHJvY2Vzc0dlbmVyaWNSYXdUZXh0 U3RhcnRUYWcoV1RGTW92ZSh0b2tlbikpOwogICAgICAgICByZXR1cm47CiAgICAgfQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggNmYzNTM4Y2FiM2MyNzU5ODRiMTcxYzA3MmY1MDc4 MWI4MjM0NTdmMS4uNDlmY2Y3YjNmODUwYmNhMDM3OTUyZWIyMzc2MDFhZjE1MTVkMWYzMCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMDIg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBIVE1MIFBhcnNlcjog UmVtb3ZlIGNvbmRpdGlvbmFsIHBhcnNpbmcgb2YgPG5vZW1iZWQ+IGNvbnRlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjUxNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc3luYyBXUFQgYWZ0ZXIg aHR0cHM6Ly9naXRodWIuY29tL3dlYi1wbGF0Zm9ybS10ZXN0cy93cHQvcHVsbC8xNTQ3MSB0byBn YWluCisgICAgICAgIHRlc3QgY292ZXJhZ2UuIEJvdGggR2Vja28gYW5kIEJsaW5rIGFyZSBwYXNz aW5nIHRoZSBuZXcgY2hlY2ssIG9ubHkgV2ViS2l0IHdhcworICAgICAgICBmYWlsaW5nLgorCisg ICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbXBhcnNpbmcvRE9NUGFyc2VyLXBhcnNlRnJv bVN0cmluZy1odG1sLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMv ZG9tcGFyc2luZy9ET01QYXJzZXItcGFyc2VGcm9tU3RyaW5nLWh0bWwuaHRtbDoKKwogMjAxOS0w NC0wMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFhNTEh0dHBS ZXF1ZXN0VXBsb2FkJ3MgbG9hZHN0YXJ0IGV2ZW50IG5vdCBjb3JyZWN0IGluaXRpYWxpemVkCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Rv bXBhcnNpbmcvRE9NUGFyc2VyLXBhcnNlRnJvbVN0cmluZy1odG1sLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tcGFyc2luZy9ET01Q YXJzZXItcGFyc2VGcm9tU3RyaW5nLWh0bWwtZXhwZWN0ZWQudHh0CmluZGV4IDVkYWZjMjQ2YWM2 ODg4NTQzYjliYjA5ODJjOTEzZjEwZmY1YmQ2MmMuLjA4ZDFlZTdhNmE4MTIwNTJiY2Y2MzlkMTYy MTA5ODQyOGNkY2QwZDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZG9tcGFyc2luZy9ET01QYXJzZXItcGFyc2VGcm9tU3RyaW5nLWh0bWwt ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvZG9tcGFyc2luZy9ET01QYXJzZXItcGFyc2VGcm9tU3RyaW5nLWh0bWwtZXhwZWN0ZWQu dHh0CkBAIC04LDUgKzgsNiBAQCBQQVNTIFVSTCB2YWx1ZQogUEFTUyBiYXNlVVJJIHZhbHVlIAog UEFTUyBMb2NhdGlvbiB2YWx1ZSAKIFBBU1MgRE9NUGFyc2VyIHBhcnNlcyBIVE1MIHRhZyBzb3Vw IHdpdGggbm8gcHJvYmxlbXMgCitQQVNTIERPTVBhcnNlciBzaG91bGQgaGFuZGxlIHRoZSBjb250 ZW50IG9mIDxub2VtYmVkPiBhcyByYXcgdGV4dCAKIFBBU1MgRE9NUGFyc2VyIHRocm93cyBvbiBh biBpbnZhbGlkIGVudW0gdmFsdWUgCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tcGFyc2luZy9ET01QYXJzZXItcGFyc2VGcm9tU3Ry aW5nLWh0bWwuaHRtbCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZG9tcGFyc2luZy9ET01QYXJzZXItcGFyc2VGcm9tU3RyaW5nLWh0bWwuaHRtbAppbmRleCBl YzQyNDQyM2ExZDI4OTg4ZDJiOTQ5YjUxZTk0NjdmMGNmNzAyMjkwLi5hZDY1Y2M1ODYxODQ2MjU5 MTU2OGRkYTYyMmYzNWI2OGE2NGMxZDYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbXBhcnNpbmcvRE9NUGFyc2VyLXBhcnNlRnJvbVN0 cmluZy1odG1sLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9kb21wYXJzaW5nL0RPTVBhcnNlci1wYXJzZUZyb21TdHJpbmctaHRtbC5odG1sCkBA IC02Niw2ICs2NiwxMSBAQCB0ZXN0KGZ1bmN0aW9uKCkgewogICAgIGFzc2VydF9lcXVhbHMoaHRt bGRvYy5kb2N1bWVudEVsZW1lbnQubmFtZXNwYWNlVVJJLCAiaHR0cDovL3d3dy53My5vcmcvMTk5 OS94aHRtbCIpOwogfSwgIkRPTVBhcnNlciBwYXJzZXMgSFRNTCB0YWcgc291cCB3aXRoIG5vIHBy b2JsZW1zIik7CiAKK3Rlc3QoZnVuY3Rpb24oKSB7CisgICBjb25zdCBkb2MgPSBuZXcgRE9NUGFy c2VyKCkucGFyc2VGcm9tU3RyaW5nKCc8bm9lbWJlZD4mbHQ7YSZndDs8L25vZW1iZWQ+JywgJ3Rl eHQvaHRtbCcpOworICAgYXNzZXJ0X2VxdWFscyhkb2MucXVlcnlTZWxlY3Rvcignbm9lbWJlZCcp LnRleHRDb250ZW50LCAnJmx0O2EmZ3Q7Jyk7Cit9LCAnRE9NUGFyc2VyIHNob3VsZCBoYW5kbGUg dGhlIGNvbnRlbnQgb2YgPG5vZW1iZWQ+IGFzIHJhdyB0ZXh0Jyk7CisKIHRlc3QoZnVuY3Rpb24o KSB7CiAgICAgYXNzZXJ0X3Rocm93cyhuZXcgVHlwZUVycm9yKCksIGZ1bmN0aW9uKCkgewogICAg ICAgICBuZXcgRE9NUGFyc2VyKCkucGFyc2VGcm9tU3RyaW5nKCIiLCAidGV4dC9mb28tdGhpcy1p cy1pbnZhbGlkIik7Cg==