196511 2019-04-02 15:41:44 -0700 Cursor count badge reverts to Zero during Drag & Drop of multiple items 2019-04-03 11:36:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181081 InRadar P2 Normal --- 1 timothy timothy chudesno commit-queue dbates jonlee thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1523498 0 timothy 2019-04-02 15:41:44 -0700 When you drag & drop multiple files to iCloud Drive or a text field, the mouse cursor gives a Zero (0) file count, regardless of the number of files you have. <rdar://problem/34373187> 1523499 1 366545 timothy 2019-04-02 15:43:19 -0700 Created attachment 366545 Patch 1523582 2 366545 dbates 2019-04-02 19:58:23 -0700 Comment on attachment 366545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366545&action=review Bade is UI. So, likely no way to test. > Source/WebCore/page/DragController.cpp:-464 > - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this 1523589 3 366545 timothy 2019-04-02 20:19:57 -0700 Comment on attachment 366545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366545&action=review >> Source/WebCore/page/DragController.cpp:-464 >> - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; > > I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this This was added by Jon Lee 7 years ago. It was to provide more info to the user what might happen when the drag moves over elements in the page. I think it just wasn’t fully thought out. https://trac.webkit.org/changeset/99108/webkit 1523595 4 366545 commit-queue 2019-04-02 20:46:42 -0700 Comment on attachment 366545 Patch Clearing flags on attachment: 366545 Committed r243785: <https://trac.webkit.org/changeset/243785> 1523596 5 commit-queue 2019-04-02 20:46:44 -0700 All reviewed patches have been landed. Closing bug. 1523602 6 366545 wenson_hsieh 2019-04-02 20:59:37 -0700 Comment on attachment 366545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366545&action=review >>> Source/WebCore/page/DragController.cpp:-464 >>> - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; >> >> I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this > > This was added by Jon Lee 7 years ago. It was to provide more info to the user what might happen when the drag moves over elements in the page. I think it just wasn’t fully thought out. > > https://trac.webkit.org/changeset/99108/webkit We should ensure that dragging multiple files over a regular input type=file does not cause the drop to occur. 1523603 7 wenson_hsieh 2019-04-02 21:00:12 -0700 (In reply to Wenson Hsieh from comment #6) > Comment on attachment 366545 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366545&action=review > > >>> Source/WebCore/page/DragController.cpp:-464 > >>> - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; > >> > >> I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this > > > > This was added by Jon Lee 7 years ago. It was to provide more info to the user what might happen when the drag moves over elements in the page. I think it just wasn’t fully thought out. > > > > https://trac.webkit.org/changeset/99108/webkit > > We should ensure that dragging multiple files over a regular input type=file > does not cause the drop to occur. (Regular file input, as opposed to an <input type=file multiple>) 1523604 8 wenson_hsieh 2019-04-02 21:10:57 -0700 (In reply to Wenson Hsieh from comment #7) > (In reply to Wenson Hsieh from comment #6) > > Comment on attachment 366545 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=366545&action=review > > > > >>> Source/WebCore/page/DragController.cpp:-464 > > >>> - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; > > >> > > >> I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this > > > > > > This was added by Jon Lee 7 years ago. It was to provide more info to the user what might happen when the drag moves over elements in the page. I think it just wasn’t fully thought out. > > > > > > https://trac.webkit.org/changeset/99108/webkit > > > > We should ensure that dragging multiple files over a regular input type=file > > does not cause the drop to occur. > > (Regular file input, as opposed to an <input type=file multiple>) Oh sorry, I misread the branch. The change looks right — I can't think of any reason why we wouldn't want to update m_numberOfItemsToBeAccepted when dragging a single file, when we're not dropping over a file input. 1523609 9 366545 timothy 2019-04-02 21:25:04 -0700 Comment on attachment 366545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366545&action=review >>>>>> Source/WebCore/page/DragController.cpp:-464 >>>>>> - m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1; >>>>> >>>>> I can’t help but wonder, why? Why did we do this? I so want to understand the comment, but it is broken English. Could this be a platform/port-specific hack? Windows? GTK? If so, need to move hack. <—- not cq’ing because of this >>>> >>>> This was added by Jon Lee 7 years ago. It was to provide more info to the user what might happen when the drag moves over elements in the page. I think it just wasn’t fully thought out. >>>> >>>> https://trac.webkit.org/changeset/99108/webkit >>> >>> We should ensure that dragging multiple files over a regular input type=file does not cause the drop to occur. >> >> (Regular file input, as opposed to an <input type=file multiple>) > > Oh sorry, I misread the branch. The change looks right — I can't think of any reason why we wouldn't want to update m_numberOfItemsToBeAccepted when dragging a single file, when we're not dropping over a file input. Yep, the if (m_fileInputElementUnderMouse) block handles that. 1523775 10 ap 2019-04-03 10:24:51 -0700 Is this the same as bug 181081? 1523810 11 timothy 2019-04-03 11:32:01 -0700 *** Bug 181081 has been marked as a duplicate of this bug. *** 1523814 12 timothy 2019-04-03 11:36:04 -0700 (In reply to Alexey Proskuryakov from comment #10) > Is this the same as bug 181081? Yes. 366545 2019-04-02 15:43:19 -0700 2019-04-02 20:46:42 -0700 Patch bug-196511-20190402154315.patch text/plain 2356 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZiMmM4ODZkZDQ5ODNj N2NlOWUyZjQxNTFhZWEyZjhiYmViZWY2My4uN2NiYmFlNDk5YTkzODY4NDM3YWMwOTI5MGY5YWUy N2FjZDgzMzQ1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTAyICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBDdXJzb3IgY291bnQg YmFkZ2UgcmV2ZXJ0cyB0byBaZXJvIGR1cmluZyBEcmFnICYgRHJvcCBvZiBtdWx0aXBsZSBpdGVt cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjUx MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFn ZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6 dHJ5RG9jdW1lbnREcmFnKTogRG9uJ3Qgc2V0IG1fbnVtYmVyT2ZJdGVtc1RvQmVBY2NlcHRlZCB0 bworICAgICAgICB6ZXJvIHdoZW4gZHJhZ2dpbmcgdG8gYSBub24tZmlsZSBpbnB1dCBlbGVtZW50 LgorCiAyMDE5LTA0LTAyICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgogCiAgICAgICAgIFtDTWFrZV0gV0VCS0lUX01BS0VfRk9SV0FSRElOR19IRUFERVJTIHNob3Vs ZG4ndCB1c2UgUE9TVF9CVUlMRCB0byBjb3B5IGdlbmVyYXRlZCBoZWFkZXJzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCmluZGV4IGEzM2YyNmYxMWI2MTAzZjU1ZTcxMjNhMTIz ZmYzZmIzMjg2OGUxOWQuLmU5ZjgzM2I3OGUyNDI4NzIxYmVhOTkyNjY2YWUzMDkyNjRlZmNmMjkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC00NDIsNyArNDQyLDYg QEAgRHJhZ0hhbmRsaW5nTWV0aG9kIERyYWdDb250cm9sbGVyOjp0cnlEb2N1bWVudERyYWcoY29u c3QgRHJhZ0RhdGEmIGRyYWdEYXRhLCBEcmEKIAogICAgICAgICBGcmFtZSogaW5uZXJGcmFtZSA9 IGVsZW1lbnQtPmRvY3VtZW50KCkuZnJhbWUoKTsKICAgICAgICAgZHJhZ09wZXJhdGlvbiA9IGRy YWdJc01vdmUoaW5uZXJGcmFtZS0+c2VsZWN0aW9uKCksIGRyYWdEYXRhKSA/IERyYWdPcGVyYXRp b25Nb3ZlIDogRHJhZ09wZXJhdGlvbkNvcHk7Ci0gICAgICAgIG1fbnVtYmVyT2ZJdGVtc1RvQmVB Y2NlcHRlZCA9IDA7CiAKICAgICAgICAgdW5zaWduZWQgbnVtYmVyT2ZGaWxlcyA9IGRyYWdEYXRh Lm51bWJlck9mRmlsZXMoKTsKICAgICAgICAgaWYgKG1fZmlsZUlucHV0RWxlbWVudFVuZGVyTW91 c2UpIHsKQEAgLTQ1OSw5ICs0NTgsOSBAQCBEcmFnSGFuZGxpbmdNZXRob2QgRHJhZ0NvbnRyb2xs ZXI6OnRyeURvY3VtZW50RHJhZyhjb25zdCBEcmFnRGF0YSYgZHJhZ0RhdGEsIERyYQogICAgICAg ICAgICAgICAgIGRyYWdPcGVyYXRpb24gPSBEcmFnT3BlcmF0aW9uTm9uZTsKICAgICAgICAgICAg IG1fZmlsZUlucHV0RWxlbWVudFVuZGVyTW91c2UtPnNldENhblJlY2VpdmVEcm9wcGVkRmlsZXMo bV9udW1iZXJPZkl0ZW1zVG9CZUFjY2VwdGVkKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAg ICAgIC8vIFdlIGFyZSBub3Qgb3ZlciBhIGZpbGUgaW5wdXQgZWxlbWVudC4gVGhlIGRyYWdnZWQg aXRlbShzKSB3aWxsIG9ubHkKLSAgICAgICAgICAgIC8vIGJlIGxvYWRlZCBpbnRvIHRoZSB2aWV3 IHRoZSBudW1iZXIgb2YgZHJhZ2dlZCBpdGVtcyBpcyAxLgotICAgICAgICAgICAgbV9udW1iZXJP Zkl0ZW1zVG9CZUFjY2VwdGVkID0gbnVtYmVyT2ZGaWxlcyAhPSAxID8gMCA6IDE7CisgICAgICAg ICAgICAvLyBXZSBhcmUgbm90IG92ZXIgYSBmaWxlIGlucHV0IGVsZW1lbnQuIFRoZSBkcmFnZ2Vk IGl0ZW0ocykgd2lsbCBsb2FkZWQgaW50byB0aGUgdmlldywKKyAgICAgICAgICAgIC8vIGRyb3Bw ZWQgYXMgdGV4dCBwYXRocyBvbiBvdGhlciBpbnB1dCBlbGVtZW50cywgb3IgaGFuZGxlZCBieSBz Y3JpcHQgb24gdGhlIHBhZ2UuCisgICAgICAgICAgICBtX251bWJlck9mSXRlbXNUb0JlQWNjZXB0 ZWQgPSBudW1iZXJPZkZpbGVzOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKG1fZmlsZUlucHV0 RWxlbWVudFVuZGVyTW91c2UpCg==