196501 2019-04-02 11:27:42 -0700 [ews-build] Configure buildbot try credentials in environment variables 2019-04-02 14:10:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu jbedard lforschler webkit-bug-importer oldest_to_newest 1523369 0 aakash_jain 2019-04-02 11:27:42 -0700 Currently ews-build use very weak username/password for buildbot try. This password is hard-coded in source code. We should instead read the credentials from environment variables and configure strong password. 1523370 1 366509 aakash_jain 2019-04-02 11:30:18 -0700 Created attachment 366509 Patch 1523457 2 366509 commit-queue 2019-04-02 14:09:23 -0700 Comment on attachment 366509 Patch Clearing flags on attachment: 366509 Committed r243759: <https://trac.webkit.org/changeset/243759> 1523458 3 commit-queue 2019-04-02 14:09:25 -0700 All reviewed patches have been landed. Closing bug. 1523459 4 webkit-bug-importer 2019-04-02 14:10:18 -0700 <rdar://problem/49533667> 366509 2019-04-02 11:30:18 -0700 2019-04-02 14:09:23 -0700 Patch bug-196501-20190402143110.patch text/plain 3251 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzc0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA0LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBDb25maWd1cmUgYnVpbGRib3QgdHJ5IGNyZWRlbnRp YWxzIGluIGVudmlyb25tZW50IHZhcmlhYmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NTAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENv bmZpZy5weTogUmVhZCBjcmVkZW50aWFscyBmcm9tIGVudmlyb25tZW50IHZhcmlhYmxlcy4KKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHk6 IFJlbmFtZSBCVUlMREJPVF9QQl9VU0VSTkFNRSB0byBCVUlMREJPVF9UUllfVVNFUk5BTUUuCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29uZmlnLnB5OiBEaXR0by4K KwogMjAxOS0wNC0wMiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4K IAogICAgICAgICBbQ01ha2VdIFdFQktJVF9NQUtFX0ZPUldBUkRJTkdfSEVBREVSUyBzaG91bGRu J3QgdXNlIFBPU1RfQlVJTEQgdG8gY29weSBnZW5lcmF0ZWQgaGVhZGVycwpJbmRleDogVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29uZmlnLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbmZpZy5weQkocmV2aXNpb24gMjQz NzQ4KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29uZmlnLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yOCw4ICsyOCw4IEBAIFBBVENIX0ZPTERFUiA9ICcvdG1wLycKIAog QlVJTERCT1RfU0VSVkVSX0hPU1QgPSAnZXdzLWJ1aWxkLndlYmtpdC5vcmcnCiBCVUlMREJPVF9T RVJWRVJfUE9SVCA9ICc1NTU1JwotQlVJTERCT1RfUEJfVVNFUk5BTUUgPSBvcy5nZXRlbnYoJ0JV SUxEQk9UX1BCX1VTRVJOQU1FJywgJ3NhbXBsZXVzZXInKQotQlVJTERCT1RfUEJfUEFTU1dPUkQg PSBvcy5nZXRlbnYoJ0JVSUxEQk9UX1BCX1BBU1NXT1JEJywgJ3NhbXBsZXBhc3MnKQorQlVJTERC T1RfVFJZX1VTRVJOQU1FID0gb3MuZ2V0ZW52KCdCVUlMREJPVF9UUllfVVNFUk5BTUUnLCAnc2Ft cGxldXNlcicpCitCVUlMREJPVF9UUllfUEFTU1dPUkQgPSBvcy5nZXRlbnYoJ0JVSUxEQk9UX1RS WV9QQVNTV09SRCcsICdzYW1wbGVwYXNzJykKIAogU1VDQ0VTUyA9IDAKIEVSUl9VTkVYUEVDVEVE ID0gLTEKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9i dWlsZGJvdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy9jb21tb24vYnVpbGRib3QucHkJKHJldmlzaW9uIDI0Mzc0OCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weQkod29ya2luZyBjb3B5 KQpAQCAtNDMsOCArNDMsOCBAQCBjbGFzcyBCdWlsZGJvdCgpOgogICAgICAgICBjb21tYW5kID0g WydidWlsZGJvdCcsICd0cnknLAogICAgICAgICAgICAgICAgICAgICctLWNvbm5lY3Q9cGInLAog ICAgICAgICAgICAgICAgICAgICctLW1hc3Rlcj17fTp7fScuZm9ybWF0KGNvbmZpZy5CVUlMREJP VF9TRVJWRVJfSE9TVCwgY29uZmlnLkJVSUxEQk9UX1NFUlZFUl9QT1JUKSwKLSAgICAgICAgICAg ICAgICAgICAnLS11c2VybmFtZT17fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9QQl9VU0VSTkFN RSksCi0gICAgICAgICAgICAgICAgICAgJy0tcGFzc3dkPXt9Jy5mb3JtYXQoY29uZmlnLkJVSUxE Qk9UX1BCX1BBU1NXT1JEKSwKKyAgICAgICAgICAgICAgICAgICAnLS11c2VybmFtZT17fScuZm9y bWF0KGNvbmZpZy5CVUlMREJPVF9UUllfVVNFUk5BTUUpLAorICAgICAgICAgICAgICAgICAgICct LXBhc3N3ZD17fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9UUllfUEFTU1dPUkQpLAogICAgICAg ICAgICAgICAgICAgICctLWRpZmY9e30nLmZvcm1hdChwYXRjaF9wYXRoKSwKICAgICAgICAgICAg ICAgICAgICAnLS1yZXBvc2l0b3J5PSddCiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CShyZXZpc2lvbiAyNDM3NDgpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weQkod29ya2luZyBjb3B5 KQpAQCAtNzksNyArNzksNyBAQCBkZWYgbG9hZEJ1aWxkZXJDb25maWcoYywgaXNfdGVzdF9tb2Rl X2VuCiAgICAgICAgIHNjaGVkdWxlciA9IGRpY3QobWFwKGxhbWJkYSBrZXlfdmFsdWVfcGFpcjog KHN0cihrZXlfdmFsdWVfcGFpclswXSksIGtleV92YWx1ZV9wYWlyWzFdKSwgc2NoZWR1bGVyLml0 ZW1zKCkpKQogICAgICAgICBpZiAoc2NoZWR1bGVyQ2xhc3NOYW1lID09ICdUcnlfVXNlcnBhc3Mn KToKICAgICAgICAgICAgICMgRklYTUU6IFJlYWQgdGhlIGNyZWRlbnRpYWxzIGZyb20gbG9jYWwg ZmlsZSBvbiBkaXNrLgotICAgICAgICAgICAgc2NoZWR1bGVyWyd1c2VycGFzcyddID0gWygnc2Ft cGxldXNlcicsICdzYW1wbGVwYXNzJyldCisgICAgICAgICAgICBzY2hlZHVsZXJbJ3VzZXJwYXNz J10gPSBbKG9zLmdldGVudignQlVJTERCT1RfVFJZX1VTRVJOQU1FJywgJ3NhbXBsZXVzZXInKSwg b3MuZ2V0ZW52KCdCVUlMREJPVF9UUllfUEFTU1dPUkQnLCAnc2FtcGxlcGFzcycpKV0KICAgICAg ICAgY1snc2NoZWR1bGVycyddLmFwcGVuZChzY2hlZHVsZXJDbGFzcygqKnNjaGVkdWxlcikpCiAK IAo=