196466 2019-04-01 15:09:45 -0700 Attr nodes are not cloned properly 2019-04-01 20:15:31 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dom.spec.whatwg.org/#concept-node-clone InRadar P2 Normal --- 1 cdumez cdumez achristensen dbates esprehn+autocc ews-watchlist ggaren kangil.han koivisto rniwa webkit-bug-importer oldest_to_newest 1523085 0 cdumez 2019-04-01 15:09:45 -0700 Attr nodes are not cloned properly according to: - https://dom.spec.whatwg.org/#concept-node-clone A cloned Attr node should retain its prefix and namespace. Both Gecko and Blink agree with the DOM specification here. 1523086 1 366428 cdumez 2019-04-01 15:11:57 -0700 Created attachment 366428 Patch 1523167 2 366428 rniwa 2019-04-01 18:52:03 -0700 Comment on attachment 366428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366428&action=review > Source/WebCore/dom/Document.cpp:992 > // FIXME: This will "Attr::normalize" child nodes of Attr. Should we remove this FIXME? 1523182 3 366428 cdumez 2019-04-01 19:40:35 -0700 Comment on attachment 366428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366428&action=review >> Source/WebCore/dom/Document.cpp:992 >> // FIXME: This will "Attr::normalize" child nodes of Attr. > > Should we remove this FIXME? Is it not valid anymore? 1523185 4 rniwa 2019-04-01 19:47:17 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 366428 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366428&action=review > > >> Source/WebCore/dom/Document.cpp:992 > >> // FIXME: This will "Attr::normalize" child nodes of Attr. > > > > Should we remove this FIXME? > > Is it not valid anymore? There is no Attr::normalize anymore. This is about normalizing the text child nodes of Attr when we supported multiple child nodes for Attr: https://dom.spec.whatwg.org/#dom-node-normalize But that's totally irrelevant now since Attr isn't even a ContainerNode now. 1523197 5 cdumez 2019-04-01 20:14:56 -0700 Committed r243734: <https://trac.webkit.org/changeset/243734> 1523198 6 webkit-bug-importer 2019-04-01 20:15:18 -0700 <rdar://problem/49506786> 1523199 7 cdumez 2019-04-01 20:15:31 -0700 (In reply to Ryosuke Niwa from comment #4) > (In reply to Chris Dumez from comment #3) > > Comment on attachment 366428 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=366428&action=review > > > > >> Source/WebCore/dom/Document.cpp:992 > > >> // FIXME: This will "Attr::normalize" child nodes of Attr. > > > > > > Should we remove this FIXME? > > > > Is it not valid anymore? > > There is no Attr::normalize anymore. This is about normalizing the text > child nodes of Attr when we supported multiple child nodes for Attr: > https://dom.spec.whatwg.org/#dom-node-normalize > > But that's totally irrelevant now since Attr isn't even a ContainerNode now. Oh right. Fixed before landing, thanks. 366428 2019-04-01 15:11:57 -0700 2019-04-01 20:15:10 -0700 Patch bug-196466-20190401151156.patch text/plain 3571 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI0ODhmN2Y3ZTg4M2Nm NTMyNjYzM2UxMDUyYjNmYjMzZTg3Njg2YS4uOWJjY2RiMzYzNzkzMDk4ZTU0ZThlM2NlMzAyNmJj ODU3ZWZmZGQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA0LTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXR0ciBub2RlcyBhcmUgbm90 IGNsb25lZCBwcm9wZXJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2NDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXR0ciBub2RlcyBhcmUgbm90IGNsb25lZCBwcm9wZXJseSBhY2NvcmRpbmcgdG86 CisgICAgICAgIC0gaHR0cHM6Ly9kb20uc3BlYy53aGF0d2cub3JnLyNjb25jZXB0LW5vZGUtY2xv bmUKKworICAgICAgICBBIGNsb25lZCBBdHRyIG5vZGUgc2hvdWxkIHJldGFpbiBpdHMgcHJlZml4 IGFuZCBuYW1lc3BhY2UuCisKKyAgICAgICAgQm90aCBHZWNrbyBhbmQgQmxpbmsgYWdyZWUgd2l0 aCB0aGUgRE9NIHNwZWNpZmljYXRpb24gaGVyZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJl YmFzZWxpbmVkIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmltcG9ydE5vZGUpOgorCiAyMDE5LTA0LTAxICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgZXZlbnQg cmVnaW9uIHdoZW4gdG9nZ2xpbmcgcG9pbnRlci1ldmVudHM6bm9uZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKaW5kZXggYmQxNmVkMjkzMGExZThiOTJmNGQ4ZmE3NmU3ODIyYTFkMGVmMGI5MC4uODkz ZGYyYzY1ZWRlZjE5NmQ3NDIyNmM5NDAyOWQxZmJlZmRlZGM1ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCkBAIC05ODgsMTAgKzk4OCwxMSBAQCBFeGNlcHRpb25PcjxSZWY8Tm9kZT4+IERvY3Vt ZW50OjppbXBvcnROb2RlKE5vZGUmIG5vZGVUb0ltcG9ydCwgYm9vbCBkZWVwKQogICAgIGNhc2Ug Q09NTUVOVF9OT0RFOgogICAgICAgICByZXR1cm4gbm9kZVRvSW1wb3J0LmNsb25lTm9kZUludGVy bmFsKGRvY3VtZW50KCksIGRlZXAgPyBDbG9uaW5nT3BlcmF0aW9uOjpFdmVyeXRoaW5nIDogQ2xv bmluZ09wZXJhdGlvbjo6T25seVNlbGYpOwogCi0gICAgY2FzZSBBVFRSSUJVVEVfTk9ERToKKyAg ICBjYXNlIEFUVFJJQlVURV9OT0RFOiB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHdpbGwgIkF0 dHI6Om5vcm1hbGl6ZSIgY2hpbGQgbm9kZXMgb2YgQXR0ci4KLSAgICAgICAgcmV0dXJuIFJlZjxO b2RlPiB7IEF0dHI6OmNyZWF0ZSgqdGhpcywgUXVhbGlmaWVkTmFtZShudWxsQXRvbSgpLCBkb3du Y2FzdDxBdHRyPihub2RlVG9JbXBvcnQpLm5hbWUoKSwgbnVsbEF0b20oKSksIGRvd25jYXN0PEF0 dHI+KG5vZGVUb0ltcG9ydCkudmFsdWUoKSkgfTsKLQorICAgICAgICBhdXRvJiBhdHRyaWJ1dGUg PSBkb3duY2FzdDxBdHRyPihub2RlVG9JbXBvcnQpOworICAgICAgICByZXR1cm4gUmVmPE5vZGU+ IHsgQXR0cjo6Y3JlYXRlKCp0aGlzLCBhdHRyaWJ1dGUucXVhbGlmaWVkTmFtZSgpLCBhdHRyaWJ1 dGUudmFsdWUoKSkgfTsKKyAgICB9CiAgICAgY2FzZSBET0NVTUVOVF9OT0RFOiAvLyBDYW4ndCBp bXBvcnQgYSBkb2N1bWVudCBpbnRvIGFub3RoZXIgZG9jdW1lbnQuCiAgICAgY2FzZSBET0NVTUVO VF9UWVBFX05PREU6IC8vIEZJWE1FOiBTdXBwb3J0IGNsb25pbmcgYSBEb2N1bWVudFR5cGUgbm9k ZSBwZXIgRE9NNC4KICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCBiNTE2NmQ1ZDZiNWRjZTdlOWQ0YzRjM2Q1NGU2NjJkZmFhZGI2YTg2Li5mMjNkOGY0NTA2 YTI0YTZhYWNkMDc3OTRkNDBkZjk1N2ZjZDU2N2I3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wNC0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgorCisgICAgICAgIEF0dHIgbm9kZXMgYXJlIG5vdCBjbG9uZWQgcHJvcGVybHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjQ2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxp bmUgV1BUIHRlc3Qgbm93IHRoYXQgb25lIG1vcmUgY2hlY2sgaXMgcGFzc2luZy4KKworICAgICAg ICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvRG9jdW1lbnQtaW1wb3J0Tm9kZS1leHBl Y3RlZC50eHQ6CisKIDIwMTktMDQtMDEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBTdXBwb3J0ICJub3JlZmVycmVyIiBmb3Igd2luZG93Lm9wZW4oKQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9k ZXMvRG9jdW1lbnQtaW1wb3J0Tm9kZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVudC1pbXBvcnROb2RlLWV4 cGVjdGVkLnR4dAppbmRleCBhYjAzYjA2YWM2NmVjYmI0ZjhmNTY4ZWUzMzEyYzkwNWE1YmVlZmRi Li43ZDA2Nzk0M2Y4NjM4YWU2M2I4YTY2NTE2MjhhN2NhY2U0ZTkzNDljIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1 bWVudC1pbXBvcnROb2RlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVudC1pbXBvcnROb2RlLWV4cGVj dGVkLnR4dApAQCAtMyw1ICszLDUgQEAgUEFTUyBObyAnZGVlcCcgYXJndW1lbnQuCiBQQVNTIFVu ZGVmaW5lZCAnZGVlcCcgYXJndW1lbnQuIAogUEFTUyBUcnVlICdkZWVwJyBhcmd1bWVudC4gCiBQ QVNTIEZhbHNlICdkZWVwJyBhcmd1bWVudC4gCi1GQUlMIEltcG9ydCBhbiBBdHRyIG5vZGUgd2l0 aCBuYW1lc3BhY2UvcHJlZml4IGNvcnJlY3RseS4gYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgKHN0 cmluZykgInAiIGJ1dCBnb3QgKG9iamVjdCkgbnVsbAorUEFTUyBJbXBvcnQgYW4gQXR0ciBub2Rl IHdpdGggbmFtZXNwYWNlL3ByZWZpeCBjb3JyZWN0bHkuIAogCg==