196443 2019-04-01 07:57:40 -0700 Update the status of ResizeObserver in features.json 2019-04-02 04:00:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cathiechen cathiechen commit-queue ews-watchlist fred.wang joepeck rbuis rego rwlbuis webkit-bug-importer oldest_to_newest 1522914 0 cathiechen 2019-04-01 07:57:40 -0700 Update the status of ResizeObserver in features.json 1522915 1 366395 cathiechen 2019-04-01 08:07:50 -0700 Created attachment 366395 Patch 1523020 2 366395 rego 2019-04-01 12:49:29 -0700 Comment on attachment 366395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Some nitpicks. > Source/WebCore/features.json:1139 > + "status": "Partially Supported" Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. Alos you could add: "enabled-by-default": false > Source/WebCore/features.json:1141 > + "url": "https://wicg.github.io/ResizeObserver/", Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ > Source/WebCore/features.json:1144 > + "description": "An API for observing changes to Element’s size.", I see a weird character here between "Element" and "size". 1523210 3 366468 cathiechen 2019-04-01 20:43:55 -0700 Created attachment 366468 Patch 1523211 4 366395 cathiechen 2019-04-01 20:44:18 -0700 Comment on attachment 366395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366395&action=review Done! Thanks:) >> Source/WebCore/features.json:1139 >> + "status": "Partially Supported" > > Nit: Maybe I'd say "In Development" as it's still behind build and runtime flags. > Alos you could add: "enabled-by-default": false Done >> Source/WebCore/features.json:1141 >> + "url": "https://wicg.github.io/ResizeObserver/", > > Nit: I believe this should be now https://drafts.csswg.org/resize-observer/ Done >> Source/WebCore/features.json:1144 >> + "description": "An API for observing changes to Element’s size.", > > I see a weird character here between "Element" and "size". Done 1523257 5 366468 rego 2019-04-02 03:15:46 -0700 Comment on attachment 366468 Patch Thanks for updating features.json! BTW, you could have uploaded the 2nd version of the patch with "Reviewed by Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in this case). 1523258 6 366480 cathiechen 2019-04-02 03:20:21 -0700 Created attachment 366480 Patch 1523259 7 cathiechen 2019-04-02 03:21:25 -0700 (In reply to Manuel Rego Casasnovas from comment #5) > Comment on attachment 366468 [details] > Patch > > Thanks for updating features.json! > > BTW, you could have uploaded the 2nd version of the patch with "Reviewed by > Rob Buis" already filled in the ChangeLog (anyway it's not a big deal in > this case). Done! Thanks :) 1523268 8 366480 commit-queue 2019-04-02 03:59:07 -0700 Comment on attachment 366480 Patch Clearing flags on attachment: 366480 Committed r243739: <https://trac.webkit.org/changeset/243739> 1523269 9 commit-queue 2019-04-02 03:59:09 -0700 All reviewed patches have been landed. Closing bug. 1523270 10 webkit-bug-importer 2019-04-02 04:00:26 -0700 <rdar://problem/49515062> 366395 2019-04-01 08:07:50 -0700 2019-04-01 20:43:34 -0700 Patch bug-196443-20190401230748.patch text/plain 1642 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc3ZWIyOWI5YTJmYzU5 ZmIzNTY4NWE3ZjBhMzc0MWNkMjgzOThkNC4uMjIzNDcxMzM5OTM4NjIzZmIzOGUxODEzNmRhNDdl MzExZmZkZmJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTAxICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBVcGRhdGUgdGhlIHN0 YXR1cyBvZiBSZXNpemVPYnNlcnZlciBpbiBmZWF0dXJlcy5qc29uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NDQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDE5 LTA0LTAxICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgogCiAgICAg ICAgIEJlIGxlc3Mgc3RyaWN0IGFib3V0IGNsb3NpbmcgYmxvY2tzIGluIGF0dHJpYnV0ZSBhbmQg ZnVuY3Rpb25hbCBwc2V1ZG8tZWxlbWVudCBzZWxlY3RvcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9mZWF0dXJlcy5qc29uIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgppbmRl eCBjNmFlYTcwMTUzMmE2MjQ0NTk0MGJlYzI5MDdlYjEwNjhkY2ZmMDJlLi43MjM5MTEyZTljNzNk OGNhN2I1YTkyYmVjM2Q0YzE0YTQxMTQ5YzI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9m ZWF0dXJlcy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KQEAgLTExMzMs NiArMTEzMywyMCBAQAogICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJTdHJlYW1zIiwKICAgICAg ICAgImNvbW1lbnQiOiAiVGhlIGltcGxlbWVudGF0aW9uIGRvZXMgbm90IHN1cHBvcnQgUmVhZGFi bGVTdHJlYW1CWU9CUmVhZGVyLiIKICAgICB9LAorICAgIHsKKyAgICAgICAgIm5hbWUiOiAiUmVz aXplIE9ic2VydmVyIiwKKyAgICAgICAgInN0YXR1cyI6IHsKKyAgICAgICAgICAgICJzdGF0dXMi OiAiUGFydGlhbGx5IFN1cHBvcnRlZCIKKyAgICAgICAgfSwKKyAgICAgICAgInVybCI6ICJodHRw czovL3dpY2cuZ2l0aHViLmlvL1Jlc2l6ZU9ic2VydmVyLyIsCisgICAgICAgICJ3ZWJraXQtdXJs IjogImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3NDMiLAorICAg ICAgICAia2V5d29yZHMiOiBbInJlc2l6ZSIsICJyZXNpemUgb2JzZXJ2ZXIiLCAicmVzaXplb2Jz ZXJ2ZXIiXSwKKyAgICAgICAgImRlc2NyaXB0aW9uIjogIkFuIEFQSSBmb3Igb2JzZXJ2aW5nIGNo YW5nZXMgdG8gRWxlbWVudOKAmXMgc2l6ZS4iLAorICAgICAgICAiY29udGFjdCI6IHsKKyAgICAg ICAgICAgICJuYW1lIjogIkNhdGhpZSBDaGVuIiwKKyAgICAgICAgICAgICJlbWFpbCI6ICJjYXRo aWVjaGVuQGlnYWxpYS5jb20iCisgICAgICAgIH0KKyAgICB9LAogICAgIHsKICAgICAgICAgIm5h bWUiOiAiU2Nyb2xsIEFuY2hvcmluZyIsCiAgICAgICAgICJzdGF0dXMiOiB7Cg== 366468 2019-04-01 20:43:55 -0700 2019-04-02 03:20:14 -0700 Patch bug-196443-20190402114352.patch text/plain 1680 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc3ZWIyOWI5YTJmYzU5 ZmIzNTY4NWE3ZjBhMzc0MWNkMjgzOThkNC4uMjIzNDcxMzM5OTM4NjIzZmIzOGUxODEzNmRhNDdl MzExZmZkZmJjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTAxICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBVcGRhdGUgdGhlIHN0 YXR1cyBvZiBSZXNpemVPYnNlcnZlciBpbiBmZWF0dXJlcy5qc29uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NDQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDE5 LTA0LTAxICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgogCiAgICAg ICAgIEJlIGxlc3Mgc3RyaWN0IGFib3V0IGNsb3NpbmcgYmxvY2tzIGluIGF0dHJpYnV0ZSBhbmQg ZnVuY3Rpb25hbCBwc2V1ZG8tZWxlbWVudCBzZWxlY3RvcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9mZWF0dXJlcy5qc29uIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgppbmRl eCBjNmFlYTcwMTUzMmE2MjQ0NTk0MGJlYzI5MDdlYjEwNjhkY2ZmMDJlLi42NzM1Yzg2NzgzN2M5 YzdhYWNhNmMzMDFhZmNiYWE4YmNkYzVkNDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9m ZWF0dXJlcy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KQEAgLTExMzMs NiArMTEzMywyMSBAQAogICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJTdHJlYW1zIiwKICAgICAg ICAgImNvbW1lbnQiOiAiVGhlIGltcGxlbWVudGF0aW9uIGRvZXMgbm90IHN1cHBvcnQgUmVhZGFi bGVTdHJlYW1CWU9CUmVhZGVyLiIKICAgICB9LAorICAgIHsKKyAgICAgICAgIm5hbWUiOiAiUmVz aXplIE9ic2VydmVyIiwKKyAgICAgICAgInN0YXR1cyI6IHsKKyAgICAgICAgICAgICJzdGF0dXMi OiAiSW4gRGV2ZWxvcG1lbnQiLAorICAgICAgICAgICAgImVuYWJsZWQtYnktZGVmYXVsdCI6IGZh bHNlCisgICAgICAgIH0sCisgICAgICAgICJ1cmwiOiAiaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3Jn L3Jlc2l6ZS1vYnNlcnZlci8iLAorICAgICAgICAid2Via2l0LXVybCI6ICJodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NzQzIiwKKyAgICAgICAgImtleXdvcmRzIjog WyJyZXNpemUiLCAicmVzaXplIG9ic2VydmVyIiwgInJlc2l6ZW9ic2VydmVyIl0sCisgICAgICAg ICJkZXNjcmlwdGlvbiI6ICJBbiBBUEkgZm9yIG9ic2VydmluZyBjaGFuZ2VzIHRvIEVsZW1lbnQn cyBzaXplLiIsCisgICAgICAgICJjb250YWN0IjogeworICAgICAgICAgICAgIm5hbWUiOiAiQ2F0 aGllIENoZW4iLAorICAgICAgICAgICAgImVtYWlsIjogImNhdGhpZWNoZW5AaWdhbGlhLmNvbSIK KyAgICAgICAgfQorICAgIH0sCiAgICAgewogICAgICAgICAibmFtZSI6ICJTY3JvbGwgQW5jaG9y aW5nIiwKICAgICAgICAgInN0YXR1cyI6IHsK 366480 2019-04-02 03:20:21 -0700 2019-04-02 03:59:07 -0700 Patch bug-196443-20190402182019.patch text/plain 1674 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc3ZWIyOWI5YTJmYzU5 ZmIzNTY4NWE3ZjBhMzc0MWNkMjgzOThkNC4uNjZlNmM3YTk3MGI2YWE5NGEzNmZhZDUxNWJhN2Q4 NWYyYjRjMWZmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0LTAxICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBVcGRhdGUgdGhlIHN0 YXR1cyBvZiBSZXNpemVPYnNlcnZlciBpbiBmZWF0dXJlcy5qc29uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NDQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgUm9iIEJ1aXMuCisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDE5LTA0LTAx ICBFbWlsaW8gQ29ib3Mgw4FsdmFyZXogIDxlbWlsaW9AY3Jpc2FsLmlvPgogCiAgICAgICAgIEJl IGxlc3Mgc3RyaWN0IGFib3V0IGNsb3NpbmcgYmxvY2tzIGluIGF0dHJpYnV0ZSBhbmQgZnVuY3Rp b25hbCBwc2V1ZG8tZWxlbWVudCBzZWxlY3RvcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9mZWF0dXJlcy5qc29uIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgppbmRleCBjNmFl YTcwMTUzMmE2MjQ0NTk0MGJlYzI5MDdlYjEwNjhkY2ZmMDJlLi42NzM1Yzg2NzgzN2M5YzdhYWNh NmMzMDFhZmNiYWE4YmNkYzVkNDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJl cy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KQEAgLTExMzMsNiArMTEz MywyMSBAQAogICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJTdHJlYW1zIiwKICAgICAgICAgImNv bW1lbnQiOiAiVGhlIGltcGxlbWVudGF0aW9uIGRvZXMgbm90IHN1cHBvcnQgUmVhZGFibGVTdHJl YW1CWU9CUmVhZGVyLiIKICAgICB9LAorICAgIHsKKyAgICAgICAgIm5hbWUiOiAiUmVzaXplIE9i c2VydmVyIiwKKyAgICAgICAgInN0YXR1cyI6IHsKKyAgICAgICAgICAgICJzdGF0dXMiOiAiSW4g RGV2ZWxvcG1lbnQiLAorICAgICAgICAgICAgImVuYWJsZWQtYnktZGVmYXVsdCI6IGZhbHNlCisg ICAgICAgIH0sCisgICAgICAgICJ1cmwiOiAiaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL3Jlc2l6 ZS1vYnNlcnZlci8iLAorICAgICAgICAid2Via2l0LXVybCI6ICJodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NzQzIiwKKyAgICAgICAgImtleXdvcmRzIjogWyJyZXNp emUiLCAicmVzaXplIG9ic2VydmVyIiwgInJlc2l6ZW9ic2VydmVyIl0sCisgICAgICAgICJkZXNj cmlwdGlvbiI6ICJBbiBBUEkgZm9yIG9ic2VydmluZyBjaGFuZ2VzIHRvIEVsZW1lbnQncyBzaXpl LiIsCisgICAgICAgICJjb250YWN0IjogeworICAgICAgICAgICAgIm5hbWUiOiAiQ2F0aGllIENo ZW4iLAorICAgICAgICAgICAgImVtYWlsIjogImNhdGhpZWNoZW5AaWdhbGlhLmNvbSIKKyAgICAg ICAgfQorICAgIH0sCiAgICAgewogICAgICAgICAibmFtZSI6ICJTY3JvbGwgQW5jaG9yaW5nIiwK ICAgICAgICAgInN0YXR1cyI6IHsK