196434 2019-03-31 00:50:34 -0700 Missing includes that were previously provided via UnifiedSources 2019-04-03 08:58:12 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psaavedra psaavedra bugs-noreply cdumez commit-queue david_quesada dbates ews-feeder ggaren mcatanzaro simon.fraser thorton oldest_to_newest 1522823 0 psaavedra 2019-03-31 00:50:34 -0700 Disabling video causes a build failure after "Delete WebMetal implementation in favor of WebGPU": commit 2387e41376c396976e8f6950a7dfbbaa7713bf52 Author: mmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Fri Mar 29 22:18:59 2019 +0000 Delete WebMetal implementation in favor of WebGPU https://bugs.webkit.org/show_bug.cgi?id=195418 Reviewed by Dean Jackson. cmake -G Ninja -DPORT=WPE -DCMAKE_BUILD_TYPE=Release ... -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF -DENABLE_WEB_AUDIO=OFF:: In file included from /git/Source/WebCore/platform/Timer.h:37, from /git/Source/WebCore/platform/GenericTaskQueue.h:28, from /git/Source/WebCore/dom/Document.h:41, from /git/Source/WebCore/html/parser/XSSAuditor.cpp:32, from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-25.cpp:1: DerivedSources/ForwardingHeaders/wtf/WeakPtr.h: In instantiation of 'WTF::WeakPtr<T> WTF::makeWeakPtr(T&) [with T = WebCore::HTMLInputElement]': /git/Source/WebCore/html/InputType.h:318:40: required from here DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:183:55: error: invalid use of incomplete type 'class WebCore::HTMLInputElement' return { adoptRef(*weak_reference_downcast<T>(ref.weakPtrFactory().createWeakPtr(ref).m_ref.leakRef())) }; ~~~~^~~~~~~~~~~~~~ In file included from /git/Source/WebCore/html/HTMLElement.h:174, from /git/Source/WebCore/html/HTMLParamElement.h:25, from /git/Source/WebCore/html/parser/XSSAuditor.cpp:39, from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-25.cpp:1: DerivedSources/WebCore/HTMLElementTypeHelpers.h:400:7: note: forward declaration of 'class WebCore::HTMLInputElement' class HTMLInputElement; 1522824 1 366376 psaavedra 2019-03-31 00:58:22 -0700 Created attachment 366376 patch 1522829 2 366376 david_quesada 2019-03-31 10:57:51 -0700 Comment on attachment 366376 patch View in context: https://bugs.webkit.org/attachment.cgi?id=366376&action=review > Source/WebCore/html/InputType.h:35 > +#include "HTMLInputElement.h" There's a forward declaration of HTMLInputElement on line 58/59. You should remove that if you're going to include the full header. 1522897 3 366393 psaavedra 2019-04-01 04:28:54 -0700 Created attachment 366393 patch 1522898 4 psaavedra 2019-04-01 04:30:38 -0700 (In reply to David Quesada from comment #2) > Comment on attachment 366376 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366376&action=review > > > Source/WebCore/html/InputType.h:35 > > +#include "HTMLInputElement.h" > > There's a forward declaration of HTMLInputElement on line 58/59. You should > remove that if you're going to include the full header. +1 1523357 5 psaavedra 2019-04-02 11:14:04 -0700 (In reply to Pablo Saavedra from comment #4) > (In reply to David Quesada from comment #2) > > Comment on attachment 366376 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=366376&action=review > > > > > Source/WebCore/html/InputType.h:35 > > > +#include "HTMLInputElement.h" > > > > There's a forward declaration of HTMLInputElement on line 58/59. You should > > remove that if you're going to include the full header. > > +1 I've fixed what you suggest. WDYT, does it look good, now? 1523635 6 366583 psaavedra 2019-04-03 00:35:01 -0700 Created attachment 366583 patch 1523636 7 366584 psaavedra 2019-04-03 00:40:31 -0700 Created attachment 366584 patch 1523660 8 366584 ews-feeder 2019-04-03 02:47:00 -0700 Comment on attachment 366584 patch Rejecting attachment 366584 from commit-queue. psaavedra@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1523721 9 366584 commit-queue 2019-04-03 08:58:10 -0700 Comment on attachment 366584 patch Clearing flags on attachment: 366584 Committed r243799: <https://trac.webkit.org/changeset/243799> 1523722 10 commit-queue 2019-04-03 08:58:12 -0700 All reviewed patches have been landed. Closing bug. 366376 2019-03-31 00:58:22 -0700 2019-04-01 04:27:55 -0700 patch bug-196434-20190331095821.patch text/plain 1034 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU0ZGU1NmQxZWE0YjY5 OWE0OWE3NGViMjliNDE4NjM0MzdiOTg2My4uYzljNjllMTk3YTllY2UwNjA5ZGIxNmZjODNmYmNh YzM2YmE4NmE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAzLTMxICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5j bHVkZXMgdGhhdCB3ZXJlIHByZXZpb3VzbHkgcHJvdmlkZWQgdmlhIFVuaWZpZWRTb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0MzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSW5w dXRUeXBlLmg6CisKIDIwMTktMDMtMjkgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgog CiAgICAgICAgIGdsLnJlYWRQaXhlbHMgd2l0aCB0eXBlIGdsLkZMT0FUIGRvZXMgbm90IHdvcmsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0lucHV0VHlwZS5oCmluZGV4IGYwMjVhMTVlMmQ5ZTNiOWNlNmExN2VmN2M0N2I4 MDg1ZDc1MDZkZmUuLmM0ZjY4MTYyZDU5M2FjMDE1ZjhmM2MyNjQzNWQ0ZTMyZDQxNDQ5MzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9JbnB1dFR5cGUuaApAQCAtMzIsNiArMzIsNyBAQAogCiAjcHJhZ21hIG9uY2UK IAorI2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MVGV4dEZvcm1D b250cm9sRWxlbWVudC5oIgogI2luY2x1ZGUgIlJlbmRlclB0ci5oIgogI2luY2x1ZGUgIlN0ZXBS YW5nZS5oIgo= 366393 2019-04-01 04:28:54 -0700 2019-04-03 00:34:57 -0700 patch bug-196434-20190401132853.patch text/plain 1232 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNjZGFlYzJlOTg5MDU0 M2Q4YjgwNTI5ZGY1MzIyMDRjZTlmMzBlMy4uMzMzNjNhY2Y2NTZlYTc2MjA1MDYxOTk4ZmIxMGJj YmNlNWEzOWM2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAzLTMxICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5j bHVkZXMgdGhhdCB3ZXJlIHByZXZpb3VzbHkgcHJvdmlkZWQgdmlhIFVuaWZpZWRTb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0MzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSW5w dXRUeXBlLmg6CisKIDIwMTktMDMtMzEgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGln YWxpYS5jb20+CiAKICAgICAgICAgU2Nyb2xsIHBvc2l0aW9uIGdldHMgcmVzZXQgd2hlbiBvdmVy ZmxvdzpzY3JvbGwgaXMgaW5zaWRlIGdyaWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCmluZGV4IGYw MjVhMTVlMmQ5ZTNiOWNlNmExN2VmN2M0N2I4MDg1ZDc1MDZkZmUuLjY0M2I1OWU0N2FhMmNkZDUy MDdlNDRkMjYwMDNlMWU3ZTQ3Y2VkNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaApAQCAtMzIs NiArMzIsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQu aCIKICNpbmNsdWRlICJIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5oIgogI2luY2x1ZGUgIlJl bmRlclB0ci5oIgogI2luY2x1ZGUgIlN0ZXBSYW5nZS5oIgpAQCAtNTUsNyArNTYsNiBAQCBjbGFz cyBFdmVudDsKIGNsYXNzIEZpbGVMaXN0OwogY2xhc3MgSFRNTEVsZW1lbnQ7CiBjbGFzcyBIVE1M Rm9ybUVsZW1lbnQ7Ci1jbGFzcyBIVE1MSW5wdXRFbGVtZW50OwogY2xhc3MgSWNvbjsKIGNsYXNz IEtleWJvYXJkRXZlbnQ7CiBjbGFzcyBNb3VzZUV2ZW50Owo= 366583 2019-04-03 00:35:01 -0700 2019-04-03 00:40:27 -0700 patch bug-196434-20190403093500.patch text/plain 1270 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ViYmIxYmQ1NDBlZDUx NzM5MDBiMmIzOTZlNzgzNGQxMTVlNTJlMy4uOTIxYTE1NDlkZThiNTQzNWU0MzEwYjFmMThjZDVj Mzg0ZWQwYjhhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAzLTMxICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5j bHVkZXMgdGhhdCB3ZXJlIHByZXZpb3VzbHkgcHJvdmlkZWQgdmlhIFVuaWZpZWRTb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0MzQKKwor ICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICAqIGh0bWwvSW5wdXRUeXBl Lmg6CisKIDIwMTktMDQtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIzODI2Nik6IEV4Y2hhbmdlIDIwMTMgT3V0bG9vayBX ZWIgQWNjZXNzIGRpc3BsYXlzIHBhcnRpYWxseSBibGFuayBwYWdlIHdoZW4gY3JlYXRpbmcgbmV3 IGUtbWFpbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKaW5kZXggZjAyNWExNWUyZDllM2I5Y2U2YTE3 ZWY3YzQ3YjgwODVkNzUwNmRmZS4uNjQzYjU5ZTQ3YWEyY2RkNTIwN2U0NGQyNjAwM2UxZTdlNDdj ZWQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCkBAIC0zMiw2ICszMiw3IEBACiAKICNwcmFn bWEgb25jZQogCisjaW5jbHVkZSAiSFRNTElucHV0RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxU ZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyUHRyLmgiCiAjaW5jbHVk ZSAiU3RlcFJhbmdlLmgiCkBAIC01NSw3ICs1Niw2IEBAIGNsYXNzIEV2ZW50OwogY2xhc3MgRmls ZUxpc3Q7CiBjbGFzcyBIVE1MRWxlbWVudDsKIGNsYXNzIEhUTUxGb3JtRWxlbWVudDsKLWNsYXNz IEhUTUxJbnB1dEVsZW1lbnQ7CiBjbGFzcyBJY29uOwogY2xhc3MgS2V5Ym9hcmRFdmVudDsKIGNs YXNzIE1vdXNlRXZlbnQ7Cg== 366584 2019-04-03 00:40:31 -0700 2019-04-03 08:58:10 -0700 patch bug-196434-20190403094030.patch text/plain 1270 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ViYmIxYmQ1NDBlZDUx NzM5MDBiMmIzOTZlNzgzNGQxMTVlNTJlMy4uOTIxYTE1NDlkZThiNTQzNWU0MzEwYjFmMThjZDVj Mzg0ZWQwYjhhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAzLTMxICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5j bHVkZXMgdGhhdCB3ZXJlIHByZXZpb3VzbHkgcHJvdmlkZWQgdmlhIFVuaWZpZWRTb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0MzQKKwor ICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICAqIGh0bWwvSW5wdXRUeXBl Lmg6CisKIDIwMTktMDQtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIzODI2Nik6IEV4Y2hhbmdlIDIwMTMgT3V0bG9vayBX ZWIgQWNjZXNzIGRpc3BsYXlzIHBhcnRpYWxseSBibGFuayBwYWdlIHdoZW4gY3JlYXRpbmcgbmV3 IGUtbWFpbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKaW5kZXggZjAyNWExNWUyZDllM2I5Y2U2YTE3 ZWY3YzQ3YjgwODVkNzUwNmRmZS4uNjQzYjU5ZTQ3YWEyY2RkNTIwN2U0NGQyNjAwM2UxZTdlNDdj ZWQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCkBAIC0zMiw2ICszMiw3IEBACiAKICNwcmFn bWEgb25jZQogCisjaW5jbHVkZSAiSFRNTElucHV0RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxU ZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyUHRyLmgiCiAjaW5jbHVk ZSAiU3RlcFJhbmdlLmgiCkBAIC01NSw3ICs1Niw2IEBAIGNsYXNzIEV2ZW50OwogY2xhc3MgRmls ZUxpc3Q7CiBjbGFzcyBIVE1MRWxlbWVudDsKIGNsYXNzIEhUTUxGb3JtRWxlbWVudDsKLWNsYXNz IEhUTUxJbnB1dEVsZW1lbnQ7CiBjbGFzcyBJY29uOwogY2xhc3MgS2V5Ym9hcmRFdmVudDsKIGNs YXNzIE1vdXNlRXZlbnQ7Cg==