196421 2019-03-29 20:18:20 -0700 Web Inspector: CPU Usage Timeline - Adjust Energy Impact Threshholds 2019-04-01 11:55:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1522726 0 joepeck 2019-03-29 20:18:20 -0700 CPU Usage Timeline - Adjust Energy Impact Thresholds • Low - Keep Below 3% to continue to encourage idle pages stay below 3% NOTE: Might want to reduce to 2.5 or 2 after fixing bug 196419 • High - Make Above 30% instead of 50% to encourage long running interactivity to stay below 30% NOTE: Obviously depends on interaction, but sustained (1-2min) at 30%+ will certainly impact battery • Very High - Make above 100% instead of 150% NOTE: CPU Usage spikes around page load and is quite often still under 100% despite many threads. Drop this a bit as we dropped High down. 1522729 1 joepeck 2019-03-29 20:21:03 -0700 <rdar://problem/49125703> 1522730 2 366348 joepeck 2019-03-29 20:21:53 -0700 Created attachment 366348 [PATCH] Proposed Fix 1522731 3 webkit-bug-importer 2019-03-29 20:22:05 -0700 <rdar://problem/49444349> 1522732 4 joepeck 2019-03-29 20:24:24 -0700 <rdar://problem/49125703> 1522941 5 366348 hi 2019-04-01 10:30:37 -0700 Comment on attachment 366348 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=366348&action=review r=me > Source/WebInspectorUI/ChangeLog:19 > + - Reduce the size of the Medium section, and increase the High section Missing "." at the end of this line. I'd also remove the "-" and indent, as this "point" isn't related to a Low/High/Very High, and is instead a more general comment (e.g. it's not part of a "list"). > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:1106 > // Low. (<=3% CPU, mapped to 0-10) Given that these comments will have to be updated any time we change the thresholds, I think it might be "easier" to just remove them altogether. Each "section" is already semi-obvious by the `UIString`s in each block. > Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:1109 > + this._energyChart.value = mapWithBias(average, 0, CPUTimelineView.lowEnergyThreshold, 0, CPUTimelineView.lowEnergyGraphBoundary, 0.85); Do you also want to make the biases into `static get`? 1522991 6 joepeck 2019-04-01 11:55:15 -0700 https://trac.webkit.org/r243704 366348 2019-03-29 20:21:53 -0700 2019-04-01 11:55:10 -0700 [PATCH] Proposed Fix thresh-2.patch text/plain 6173 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAwNDJhYzhkNGU3Li40NjM0YjhjMGUxYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUgQEAKKzIwMTktMDMtMjkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDUFUgVXNhZ2UgVGltZWxpbmUgLSBBZGp1c3QgRW5lcmd5IEltcGFjdCBUaHJlc2hob2xkcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2NDIxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTEyNTcwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIExvdyAtIEtlZXAgQmVsb3cgMyUgdG8gY29udGlu dWUgdG8gZW5jb3VyYWdlIGlkbGUgcGFnZXMgc3RheSBiZWxvdyAzJQorICAgICAgICAgIE1pZ2h0 IHdhbnQgdG8gcmVkdWNlIHRvIDIuNSBvciAyIGFmdGVyIGZpeGluZyBidWcgMTk2NDE5LgorCisg ICAgICAgIC0gSGlnaCAtIE1ha2UgQWJvdmUgMzAlIGluc3RlYWQgb2YgNTAlIHRvIGVuY291cmFn ZSBsb25nIHJ1bm5pbmcgaW50ZXJhY3Rpdml0eSB0byBzdGF5IGJlbG93IDMwJQorICAgICAgICAg IERlcGVuZHMgb24gaW50ZXJhY3Rpb24sIGJ1dCBzdXN0YWluZWQgKDEtMm1pbikgYXQgMzAlKyB3 aWxsIGNlcnRhaW5seSBpbXBhY3QgYmF0dGVyeS4KKworICAgICAgICAtIFZlcnkgSGlnaCAtIE1h a2UgYWJvdmUgMTAwJSBpbnN0ZWFkIG9mIDE1MCUKKyAgICAgICAgICBDUFUgVXNhZ2Ugc3Bpa2Vz IGFyb3VuZCBwYWdlIGxvYWQgYW5kIGlzIHF1aXRlIG9mdGVuIHN0aWxsIHVuZGVyIDEwMCUgZGVz cGl0ZSBtYW55IHRocmVhZHMuCisgICAgICAgICAgRHJvcCB0aGlzIGEgYml0IGFzIHdlIGRyb3Bw ZWQgSGlnaCBkb3duLgorCisgICAgICAgIC0gUmVkdWNlIHRoZSBzaXplIG9mIHRoZSBNZWRpdW0g c2VjdGlvbiwgYW5kIGluY3JlYXNlIHRoZSBIaWdoIHNlY3Rpb24KKyAgICAgICAgICBIYXZpbmcg NzAlIG9mIHRoZSBjaGFydCBiZSAiTWVkaXVtIiBpcyBqdXN0IHRvbyBtdWNoIE1lZGl1bSwgYW5k CisgICAgICAgICAgd2UndmUgbm93IG1hZGUgaXQgbW9yZSBwb3NzaWJsZSB0byBiZSBpbiB0aGUg SGlnaCByYW5nZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVW aWV3LmpzOgorICAgICAgICAoV0kuQ1BVVGltZWxpbmVWaWV3LnByb3RvdHlwZS5nZXQgbWVkaXVt RW5lcmd5VGhyZXNob2xkKToKKyAgICAgICAgKFdJLkNQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUu Z2V0IGhpZ2hFbmVyZ3lUaHJlc2hvbGQpOgorICAgICAgICAoV0kuQ1BVVGltZWxpbmVWaWV3LnBy b3RvdHlwZS5nZXQgbG93RW5lcmd5R3JhcGhCb3VuZGFyeSk6CisgICAgICAgIChXSS5DUFVUaW1l bGluZVZpZXcucHJvdG90eXBlLmdldCBtZWRpdW1FbmVyZ3lHcmFwaEJvdW5kYXJ5KToKKyAgICAg ICAgKFdJLkNQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUuZ2V0IGhpZ2hFbmVyZ3lHcmFwaEJvdW5k YXJ5KToKKyAgICAgICAgKFdJLkNQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUuaW5pdGlhbExheW91 dCk6CisgICAgICAgIChXSS5DUFVUaW1lbGluZVZpZXcucHJvdG90eXBlLmxheW91dC5iZXN0VGhy ZWFkTGF5b3V0TWF4KToKKyAgICAgICAgKFdJLkNQVVRpbWVsaW5lVmlldy5wcm90b3R5cGUuX2xh eW91dEVuZXJneUNoYXJ0KToKKwogMjAxOS0wMy0yOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3cgUmVzb3VyY2UgSW5p dGlhdG9yIGluIE5ldHdvcmsgVGFiIGRldGFpbCB2aWV3cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVWaWV3Lmpz CmluZGV4IDk3ZmM4ZDQ3OTZmLi5hMGUzNDIxNjRhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NQVVRpbWVsaW5lVmlldy5q cwpAQCAtNzEsOCArNzEsMTIgQEAgV0kuQ1BVVGltZWxpbmVWaWV3ID0gY2xhc3MgQ1BVVGltZWxp bmVWaWV3IGV4dGVuZHMgV0kuVGltZWxpbmVWaWV3CiAgICAgc3RhdGljIGdldCBpbmRpY2F0b3JW aWV3SGVpZ2h0KCkgeyByZXR1cm4gMTU7IH0KIAogICAgIHN0YXRpYyBnZXQgbG93RW5lcmd5VGhy ZXNob2xkKCkgeyByZXR1cm4gMzsgfQotICAgIHN0YXRpYyBnZXQgbWVkaXVtRW5lcmd5VGhyZXNo b2xkKCkgeyByZXR1cm4gNTA7IH0KLSAgICBzdGF0aWMgZ2V0IGhpZ2hFbmVyZ3lUaHJlc2hvbGQo KSB7IHJldHVybiAxNTA7IH0KKyAgICBzdGF0aWMgZ2V0IG1lZGl1bUVuZXJneVRocmVzaG9sZCgp IHsgcmV0dXJuIDMwOyB9CisgICAgc3RhdGljIGdldCBoaWdoRW5lcmd5VGhyZXNob2xkKCkgeyBy ZXR1cm4gMTAwOyB9CisKKyAgICBzdGF0aWMgZ2V0IGxvd0VuZXJneUdyYXBoQm91bmRhcnkoKSB7 IHJldHVybiAxMDsgfQorICAgIHN0YXRpYyBnZXQgbWVkaXVtRW5lcmd5R3JhcGhCb3VuZGFyeSgp IHsgcmV0dXJuIDcwOyB9CisgICAgc3RhdGljIGdldCBoaWdoRW5lcmd5R3JhcGhCb3VuZGFyeSgp IHsgcmV0dXJuIDEwMDsgfQogCiAgICAgc3RhdGljIGdldCBkZWZhdWx0U2VjdGlvbkxpbWl0KCkg eyByZXR1cm4gNTsgfQogCkBAIC0yNjEsOSArMjY1LDkgQEAgV0kuQ1BVVGltZWxpbmVWaWV3ID0g Y2xhc3MgQ1BVVGltZWxpbmVWaWV3IGV4dGVuZHMgV0kuVGltZWxpbmVWaWV3CiAgICAgICAgICAg ICBoZWlnaHQ6IDExMCwKICAgICAgICAgICAgIHN0cm9rZVdpZHRoOiAyMCwKICAgICAgICAgICAg IHNlZ21lbnRzOiBbCi0gICAgICAgICAgICAgICAge2NsYXNzTmFtZTogImxvdyIsIGxpbWl0OiAx MH0sCi0gICAgICAgICAgICAgICAge2NsYXNzTmFtZTogIm1lZGl1bSIsIGxpbWl0OiA4MH0sCi0g ICAgICAgICAgICAgICAge2NsYXNzTmFtZTogImhpZ2giLCBsaW1pdDogMTAwfSwKKyAgICAgICAg ICAgICAgICB7Y2xhc3NOYW1lOiAibG93IiwgbGltaXQ6IENQVVRpbWVsaW5lVmlldy5sb3dFbmVy Z3lHcmFwaEJvdW5kYXJ5fSwKKyAgICAgICAgICAgICAgICB7Y2xhc3NOYW1lOiAibWVkaXVtIiwg bGltaXQ6IENQVVRpbWVsaW5lVmlldy5tZWRpdW1FbmVyZ3lHcmFwaEJvdW5kYXJ5fSwKKyAgICAg ICAgICAgICAgICB7Y2xhc3NOYW1lOiAiaGlnaCIsIGxpbWl0OiBDUFVUaW1lbGluZVZpZXcuaGln aEVuZXJneUdyYXBoQm91bmRhcnl9LAogICAgICAgICAgICAgXQogICAgICAgICB9KTsKICAgICAg ICAgdGhpcy5hZGRTdWJ2aWV3KHRoaXMuX2VuZXJneUNoYXJ0KTsKQEAgLTU5MSw3ICs1OTUsNyBA QCBXSS5DUFVUaW1lbGluZVZpZXcgPSBjbGFzcyBDUFVUaW1lbGluZVZpZXcgZXh0ZW5kcyBXSS5U aW1lbGluZVZpZXcKIAogICAgICAgICBmdW5jdGlvbiBiZXN0VGhyZWFkTGF5b3V0TWF4KHZhbHVl KSB7CiAgICAgICAgICAgICBpZiAodmFsdWUgPiAxMDApCi0gICAgICAgICAgICAgICAgcmV0dXJu IE1hdGguY2VpbCh2YWx1ZSk7ICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgcmV0dXJuIE1h dGguY2VpbCh2YWx1ZSk7CiAgICAgICAgICAgICByZXR1cm4gKE1hdGguZmxvb3IodmFsdWUgLyAy NSkgKyAxKSAqIDI1OwogICAgICAgICB9CiAKQEAgLTExMDIsMTkgKzExMDYsMTkgQEAgV0kuQ1BV VGltZWxpbmVWaWV3ID0gY2xhc3MgQ1BVVGltZWxpbmVWaWV3IGV4dGVuZHMgV0kuVGltZWxpbmVW aWV3CiAgICAgICAgICAgICAvLyBMb3cuICg8PTMlIENQVSwgbWFwcGVkIHRvIDAtMTApCiAgICAg ICAgICAgICB0aGlzLl9lbmVyZ3lJbXBhY3RMYWJlbEVsZW1lbnQudGV4dENvbnRlbnQgPSBXSS5V SVN0cmluZygiTG93Iik7CiAgICAgICAgICAgICB0aGlzLl9lbmVyZ3lJbXBhY3RMYWJlbEVsZW1l bnQuY2xhc3NMaXN0LmFkZCgibG93Iik7Ci0gICAgICAgICAgICB0aGlzLl9lbmVyZ3lDaGFydC52 YWx1ZSA9IG1hcFdpdGhCaWFzKGF2ZXJhZ2UsIDAsIENQVVRpbWVsaW5lVmlldy5sb3dFbmVyZ3lU aHJlc2hvbGQsIDAsIDEwLCAwLjg1KTsKKyAgICAgICAgICAgIHRoaXMuX2VuZXJneUNoYXJ0LnZh bHVlID0gbWFwV2l0aEJpYXMoYXZlcmFnZSwgMCwgQ1BVVGltZWxpbmVWaWV3Lmxvd0VuZXJneVRo cmVzaG9sZCwgMCwgQ1BVVGltZWxpbmVWaWV3Lmxvd0VuZXJneUdyYXBoQm91bmRhcnksIDAuODUp OwogICAgICAgICB9IGVsc2UgaWYgKGF2ZXJhZ2UgPD0gQ1BVVGltZWxpbmVWaWV3LiBtZWRpdW1F bmVyZ3lUaHJlc2hvbGQpIHsKLSAgICAgICAgICAgIC8vIE1lZGl1bSAoMyUtOTAlIENQVSwgbWFw cGVkIHRvIDEwLTgwKQorICAgICAgICAgICAgLy8gTWVkaXVtICgzJS0zMCUgQ1BVLCBtYXBwZWQg dG8gMTAtNzApCiAgICAgICAgICAgICB0aGlzLl9lbmVyZ3lJbXBhY3RMYWJlbEVsZW1lbnQudGV4 dENvbnRlbnQgPSBXSS5VSVN0cmluZygiTWVkaXVtIik7CiAgICAgICAgICAgICB0aGlzLl9lbmVy Z3lJbXBhY3RMYWJlbEVsZW1lbnQuY2xhc3NMaXN0LmFkZCgibWVkaXVtIik7Ci0gICAgICAgICAg ICB0aGlzLl9lbmVyZ3lDaGFydC52YWx1ZSA9IG1hcFdpdGhCaWFzKGF2ZXJhZ2UsIENQVVRpbWVs aW5lVmlldy5sb3dFbmVyZ3lUaHJlc2hvbGQsIENQVVRpbWVsaW5lVmlldy5tZWRpdW1FbmVyZ3lU aHJlc2hvbGQsIDEwLCA4MCwgMC42KTsKKyAgICAgICAgICAgIHRoaXMuX2VuZXJneUNoYXJ0LnZh bHVlID0gbWFwV2l0aEJpYXMoYXZlcmFnZSwgQ1BVVGltZWxpbmVWaWV3Lmxvd0VuZXJneVRocmVz aG9sZCwgQ1BVVGltZWxpbmVWaWV3Lm1lZGl1bUVuZXJneVRocmVzaG9sZCwgQ1BVVGltZWxpbmVW aWV3Lmxvd0VuZXJneUdyYXBoQm91bmRhcnksIENQVVRpbWVsaW5lVmlldy5tZWRpdW1FbmVyZ3lH cmFwaEJvdW5kYXJ5LCAwLjYpOwogICAgICAgICB9IGVsc2UgaWYgKGF2ZXJhZ2UgPCBDUFVUaW1l bGluZVZpZXcuIGhpZ2hFbmVyZ3lUaHJlc2hvbGQpIHsKLSAgICAgICAgICAgIC8vIEhpZ2guICg1 MC0xNTAlIENQVSwgbWFwcGVkIHRvIDgwLTEwMCkKKyAgICAgICAgICAgIC8vIEhpZ2guICgzMCUt MTAwJSBDUFUsIG1hcHBlZCB0byA3MC0xMDApCiAgICAgICAgICAgICB0aGlzLl9lbmVyZ3lJbXBh Y3RMYWJlbEVsZW1lbnQudGV4dENvbnRlbnQgPSBXSS5VSVN0cmluZygiSGlnaCIpOwogICAgICAg ICAgICAgdGhpcy5fZW5lcmd5SW1wYWN0TGFiZWxFbGVtZW50LmNsYXNzTGlzdC5hZGQoImhpZ2gi KTsKLSAgICAgICAgICAgIHRoaXMuX2VuZXJneUNoYXJ0LnZhbHVlID0gbWFwV2l0aEJpYXMoYXZl cmFnZSwgQ1BVVGltZWxpbmVWaWV3Lm1lZGl1bUVuZXJneVRocmVzaG9sZCwgQ1BVVGltZWxpbmVW aWV3LmhpZ2hFbmVyZ3lUaHJlc2hvbGQsIDgwLCAxMDAsIDAuOSk7CisgICAgICAgICAgICB0aGlz Ll9lbmVyZ3lDaGFydC52YWx1ZSA9IG1hcFdpdGhCaWFzKGF2ZXJhZ2UsIENQVVRpbWVsaW5lVmll dy5tZWRpdW1FbmVyZ3lUaHJlc2hvbGQsIENQVVRpbWVsaW5lVmlldy5oaWdoRW5lcmd5VGhyZXNo b2xkLCBDUFVUaW1lbGluZVZpZXcubWVkaXVtRW5lcmd5R3JhcGhCb3VuZGFyeSwgQ1BVVGltZWxp bmVWaWV3LmhpZ2hFbmVyZ3lHcmFwaEJvdW5kYXJ5LCAwLjkpOwogICAgICAgICB9IGVsc2Ugewot ICAgICAgICAgICAgLy8gVmVyeSBIaWdoLiAoPjE1MCUgQ1BVLCBtYXBwZWQgdG8gMTAwKQorICAg ICAgICAgICAgLy8gVmVyeSBIaWdoLiAoPjEwMCUgQ1BVLCBtYXBwZWQgdG8gMTAwKQogICAgICAg ICAgICAgdGhpcy5fZW5lcmd5SW1wYWN0TGFiZWxFbGVtZW50LnRleHRDb250ZW50ID0gV0kuVUlT dHJpbmcoIlZlcnkgSGlnaCIpOwogICAgICAgICAgICAgdGhpcy5fZW5lcmd5SW1wYWN0TGFiZWxF bGVtZW50LmNsYXNzTGlzdC5hZGQoImhpZ2giKTsKICAgICAgICAgICAgIHRoaXMuX2VuZXJneUNo YXJ0LnZhbHVlID0gMTAwOwo=