196419 2019-03-29 19:58:57 -0700 Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline 2019-03-30 09:38:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck benjamin commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1522720 0 joepeck 2019-03-29 19:58:57 -0700 JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline Oops, we forgot to call the platformSaveStateBeforeStarting function in the patch that was put up for review and landed... 1522721 1 webkit-bug-importer 2019-03-29 19:59:18 -0700 <rdar://problem/49444023> 1522722 2 366346 joepeck 2019-03-29 20:01:21 -0700 Created attachment 366346 [PATCH] Proposed Fix 1522723 3 366346 hi 2019-03-29 20:09:06 -0700 Comment on attachment 366346 [PATCH] Proposed Fix r=mews, oops :P 1522776 4 366346 commit-queue 2019-03-30 09:38:22 -0700 Comment on attachment 366346 [PATCH] Proposed Fix Clearing flags on attachment: 366346 Committed r243679: <https://trac.webkit.org/changeset/243679> 1522777 5 commit-queue 2019-03-30 09:38:23 -0700 All reviewed patches have been landed. Closing bug. 366346 2019-03-29 20:01:21 -0700 2019-03-30 09:38:22 -0700 [PATCH] Proposed Fix oops-1.patch text/plain 1445 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjg0MmZiMTY1My4uZDU0NDlhODczNmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMy0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEpTQyBTYW1wbGluZyBQcm9maWxlciB0aHJl YWQgbm90IGdldHRpbmcgc3VidHJhY3RlZCBpbiBDUFUgVXNhZ2UgVGltZWxpbmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjQxOQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDk0NDQwMjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwYWdlL1Jlc291cmNlVXNhZ2VUaHJlYWQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVzb3VyY2VVc2FnZVRocmVhZDo6YWRkT2JzZXJ2ZXIpOgorICAgICAgICBX ZSBmb3Jnb3QgdG8gY2FsbCB0aGUgZnVuY3Rpb24gdGhhdCB3b3VsZCBzZXR1cCBwbGF0Zm9ybSBz dGF0ZQorICAgICAgICBhbGxvd2luZyB1cyB0byBzdWJ0cmFjdCBvdXQgdGhlIHNhbXBsaW5nIHBy b2ZpbGVyIHRocmVhZC4KKwogMjAxOS0wMy0yOCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiB1bmJpbmRpbmcgYSBjYW52 YXMgc2hvdWxkIGFsd2F5cyByZW1vdmUgdGhlIGFnZW50IGFzIGFuIG9ic2VydmVyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Jlc291cmNlVXNhZ2VUaHJlYWQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9SZXNvdXJjZVVzYWdlVGhyZWFkLmNwcAppbmRleCA1MDM2MjYwYzljNC4u MDIyZDY0YjRkYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUmVzb3VyY2VVc2Fn ZVRocmVhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9SZXNvdXJjZVVzYWdlVGhyZWFk LmNwcApAQCAtNTgsOCArNTgsMTAgQEAgdm9pZCBSZXNvdXJjZVVzYWdlVGhyZWFkOjphZGRPYnNl cnZlcih2b2lkKiBrZXksIFJlc291cmNlVXNhZ2VDb2xsZWN0aW9uTW9kZSBtb2QKIAogICAgICAg ICByZXNvdXJjZVVzYWdlVGhyZWFkLnJlY29tcHV0ZUNvbGxlY3Rpb25Nb2RlKCk7CiAKLSAgICAg ICAgaWYgKHdhc0VtcHR5KQorICAgICAgICBpZiAod2FzRW1wdHkpIHsKKyAgICAgICAgICAgIHJl c291cmNlVXNhZ2VUaHJlYWQucGxhdGZvcm1TYXZlU3RhdGVCZWZvcmVTdGFydGluZygpOwogICAg ICAgICAgICAgcmVzb3VyY2VVc2FnZVRocmVhZC5tX2NvbmRpdGlvbi5ub3RpZnlBbGwoKTsKKyAg ICAgICAgfQogICAgIH0KIH0KIAo=