196417 2019-03-29 17:43:36 -0700 [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser 2019-04-03 08:01:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED DUPLICATE 196402 https://bugs.webkit.org/show_bug.cgi?id=196402 P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia darin ews-watchlist gustavo mcatanzaro oldest_to_newest 1522681 0 mcatanzaro 2019-03-29 17:43:36 -0700 This is a much simpler version of the patches in bug #195708 and bug #196402, intended for the 2.24 branch. We can't just backport those because the second patch adds new web process API. 1522682 1 366335 mcatanzaro 2019-03-29 17:48:33 -0700 Created attachment 366335 Patch 1522684 2 ews-watchlist 2019-03-29 17:52:25 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1522923 3 366335 darin 2019-04-01 08:51:58 -0700 Comment on attachment 366335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366335&action=review > Source/WebKit/ChangeLog:3 > + [WPE][GTK][STABLE] webkit_dom_element_html_input_element_set_editing_value should use HTMLInputElement::setValueForUser Ideally should explain why. This title just says exactly what the patch does, and not why. 1522930 4 mcatanzaro 2019-04-01 10:04:53 -0700 True. This patch is kinda low-effort since it's not intended for trunk, though. I figure anyone looking at the stable branch can follow the link to Bugzilla. 1523232 5 366335 cgarcia 2019-04-01 22:40:52 -0700 Comment on attachment 366335 Patch I would do this in trunk too, instead of adding new function. This is wrapping an internal function in the end, so it doesn't matter if the name doesn't match. 1523697 6 mcatanzaro 2019-04-03 08:01:40 -0700 *** This bug has been marked as a duplicate of bug 196402 *** 366335 2019-03-29 17:48:33 -0700 2019-04-01 08:51:58 -0700 Patch bug-196417-20190329194832.patch text/plain 2506 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2ZTFkNTcwYTYzYjU2ZWQ4 OGRiYWNhY2JlMGQ0YzE1ZTQ0YzVlYjEuLjI3MDU0MWE5Y2Q1MGFjOTg3ODcyNDEyMWU4YTdiZTA0 MmViNGFkYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDMtMjkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS11b U1RBQkxFXSB3ZWJraXRfZG9tX2VsZW1lbnRfaHRtbF9pbnB1dF9lbGVtZW50X3NldF9lZGl0aW5n X3ZhbHVlIHNob3VsZCB1c2UgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVGb3JVc2VyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0MTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIvRE9NL1dlYktpdERPTUVsZW1lbnQuY3BwOgorICAgICAg ICAod2Via2l0X2RvbV9lbGVtZW50X2h0bWxfaW5wdXRfZWxlbWVudF9zZXRfZWRpdGluZ192YWx1 ZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJL aXRET01IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb21faHRtbF9pbnB1 dF9lbGVtZW50X3NldF9lZGl0aW5nX3ZhbHVlKToKKwogMjAxOS0wMy0yOSAgQ2F0aGllIENoZW4g IDxjYXRoaWVjaGVuQGlnYWxpYS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFJlc2l6ZU9ic2Vy dmVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0FQSS9nbGliL0RPTS9XZWJLaXRET01FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9ET00vV2ViS2l0RE9NRWxlbWVudC5jcHAKaW5k ZXggMTMzMjQ5NTU3N2FkOTFmZTQ0ZjA2Nzk2Njc0NTFmYjE2ZWE3MDA1ZS4uZmZhY2M4NTZkYTQx OTJjYzI0ZmVkMzRhMDdlYTk2MzE5YjU0ZWMzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL0RPTS9XZWJLaXRET01FbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIv RE9NL1dlYktpdERPTUVsZW1lbnQuY3BwCkBAIC0xNjAsNSArMTYwLDUgQEAgdm9pZCB3ZWJraXRf ZG9tX2VsZW1lbnRfaHRtbF9pbnB1dF9lbGVtZW50X3NldF9lZGl0aW5nX3ZhbHVlKFdlYktpdERP TUVsZW1lbnQqIGUKICAgICBpZiAoIWlzPFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ+KG5vZGUp KQogICAgICAgICByZXR1cm47CiAKLSAgICBkb3duY2FzdDxXZWJDb3JlOjpIVE1MSW5wdXRFbGVt ZW50Pigqbm9kZSkuc2V0RWRpdGluZ1ZhbHVlKFN0cmluZzo6ZnJvbVVURjgodmFsdWUpKTsKKyAg ICBkb3duY2FzdDxXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Pigqbm9kZSkuc2V0VmFsdWVGb3JV c2VyKFN0cmluZzo6ZnJvbVVURjgodmFsdWUpKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJLaXRET01IVE1MSW5w dXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvZ3RrL0RPTS9XZWJLaXRET01IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCAzZGVkNWUyOWQ1 YzVlODA1ZmUwYmQ4NGE3MGQxNmQxZTg4ZDRmMDgzLi4zNDBhZTM5MzE5MjY3NWM0ZTNlZTQ1NGU3 MGVmZTU0ZDE1NzlkNWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2d0ay9ET00vV2ViS2l0RE9NSFRNTElucHV0RWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvRE9NL1dl YktpdERPTUhUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0xMDA3LDYgKzEwMDcsNiBAQCB2b2lkIHdl YmtpdF9kb21faHRtbF9pbnB1dF9lbGVtZW50X3NldF9lZGl0aW5nX3ZhbHVlKFdlYktpdERPTUhU TUxJbnB1dEVsZW1lbnQqCiAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0RPTV9JU19IVE1MX0lO UFVUX0VMRU1FTlQoc2VsZikpOwogICBnX3JldHVybl9pZl9mYWlsKHZhbHVlKTsKIAotICBXZWJL aXQ6OmNvcmUoc2VsZiktPnNldEVkaXRpbmdWYWx1ZShXVEY6OlN0cmluZzo6ZnJvbVVURjgodmFs dWUpKTsKKyAgV2ViS2l0Ojpjb3JlKHNlbGYpLT5zZXRWYWx1ZUZvclVzZXIoV1RGOjpTdHJpbmc6 OmZyb21VVEY4KHZhbHVlKSk7CiB9CiBHX0dOVUNfRU5EX0lHTk9SRV9ERVBSRUNBVElPTlM7Cg==