196414 2019-03-29 16:45:15 -0700 REGRESSION(236463) DownloadManager can call a null CompletionHandler 2019-04-08 11:47:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen azaaad32 ggaren webkit-bug-importer oldest_to_newest 1522653 0 achristensen 2019-03-29 16:45:15 -0700 REGRESSION(236463) DownloadManager can call a null CompletionHandler 1522654 1 366327 achristensen 2019-03-29 16:47:54 -0700 Created attachment 366327 Patch 1524886 2 366327 ggaren 2019-04-05 16:18:22 -0700 Comment on attachment 366327 Patch r=me Can haz regression test? 1525274 3 achristensen 2019-04-08 11:46:38 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 366327 [details] > Patch > > r=me > > Can haz regression test? Unfortunately, no. This is a hard-to-hit race condition when tearing things down while a download's location is being decided. It depends on IPC ordering. http://trac.webkit.org/r244030 1525275 4 webkit-bug-importer 2019-04-08 11:47:15 -0700 <rdar://problem/49704618> 366327 2019-03-29 16:47:54 -0700 2019-04-05 16:18:22 -0700 Patch bug-196414-20190329164754.patch text/plain 1839 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM2NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTI5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTigy MzY0NjMpIERvd25sb2FkTWFuYWdlciBjYW4gY2FsbCBhIG51bGwgQ29tcGxldGlvbkhhbmRsZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjQxNAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDgzODk0MzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3Vy Y2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmNv bnZlcnRUb0Rvd25sb2FkKToKKyAgICAgICAgRG93bmxvYWRNYW5hZ2VyOjpjb250aW51ZURlY2lk ZVBlbmRpbmdEb3dubG9hZERlc3RpbmF0aW9uIGlzIGJlaW5nIGNhbGxlZCB3aGVuIHRoZXJlIGlz IG5vIGNvbXBsZXRpb24gaGFuZGxlci4KKyAgICAgICAgcjIzNjQ2MyBpbnRyb2R1Y2VkIGFuIHVu Y2hlY2tlZCBjb2RlIHBhdGggdGhhdCBjYW4gYWxsb3cgdGhpcyB0byBoYXBwZW4uCisKIDIwMTkt MDMtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAg ICBEZWxldGUgV2ViTWV0YWwgaW1wbGVtZW50YXRpb24gaW4gZmF2b3Igb2YgV2ViR1BVCkluZGV4 OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3Vy Y2VMb2FkZXIuY3BwCShyZXZpc2lvbiAyNDM1NjYpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMSw4 ICszMjEsOCBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6Y29udmVydFRvRG93CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKLSAgICBBU1NFUlQobV9yZXNwb25zZUNvbXBsZXRpb25IYW5k bGVyKTsKLSAgICBtX2Nvbm5lY3Rpb24tPm5ldHdvcmtQcm9jZXNzKCkuZG93bmxvYWRNYW5hZ2Vy KCkuY29udmVydE5ldHdvcmtMb2FkVG9Eb3dubG9hZChkb3dubG9hZElELCBzdGQ6OmV4Y2hhbmdl KG1fbmV0d29ya0xvYWQsIG51bGxwdHIpLCBXVEZNb3ZlKG1fcmVzcG9uc2VDb21wbGV0aW9uSGFu ZGxlciksIFdURk1vdmUobV9maWxlUmVmZXJlbmNlcyksIHJlcXVlc3QsIHJlc3BvbnNlKTsKKyAg ICBpZiAobV9yZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyKQorICAgICAgICBtX2Nvbm5lY3Rpb24t Pm5ldHdvcmtQcm9jZXNzKCkuZG93bmxvYWRNYW5hZ2VyKCkuY29udmVydE5ldHdvcmtMb2FkVG9E b3dubG9hZChkb3dubG9hZElELCBzdGQ6OmV4Y2hhbmdlKG1fbmV0d29ya0xvYWQsIG51bGxwdHIp LCBXVEZNb3ZlKG1fcmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciksIFdURk1vdmUobV9maWxlUmVm ZXJlbmNlcyksIHJlcXVlc3QsIHJlc3BvbnNlKTsKIH0KIAogdm9pZCBOZXR3b3JrUmVzb3VyY2VM b2FkZXI6OmFib3J0KCkK