196396 2019-03-29 04:18:43 -0700 UnlinkedCodeBlock constructor from cache should initialize m_didOptimize 2019-04-04 07:19:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1522427 0 tzagallo 2019-03-29 04:18:43 -0700 ... 1522430 1 366265 tzagallo 2019-03-29 04:21:21 -0700 Created attachment 366265 Patch 1524065 2 366265 saam 2019-04-03 17:12:53 -0700 Comment on attachment 366265 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366265&action=review r=me I'm not sure how you found this, but I'm starting to think running all of JetStream 2 with caching could be a good test to add. > Source/JavaScriptCore/ChangeLog:9 > + The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization > + for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT. Please add a test. 1524207 3 366265 commit-queue 2019-04-04 07:15:26 -0700 Comment on attachment 366265 Patch Clearing flags on attachment: 366265 Committed r243867: <https://trac.webkit.org/changeset/243867> 1524208 4 commit-queue 2019-04-04 07:15:27 -0700 All reviewed patches have been landed. Closing bug. 1524211 5 webkit-bug-importer 2019-04-04 07:16:22 -0700 <rdar://problem/49605973> 1524213 6 saam 2019-04-04 07:17:17 -0700 (In reply to WebKit Commit Bot from comment #3) > Comment on attachment 366265 [details] > Patch > > Clearing flags on attachment: 366265 > > Committed r243867: <https://trac.webkit.org/changeset/243867> No test? 1524215 7 tzagallo 2019-04-04 07:19:27 -0700 (In reply to Saam Barati from comment #6) > (In reply to WebKit Commit Bot from comment #3) > > Comment on attachment 366265 [details] > > Patch > > > > Clearing flags on attachment: 366265 > > > > Committed r243867: <https://trac.webkit.org/changeset/243867> > > No test? Oh, I'm sorry, I don't know how I missed your comment. I'll add a follow-up patch do this bug. 366265 2019-03-29 04:21:21 -0700 2019-04-04 07:15:26 -0700 Patch bug-196396-20190329122120.patch text/plain 1546 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NDFiNTk2YThiODgxZGZmMDAxM2NjYjYzMmNmMTU1MGZjMjQwYmE3Li4wOTdjODFlYjBmOWI2ZTFk OWUzMTg2YWI2YTdkZDM5NDkxZjJlYjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMy0yOSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBVbmxpbmtlZENvZGVCbG9jayBjb25zdHJ1Y3RvciBmcm9tIGNhY2hlIHNo b3VsZCBpbml0aWFsaXplIG1fZGlkT3B0aW1pemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBVbmxpbmtlZENvZGVCbG9jayBjb25zdHJ1Y3RvciBp biBDYWNoZWRUeXBlcyB3YXMgbWlzc2luZyB0aGUgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgZm9y IG1fZGlkT3B0aW1pemUsIHdoaWNoIGxlYWRzIHRvIGNyYXNoZXMgaW4gQ29kZUJsb2NrOjp0aHJl c2hvbGRGb3JKSVQuCisKKyAgICAgICAgKiBydW50aW1lL0NhY2hlZFR5cGVzLmNwcDoKKyAgICAg ICAgKEpTQzo6VW5saW5rZWRDb2RlQmxvY2s6OlVubGlua2VkQ29kZUJsb2NrKToKKwogMjAxOS0w My0yOSAgQ2F0aGllIENoZW4gIDxjYXRoaWVjaGVuQGlnYWxpYS5jb20+CiAKICAgICAgICAgSW1w bGVtZW50IFJlc2l6ZU9ic2VydmVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q2FjaGVkVHlwZXMuY3BwCmluZGV4IDA1ZDgwYmMwMDIxN2Q2OTgzMjY0OWVlNmZhNWYyNmQzYTI4 Y2YwYzcuLmFmMDQyYTIwYTA0NWYyNDczOWY0YzA0MjBlMGM0Y2Q1MWY2YmY2ZTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKQEAgLTE4NzQsNiAr MTg3NCw4IEBAIEFMV0FZU19JTkxJTkUgVW5saW5rZWRDb2RlQmxvY2s6OlVubGlua2VkQ29kZUJs b2NrKERlY29kZXImIGRlY29kZXIsIFN0cnVjdHVyZSoKICAgICAsIG1faGFzVGFpbENhbGxzKGNh Y2hlZENvZGVCbG9jay5oYXNUYWlsQ2FsbHMoKSkKICAgICAsIG1fY29kZVR5cGUoY2FjaGVkQ29k ZUJsb2NrLmNvZGVUeXBlKCkpCiAKKyAgICAsIG1fZGlkT3B0aW1pemUoc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KE1peGVkVHJpU3RhdGUpKQorCiAgICAgLCBtX2ZlYXR1cmVzKGNhY2hlZENvZGVCbG9j ay5mZWF0dXJlcygpKQogICAgICwgbV9wYXJzZU1vZGUoY2FjaGVkQ29kZUJsb2NrLnBhcnNlTW9k ZSgpKQogCg==