196388 2019-03-28 20:30:14 -0700 CFDictionary encoder crashes on non-string keys 2019-03-28 21:57:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1522347 0 timothy 2019-03-28 20:30:14 -0700 Crashing on exception: -[__NSCFNumber length]: unrecognized selector sent to instance 0xdb1a3f98a109385 Application Specific Backtrace 1: 0 CoreFoundation 0x00007fff45b1bc03 __exceptionPreprocess + 250 1 libobjc.A.dylib 0x00007fff7af91a56 objc_exception_throw + 48 2 CoreFoundation 0x00007fff45bad30d -[NSObject(NSObject) __retain_OA] + 0 3 CoreFoundation 0x00007fff45ba646a ___forwarding___.cold.3 + 10 4 CoreFoundation 0x00007fff45ac2e4f ___forwarding___ + 1422 5 CoreFoundation 0x00007fff45ac2838 _CF_forwarding_prep_0 + 120 6 WebKit 0x00007fff55b1b17e _ZN3IPC6encodeERNS_7EncoderEPK10__CFString + 34 7 WebKit 0x00007fff55b1af71 _ZN3IPC6encodeERNS_7EncoderEPK14__CFDictionary + 292 8 WebKit 0x00007fff55b1af93 _ZN3IPC6encodeERNS_7EncoderEPK14__CFDictionary + 326 9 WebKit 0x00007fff55c51e80 _ZNK6WebKit21PlatformPopupMenuData6encodeERN3IPC7EncoderE + 18 10 WebKit 0x00007fff55eba8a4 _ZN3IPC10Connection4sendIN8Messages12WebPageProxy13ShowPopupMenuEEEbOT_yN3WTF9OptionSetINS_10SendOptionEEE + 98 <rdar://problem/49339242> 1522348 1 webkit-bug-importer 2019-03-28 20:31:39 -0700 <rdar://problem/49407869> 1522352 2 366241 timothy 2019-03-28 20:35:18 -0700 Created attachment 366241 Patch 1522353 3 timothy 2019-03-28 20:38:54 -0700 <rdar://problem/49339242> 1522369 4 366241 commit-queue 2019-03-28 21:57:17 -0700 Comment on attachment 366241 Patch Clearing flags on attachment: 366241 Committed r243640: <https://trac.webkit.org/changeset/243640> 1522370 5 commit-queue 2019-03-28 21:57:19 -0700 All reviewed patches have been landed. Closing bug. 366241 2019-03-28 20:35:18 -0700 2019-03-28 21:57:17 -0700 Patch bug-196388-20190328203517.patch text/plain 4810 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiNTYwYzRmNzQ0ODdjZWUy MmUyZGJmOTk2YjRiZGU0YjU0NjUwZmUuLmEyMTczYzk4MmQxM2JmYTNkNDVhZGNiNWZlZGI4Yjcz OWE2YmM0OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDMtMjggIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIENGRGljdGlvbmFyeSBlbmNv ZGVyIGNyYXNoZXMgb24gbm9uLXN0cmluZyBrZXlzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2Mzg4CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQ5 MzM5MjQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgbm9uLXN0cmluZyBrZXlzIGluIENGRGljdGlvbmFyeSBlbmNvZGluZy9kZWNvZGluZy4g RW5jb2RlIHRoZSBjb3JyZWN0CisgICAgICAgIHNpemUgZm9yIGRpY3Rpb25hcmllcyBhbmQgYXJy YXlzIHdoZW4gdW5rbm93biBrZXlzIG9yIHZhbHVlcyBhcmUgc2tpcHBlZC4KKyAgICAgICAgQWxs b3cgbnVsbCBhcnJheSBlbmNvZGluZyBhbmQgZGVjb2RpbmcgbGlrZSBkaWN0aW9uYXJ5IGFscmVh ZHkgYWxsb3dlZC4KKworICAgICAgICAqIFNoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNwcDoK KyAgICAgICAgKElQQzo6ZW5jb2RlKToKKyAgICAgICAgKElQQzo6ZGVjb2RlKToKKwogMjAxOS0w My0yNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0FwcGxlIFBh eV0gUmVtb3ZlIHRoZSBBdmFpbGFibGVQYXltZW50TmV0d29ya3Mgc3luY2hyb25vdXMgbWVzc2Fn ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvY2YvQXJndW1lbnRDb2RlcnNDRi5j cHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNwcAppbmRleCA1 ZGUzZmU2YTg0NWQyMWZjMmNjZmUzNGI5ZmZmYWJiZWIzYzhlYjZiLi40MjJmMzk0NDQyNzA0MTEx MjdmYzU5ZTQ3YjE0ZTM0ZTRmOGI1MDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9jZi9Bcmd1bWVudENvZGVyc0NGLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9jZi9B cmd1bWVudENvZGVyc0NGLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkRhdGFSZWZl cmVuY2UuaCIKICNpbmNsdWRlICJEZWNvZGVyLmgiCiAjaW5jbHVkZSAiRW5jb2Rlci5oIgorI2lu Y2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL1Byb2Nlc3NQcml2aWxlZ2UuaD4K ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL2NmL0NGVVJMRXh0cmFzLmg+ CkBAIC0zMjYsMjIgKzMyNyw0NiBAQCBib29sIGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBSZXRh aW5QdHI8Q0ZUeXBlUmVmPiYgcmVzdWx0KQogCiB2b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVy LCBDRkFycmF5UmVmIGFycmF5KQogeworICAgIGlmICghYXJyYXkpIHsKKyAgICAgICAgZW5jb2Rl ciA8PCB0cnVlOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgZW5jb2RlciA8PCBmYWxz ZTsKKwogICAgIENGSW5kZXggc2l6ZSA9IENGQXJyYXlHZXRDb3VudChhcnJheSk7CiAgICAgVmVj dG9yPENGVHlwZVJlZiwgMzI+IHZhbHVlcyhzaXplKTsKIAogICAgIENGQXJyYXlHZXRWYWx1ZXMo YXJyYXksIENGUmFuZ2VNYWtlKDAsIHNpemUpLCB2YWx1ZXMuZGF0YSgpKTsKIAotICAgIGVuY29k ZXIgPDwgc3RhdGljX2Nhc3Q8dWludDY0X3Q+KHNpemUpOwotCisgICAgSGFzaFNldDxDRkluZGV4 PiBpbnZhbGlkSW5kaWNpZXM7CiAgICAgZm9yIChDRkluZGV4IGkgPSAwOyBpIDwgc2l6ZTsgKytp KSB7Ci0gICAgICAgIEFTU0VSVCh2YWx1ZXNbaV0pOworICAgICAgICAvLyBJZ25vcmUgdmFsdWVz IHdlIGRvbid0IHN1cHBvcnQuCisgICAgICAgIEFTU0VSVCh0eXBlRnJvbUNGVHlwZVJlZih2YWx1 ZXNbaV0pICE9IFVua25vd24pOworICAgICAgICBpZiAodHlwZUZyb21DRlR5cGVSZWYodmFsdWVz W2ldKSA9PSBVbmtub3duKQorICAgICAgICAgICAgaW52YWxpZEluZGljaWVzLmFkZChpKTsKKyAg ICB9CiAKKyAgICBlbmNvZGVyIDw8IHN0YXRpY19jYXN0PHVpbnQ2NF90PihzaXplIC0gaW52YWxp ZEluZGljaWVzLnNpemUoKSk7CisKKyAgICBmb3IgKENGSW5kZXggaSA9IDA7IGkgPCBzaXplOyAr K2kpIHsKKyAgICAgICAgaWYgKGludmFsaWRJbmRpY2llcy5jb250YWlucyhpKSkKKyAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICBlbmNvZGUoZW5jb2RlciwgdmFsdWVzW2ldKTsKICAgICB9 CiB9CiAKIGJvb2wgZGVjb2RlKERlY29kZXImIGRlY29kZXIsIFJldGFpblB0cjxDRkFycmF5UmVm PiYgcmVzdWx0KQogeworICAgIGJvb2wgaXNOdWxsID0gZmFsc2U7CisgICAgaWYgKCFkZWNvZGVy LmRlY29kZShpc051bGwpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoaXNOdWxs KSB7CisgICAgICAgIHJlc3VsdCA9IG51bGxwdHI7CisgICAgICAgIHJldHVybiB0cnVlOworICAg IH0KKwogICAgIHVpbnQ2NF90IHNpemU7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShzaXplKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNDE0LDYgKzQzOSw3IEBAIHZvaWQgZW5jb2RlKEVu Y29kZXImIGVuY29kZXIsIENGRGljdGlvbmFyeVJlZiBkaWN0aW9uYXJ5KQogICAgICAgICBlbmNv ZGVyIDw8IHRydWU7CiAgICAgICAgIHJldHVybjsKICAgICB9CisKICAgICBlbmNvZGVyIDw8IGZh bHNlOwogCiAgICAgQ0ZJbmRleCBzaXplID0gQ0ZEaWN0aW9uYXJ5R2V0Q291bnQoZGljdGlvbmFy eSk7CkBAIC00MjIsMTggKzQ0OCwyNSBAQCB2b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBD RkRpY3Rpb25hcnlSZWYgZGljdGlvbmFyeSkKICAgICAKICAgICBDRkRpY3Rpb25hcnlHZXRLZXlz QW5kVmFsdWVzKGRpY3Rpb25hcnksIGtleXMuZGF0YSgpLCB2YWx1ZXMuZGF0YSgpKTsKIAotICAg IGVuY29kZXIgPDwgc3RhdGljX2Nhc3Q8dWludDY0X3Q+KHNpemUpOwotCisgICAgSGFzaFNldDxD RlR5cGVSZWY+IGludmFsaWRLZXlzOwogICAgIGZvciAoQ0ZJbmRleCBpID0gMDsgaSA8IHNpemU7 ICsraSkgewogICAgICAgICBBU1NFUlQoa2V5c1tpXSk7Ci0gICAgICAgIEFTU0VSVChDRkdldFR5 cGVJRChrZXlzW2ldKSA9PSBDRlN0cmluZ0dldFR5cGVJRCgpKTsKICAgICAgICAgQVNTRVJUKHZh bHVlc1tpXSk7CiAKLSAgICAgICAgLy8gSWdub3JlIHZhbHVlcyB3ZSBkb24ndCByZWNvZ25pemUu Ci0gICAgICAgIGlmICh0eXBlRnJvbUNGVHlwZVJlZih2YWx1ZXNbaV0pID09IFVua25vd24pCisg ICAgICAgIC8vIElnbm9yZSBrZXlzL3ZhbHVlcyB3ZSBkb24ndCBzdXBwb3J0LgorICAgICAgICBB U1NFUlQodHlwZUZyb21DRlR5cGVSZWYoa2V5c1tpXSkgIT0gVW5rbm93bik7CisgICAgICAgIEFT U0VSVCh0eXBlRnJvbUNGVHlwZVJlZih2YWx1ZXNbaV0pICE9IFVua25vd24pOworICAgICAgICBp ZiAodHlwZUZyb21DRlR5cGVSZWYoa2V5c1tpXSkgPT0gVW5rbm93biB8fCB0eXBlRnJvbUNGVHlw ZVJlZih2YWx1ZXNbaV0pID09IFVua25vd24pCisgICAgICAgICAgICBpbnZhbGlkS2V5cy5hZGQo a2V5c1tpXSk7CisgICAgfQorCisgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDx1aW50NjRfdD4o c2l6ZSAtIGludmFsaWRLZXlzLnNpemUoKSk7CisKKyAgICBmb3IgKENGSW5kZXggaSA9IDA7IGkg PCBzaXplOyArK2kpIHsKKyAgICAgICAgaWYgKGludmFsaWRLZXlzLmNvbnRhaW5zKGtleXNbaV0p KQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgZW5jb2RlKGVuY29kZXIsIHN0YXRp Y19jYXN0PENGU3RyaW5nUmVmPihrZXlzW2ldKSk7CisgICAgICAgIGVuY29kZShlbmNvZGVyLCBr ZXlzW2ldKTsKICAgICAgICAgZW5jb2RlKGVuY29kZXIsIHZhbHVlc1tpXSk7CiAgICAgfQogfQpA QCAtNDQzLDYgKzQ3Niw3IEBAIGJvb2wgZGVjb2RlKERlY29kZXImIGRlY29kZXIsIFJldGFpblB0 cjxDRkRpY3Rpb25hcnlSZWY+JiByZXN1bHQpCiAgICAgYm9vbCBpc051bGwgPSBmYWxzZTsKICAg ICBpZiAoIWRlY29kZXIuZGVjb2RlKGlzTnVsbCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKKwog ICAgIGlmIChpc051bGwpIHsKICAgICAgICAgcmVzdWx0ID0gbnVsbHB0cjsKICAgICAgICAgcmV0 dXJuIHRydWU7CkBAIC00NTQsOCArNDg4LDcgQEAgYm9vbCBkZWNvZGUoRGVjb2RlciYgZGVjb2Rl ciwgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4mIHJlc3VsdCkKIAogICAgIFJldGFpblB0cjxD Rk11dGFibGVEaWN0aW9uYXJ5UmVmPiBkaWN0aW9uYXJ5ID0gYWRvcHRDRihDRkRpY3Rpb25hcnlD cmVhdGVNdXRhYmxlKDAsIDAsICZrQ0ZUeXBlRGljdGlvbmFyeUtleUNhbGxCYWNrcywgJmtDRlR5 cGVEaWN0aW9uYXJ5VmFsdWVDYWxsQmFja3MpKTsKICAgICBmb3IgKHVpbnQ2NF90IGkgPSAwOyBp IDwgc2l6ZTsgKytpKSB7Ci0gICAgICAgIC8vIFRyeSB0byBkZWNvZGUgdGhlIGtleSBuYW1lLgot ICAgICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGtleTsKKyAgICAgICAgUmV0YWluUHRyPENG VHlwZVJlZj4ga2V5OwogICAgICAgICBpZiAoIWRlY29kZShkZWNvZGVyLCBrZXkpKQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCg==