196343 2019-03-28 02:13:02 -0700 Opcode.h(159,27): warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int] 2019-03-28 18:30:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1522021 0 fujii 2019-03-28 02:13:02 -0700 Clang 8.0.0 reports the following compilation warning. > [1229/6361] Building CXX object Source\JavaScriptCore\CMakeFiles\LLIntOffsetsExtractor.dir\llint\LLIntOffsetsExtractor.cpp.obj > In file included from ..\..\Source\JavaScriptCore\llint\LLIntOffsetsExtractor.cpp:31: > In file included from DerivedSources\JavaScriptCore\BytecodeStructs.h:32: > In file included from ..\..\Source\JavaScriptCore\bytecode\BytecodeDumper.h:29: > In file included from ..\..\Source\JavaScriptCore\bytecode/CallLinkInfo.h:31: > In file included from ..\..\Source\JavaScriptCore\jit\PolymorphicCallStubRoutine.h:30: > In file included from ..\..\Source\JavaScriptCore\bytecode\CallEdge.h:28: > In file included from ..\..\Source\JavaScriptCore\bytecode/CallVariant.h:28: > In file included from ..\..\Source\JavaScriptCore\runtime\ExecutableBaseInlines.h:28: > In file included from ..\..\Source\JavaScriptCore\runtime/ExecutableBase.h:34: > In file included from ..\..\Source\JavaScriptCore\bytecode\UnlinkedCodeBlock.h:34: > In file included from ..\..\Source\JavaScriptCore\bytecode/InstructionStream.h:29: > In file included from ..\..\Source\JavaScriptCore\bytecode/Instruction.h:28: > ..\..\Source\JavaScriptCore\bytecode/Opcode.h(159,27): warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int] > return PADDING_STRING + PADDING_STRING_LENGTH - pad; > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ > ..\..\Source\JavaScriptCore\bytecode/Opcode.h(159,27): note: use array indexing to silence this warning > return PADDING_STRING + PADDING_STRING_LENGTH - pad; > ^ > & [ ] > 1 warning generated. > clang version 8.0.0 (tags/RELEASE_800/final) > Target: x86_64-pc-windows-msvc > Thread model: posix 1522022 1 366158 fujii 2019-03-28 02:38:40 -0700 Created attachment 366158 Patch 1522023 2 fujii 2019-03-28 02:41:16 -0700 I have questions. * How to test this code? * Is there a port enabling OPCODE_STATS? 1522024 3 366159 fujii 2019-03-28 02:53:12 -0700 Created attachment 366159 Patch 1522027 4 fujii 2019-03-28 03:04:30 -0700 If define ENABLE_OPCODE_STATS 1, can't compile due to other issues. > In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6: > ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(97,38): error: no template named 'pair'; did you mean 'std::pair'? > std::pair<int, int> leftPair = *(pair<int, int>*) left; > ^~~~ > std::pair > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here > struct pair > ^ > In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f0a787a9-8.cpp:6: > ..\..\Source\JavaScriptCore\bytecode/Opcode.cpp(99,39): error: no template named 'pair'; did you mean 'std::pair'? > std::pair<int, int> rightPair = *(pair<int, int>*) right; > ^~~~ > std::pair > C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\utility(93,9): note: 'std::pair' declared here > struct pair > ^ > 2 errors generated. 1522029 5 366159 fujii 2019-03-28 03:17:07 -0700 Comment on attachment 366159 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366159&action=review > Source/JavaScriptCore/bytecode/Opcode.cpp:63 > + return &padding[stringLength - width]; out-of-bound access occurs if the opcode name is longer than width. 1522030 6 366162 fujii 2019-03-28 03:19:45 -0700 Created attachment 366162 Patch 1522031 7 fujii 2019-03-28 03:25:57 -0700 (In reply to Fujii Hironori from comment #2) > I have questions. > * How to test this code? Define ENABLE_OPCODE_STATS and execute jsc.exe and type "quit()". > * Is there a port enabling OPCODE_STATS? No. 1522315 8 fujii 2019-03-28 18:29:54 -0700 Committed r243633: <https://trac.webkit.org/changeset/243633> 1522316 9 webkit-bug-importer 2019-03-28 18:30:56 -0700 <rdar://problem/49405319> 366158 2019-03-28 02:38:40 -0700 2019-03-28 02:52:53 -0700 Patch bug-196343-20190328183839.patch text/plain 2821 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NzBkMDQ0MzcxNDg4MjM0OWI2MDFlNjc3NWRhZWIxMGRiMDcwZTk2Li40NDQ5NjIzYTZkNzFlZjhl MDVlOTI5MDk5YTJkOWUwNWVhZjM5NDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBPcGNvZGUuaCgxNTksMjcpOiB3YXJuaW5nOiBhZGRpbmcgJ3Vu c2lnbmVkIGludCcgdG8gYSBzdHJpbmcgZG9lcyBub3QgYXBwZW5kIHRvIHRoZSBzdHJpbmcgWy1X c3RyaW5nLXBsdXMtaW50XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2xhbmcgcmVwb3J0cyBhIGNvbXBpbGF0aW9uIHdhcm5pbmcgYW5kIHJlY29tbWVu ZCAnJlBBRERJTkdfU1RSSU5HW1BBRERJTkdfU1RSSU5HX0xFTkdUSF0nCisgICAgICAgIGluc3Rl YWQgb2YgJ1BBRERJTkdfU1RSSU5HICsgUEFERElOR19TVFJJTkdfTEVOR1RIJy4KKworICAgICAg ICAqIGJ5dGVjb2RlL09wY29kZS5jcHA6CisgICAgICAgIChKU0M6OnBhZE9wY29kZU5hbWUpOiBN b3ZlZCBwYWRPcGNvZGVOYW1lIGZyb20gT3Bjb2RlLmggYmVjYXVzZQorICAgICAgICB0aGlzIGZ1 bmN0aW9uIGlzIHVzZWQgb25seSBpbiBPcGNvZGUuY3BwLiBDaGFuZ2VkIG1hY3JvcworICAgICAg ICBQQURESU5HX1NUUklORyBhbmQgUEFERElOR19TVFJJTkdfTEVOR1RIIHRvIHNpbXBsZSB2YXJp YWJsZXMuCisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmg6CisgICAgICAgIChKU0M6OnBhZE9w Y29kZU5hbWUpOiBNb3ZlZC4KKwogMjAxOS0wMy0yNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIE93bmVyIG9mIHdhdGNocG9pbnRzIHNob3VsZCB2 YWxpZGF0ZSBhdCBHQyBmaW5hbGl6aW5nIHBoYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9PcGNvZGUuY3BwCmluZGV4IDJkZDkzNDQ4ZmFhMDhjOGJmMmQ2YWIzYjhkYmM2NmRkM2Yz NjUzOWMuLmRiMDUyMTVmNjJiYTIxY2VhNTdiM2UzNTFlMmNkMGU1ZWUyYjliY2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCkBAIC01NCw2ICs1NCwxMyBAQCBj b25zdCBjaGFyKiBjb25zdCBvcGNvZGVOYW1lc1tdID0gewogCiAjaWYgRU5BQkxFKE9QQ09ERV9T VEFUUykKIAoraW5saW5lIGNvbnN0IGNoYXIqIHBhZE9wY29kZU5hbWUoT3Bjb2RlSUQgb3AsIHVu c2lnbmVkIHdpZHRoKQoreworICAgIGF1dG8gcGFkZGluZyA9ICIgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICI7CisgICAgYXV0byBpbmRleCA9IHN0ZDo6bWF4KHN0cmxlbihwYWRkaW5n KSArIHN0cmxlbihvcGNvZGVOYW1lc1tvcF0pIC0gd2lkdGgsIDApOworICAgIHJldHVybiAmcGFk ZGluZ1tpbmRleF07Cit9CisKIGxvbmcgbG9uZyBPcGNvZGVTdGF0czo6b3Bjb2RlQ291bnRzW251 bU9wY29kZUlEc107CiBsb25nIGxvbmcgT3Bjb2RlU3RhdHM6Om9wY29kZVBhaXJDb3VudHNbbnVt T3Bjb2RlSURzXVtudW1PcGNvZGVJRHNdOwogaW50IE9wY29kZVN0YXRzOjpsYXN0T3Bjb2RlID0g LTE7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKaW5kZXggZmVlYjQ0Mjdm Njg1OTU0MWU1NzhmZTUwOWRhZmI1YzNjY2Y1YThmNi4uOGFjNjAzZTNjYzVmN2IxOTM1NDRiYjBj ZmYwODQ4ZGRiMjIwNzRjZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL09wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUu aApAQCAtMTQ3LDIxICsxNDcsOCBAQCB0eXBlZGVmIHZvaWQqIE9wY29kZTsKIHR5cGVkZWYgT3Bj b2RlSUQgT3Bjb2RlOwogI2VuZGlmCiAKLSNkZWZpbmUgUEFERElOR19TVFJJTkcgIiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIgotI2RlZmluZSBQQURESU5HX1NUUklOR19MRU5HVEgg c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0cmxlbihQQURESU5HX1NUUklORykpCi0KIGV4dGVybiBj b25zdCBjaGFyKiBjb25zdCBvcGNvZGVOYW1lc1tdOwogCi1pbmxpbmUgY29uc3QgY2hhciogcGFk T3Bjb2RlTmFtZShPcGNvZGVJRCBvcCwgdW5zaWduZWQgd2lkdGgpCi17Ci0gICAgdW5zaWduZWQg cGFkID0gd2lkdGggLSBzdHJsZW4ob3Bjb2RlTmFtZXNbb3BdKTsKLSAgICBwYWQgPSBzdGQ6Om1p bihwYWQsIFBBRERJTkdfU1RSSU5HX0xFTkdUSCk7Ci0gICAgcmV0dXJuIFBBRERJTkdfU1RSSU5H ICsgUEFERElOR19TVFJJTkdfTEVOR1RIIC0gcGFkOwotfQotCi0jdW5kZWYgUEFERElOR19TVFJJ TkdfTEVOR1RICi0jdW5kZWYgUEFERElOR19TVFJJTkcKLQogI2lmIEVOQUJMRShPUENPREVfU1RB VFMpCiAKIHN0cnVjdCBPcGNvZGVTdGF0cyB7Cg== 366159 2019-03-28 02:53:12 -0700 2019-03-28 03:19:26 -0700 Patch bug-196343-20190328185311.patch text/plain 2878 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NzBkMDQ0MzcxNDg4MjM0OWI2MDFlNjc3NWRhZWIxMGRiMDcwZTk2Li40NDQ5NjIzYTZkNzFlZjhl MDVlOTI5MDk5YTJkOWUwNWVhZjM5NDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBPcGNvZGUuaCgxNTksMjcpOiB3YXJuaW5nOiBhZGRpbmcgJ3Vu c2lnbmVkIGludCcgdG8gYSBzdHJpbmcgZG9lcyBub3QgYXBwZW5kIHRvIHRoZSBzdHJpbmcgWy1X c3RyaW5nLXBsdXMtaW50XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2xhbmcgcmVwb3J0cyBhIGNvbXBpbGF0aW9uIHdhcm5pbmcgYW5kIHJlY29tbWVu ZCAnJlBBRERJTkdfU1RSSU5HW1BBRERJTkdfU1RSSU5HX0xFTkdUSF0nCisgICAgICAgIGluc3Rl YWQgb2YgJ1BBRERJTkdfU1RSSU5HICsgUEFERElOR19TVFJJTkdfTEVOR1RIJy4KKworICAgICAg ICAqIGJ5dGVjb2RlL09wY29kZS5jcHA6CisgICAgICAgIChKU0M6OnBhZE9wY29kZU5hbWUpOiBN b3ZlZCBwYWRPcGNvZGVOYW1lIGZyb20gT3Bjb2RlLmggYmVjYXVzZQorICAgICAgICB0aGlzIGZ1 bmN0aW9uIGlzIHVzZWQgb25seSBpbiBPcGNvZGUuY3BwLiBDaGFuZ2VkIG1hY3JvcworICAgICAg ICBQQURESU5HX1NUUklORyBhbmQgUEFERElOR19TVFJJTkdfTEVOR1RIIHRvIHNpbXBsZSB2YXJp YWJsZXMuCisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmg6CisgICAgICAgIChKU0M6OnBhZE9w Y29kZU5hbWUpOiBNb3ZlZC4KKwogMjAxOS0wMy0yNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIE93bmVyIG9mIHdhdGNocG9pbnRzIHNob3VsZCB2 YWxpZGF0ZSBhdCBHQyBmaW5hbGl6aW5nIHBoYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9PcGNvZGUuY3BwCmluZGV4IDJkZDkzNDQ4ZmFhMDhjOGJmMmQ2YWIzYjhkYmM2NmRkM2Yz NjUzOWMuLmNjOTlmMDQ4NWZiNzFiYjFhYmRjYWE3ZDI2MzE4OTljYzEyYjgyOTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCkBAIC01NCw2ICs1NCwxNSBAQCBj b25zdCBjaGFyKiBjb25zdCBvcGNvZGVOYW1lc1tdID0gewogCiAjaWYgRU5BQkxFKE9QQ09ERV9T VEFUUykKIAoraW5saW5lIGNvbnN0IGNoYXIqIHBhZE9wY29kZU5hbWUoT3Bjb2RlSUQgb3AsIHVu c2lnbmVkIHdpZHRoKQoreworICAgIGF1dG8gcGFkZGluZyA9ICIgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICI7CisgICAgYXV0byBzdHJpbmdMZW5ndGggPSBzdHJsZW4ocGFkZGluZykg KyBzdHJsZW4ob3Bjb2RlTmFtZXNbb3BdKTsKKyAgICBpZiAoc3RyaW5nTGVuZ3RoIDwgd2lkdGgp CisgICAgICAgIHJldHVybiBwYWRkaW5nOworICAgIHJldHVybiAmcGFkZGluZ1tzdHJpbmdMZW5n dGggLSB3aWR0aF07Cit9CisKIGxvbmcgbG9uZyBPcGNvZGVTdGF0czo6b3Bjb2RlQ291bnRzW251 bU9wY29kZUlEc107CiBsb25nIGxvbmcgT3Bjb2RlU3RhdHM6Om9wY29kZVBhaXJDb3VudHNbbnVt T3Bjb2RlSURzXVtudW1PcGNvZGVJRHNdOwogaW50IE9wY29kZVN0YXRzOjpsYXN0T3Bjb2RlID0g LTE7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKaW5kZXggZmVlYjQ0Mjdm Njg1OTU0MWU1NzhmZTUwOWRhZmI1YzNjY2Y1YThmNi4uOGFjNjAzZTNjYzVmN2IxOTM1NDRiYjBj ZmYwODQ4ZGRiMjIwNzRjZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL09wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUu aApAQCAtMTQ3LDIxICsxNDcsOCBAQCB0eXBlZGVmIHZvaWQqIE9wY29kZTsKIHR5cGVkZWYgT3Bj b2RlSUQgT3Bjb2RlOwogI2VuZGlmCiAKLSNkZWZpbmUgUEFERElOR19TVFJJTkcgIiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIgotI2RlZmluZSBQQURESU5HX1NUUklOR19MRU5HVEgg c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0cmxlbihQQURESU5HX1NUUklORykpCi0KIGV4dGVybiBj b25zdCBjaGFyKiBjb25zdCBvcGNvZGVOYW1lc1tdOwogCi1pbmxpbmUgY29uc3QgY2hhciogcGFk T3Bjb2RlTmFtZShPcGNvZGVJRCBvcCwgdW5zaWduZWQgd2lkdGgpCi17Ci0gICAgdW5zaWduZWQg cGFkID0gd2lkdGggLSBzdHJsZW4ob3Bjb2RlTmFtZXNbb3BdKTsKLSAgICBwYWQgPSBzdGQ6Om1p bihwYWQsIFBBRERJTkdfU1RSSU5HX0xFTkdUSCk7Ci0gICAgcmV0dXJuIFBBRERJTkdfU1RSSU5H ICsgUEFERElOR19TVFJJTkdfTEVOR1RIIC0gcGFkOwotfQotCi0jdW5kZWYgUEFERElOR19TVFJJ TkdfTEVOR1RICi0jdW5kZWYgUEFERElOR19TVFJJTkcKLQogI2lmIEVOQUJMRShPUENPREVfU1RB VFMpCiAKIHN0cnVjdCBPcGNvZGVTdGF0cyB7Cg== 366162 2019-03-28 03:19:45 -0700 2019-03-28 08:40:47 -0700 Patch bug-196343-20190328191944.patch text/plain 3723 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NzBkMDQ0MzcxNDg4MjM0OWI2MDFlNjc3NWRhZWIxMGRiMDcwZTk2Li4yMDk2YTE3MzNiN2JhNjNm ODRmYTlhMzJjNDMzMTUwZjhiN2IyYzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMy0yOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBPcGNvZGUuaCgxNTksMjcpOiB3YXJuaW5nOiBhZGRpbmcgJ3Vu c2lnbmVkIGludCcgdG8gYSBzdHJpbmcgZG9lcyBub3QgYXBwZW5kIHRvIHRoZSBzdHJpbmcgWy1X c3RyaW5nLXBsdXMtaW50XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2xhbmcgcmVwb3J0cyBhIGNvbXBpbGF0aW9uIHdhcm5pbmcgYW5kIHJlY29tbWVu ZCAnJlBBRERJTkdfU1RSSU5HW1BBRERJTkdfU1RSSU5HX0xFTkdUSF0nCisgICAgICAgIGluc3Rl YWQgb2YgJ1BBRERJTkdfU1RSSU5HICsgUEFERElOR19TVFJJTkdfTEVOR1RIJy4KKworICAgICAg ICAqIGJ5dGVjb2RlL09wY29kZS5jcHA6CisgICAgICAgIChKU0M6OnBhZE9wY29kZU5hbWUpOiBN b3ZlZCBwYWRPcGNvZGVOYW1lIGZyb20gT3Bjb2RlLmggYmVjYXVzZQorICAgICAgICB0aGlzIGZ1 bmN0aW9uIGlzIHVzZWQgb25seSBpbiBPcGNvZGUuY3BwLiBDaGFuZ2VkIG1hY3JvcworICAgICAg ICBQQURESU5HX1NUUklORyBhbmQgUEFERElOR19TVFJJTkdfTEVOR1RIIHRvIHNpbXBsZSB2YXJp YWJsZXMuCisgICAgICAgIChKU0M6OmNvbXBhcmVPcGNvZGVQYWlySW5kaWNlcyk6IFJlcGxhY2Vk IHBhaXIgd2l0aCBzdGQ6OnBhaXIuCisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmg6CisgICAg ICAgIChKU0M6OnBhZE9wY29kZU5hbWUpOiBNb3ZlZC4KKwogMjAxOS0wMy0yNyAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIE93bmVyIG9mIHdhdGNo cG9pbnRzIHNob3VsZCB2YWxpZGF0ZSBhdCBHQyBmaW5hbGl6aW5nIHBoYXNlCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCmluZGV4IDJkZDkzNDQ4ZmFhMDhjOGJmMmQ2 YWIzYjhkYmM2NmRkM2YzNjUzOWMuLjI4NGNlZjdmNjQ0ZjIzYmExZjc1OTk2MTY5MjE2OGY1Mjlm MGFjNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuY3BwCkBAIC01 NCw2ICs1NCwxOCBAQCBjb25zdCBjaGFyKiBjb25zdCBvcGNvZGVOYW1lc1tdID0gewogCiAjaWYg RU5BQkxFKE9QQ09ERV9TVEFUUykKIAoraW5saW5lIGNvbnN0IGNoYXIqIHBhZE9wY29kZU5hbWUo T3Bjb2RlSUQgb3AsIHVuc2lnbmVkIHdpZHRoKQoreworICAgIGF1dG8gcGFkZGluZyA9ICIgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICI7CisgICAgYXV0byBwYWRkaW5nTGVuZ3RoID0g c3RybGVuKHBhZGRpbmcpOworICAgIGF1dG8gb3Bjb2RlTmFtZUxlbmd0aCA9IHN0cmxlbihvcGNv ZGVOYW1lc1tvcF0pOworICAgIGlmIChvcGNvZGVOYW1lTGVuZ3RoID49IHdpZHRoKQorICAgICAg ICByZXR1cm4gIiI7CisgICAgaWYgKHBhZGRpbmdMZW5ndGggKyBvcGNvZGVOYW1lTGVuZ3RoIDwg d2lkdGgpCisgICAgICAgIHJldHVybiBwYWRkaW5nOworICAgIHJldHVybiAmcGFkZGluZ1twYWRk aW5nTGVuZ3RoICsgb3Bjb2RlTmFtZUxlbmd0aCAtIHdpZHRoXTsKK30KKwogbG9uZyBsb25nIE9w Y29kZVN0YXRzOjpvcGNvZGVDb3VudHNbbnVtT3Bjb2RlSURzXTsKIGxvbmcgbG9uZyBPcGNvZGVT dGF0czo6b3Bjb2RlUGFpckNvdW50c1tudW1PcGNvZGVJRHNdW251bU9wY29kZUlEc107CiBpbnQg T3Bjb2RlU3RhdHM6Omxhc3RPcGNvZGUgPSAtMTsKQEAgLTg1LDkgKzk3LDkgQEAgc3RhdGljIGlu dCBjb21wYXJlT3Bjb2RlSW5kaWNlcyhjb25zdCB2b2lkKiBsZWZ0LCBjb25zdCB2b2lkKiByaWdo dCkKIAogc3RhdGljIGludCBjb21wYXJlT3Bjb2RlUGFpckluZGljZXMoY29uc3Qgdm9pZCogbGVm dCwgY29uc3Qgdm9pZCogcmlnaHQpCiB7Ci0gICAgc3RkOjpwYWlyPGludCwgaW50PiBsZWZ0UGFp ciA9ICoocGFpcjxpbnQsIGludD4qKSBsZWZ0OworICAgIHN0ZDo6cGFpcjxpbnQsIGludD4gbGVm dFBhaXIgPSAqKHN0ZDo6cGFpcjxpbnQsIGludD4qKSBsZWZ0OwogICAgIGxvbmcgbG9uZyBsZWZ0 VmFsdWUgPSBPcGNvZGVTdGF0czo6b3Bjb2RlUGFpckNvdW50c1tsZWZ0UGFpci5maXJzdF1bbGVm dFBhaXIuc2Vjb25kXTsKLSAgICBzdGQ6OnBhaXI8aW50LCBpbnQ+IHJpZ2h0UGFpciA9ICoocGFp cjxpbnQsIGludD4qKSByaWdodDsKKyAgICBzdGQ6OnBhaXI8aW50LCBpbnQ+IHJpZ2h0UGFpciA9 ICooc3RkOjpwYWlyPGludCwgaW50PiopIHJpZ2h0OwogICAgIGxvbmcgbG9uZyByaWdodFZhbHVl ID0gT3Bjb2RlU3RhdHM6Om9wY29kZVBhaXJDb3VudHNbcmlnaHRQYWlyLmZpcnN0XVtyaWdodFBh aXIuc2Vjb25kXTsKICAgICAKICAgICBpZiAobGVmdFZhbHVlIDwgcmlnaHRWYWx1ZSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaAppbmRleCBmZWViNDQyN2Y2ODU5NTQxZTU3 OGZlNTA5ZGFmYjVjM2NjZjVhOGY2Li44YWM2MDNlM2NjNWY3YjE5MzU0NGJiMGNmZjA4NDhkZGIy MjA3NGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2Rl LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oCkBAIC0xNDcs MjEgKzE0Nyw4IEBAIHR5cGVkZWYgdm9pZCogT3Bjb2RlOwogdHlwZWRlZiBPcGNvZGVJRCBPcGNv ZGU7CiAjZW5kaWYKIAotI2RlZmluZSBQQURESU5HX1NUUklORyAiICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiCi0jZGVmaW5lIFBBRERJTkdfU1RSSU5HX0xFTkdUSCBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oc3RybGVuKFBBRERJTkdfU1RSSU5HKSkKLQogZXh0ZXJuIGNvbnN0IGNoYXIq IGNvbnN0IG9wY29kZU5hbWVzW107CiAKLWlubGluZSBjb25zdCBjaGFyKiBwYWRPcGNvZGVOYW1l KE9wY29kZUlEIG9wLCB1bnNpZ25lZCB3aWR0aCkKLXsKLSAgICB1bnNpZ25lZCBwYWQgPSB3aWR0 aCAtIHN0cmxlbihvcGNvZGVOYW1lc1tvcF0pOwotICAgIHBhZCA9IHN0ZDo6bWluKHBhZCwgUEFE RElOR19TVFJJTkdfTEVOR1RIKTsKLSAgICByZXR1cm4gUEFERElOR19TVFJJTkcgKyBQQURESU5H X1NUUklOR19MRU5HVEggLSBwYWQ7Ci19Ci0KLSN1bmRlZiBQQURESU5HX1NUUklOR19MRU5HVEgK LSN1bmRlZiBQQURESU5HX1NUUklORwotCiAjaWYgRU5BQkxFKE9QQ09ERV9TVEFUUykKIAogc3Ry dWN0IE9wY29kZVN0YXRzIHsK