196338 2019-03-27 21:59:43 -0700 [SimpleLineLayout] Disable SLL when text-underline-position is not auto. 2019-03-28 15:15:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham dbates koivisto simon.fraser zalan oldest_to_newest 1521997 0 zalan 2019-03-27 21:59:43 -0700 we don't support text-underline-position yet. 1521998 1 zalan 2019-03-27 22:00:03 -0700 <rdar://problem/47975167> 1522002 2 366153 zalan 2019-03-27 22:16:52 -0700 Created attachment 366153 Patch 1522005 3 366153 dbates 2019-03-27 22:49:28 -0700 Comment on attachment 366153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366153&action=review > Source/WebCore/ChangeLog:7 > + Disable simple line layout unconditionally on non-auto text-underline-position content. We don's support it yet. Don? Changelog order does not look correct. This line should be under the next line. See other change logs. > LayoutTests/fast/text/simple-line-layout-with-text-underline-position-expected.html:1 > +<html> Ok as-is. Bothers me there is no doctype, but that is just me and no quirks to trip over. > LayoutTests/fast/text/simple-line-layout-with-text-underline-position-expected.html:5 > +<body></body> Haha. Got it, SLL disabled = no output just like a page with an empty body. 😀 > LayoutTests/fast/text/simple-line-layout-with-text-underline-position.html:1 > +<html> Ok as-is. Test uses quirks mode, but this seems unnecessary. > LayoutTests/fast/text/simple-line-layout-with-text-underline-position.html:3 > +<title>This tests that simple line layout is disabled for text-underline-position: under</title> Ok as-is. I personally don't like long web page titles. WPT like it. I don't. Want to know more then ask me. No need to appease me though. > LayoutTests/fast/text/simple-line-layout-with-text-underline-position.html:10 > + overflow:hidden; Ok as-is. Inconsistent style. (Alexey would say this adds randomness, but to me it just bothers me though no need to do anything; ok as-is.) Look at other lines if you want to. > LayoutTests/fast/text/simple-line-layout-with-text-underline-position.html:24 > +<div class=first>Pass if after selecting these 2 lines</div> Ok as-is. Text does not make sense to me. Test does not look like it programmatically selects anything. 1522060 4 366172 zalan 2019-03-28 07:40:42 -0700 Created attachment 366172 Patch 1522062 5 366173 zalan 2019-03-28 07:42:26 -0700 Created attachment 366173 Patch 1522064 6 zalan 2019-03-28 07:49:40 -0700 > Ok as-is. I personally don't like long web page titles. WPT like it. I > don't. Want to know more then ask me. No need to appease me though. I am curious. Will swing by. > > > LayoutTests/fast/text/simple-line-layout-with-text-underline-position.html:24 > > +<div class=first>Pass if after selecting these 2 lines</div> > > Ok as-is. Text does not make sense to me. Test does not look like it > programmatically selects anything. This is for me when in 9months this test starts failing on the bots, I can just read the text and test it quickly. 1522080 7 zalan 2019-03-28 09:02:31 -0700 Committed r243605: <https://trac.webkit.org/changeset/243605> 1522086 8 366173 simon.fraser 2019-03-28 09:45:04 -0700 Comment on attachment 366173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366173&action=review > Source/WebCore/ChangeLog:9 > + Disable simple line layout unconditionally on non-auto text-underline-position content. We don't support it yet. I would have liked this to describe the symptoms. 1522101 9 zalan 2019-03-28 10:47:19 -0700 (In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 366173 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366173&action=review > > > Source/WebCore/ChangeLog:9 > > + Disable simple line layout unconditionally on non-auto text-underline-position content. We don't support it yet. > > I would have liked this to describe the symptoms. the disappearing text? (like with most of the SLL patches) 1522246 10 simon.fraser 2019-03-28 15:15:19 -0700 (In reply to zalan from comment #9) > (In reply to Simon Fraser (smfr) from comment #8) > > Comment on attachment 366173 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=366173&action=review > > > > > Source/WebCore/ChangeLog:9 > > > + Disable simple line layout unconditionally on non-auto text-underline-position content. We don't support it yet. "This fixes a bug on Pearson test content where text would disappear after selecting, then using one of the overlay tools". 366153 2019-03-27 22:16:52 -0700 2019-03-28 07:40:41 -0700 Patch bug-196338-20190327221649.patch text/plain 4582 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5ZTRiYjBmMWJhN2Q0 MzI4NWY0MDkyN2ZhMzljYjYzOGNkOWVlYy4uOGZiYzBlZWRmMzQ0NzNkYmU2ODBmMmQyZTBlNDA5 MGViODY0M2Q2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTI3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1NpbXBsZUxpbmVMYXlvdXRd IERpc2FibGUgU0xMIHdoZW4gdGV4dC11bmRlcmxpbmUtcG9zaXRpb24gaXMgbm90IGF1dG8uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzMzgKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3OTc1MTY3PgorCisgICAgICAgIERpc2FibGUgc2ltcGxl IGxpbmUgbGF5b3V0IHVuY29uZGl0aW9uYWxseSBvbiBub24tYXV0byB0ZXh0LXVuZGVybGluZS1w b3NpdGlvbiBjb250ZW50LiBXZSBkb24ncyBzdXBwb3J0IGl0IHlldC4gCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L3NpbXBs ZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9uLmh0bWwKKworICAgICAg ICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNp bXBsZUxpbmVMYXlvdXQ6OmNhblVzZUZvclN0eWxlKToKKwogMjAxOS0wMy0yNyAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtDb250ZW50Q2hhbmdlT2JzZXJ2ZXJd IFN0b3AgdXNpbmcgdGhlIGdsb2JhbCBfV0tDb250ZW50Q2hhbmdlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKaW5kZXggYTk1YTExNTM5MWQ1MmQyMDMy MDA1Nzg5OWJjNTlkM2RhYmE1Y2UwMi4uODVmYWM0Y2U2NmVlYWM5ZjU1MzM3NjI1YTI2ZmE5YmI4 NjkxNzJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0 LmNwcApAQCAtMjAxLDcgKzIwMSw3IEBAIHN0YXRpYyBBdm9pZGFuY2VSZWFzb25GbGFncyBjYW5V c2VGb3JTdHlsZShjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUsIEluY2x1ZGVSZWFzCiAgICAgQXZv aWRhbmNlUmVhc29uRmxhZ3MgcmVhc29ucyA9IHsgfTsKICAgICBpZiAoc3R5bGUudGV4dE92ZXJm bG93KCkgPT0gVGV4dE92ZXJmbG93OjpFbGxpcHNpcykKICAgICAgICAgU0VUX1JFQVNPTl9BTkRf UkVUVVJOX0lGX05FRURFRChGbG93SGFzVGV4dE92ZXJmbG93LCByZWFzb25zLCBpbmNsdWRlUmVh c29ucyk7Ci0gICAgaWYgKChzdHlsZS50ZXh0RGVjb3JhdGlvbnNJbkVmZmVjdCgpICYgVGV4dERl Y29yYXRpb246OlVuZGVybGluZSkgJiYgKHN0eWxlLnRleHRVbmRlcmxpbmVQb3NpdGlvbigpICE9 IFRleHRVbmRlcmxpbmVQb3NpdGlvbjo6QXV0byB8fCAhc3R5bGUudGV4dFVuZGVybGluZU9mZnNl dCgpLmlzQXV0bygpIHx8ICFzdHlsZS50ZXh0RGVjb3JhdGlvblRoaWNrbmVzcygpLmlzQXV0bygp KSkKKyAgICBpZiAoc3R5bGUudGV4dFVuZGVybGluZVBvc2l0aW9uKCkgIT0gVGV4dFVuZGVybGlu ZVBvc2l0aW9uOjpBdXRvIHx8ICFzdHlsZS50ZXh0VW5kZXJsaW5lT2Zmc2V0KCkuaXNBdXRvKCkg fHwgIXN0eWxlLnRleHREZWNvcmF0aW9uVGhpY2tuZXNzKCkuaXNBdXRvKCkpCiAgICAgICAgIFNF VF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd0hhc1Vuc3VwcG9ydGVkVW5kZXJsaW5l RGVjb3JhdGlvbiwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogICAgIC8vIE5vbi12aXNpYmxl IG92ZXJmbG93IHNob3VsZCBiZSBwcmV0dHkgZWFzeSB0byBzdXBwb3J0LgogICAgIGlmIChzdHls ZS5vdmVyZmxvd1goKSAhPSBPdmVyZmxvdzo6VmlzaWJsZSB8fCBzdHlsZS5vdmVyZmxvd1koKSAh PSBPdmVyZmxvdzo6VmlzaWJsZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxZTcyMjU4YzEzNzVkNDc5NGM2YjRiOTc2ZmQ1 NjFjOThhNzQ1ODVhLi4yNzIxYmZmMDc0ZGM3ZjZkNGFkYTUyNjdhYjNmYzZkODQxYTQ4MWFjIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDMtMjcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KKworICAgICAgICBbU2ltcGxlTGluZUxheW91dF0gRGlzYWJsZSBTTEwgd2hlbiB0 ZXh0LXVuZGVybGluZS1wb3NpdGlvbiBpcyBub3QgYXV0by4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjMzOAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDc5NzUxNjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxpbmUt cG9zaXRpb24tZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L3NpbXBs ZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9uLmh0bWw6IEFkZGVkLgor CiAyMDE5LTAzLTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg WyBpT1MgU2ltdWxhdG9yIF0gUkVHUkVTU0lPTiAocjIzNzcwMikgTGF5b3V0IFRlc3QgaHR0cC90 ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELXNjcmlwdC1pbmplY3QtaW50by1pbmFjdGl2ZS13aW5k b3cuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv dGV4dC9zaW1wbGUtbGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi1leHBl Y3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRo LXRleHQtdW5kZXJsaW5lLXBvc2l0aW9uLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDA3ZGQ2 NjM1OWQ0OWE0NDA5YzRjYTljMjY1YzY3OTdkMDViNDVkMAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvdGV4dC9zaW1wbGUtbGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGlu ZS1wb3NpdGlvbi1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNiBAQAorPGh0bWw+Cis8aGVhZD4K Kzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgc2ltcGxlIGxpbmUgbGF5b3V0IGlzIGRpc2FibGVkIGZv ciB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5kZXI8L3RpdGxlPgorPC9oZWFkPgorPGJvZHk+ PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NpbXBs ZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9uLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxpbmUtcG9z aXRpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xODUzZDcyMjE1OTNiMDZjOWY4MzdmYzU3YzNmZGRmMzlj ZjFlOTU3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NpbXBsZS1s aW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9uLmh0bWwKQEAgLTAsMCArMSwy NyBAQAorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgc2ltcGxlIGxpbmUg bGF5b3V0IGlzIGRpc2FibGVkIGZvciB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5kZXI8L3Rp dGxlPgorPHN0eWxlPgorZGl2IHsKKyAgICBjb2xvcjogd2hpdGU7ICAgICAgCit9CisKKy5maXJz dCB7CisgICAgb3ZlcmZsb3c6aGlkZGVuOworfQorLnNlY29uZCwgLmZpcnN0IHsKKwl0ZXh0LXVu ZGVybGluZS1wb3NpdGlvbjogdW5kZXI7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5k b3cuaW50ZXJuYWxzKSB7CisgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldFNpbXBsZUxpbmVMYXlv dXREZWJ1Z0JvcmRlcnNFbmFibGVkKHRydWUpOworICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRT aW1wbGVMaW5lTGF5b3V0RW5hYmxlZCh0cnVlKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+Cis8ZGl2IGNsYXNzPWZpcnN0PlBhc3MgaWYgYWZ0ZXIgc2VsZWN0aW5nIHRoZXNlIDIgbGlu ZXM8L2Rpdj4KKzxkaXYgY2xhc3M9c2Vjb25kPnRoaXMgbGluZSBpcyBzdGlsbCB2aXNpYmxlPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 366172 2019-03-28 07:40:42 -0700 2019-03-28 07:41:43 -0700 Patch bug-196338-20190328074042.patch text/plain 4561 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhlYTY1OTYwMTcxNDdm ZWQxNzYzZmQyMTAzMTQ2MDA2YTM4MmU5ZC4uNjI3ZjJhNDIwYWU5NDU0ODVmN2NiYjViMWEzYTQ5 OWI3NWMwYWJmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1NpbXBsZUxpbmVMYXlvdXRd IERpc2FibGUgU0xMIHdoZW4gdGV4dC11bmRlcmxpbmUtcG9zaXRpb24gaXMgbm90IGF1dG8uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzMzgKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3OTc1MTY3PgorCisgICAgICAgIERpc2FibGUgc2ltcGxl IGxpbmUgbGF5b3V0IHVuY29uZGl0aW9uYWxseSBvbiBub24tYXV0byB0ZXh0LXVuZGVybGluZS1w b3NpdGlvbiBjb250ZW50LiBXZSBkb24ndCBzdXBwb3J0IGl0IHlldC4gCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9zaW1wbGUt bGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi5odG1sCisKKyAgICAgICAg KiByZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1w bGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3JTdHlsZSk6CisKIDIwMTktMDMtMjggIFbDrWN0b3IgTWFu dWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBTaWxlbmNl IGxvdCBvZiB3YXJuaW5ncyB3aGVuIGNvbXBpbGluZyB3aXRoIGNsYW5nCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKaW5kZXggYTk1YTExNTM5MWQ1MmQy MDMyMDA1Nzg5OWJjNTlkM2RhYmE1Y2UwMi4uODVmYWM0Y2U2NmVlYWM5ZjU1MzM3NjI1YTI2ZmE5 YmI4NjkxNzJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxp bmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0LmNwcApAQCAtMjAxLDcgKzIwMSw3IEBAIHN0YXRpYyBBdm9pZGFuY2VSZWFzb25GbGFncyBj YW5Vc2VGb3JTdHlsZShjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUsIEluY2x1ZGVSZWFzCiAgICAg QXZvaWRhbmNlUmVhc29uRmxhZ3MgcmVhc29ucyA9IHsgfTsKICAgICBpZiAoc3R5bGUudGV4dE92 ZXJmbG93KCkgPT0gVGV4dE92ZXJmbG93OjpFbGxpcHNpcykKICAgICAgICAgU0VUX1JFQVNPTl9B TkRfUkVUVVJOX0lGX05FRURFRChGbG93SGFzVGV4dE92ZXJmbG93LCByZWFzb25zLCBpbmNsdWRl UmVhc29ucyk7Ci0gICAgaWYgKChzdHlsZS50ZXh0RGVjb3JhdGlvbnNJbkVmZmVjdCgpICYgVGV4 dERlY29yYXRpb246OlVuZGVybGluZSkgJiYgKHN0eWxlLnRleHRVbmRlcmxpbmVQb3NpdGlvbigp ICE9IFRleHRVbmRlcmxpbmVQb3NpdGlvbjo6QXV0byB8fCAhc3R5bGUudGV4dFVuZGVybGluZU9m ZnNldCgpLmlzQXV0bygpIHx8ICFzdHlsZS50ZXh0RGVjb3JhdGlvblRoaWNrbmVzcygpLmlzQXV0 bygpKSkKKyAgICBpZiAoc3R5bGUudGV4dFVuZGVybGluZVBvc2l0aW9uKCkgIT0gVGV4dFVuZGVy bGluZVBvc2l0aW9uOjpBdXRvIHx8ICFzdHlsZS50ZXh0VW5kZXJsaW5lT2Zmc2V0KCkuaXNBdXRv KCkgfHwgIXN0eWxlLnRleHREZWNvcmF0aW9uVGhpY2tuZXNzKCkuaXNBdXRvKCkpCiAgICAgICAg IFNFVF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd0hhc1Vuc3VwcG9ydGVkVW5kZXJs aW5lRGVjb3JhdGlvbiwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogICAgIC8vIE5vbi12aXNp YmxlIG92ZXJmbG93IHNob3VsZCBiZSBwcmV0dHkgZWFzeSB0byBzdXBwb3J0LgogICAgIGlmIChz dHlsZS5vdmVyZmxvd1goKSAhPSBPdmVyZmxvdzo6VmlzaWJsZSB8fCBzdHlsZS5vdmVyZmxvd1ko KSAhPSBPdmVyZmxvdzo6VmlzaWJsZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZDUxZTMzZDM4ODFhMmVhYjYwOGU2ODkz N2ExNzMyYTZkZDZkOTE5Li5iN2U5ZDBlYzM1MDNkNmQ0MDZkMDgxNWJlNjlmY2Q3MDhkODNiNDNm IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDMtMjggIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KKworICAgICAgICBbU2ltcGxlTGluZUxheW91dF0gRGlzYWJsZSBTTEwgd2hl biB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbiBpcyBub3QgYXV0by4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjMzOAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDc5NzUxNjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgorCisg ICAgICAgICogZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5l LXBvc2l0aW9uLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9zaW1w bGUtbGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi5odG1sOiBBZGRlZC4K KwogMjAxOS0wMy0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0ZyZWVUeXBlXSBJbmNvcnJlY3QgYXBwbGljYXRpb24gb2YgZ2x5cGggcG9z aXRpb25pbmcgaW4gdGhlIFkgZGlyZWN0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxpbmUtcG9zaXRpb24tZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9zaW1wbGUtbGluZS1sYXlvdXQtd2l0 aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYzYjJi OGE4ZmViNGZjZDljNWI3OGEzYjUwNGE5YzY3N2M3N2NjYzgKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxp bmUtcG9zaXRpb24tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDcgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgc2ltcGxlIGxpbmUgbGF5 b3V0IGlzIGRpc2FibGVkIGZvciB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5kZXI8L3RpdGxl PgorPC9oZWFkPgorPGJvZHk+PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0 aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgt dGV4dC11bmRlcmxpbmUtcG9zaXRpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zY2VlNDM5MDE1NGYyNmEx MzQ2NjhlNmU3OGQ4NmZiOWQ2NmRiMzVmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9u Lmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgor PHRpdGxlPlRoaXMgdGVzdHMgdGhhdCBzaW1wbGUgbGluZSBsYXlvdXQgaXMgZGlzYWJsZWQgZm9y IHRleHQtdW5kZXJsaW5lLXBvc2l0aW9uOiB1bmRlcjwvdGl0bGU+Cis8c3R5bGU+CitkaXYgewor ICAgIGNvbG9yOiB3aGl0ZTsgICAgICAKK30KKworLmZpcnN0IHsKKyAgICBvdmVyZmxvdzogaGlk ZGVuOworfQorLnNlY29uZCwgLmZpcnN0IHsKKwl0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5k ZXI7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAg aW50ZXJuYWxzLnNldHRpbmdzLnNldFNpbXBsZUxpbmVMYXlvdXREZWJ1Z0JvcmRlcnNFbmFibGVk KHRydWUpOworICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRTaW1wbGVMaW5lTGF5b3V0RW5hYmxl ZCh0cnVlKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPWZpcnN0 PlBhc3MgaWYgYWZ0ZXIgc2VsZWN0aW5nIHRoZXNlIDIgbGluZXM8L2Rpdj4KKzxkaXYgY2xhc3M9 c2Vjb25kPnRoaXMgbGluZSBpcyBzdGlsbCB2aXNpYmxlPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ Cg== 366173 2019-03-28 07:42:26 -0700 2019-03-28 09:02:47 -0700 Patch bug-196338-20190328074225.patch text/plain 4561 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhlYTY1OTYwMTcxNDdm ZWQxNzYzZmQyMTAzMTQ2MDA2YTM4MmU5ZC4uNDNhMDAyYzQ2NzU0MWNkOGViMzQyY2IwY2NhZTYx ZjI2OWMxNjQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1NpbXBsZUxpbmVMYXlvdXRd IERpc2FibGUgU0xMIHdoZW4gdGV4dC11bmRlcmxpbmUtcG9zaXRpb24gaXMgbm90IGF1dG8uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzMzgKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3OTc1MTY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IERh bmllbCBCYXRlcy4KKworICAgICAgICBEaXNhYmxlIHNpbXBsZSBsaW5lIGxheW91dCB1bmNvbmRp dGlvbmFsbHkgb24gbm9uLWF1dG8gdGV4dC11bmRlcmxpbmUtcG9zaXRpb24gY29udGVudC4gV2Ug ZG9uJ3Qgc3VwcG9ydCBpdCB5ZXQuIAorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9zaW1wbGUt bGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi5odG1sCisKKyAgICAgICAg KiByZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1w bGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3JTdHlsZSk6CisKIDIwMTktMDMtMjggIFbDrWN0b3IgTWFu dWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBTaWxlbmNl IGxvdCBvZiB3YXJuaW5ncyB3aGVuIGNvbXBpbGluZyB3aXRoIGNsYW5nCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKaW5kZXggYTk1YTExNTM5MWQ1MmQy MDMyMDA1Nzg5OWJjNTlkM2RhYmE1Y2UwMi4uODVmYWM0Y2U2NmVlYWM5ZjU1MzM3NjI1YTI2ZmE5 YmI4NjkxNzJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxp bmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0LmNwcApAQCAtMjAxLDcgKzIwMSw3IEBAIHN0YXRpYyBBdm9pZGFuY2VSZWFzb25GbGFncyBj YW5Vc2VGb3JTdHlsZShjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUsIEluY2x1ZGVSZWFzCiAgICAg QXZvaWRhbmNlUmVhc29uRmxhZ3MgcmVhc29ucyA9IHsgfTsKICAgICBpZiAoc3R5bGUudGV4dE92 ZXJmbG93KCkgPT0gVGV4dE92ZXJmbG93OjpFbGxpcHNpcykKICAgICAgICAgU0VUX1JFQVNPTl9B TkRfUkVUVVJOX0lGX05FRURFRChGbG93SGFzVGV4dE92ZXJmbG93LCByZWFzb25zLCBpbmNsdWRl UmVhc29ucyk7Ci0gICAgaWYgKChzdHlsZS50ZXh0RGVjb3JhdGlvbnNJbkVmZmVjdCgpICYgVGV4 dERlY29yYXRpb246OlVuZGVybGluZSkgJiYgKHN0eWxlLnRleHRVbmRlcmxpbmVQb3NpdGlvbigp ICE9IFRleHRVbmRlcmxpbmVQb3NpdGlvbjo6QXV0byB8fCAhc3R5bGUudGV4dFVuZGVybGluZU9m ZnNldCgpLmlzQXV0bygpIHx8ICFzdHlsZS50ZXh0RGVjb3JhdGlvblRoaWNrbmVzcygpLmlzQXV0 bygpKSkKKyAgICBpZiAoc3R5bGUudGV4dFVuZGVybGluZVBvc2l0aW9uKCkgIT0gVGV4dFVuZGVy bGluZVBvc2l0aW9uOjpBdXRvIHx8ICFzdHlsZS50ZXh0VW5kZXJsaW5lT2Zmc2V0KCkuaXNBdXRv KCkgfHwgIXN0eWxlLnRleHREZWNvcmF0aW9uVGhpY2tuZXNzKCkuaXNBdXRvKCkpCiAgICAgICAg IFNFVF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd0hhc1Vuc3VwcG9ydGVkVW5kZXJs aW5lRGVjb3JhdGlvbiwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogICAgIC8vIE5vbi12aXNp YmxlIG92ZXJmbG93IHNob3VsZCBiZSBwcmV0dHkgZWFzeSB0byBzdXBwb3J0LgogICAgIGlmIChz dHlsZS5vdmVyZmxvd1goKSAhPSBPdmVyZmxvdzo6VmlzaWJsZSB8fCBzdHlsZS5vdmVyZmxvd1ko KSAhPSBPdmVyZmxvdzo6VmlzaWJsZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzZDUxZTMzZDM4ODFhMmVhYjYwOGU2ODkz N2ExNzMyYTZkZDZkOTE5Li5iN2U5ZDBlYzM1MDNkNmQ0MDZkMDgxNWJlNjlmY2Q3MDhkODNiNDNm IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDMtMjggIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KKworICAgICAgICBbU2ltcGxlTGluZUxheW91dF0gRGlzYWJsZSBTTEwgd2hl biB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbiBpcyBub3QgYXV0by4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjMzOAorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDc5NzUxNjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgorCisg ICAgICAgICogZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5l LXBvc2l0aW9uLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9zaW1w bGUtbGluZS1sYXlvdXQtd2l0aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi5odG1sOiBBZGRlZC4K KwogMjAxOS0wMy0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0ZyZWVUeXBlXSBJbmNvcnJlY3QgYXBwbGljYXRpb24gb2YgZ2x5cGggcG9z aXRpb25pbmcgaW4gdGhlIFkgZGlyZWN0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxpbmUtcG9zaXRpb24tZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9zaW1wbGUtbGluZS1sYXlvdXQtd2l0 aC10ZXh0LXVuZGVybGluZS1wb3NpdGlvbi1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYzYjJi OGE4ZmViNGZjZDljNWI3OGEzYjUwNGE5YzY3N2M3N2NjYzgKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtdGV4dC11bmRlcmxp bmUtcG9zaXRpb24tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDcgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgc2ltcGxlIGxpbmUgbGF5 b3V0IGlzIGRpc2FibGVkIGZvciB0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5kZXI8L3RpdGxl PgorPC9oZWFkPgorPGJvZHk+PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0 aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgt dGV4dC11bmRlcmxpbmUtcG9zaXRpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zY2VlNDM5MDE1NGYyNmEx MzQ2NjhlNmU3OGQ4NmZiOWQ2NmRiMzVmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC13aXRoLXRleHQtdW5kZXJsaW5lLXBvc2l0aW9u Lmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgor PHRpdGxlPlRoaXMgdGVzdHMgdGhhdCBzaW1wbGUgbGluZSBsYXlvdXQgaXMgZGlzYWJsZWQgZm9y IHRleHQtdW5kZXJsaW5lLXBvc2l0aW9uOiB1bmRlcjwvdGl0bGU+Cis8c3R5bGU+CitkaXYgewor ICAgIGNvbG9yOiB3aGl0ZTsgICAgICAKK30KKworLmZpcnN0IHsKKyAgICBvdmVyZmxvdzogaGlk ZGVuOworfQorLnNlY29uZCwgLmZpcnN0IHsKKwl0ZXh0LXVuZGVybGluZS1wb3NpdGlvbjogdW5k ZXI7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAg aW50ZXJuYWxzLnNldHRpbmdzLnNldFNpbXBsZUxpbmVMYXlvdXREZWJ1Z0JvcmRlcnNFbmFibGVk KHRydWUpOworICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRTaW1wbGVMaW5lTGF5b3V0RW5hYmxl ZCh0cnVlKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPWZpcnN0 PlBhc3MgaWYgYWZ0ZXIgc2VsZWN0aW5nIHRoZXNlIDIgbGluZXM8L2Rpdj4KKzxkaXYgY2xhc3M9 c2Vjb25kPnRoaXMgbGluZSBpcyBzdGlsbCB2aXNpYmxlPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==