196334 2019-03-27 18:03:11 -0700 JetStream 2 should not report time values as scores 2019-03-27 18:48:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez commit-queue ews-watchlist fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset rniwa ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1521945 0 saam 2019-03-27 18:03:11 -0700 ... 1521952 1 366138 saam 2019-03-27 18:14:28 -0700 Created attachment 366138 patch 1521953 2 366138 ysuzuki 2019-03-27 18:21:22 -0700 Comment on attachment 366138 patch View in context: https://bugs.webkit.org/attachment.cgi?id=366138&action=review r=me > Websites/browserbench.org/JetStream2.0/JetStreamDriver.js:324 > const subTimes = benchmark.subTimes(); subTimes return scores, it is a bit tricky. But it seems that all the XXXTimes in benchmarks now uses score (toScore()). So I think we should rename these variables and methods at some point to reflect that this is a score. 1521965 3 366138 commit-queue 2019-03-27 18:47:34 -0700 Comment on attachment 366138 patch Clearing flags on attachment: 366138 Committed r243597: <https://trac.webkit.org/changeset/243597> 1521966 4 commit-queue 2019-03-27 18:47:36 -0700 All reviewed patches have been landed. Closing bug. 1521967 5 webkit-bug-importer 2019-03-27 18:48:16 -0700 <rdar://problem/49363811> 366138 2019-03-27 18:14:28 -0700 2019-03-27 18:47:34 -0700 patch a-backup.diff text/plain 3358 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM1OTYpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAzLTI3ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEpldFN0cmVhbSAyIHNo b3VsZCBub3QgcmVwb3J0IHRpbWUgdmFsdWVzIGFzIHNjb3JlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MzM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBKZXRTdHJlYW0yL0pldFN0cmVhbURyaXZl ci5qczoKKyAgICAgICAgKHRvVGltZVZhbHVlKToKKyAgICAgICAgKERyaXZlci5wcm90b3R5cGUu YXN5bmMucmVwb3J0U2NvcmVUb1J1bkJlbmNobWFya1J1bm5lcik6CisKIDIwMTktMDMtMjcgIFNh YW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4 IGluZGl2aWR1YWwgYmVuY2htYXJrIGRlc2NyaXB0aW9uIHVybHMgdG8gZ28gdG8gaW4tZGVwdGgu aHRtbCBpbnN0ZWFkIG9mIGFib3V0Lmh0bWwKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvSmV0U3Ry ZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9K ZXRTdHJlYW0yL0pldFN0cmVhbURyaXZlci5qcwkocmV2aXNpb24gMjQzNTU4KQorKysgUGVyZm9y bWFuY2VUZXN0cy9KZXRTdHJlYW0yL0pldFN0cmVhbURyaXZlci5qcwkod29ya2luZyBjb3B5KQpA QCAtODIsNiArODIsMTAgQEAgZnVuY3Rpb24gdG9TY29yZSh0aW1lVmFsdWUpIHsKICAgICByZXR1 cm4gNTAwMCAvIHRpbWVWYWx1ZTsKIH0KIAorZnVuY3Rpb24gdG9UaW1lVmFsdWUoc2NvcmUpIHsK KyAgICByZXR1cm4gNTAwMCAvIHNjb3JlOworfQorCiBmdW5jdGlvbiB1cGRhdGVVSSgpIHsKICAg ICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsKICAgICAgICAgaWYgKGlzSW5Ccm93 c2VyKQpAQCAtMzE5LDcgKzMyMyw3IEBAIGNsYXNzIERyaXZlciB7CiAgICAgICAgICAgICBjb25z dCBzdWJSZXN1bHRzID0ge30KICAgICAgICAgICAgIGNvbnN0IHN1YlRpbWVzID0gYmVuY2htYXJr LnN1YlRpbWVzKCk7CiAgICAgICAgICAgICBmb3IgKGNvbnN0IG5hbWUgaW4gc3ViVGltZXMpIHsK LSAgICAgICAgICAgICAgICBzdWJSZXN1bHRzW25hbWVdID0geyJtZXRyaWNzIjogeyJUaW1lIjog eyJjdXJyZW50IjogW3N1YlRpbWVzW25hbWVdXX19fTsKKyAgICAgICAgICAgICAgICBzdWJSZXN1 bHRzW25hbWVdID0geyJtZXRyaWNzIjogeyJUaW1lIjogeyJjdXJyZW50IjogW3RvVGltZVZhbHVl KHN1YlRpbWVzW25hbWVdKV19fX07CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICByZXN1bHRz W2JlbmNobWFyay5uYW1lXSA9IHsKICAgICAgICAgICAgICAgICAibWV0cmljcyIgOiB7CkluZGV4 OiBXZWJzaXRlcy9icm93c2VyYmVuY2gub3JnL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJz aXRlcy9icm93c2VyYmVuY2gub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjQzNTU4KQorKysgV2Vi c2l0ZXMvYnJvd3NlcmJlbmNoLm9yZy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAxOS0wMy0yNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKwor ICAgICAgICBKZXRTdHJlYW0gMiBzaG91bGQgbm90IHJlcG9ydCB0aW1lIHZhbHVlcyBhcyBzY29y ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjMz NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSmV0 U3RyZWFtMi4wL0pldFN0cmVhbURyaXZlci5qczoKKyAgICAgICAgKHRvVGltZVZhbHVlKToKKyAg ICAgICAgKERyaXZlci5wcm90b3R5cGUuYXN5bmMucmVwb3J0U2NvcmVUb1J1bkJlbmNobWFya1J1 bm5lcik6CisKIDIwMTktMDMtMjcgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4gRml4IGluZGl2aWR1YWwgYmVuY2htYXJrIGRlc2NyaXB0aW9u IHVybHMgdG8gZ28gdG8gaW4tZGVwdGguaHRtbCBpbnN0ZWFkIG9mIGFib3V0Lmh0bWwKSW5kZXg6 IFdlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcvSmV0U3RyZWFtMi4wL0pldFN0cmVhbURyaXZlci5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9icm93c2VyYmVuY2gub3JnL0pldFN0cmVhbTIuMC9K ZXRTdHJlYW1Ecml2ZXIuanMJKHJldmlzaW9uIDI0MzU1OCkKKysrIFdlYnNpdGVzL2Jyb3dzZXJi ZW5jaC5vcmcvSmV0U3RyZWFtMi4wL0pldFN0cmVhbURyaXZlci5qcwkod29ya2luZyBjb3B5KQpA QCAtODIsNiArODIsMTAgQEAgZnVuY3Rpb24gdG9TY29yZSh0aW1lVmFsdWUpIHsKICAgICByZXR1 cm4gNTAwMCAvIHRpbWVWYWx1ZTsKIH0KIAorZnVuY3Rpb24gdG9UaW1lVmFsdWUoc2NvcmUpIHsK KyAgICByZXR1cm4gNTAwMCAvIHNjb3JlOworfQorCiBmdW5jdGlvbiB1cGRhdGVVSSgpIHsKICAg ICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsKICAgICAgICAgaWYgKGlzSW5Ccm93 c2VyKQpAQCAtMzE5LDcgKzMyMyw3IEBAIGNsYXNzIERyaXZlciB7CiAgICAgICAgICAgICBjb25z dCBzdWJSZXN1bHRzID0ge30KICAgICAgICAgICAgIGNvbnN0IHN1YlRpbWVzID0gYmVuY2htYXJr LnN1YlRpbWVzKCk7CiAgICAgICAgICAgICBmb3IgKGNvbnN0IG5hbWUgaW4gc3ViVGltZXMpIHsK LSAgICAgICAgICAgICAgICBzdWJSZXN1bHRzW25hbWVdID0geyJtZXRyaWNzIjogeyJUaW1lIjog eyJjdXJyZW50IjogW3N1YlRpbWVzW25hbWVdXX19fTsKKyAgICAgICAgICAgICAgICBzdWJSZXN1 bHRzW25hbWVdID0geyJtZXRyaWNzIjogeyJUaW1lIjogeyJjdXJyZW50IjogW3RvVGltZVZhbHVl KHN1YlRpbWVzW25hbWVdKV19fX07CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICByZXN1bHRz W2JlbmNobWFyay5uYW1lXSA9IHsKICAgICAgICAgICAgICAgICAibWV0cmljcyIgOiB7Cg==