196330 2019-03-27 17:16:46 -0700 Overlays on instagram.com are shifted if you click on a photo after scrolling 2019-03-28 09:45:42 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser fred.wang koivisto simon.fraser thorton webkit-bug-importer oldest_to_newest 1521928 0 simon.fraser 2019-03-27 17:16:46 -0700 Go to an instagram page with photos. Scroll down. Click on a photo. The fixed overlay that comes up is offset by your scroll position. 1521930 1 366131 simon.fraser 2019-03-27 17:17:42 -0700 Created attachment 366131 Reduction 1521931 2 simon.fraser 2019-03-27 17:18:51 -0700 rdar://problem/49100304 1521933 3 simon.fraser 2019-03-27 17:20:55 -0700 The site basically does: document.body.style.top = -window.scrollY + 'px'; document.body.style.position = "fixed"; // show fixed overlay so we get a scrolling tree commit that has a new layout viewport (goes from origin 0,scrollTop to 0,0) and a new scrollPosition. In this case, we have to clobber the scrolling thread's notion of scroll position because the document suddenly became non-scrollable, so this has to act like a requestedScrollPosition change. 1521986 4 simon.fraser 2019-03-27 20:07:44 -0700 Ah, this is about the race between the scrolling tree commit and calling ScrollingTree::applyLayerPositions() on the main thread. I might have to have the main thread wait on the commit. 1521993 5 366149 simon.fraser 2019-03-27 21:22:21 -0700 Created attachment 366149 Patch 1522070 6 simon.fraser 2019-03-28 08:04:08 -0700 I'll try to make the attachment into a test case. 1522087 7 simon.fraser 2019-03-28 09:45:42 -0700 Landed with test: https://trac.webkit.org/r243607 366131 2019-03-27 17:17:42 -0700 2019-03-27 17:17:42 -0700 Reduction show-fixed-overlay.html text/html 1605 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4K ICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGlu aXRpYWwtc2NhbGU9MSwgc2hyaW5rLXRvLWZpdD1ubyI+CiAgICA8c3R5bGU+CiAgICAgICAgYm9k eSwgaHRtbCB7CiAgICAgICAgICAgIGhlaWdodDogMTAwJTsKICAgICAgICAgICAgbWFyZ2luOiAw OwogICAgICAgICAgICBmb250LWZhbWlseTogSGVsdmV0aWNhOwogICAgICAgICAgICBmb250LXNp emU6IDI0cHQ7CiAgICAgICAgfQogICAgICAgIGJvZHkgewogICAgICAgICAgICBvdmVyZmxvdy15 OiBzY3JvbGw7CiAgICAgICAgfQogICAgICAgIAogICAgICAgIC5yb290IHsKICAgICAgICAgICAg cG9zaXRpb246IHJlbGF0aXZlOwogICAgICAgICAgICB6LWluZGV4OiAwOwogICAgICAgICAgICBo ZWlnaHQ6IDEwMCU7CiAgICAgICAgfQogICAgICAgIAogICAgICAgIC5zZWN0aW9uIHsKICAgICAg ICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICAgICAgICBoZWlnaHQ6IDIwMDBweDsKICAg ICAgICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKICAgICAgICB9CiAgICAgICAgCiAgICAgICAgYm9k eS5vdmVybGF5ZWQgewogICAgICAgICAgICBwb3NpdGlvbjogZml4ZWQ7CiAgICAgICAgICAgIHdp ZHRoOiAxMDAlOwogICAgICAgIH0KICAgICAgICAKICAgICAgICAjb3ZlcmxheSB7CiAgICAgICAg ICAgIHBvc2l0aW9uOiBmaXhlZDsKICAgICAgICAgICAgei1pbmRleDogMTsKICAgICAgICAgICAg bGVmdDogMDsKICAgICAgICAgICAgdG9wOiAwOwogICAgICAgICAgICByaWdodDogMDsKICAgICAg ICAgICAgaGVpZ2h0OiAyMDBweDsKICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSgw LCAwLCAwLCAwLjUpOwogICAgICAgICAgICBjb2xvcjogd2hpdGU7CiAgICAgICAgICAgIHRleHQt YWxpZ246IGNlbnRlcjsKICAgICAgICB9CiAgICAgICAgCiAgICA8L3N0eWxlPgogICAgPHNjcmlw dD4KICAgICAgICBmdW5jdGlvbiBzaG93T3ZlcmxheSgpCiAgICAgICAgewogICAgICAgICAgICB3 aW5kb3cuc2Nyb2xsVG8oMCwgMjAwKTsKICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7CiAg ICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5LnN0eWxlLnRvcCA9IC13aW5kb3cuc2Nyb2xsWSAr ICdweCc7CiAgICAgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmNsYXNzTGlzdC5hZGQoJ292ZXJs YXllZCcpOwogICAgICAgICAgICB9LCAzNTAwKTsKICAgICAgICB9CiAgICAgICAgCiAgICAgICAg d2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBzaG93T3ZlcmxheSwgZmFsc2UpOwogICAg PC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CiAgICA8ZGl2IGNsYXNzPSJyb290Ij4KICAgICAgICA8 ZGl2IGNsYXNzPSJzZWN0aW9uIj4KICAgICAgICAgICAgPHA+U2Nyb2xsIGRvd24gdGhlbiBjbGlj ayB0aGUgYnV0dG9uLjwvcD4KICAgICAgICA8L2Rpdj4KICAgIDwvZGl2PgoKICAgIDxkaXYgaWQ9 Im92ZXJsYXkiPgogICAgICAgIFRoaXMgaXMgdGhlIG92ZXJsYXkKICAgIDwvZGl2Pgo8L2JvZHk+ CjwvaHRtbD4K 366149 2019-03-27 21:22:21 -0700 2019-03-27 23:05:32 -0700 Patch bug-196330-20190327212220.patch text/plain 8311 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQwYjM5MDA4YWRkN2Mz ZGIzYjJkY2MxYWU2OGI5ODZmMGQyZjlhNC4uN2YxODgyNTY2MmZkMjJhYTQ0YTk4NzQ4ZmI2MjVm MWY1NzcxMTBlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQzIEBACisyMDE5LTAzLTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPUyBXSzJd IE92ZXJsYXlzIG9uIGluc3RhZ3JhbS5jb20gYXJlIHNoaWZ0ZWQgaWYgeW91IGNsaWNrIG9uIGEg cGhvdG8gYWZ0ZXIgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTYzMzAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDkxMDAzMDQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIGNh bGwgU2Nyb2xsaW5nVHJlZTo6YXBwbHlMYXllclBvc2l0aW9ucygpIG9uIHRoZSBtYWluIHRocmVh ZCBhZnRlciBhIGZsdXNoLAorICAgICAgICB3ZSBuZWVkIHRvIGVuc3VyZSB0aGF0IHRoZSBtb3N0 IHJlY2VudCB2ZXJzaW9uIG9mIHRoZSBzY3JvbGxpbmcgdHJlZSBoYXMgYmVlbiBjb21taXR0ZWQs CisgICAgICAgIGJlY2F1c2UgaXQgaGFzIHRvIGhhdmUgc3RhdGUgKGxpa2UgcmVxdWVzdGVkIHNj cm9sbCBwb3NpdGlvbiBhbmQgbGF5b3V0IHZpZXdwb3J0IHJlY3QpCisgICAgICAgIHRoYXQgbWF0 Y2ggdGhlIGxheWVyIGZsdXNoLgorCisgICAgICAgIFRvIGZpeCB0aGlzIHdlIGhhdmUgdG8gaGF2 ZSB0aGUgbWFpbiB0aHJlYWQgd2FpdCBmb3IgdGhlIGNvbW1pdCB0byBjb21wbGV0ZSwgc28KKyAg ICAgICAgVGhyZWFkZWRTY3JvbGxpbmdUcmVlIGtlZXBzIHRyYWNrIG9mIGEgcGVuZGluZyBjb21t aXQgY291bnQsIGFuZCB1c2VzIGEgY29uZGl0aW9uCisgICAgICAgIHZhcmlhYmxlIHRvIGFsbG93 IHRoZSBtYWluIHRocmVhZCB0byBzYWZlbHkgd2FpdCBmb3IgaXQgdG8gcmVhY2ggemVyby4KKwor ICAgICAgICBUcmFjaW5nIHNob3dzIHRoYXQgdGhpcyB3b3JrcyBhcyBleHBlY3RlZCwgYW5kIHRo ZSBtYWluIHRocmVhZCBpcyBuZXZlciBibG9ja2VkIGZvcgorICAgICAgICBtb3JlIHRoYW4gYSBm ZXcgdGVucyBvZiBtaWNyb3NlY29uZHMuCisKKyAgICAgICAgQWxzbyBsb2NrIHRoZSB0cmVlIG11 dGV4IGluIFNjcm9sbGluZ1RyZWU6OmhhbmRsZVdoZWVsRXZlbnQoKSwgc2luY2Ugd2UgZW50ZXIg dGhlCisgICAgICAgIHNjcm9sbGluZyB0cmVlIGhlcmUgYW5kIHdlIGRvbid0IHdhbnQgdGhhdCBy YWNpbmcgd2l0aCBhcHBseUxheWVyUG9zaXRpb25zKCkgb24gdGhlCisgICAgICAgIG1haW4gdGhy ZWFkLgorCisgICAgICAgIEhhcmQgdG8gdGVzdCBiZWNhdXNlIGl0J3MgcmFjZXkuCisKKyAgICAg ICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGluZ1RyZWU6OmhhbmRsZVdoZWVsRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsaW5nVHJlZTo6YXBwbHlMYXllclBvc2l0aW9ucyk6CisgICAgICAgICogcGFnZS9zY3JvbGxp bmcvU2Nyb2xsaW5nVHJlZS5oOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Ny b2xsaW5nVHJlZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaHJlYWRlZFNjcm9sbGluZ1RyZWU6 OmNvbW1pdFRyZWVTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpUaHJlYWRlZFNjcm9sbGluZ1Ry ZWU6OmluY3JlbWVudFBlbmRpbmdDb21taXRDb3VudCk6CisgICAgICAgIChXZWJDb3JlOjpUaHJl YWRlZFNjcm9sbGluZ1RyZWU6OmRlY3JlbWVudFBlbmRpbmdDb21taXRDb3VudCk6CisgICAgICAg IChXZWJDb3JlOjpUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OndhaXRGb3JQZW5kaW5nQ29tbWl0cyk6 CisgICAgICAgIChXZWJDb3JlOjpUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OmFwcGx5TGF5ZXJQb3Np dGlvbnMpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5o OgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5t bToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpjb21taXRUcmVl U3RhdGUpOgorCiAyMDE5LTAzLTI2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1MgV0syXSBwb3NpdGlvbjpmaXhlZCBpbnNpZGUgb3ZlZmxvdzpz Y3JvbGwgaXMganVtcHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ1RyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nVHJlZS5jcHAKaW5kZXggMjk0YzhmMmQ0M2VhNDMwZDJkODEzYTc4N2QzN2Q5YjRkMTUyZDRm OC4uYTlkZDEwZDI3NjA5YTE2NjQ1YTBkODI4NDgxMjcxYzY5MWI0MjZmNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5jcHAKQEAgLTEwMCw2ICsx MDAsNyBAQCBTY3JvbGxpbmdFdmVudFJlc3VsdCBTY3JvbGxpbmdUcmVlOjpoYW5kbGVXaGVlbEV2 ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgdwogICAgIH0KIAogICAgIGlmIChoYXNMYXRj aGVkTm9kZSgpKSB7CisgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fdHJlZU11dGV4KTsKICAg ICAgICAgTE9HX1dJVEhfU1RSRUFNKFNjcm9sbGluZywgc3RyZWFtIDw8ICIgaGFzIGxhdGNoZWQg bm9kZSAiIDw8IGxhdGNoZWROb2RlKCkpOwogICAgICAgICBhdXRvKiBub2RlID0gbm9kZUZvcklE KGxhdGNoZWROb2RlKCkpOwogICAgICAgICBpZiAoaXM8U2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05v ZGU+KG5vZGUpKQpAQCAtMjYwLDkgKzI2MSw5IEBAIHZvaWQgU2Nyb2xsaW5nVHJlZTo6dXBkYXRl VHJlZUZyb21TdGF0ZU5vZGUoY29uc3QgU2Nyb2xsaW5nU3RhdGVOb2RlKiBzdGF0ZU5vZGUsCiAg ICAgbm9kZS0+Y29tbWl0U3RhdGVBZnRlckNoaWxkcmVuKCpzdGF0ZU5vZGUpOwogfQogCi0vLyBD YWxsZWQgZnJvbSB0aGUgbWFpbiB0aHJlYWQuCiB2b2lkIFNjcm9sbGluZ1RyZWU6OmFwcGx5TGF5 ZXJQb3NpdGlvbnMoKQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgTG9ja0hv bGRlciBsb2NrZXIobV90cmVlTXV0ZXgpOwogCiAgICAgaWYgKCFtX3Jvb3ROb2RlKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5oCmluZGV4IGM0ZTIwMzc5 OWNhZTQ4ZDM3MWY5NTViODNlZjc5ZWEzNDg1NjIyOTkuLmI0ZmJkYWZhNTA4ZWIwYmJiNTYwMDU0 ZDYxZTQ3ZTE4YWVmMmRmMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ1RyZWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlLmgKQEAgLTY5LDcgKzY5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBpbnZhbGlkYXRlKCkgeyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIGNvbW1p dFRyZWVTdGF0ZShzdGQ6OnVuaXF1ZV9wdHI8U2Nyb2xsaW5nU3RhdGVUcmVlPik7CiAgICAgCi0g ICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBhcHBseUxheWVyUG9zaXRpb25zKCk7CisgICAgV0VCQ09S RV9FWFBPUlQgdmlydHVhbCB2b2lkIGFwcGx5TGF5ZXJQb3NpdGlvbnMoKTsKIAogICAgIHZpcnR1 YWwgUmVmPFNjcm9sbGluZ1RyZWVOb2RlPiBjcmVhdGVTY3JvbGxpbmdUcmVlTm9kZShTY3JvbGxp bmdOb2RlVHlwZSwgU2Nyb2xsaW5nTm9kZUlEKSA9IDA7CiAgICAgCkBAIC0xNTMsNyArMTUzLDcg QEAgcHVibGljOgogICAgIEhhc2hTZXQ8U2Nyb2xsaW5nTm9kZUlEPiYgcG9zaXRpb25lZE5vZGVz V2l0aFJlbGF0ZWRPdmVyZmxvdygpIHsgcmV0dXJuIG1fcG9zaXRpb25lZE5vZGVzV2l0aFJlbGF0 ZWRPdmVyZmxvdzsgfQogCiAgICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5nIHNjcm9sbGluZ1RyZWVB c1RleHQoU2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0QmVoYXZpb3IgPSBTY3JvbGxpbmdTdGF0ZVRy ZWVBc1RleHRCZWhhdmlvck5vcm1hbCk7Ci0gICAgCisKIHByb3RlY3RlZDoKICAgICB2b2lkIHNl dE1haW5GcmFtZVNjcm9sbFBvc2l0aW9uKEZsb2F0UG9pbnQpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcAppbmRl eCAxZDk1MTJlOTA5MGU3OTNmNmUxM2QyOTFhOTEzZmFhNzRhNWE1ZmYyLi4wZTQ1NWExMTMzODRl MmM3ZGRhNzMwZWI2OGQ0YWIxODg5MGQ3NjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAKQEAgLTg5LDYgKzg5 LDggQEAgdm9pZCBUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OmNvbW1pdFRyZWVTdGF0ZShzdGQ6OnVu aXF1ZV9wdHI8U2Nyb2xsaW5nU3RhdGVUcmVlPgogewogICAgIEFTU0VSVChTY3JvbGxpbmdUaHJl YWQ6OmlzQ3VycmVudFRocmVhZCgpKTsKICAgICBTY3JvbGxpbmdUcmVlOjpjb21taXRUcmVlU3Rh dGUoV1RGTW92ZShzY3JvbGxpbmdTdGF0ZVRyZWUpKTsKKyAgICAKKyAgICBkZWNyZW1lbnRQZW5k aW5nQ29tbWl0Q291bnQoKTsKIH0KIAogdm9pZCBUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OnNjcm9s bGluZ1RyZWVOb2RlRGlkU2Nyb2xsKFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlJiBub2RlLCBT Y3JvbGxpbmdMYXllclBvc2l0aW9uQWN0aW9uIHNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb24p CkBAIC0xMjQsNiArMTI2LDM1IEBAIHZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpyZXBvcnRF eHBvc2VkVW5maWxsZWRBcmVhKE1vbm90b25pY1RpbWUgdGltZXN0YW1wLCB1CiAgICAgfSk7CiB9 CiAKK3ZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjppbmNyZW1lbnRQZW5kaW5nQ29tbWl0Q291 bnQoKQoreworICAgIExvY2tIb2xkZXIgY29tbWl0TG9ja2VyKG1fcGVuZGluZ0NvbW1pdENvdW50 TXV0ZXgpOworICAgICsrbV9wZW5kaW5nQ29tbWl0Q291bnQ7Cit9CisKK3ZvaWQgVGhyZWFkZWRT Y3JvbGxpbmdUcmVlOjpkZWNyZW1lbnRQZW5kaW5nQ29tbWl0Q291bnQoKQoreworICAgIExvY2tI b2xkZXIgY29tbWl0TG9ja2VyKG1fcGVuZGluZ0NvbW1pdENvdW50TXV0ZXgpOworICAgIEFTU0VS VChtX3BlbmRpbmdDb21taXRDb3VudCA+IDApOworICAgIGlmICghLS1tX3BlbmRpbmdDb21taXRD b3VudCkKKyAgICAgICAgbV9jb21taXRDb25kaXRpb24ubm90aWZ5T25lKCk7Cit9CisKK3ZvaWQg VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjp3YWl0Rm9yUGVuZGluZ0NvbW1pdHMoKQoreworICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSk7CisKKyAgICBMb2NrSG9sZGVyIGNvbW1pdExvY2tlcihtX3Bl bmRpbmdDb21taXRDb3VudE11dGV4KTsKKyAgICB3aGlsZSAobV9wZW5kaW5nQ29tbWl0Q291bnQp CisgICAgICAgIG1fY29tbWl0Q29uZGl0aW9uLndhaXQobV9wZW5kaW5nQ29tbWl0Q291bnRNdXRl eCk7Cit9CisKK3ZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjphcHBseUxheWVyUG9zaXRpb25z KCkKK3sKKyAgICB3YWl0Rm9yUGVuZGluZ0NvbW1pdHMoKTsKKyAgICBTY3JvbGxpbmdUcmVlOjph cHBseUxheWVyUG9zaXRpb25zKCk7Cit9CisKICNpZiBQTEFURk9STShDT0NPQSkKIHZvaWQgVGhy ZWFkZWRTY3JvbGxpbmdUcmVlOjpjdXJyZW50U25hcFBvaW50SW5kaWNlc0RpZENoYW5nZShTY3Jv bGxpbmdOb2RlSUQgbm9kZUlELCB1bnNpZ25lZCBob3Jpem9udGFsLCB1bnNpZ25lZCB2ZXJ0aWNh bCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVk U2Nyb2xsaW5nVHJlZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRT Y3JvbGxpbmdUcmVlLmgKaW5kZXggZGNjYWZjNGEyNDkxZDU1NDc3MWQ2NDY3MzM3MzQ5MDcxNmYw MzRiNS4uZTMyYWM1YWIxYmM4M2MxOTBhNDEwMTA0MWY5MzFiMDFkNjI4MzY5ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVl LmgKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2luY2x1ZGUgIlNjcm9sbGluZ1N0YXRlVHJlZS5oIgog I2luY2x1ZGUgIlNjcm9sbGluZ1RyZWUuaCIKKyNpbmNsdWRlIDx3dGYvQ29uZGl0aW9uLmg+CiAj aW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01NCw2ICs1 NSw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgaW52YWxpZGF0ZSgpIG92ZXJyaWRlOwogCisgICAg dm9pZCBpbmNyZW1lbnRQZW5kaW5nQ29tbWl0Q291bnQoKTsKKyAgICB2b2lkIGRlY3JlbWVudFBl bmRpbmdDb21taXRDb3VudCgpOworCiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGljaXQgVGhyZWFkZWRT Y3JvbGxpbmdUcmVlKEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3ImKTsKIApAQCAtNzQsOCArNzgs MTUgQEAgcHJvdGVjdGVkOgogCiBwcml2YXRlOgogICAgIGJvb2wgaXNUaHJlYWRlZFNjcm9sbGlu Z1RyZWUoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CisgICAgdm9pZCBhcHBseUxh eWVyUG9zaXRpb25zKCkgb3ZlcnJpZGU7CiAKICAgICBSZWZQdHI8QXN5bmNTY3JvbGxpbmdDb29y ZGluYXRvcj4gbV9zY3JvbGxpbmdDb29yZGluYXRvcjsKKworICAgIHZvaWQgd2FpdEZvclBlbmRp bmdDb21taXRzKCk7CisKKyAgICBMb2NrIG1fcGVuZGluZ0NvbW1pdENvdW50TXV0ZXg7CisgICAg dW5zaWduZWQgbV9wZW5kaW5nQ29tbWl0Q291bnQgeyAwIH07CisgICAgQ29uZGl0aW9uIG1fY29t bWl0Q29uZGl0aW9uOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5h dG9yTWFjLm1tCmluZGV4IGQxNTdjZWI5NjMxNDNmODc4ZTgxYmJhYTUwMjQ3NGQwNzM3YzdkZGQu LjNjYzJkYzBhNWRhNTUzODJhNGU0MzQ5NzRkZTI0YjQ0MTk5ZWI5NmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRp bmF0b3JNYWMubW0KQEAgLTEyMiw2ICsxMjIsOCBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9y TWFjOjpjb21taXRUcmVlU3RhdGUoKQogICAgIFJlZlB0cjxUaHJlYWRlZFNjcm9sbGluZ1RyZWU+ IHRocmVhZGVkU2Nyb2xsaW5nVHJlZSA9IGRvd25jYXN0PFRocmVhZGVkU2Nyb2xsaW5nVHJlZT4o c2Nyb2xsaW5nVHJlZSgpKTsKICAgICBTY3JvbGxpbmdTdGF0ZVRyZWUqIHVucHJvdGVjdGVkVHJl ZVN0YXRlID0gc2Nyb2xsaW5nU3RhdGVUcmVlKCktPmNvbW1pdChMYXllclJlcHJlc2VudGF0aW9u OjpQbGF0Zm9ybUxheWVyUmVwcmVzZW50YXRpb24pLnJlbGVhc2UoKTsKIAorICAgIHRocmVhZGVk U2Nyb2xsaW5nVHJlZS0+aW5jcmVtZW50UGVuZGluZ0NvbW1pdENvdW50KCk7CisKICAgICBTY3Jv bGxpbmdUaHJlYWQ6OmRpc3BhdGNoKFt0aHJlYWRlZFNjcm9sbGluZ1RyZWUsIHVucHJvdGVjdGVk VHJlZVN0YXRlXSB7CiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxTY3JvbGxpbmdTdGF0ZVRyZWU+ IHRyZWVTdGF0ZSh1bnByb3RlY3RlZFRyZWVTdGF0ZSk7CiAgICAgICAgIHRocmVhZGVkU2Nyb2xs aW5nVHJlZS0+Y29tbWl0VHJlZVN0YXRlKFdURk1vdmUodHJlZVN0YXRlKSk7Cg==