196319 2019-03-27 14:47:20 -0700 IDBRequest::dispatchEvent should check nullability of m_transaction before operations that rely on it to be non null 2019-03-28 14:26:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 196276 1 jiewen_tan jiewen_tan achristensen alecflett beidson ews-watchlist ggaren jiewen_tan jsbell webkit-bug-importer oldest_to_newest 1521853 0 jiewen_tan 2019-03-27 14:47:20 -0700 IDBRequest::dispatchEvent should check nullability of m_transaction before operations that rely on it to be non null. 1521863 1 webkit-bug-importer 2019-03-27 15:08:26 -0700 <rdar://problem/49355279> 1521934 2 366133 jiewen_tan 2019-03-27 17:33:13 -0700 Created attachment 366133 Patch 1522207 3 366133 achristensen 2019-03-28 14:13:43 -0700 Comment on attachment 366133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366133&action=review > Source/WebCore/ChangeLog:9 > + No change of behavior. Make a note of where the test is that found this. 1522208 4 366133 jiewen_tan 2019-03-28 14:16:36 -0700 Comment on attachment 366133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366133&action=review Thanks, Alex. >> Source/WebCore/ChangeLog:9 >> + No change of behavior. > > Make a note of where the test is that found this. Done. 1522213 5 jiewen_tan 2019-03-28 14:26:47 -0700 Committed r243622: <https://trac.webkit.org/changeset/243622> 366133 2019-03-27 17:33:13 -0700 2019-03-28 14:13:43 -0700 Patch bug-196319-20190327173312.patch text/plain 2673 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJlMzk1NjRkZTJjNWQz OTQ0NzA1ZjMwMjg4YjczN2E5NzZiY2NiZS4uNDAyYjNkYzgzMmE4ODQ2YjNmNWZiM2E0NzYwYTk0 ZjM2MjgwYWUwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTI3ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSURCUmVxdWVzdDo6ZGlz cGF0Y2hFdmVudCBzaG91bGQgY2hlY2sgbnVsbGFiaWxpdHkgb2YgbV90cmFuc2FjdGlvbiBiZWZv cmUgb3BlcmF0aW9ucyB0aGF0IHJlbHkgb24gaXQgdG8gYmUgbm9uIG51bGwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjMxOQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDkzNTUyNzk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorCisgICAgICAgICogTW9kdWxl cy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJSZXF1ZXN0 OjpkaXNwYXRjaEV2ZW50KToKKwogMjAxOS0wMy0yNiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWlk QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIFNWRyB0ZWFyIG9mZiBvYmplY3RzIGZv ciBTVkdMZW5ndGgsIFNWR0xlbmd0aExpc3QgYW5kIFNWR0FuaW1hdGVkTGVuZ3RoTGlzdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcAppbmRleCA0 NmJlNWUxNmViNDVlZDMyMDIwNWIyYjFmMTgyZGY5ZDRiZGRhYmJiLi5hYjdmMTU4NmQ4ZmNlMGU1 MGNhZDJjZDQ2MTM3ZmQyOGEzMmRhODcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcApAQCAtMzMwLDIxICszMzAsMjIgQEAgdm9pZCBJREJS ZXF1ZXN0OjpkaXNwYXRjaEV2ZW50KEV2ZW50JiBldmVudCkKICAgICBpZiAoIW1faGFzUGVuZGlu Z0FjdGl2aXR5KQogICAgICAgICBtX2hhc1BlbmRpbmdBY3Rpdml0eSA9IGlzT3BlbkRCUmVxdWVz dCgpICYmIChldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLnVwZ3JhZGVuZWVkZWRFdmVudCB8 fCBldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLmJsb2NrZWRFdmVudCk7CiAKKyAgICBtX2Rp c3BhdGNoaW5nRXZlbnQgPSBmYWxzZTsKKyAgICBpZiAoIW1fdHJhbnNhY3Rpb24pCisgICAgICAg IHJldHVybjsKKwogICAgIC8vIFRoZSByZXF1ZXN0IHNob3VsZCBvbmx5IHJlbWFpbiBpbiB0aGUg dHJhbnNhY3Rpb24ncyByZXF1ZXN0IGxpc3QgaWYgaXQgcmVwcmVzZW50cyBhIHBlbmRpbmcgY3Vy c29yIG9wZXJhdGlvbiwgb3IgdGhpcyBpcyBhbiBvcGVuIHJlcXVlc3QgdGhhdCB3YXMgYmxvY2tl ZC4KLSAgICBpZiAobV90cmFuc2FjdGlvbiAmJiAhbV9wZW5kaW5nQ3Vyc29yICYmIGV2ZW50LnR5 cGUoKSAhPSBldmVudE5hbWVzKCkuYmxvY2tlZEV2ZW50KQorICAgIGlmICghbV9wZW5kaW5nQ3Vy c29yICYmIGV2ZW50LnR5cGUoKSAhPSBldmVudE5hbWVzKCkuYmxvY2tlZEV2ZW50KQogICAgICAg ICBtX3RyYW5zYWN0aW9uLT5yZW1vdmVSZXF1ZXN0KCp0aGlzKTsKIAogICAgIGlmIChtX2hhc1Vu Y2F1Z2h0RXhjZXB0aW9uKQogICAgICAgICBtX3RyYW5zYWN0aW9uLT5hYm9ydER1ZVRvRmFpbGVk UmVxdWVzdChET01FeGNlcHRpb246OmNyZWF0ZShBYm9ydEVycm9yLCAiSURCVHJhbnNhY3Rpb24g d2lsbCBhYm9ydCBkdWUgdG8gdW5jYXVnaHQgZXhjZXB0aW9uIGluIGFuIGV2ZW50IGhhbmRsZXIi X3MpKTsKLSAgICBlbHNlIGlmICghZXZlbnQuZGVmYXVsdFByZXZlbnRlZCgpICYmIGV2ZW50LnR5 cGUoKSA9PSBldmVudE5hbWVzKCkuZXJyb3JFdmVudCAmJiBtX3RyYW5zYWN0aW9uICYmICFtX3Ry YW5zYWN0aW9uLT5pc0ZpbmlzaGVkT3JGaW5pc2hpbmcoKSkgeworICAgIGVsc2UgaWYgKCFldmVu dC5kZWZhdWx0UHJldmVudGVkKCkgJiYgZXZlbnQudHlwZSgpID09IGV2ZW50TmFtZXMoKS5lcnJv ckV2ZW50ICYmICFtX3RyYW5zYWN0aW9uLT5pc0ZpbmlzaGVkT3JGaW5pc2hpbmcoKSkgewogICAg ICAgICBBU1NFUlQobV9kb21FcnJvcik7CiAgICAgICAgIG1fdHJhbnNhY3Rpb24tPmFib3J0RHVl VG9GYWlsZWRSZXF1ZXN0KCptX2RvbUVycm9yKTsKICAgICB9CiAKLSAgICBpZiAobV90cmFuc2Fj dGlvbikKLSAgICAgICAgbV90cmFuc2FjdGlvbi0+ZmluaXNoZWREaXNwYXRjaEV2ZW50Rm9yUmVx dWVzdCgqdGhpcyk7Ci0KLSAgICBtX2Rpc3BhdGNoaW5nRXZlbnQgPSBmYWxzZTsKKyAgICBtX3Ry YW5zYWN0aW9uLT5maW5pc2hlZERpc3BhdGNoRXZlbnRGb3JSZXF1ZXN0KCp0aGlzKTsKIH0KIAog dm9pZCBJREJSZXF1ZXN0Ojp1bmNhdWdodEV4Y2VwdGlvbkluRXZlbnRIYW5kbGVyKCkK