196313 2019-03-27 13:29:03 -0700 validateOSREntryValue with Int52 should box the value being checked into double format 2019-03-27 18:06:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1521806 0 saam 2019-03-27 13:29:03 -0700 ... 1521809 1 saam 2019-03-27 13:32:33 -0700 <rdar://problem/49306703> 1521810 2 366099 saam 2019-03-27 13:36:23 -0700 Created attachment 366099 patch 1521812 3 366099 ysuzuki 2019-03-27 13:39:30 -0700 Comment on attachment 366099 patch View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review r=me > Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217 > // Constant AnyInt value is stored as usual boxed value in AbstractValue. We can change this comment like, Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG. > Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219 > format = FlushedInt52; > + value = jsDoubleNumber(value.asAnyInt()); You can exchange these two lines to align them to the code for FlushedDouble case. 1521814 4 366099 saam 2019-03-27 13:41:28 -0700 Comment on attachment 366099 patch View in context: https://bugs.webkit.org/attachment.cgi?id=366099&action=review >> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:217 >> // Constant AnyInt value is stored as usual boxed value in AbstractValue. > > We can change this comment like, > > Constant AnyInt value is represented as SpecAnyIntAsDouble value in DFG. This isn't always the case because you have strict and not strict. I'm going to just remove the comment. >> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:219 >> + value = jsDoubleNumber(value.asAnyInt()); > > You can exchange these two lines to align them to the code for FlushedDouble case. Sounds good. 1521816 5 366100 saam 2019-03-27 13:42:44 -0700 Created attachment 366100 patch for landing 1521946 6 366100 commit-queue 2019-03-27 18:06:07 -0700 Comment on attachment 366100 patch for landing Clearing flags on attachment: 366100 Committed r243596: <https://trac.webkit.org/changeset/243596> 1521947 7 commit-queue 2019-03-27 18:06:09 -0700 All reviewed patches have been landed. Closing bug. 366099 2019-03-27 13:36:23 -0700 2019-03-27 13:42:44 -0700 patch a-backup.diff text/plain 3175 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDM1NjEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIHZhbGlkYXRlT1NSRW50cnlWYWx1ZSB3aXRoIEludDUyIHNob3VsZCBi b3ggdGhlIHZhbHVlIGJlaW5nIGNoZWNrZWQgaW50byBkb3VibGUgZm9ybWF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzMTMKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ5MzA2NzAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3RyZXNzL3ZhbGlkYXRlLWludC01Mi1haS1zdGF0ZS5qczogQWRk ZWQuCisKIDIwMTktMDMtMjcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbSlNDXSBPd25lciBvZiB3YXRjaHBvaW50cyBzaG91bGQgdmFsaWRhdGUgYXQgR0Mg ZmluYWxpemluZyBwaGFzZQpJbmRleDogSlNUZXN0cy9zdHJlc3MvdmFsaWRhdGUtaW50LTUyLWFp LXN0YXRlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3ZhbGlkYXRlLWludC01Mi1h aS1zdGF0ZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1pbnQt NTItYWktc3RhdGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1IEBACisvL0AgcnVuRGVm YXVsdCgiLS12YWxpZGF0ZUFic3RyYWN0SW50ZXJwcmV0ZXJTdGF0ZT0xIikKKworZm9yICh2YXIg aSA9IDA7IGkgPCAxMDAwMDAwMDsgKytpKSB7CisgICAgZmlhdEludDUyKDAuMCkKK30KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQzNTYxKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5 LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIHZhbGlk YXRlT1NSRW50cnlWYWx1ZSB3aXRoIEludDUyIHNob3VsZCBib3ggdGhlIHZhbHVlIGJlaW5nIGNo ZWNrZWQgaW50byBkb3VibGUgZm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTYzMTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MzA2NzAz PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZn L0RGR09TUkVudHJ5LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpwcmVwYXJlT1NSRW50cnkpOgor ICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvQjMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkRG Rzo6TG93ZXJERkdUb0IzOjp2YWxpZGF0ZUFJU3RhdGUpOgorCiAyMDE5LTAzLTI3ICBZdXN1a2Ug U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gT3duZXIgb2Ygd2F0 Y2hwb2ludHMgc2hvdWxkIHZhbGlkYXRlIGF0IEdDIGZpbmFsaXppbmcgcGhhc2UKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCShyZXZpc2lvbiAyNDM1NTgp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjE2LDYgKzIxNiw3IEBAIHZvaWQqIHByZXBhcmVPU1JFbnRyeShFeGVjU3RhdGUq IGV4ZWMsIEMKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIC8vIENvbnN0YW50IEFueUludCB2 YWx1ZSBpcyBzdG9yZWQgYXMgdXN1YWwgYm94ZWQgdmFsdWUgaW4gQWJzdHJhY3RWYWx1ZS4KICAg ICAgICAgICAgIGZvcm1hdCA9IEZsdXNoZWRJbnQ1MjsKKyAgICAgICAgICAgIHZhbHVlID0ganNE b3VibGVOdW1iZXIodmFsdWUuYXNBbnlJbnQoKSk7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAo ZW50cnktPm1fbG9jYWxzRm9yY2VkRG91YmxlLmdldChsb2NhbCkpIHsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHJldmlzaW9uIDI0MzU1 OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjQ5LDYgKzY0OSwxMCBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGR1bXBBbmRDcmFzaCgpOwogICAgICAgICAgICAgICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgICAgICAgICAgICAgaW5wdXQgPSBKU1ZhbHVlOjpkZWNvZGUoY29udGV4 dC5ncHIocmVnKSk7IAorICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGZsdXNoRm9ybWF0ID09 IEZsdXNoZWRJbnQ1MikgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIFJFTEVBU0VfQVNT RVJUKGlucHV0LmlzQW55SW50KCkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlucHV0 ID0ganNEb3VibGVOdW1iZXIoaW5wdXQuYXNBbnlJbnQoKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIXZhbHVlLnZhbGlkYXRlT1NSRW50 cnlWYWx1ZShpbnB1dCwgZmx1c2hGb3JtYXQpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg IGR1bXBBbmRDcmFzaCgpOwogICAgICAgICAgICAgICAgICAgICB9Cg== 366100 2019-03-27 13:42:44 -0700 2019-03-27 18:06:07 -0700 patch for landing a-backup.diff text/plain 3189 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDM1NjEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIHZhbGlkYXRlT1NSRW50cnlWYWx1ZSB3aXRoIEludDUyIHNob3VsZCBi b3ggdGhlIHZhbHVlIGJlaW5nIGNoZWNrZWQgaW50byBkb3VibGUgZm9ybWF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzMTMKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ5MzA2NzAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1 a2kuCisKKyAgICAgICAgKiBzdHJlc3MvdmFsaWRhdGUtaW50LTUyLWFpLXN0YXRlLmpzOiBBZGRl ZC4KKwogMjAxOS0wMy0yNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAg ICAgICAgIFtKU0NdIE93bmVyIG9mIHdhdGNocG9pbnRzIHNob3VsZCB2YWxpZGF0ZSBhdCBHQyBm aW5hbGl6aW5nIHBoYXNlCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1pbnQtNTItYWkt c3RhdGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvdmFsaWRhdGUtaW50LTUyLWFp LXN0YXRlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3ZhbGlkYXRlLWludC01 Mi1haS1zdGF0ZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKKy8vQCBydW5EZWZh dWx0KCItLXZhbGlkYXRlQWJzdHJhY3RJbnRlcnByZXRlclN0YXRlPTEiKQorCitmb3IgKHZhciBp ID0gMDsgaSA8IDEwMDAwMDAwOyArK2kpIHsKKyAgICBmaWF0SW50NTIoMC4wKQorfQpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM1NjEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTkt MDMtMjcgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgdmFsaWRh dGVPU1JFbnRyeVZhbHVlIHdpdGggSW50NTIgc2hvdWxkIGJveCB0aGUgdmFsdWUgYmVpbmcgY2hl Y2tlZCBpbnRvIGRvdWJsZSBmb3JtYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NjMxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkzMDY3MDM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICAqIGRmZy9E RkdPU1JFbnRyeS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6cHJlcGFyZU9TUkVudHJ5KToKKyAg ICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0IzLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6 Okxvd2VyREZHVG9CMzo6dmFsaWRhdGVBSVN0YXRlKToKKwogMjAxOS0wMy0yNyAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIE93bmVyIG9mIHdhdGNo cG9pbnRzIHNob3VsZCB2YWxpZGF0ZSBhdCBHQyBmaW5hbGl6aW5nIHBoYXNlCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5LmNwcAkocmV2aXNpb24gMjQzNTU4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFbnRyeS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIxNCw3ICsyMTQsNyBAQCB2b2lkKiBwcmVwYXJlT1NSRW50cnkoRXhlY1N0YXRlKiBl eGVjLCBDCiAgICAgICAgICAgICAgICAgICAgICJtYWNoaW5lIGludC4iKTsKICAgICAgICAgICAg ICAgICByZXR1cm4gbnVsbHB0cjsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIC8vIENvbnN0 YW50IEFueUludCB2YWx1ZSBpcyBzdG9yZWQgYXMgdXN1YWwgYm94ZWQgdmFsdWUgaW4gQWJzdHJh Y3RWYWx1ZS4KKyAgICAgICAgICAgIHZhbHVlID0ganNEb3VibGVOdW1iZXIodmFsdWUuYXNBbnlJ bnQoKSk7CiAgICAgICAgICAgICBmb3JtYXQgPSBGbHVzaGVkSW50NTI7CiAgICAgICAgIH0KIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAko cmV2aXNpb24gMjQzNTU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRG R1RvQjMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDksNiArNjQ5LDEwIEBAIHByaXZhdGU6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZHVtcEFuZENyYXNoKCk7CiAgICAgICAgICAgICAg ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBpbnB1dCA9IEpTVmFsdWU6 OmRlY29kZShjb250ZXh0LmdwcihyZWcpKTsgCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAo Zmx1c2hGb3JtYXQgPT0gRmx1c2hlZEludDUyKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgUkVMRUFTRV9BU1NFUlQoaW5wdXQuaXNBbnlJbnQoKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW5wdXQgPSBqc0RvdWJsZU51bWJlcihpbnB1dC5hc0FueUludCgpKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghdmFsdWUu dmFsaWRhdGVPU1JFbnRyeVZhbHVlKGlucHV0LCBmbHVzaEZvcm1hdCkpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZHVtcEFuZENyYXNoKCk7CiAgICAgICAgICAgICAgICAgICAgIH0K