196301 2019-03-27 09:51:54 -0700 AVAudioSessionRouteSharingPolicyLongForm has been deprecated 2019-03-27 11:23:36 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson eric.carlson ews-watchlist ryanhaddad webkit-bug-importer oldest_to_newest 1521712 0 eric.carlson 2019-03-27 09:51:54 -0700 AVAudioSessionRouteSharingPolicyLongForm has been deprecated 1521714 1 eric.carlson 2019-03-27 09:52:08 -0700 <rdar://problem/49286833> 1521719 2 366077 eric.carlson 2019-03-27 10:02:28 -0700 Created attachment 366077 Patch 1521720 3 ews-watchlist 2019-03-27 10:05:01 -0700 Attachment 366077 did not pass style-queue: ERROR: Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:126: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1521756 4 366077 ryanhaddad 2019-03-27 11:23:31 -0700 Comment on attachment 366077 Patch I took care of this in https://trac.webkit.org/r243552 366077 2019-03-27 10:02:28 -0700 2019-03-27 11:23:31 -0700 Patch route-sharing-policy-deprecation-patch.txt text/plain 2388 eric.carlson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTYyODYzODA0Yi4uZDdhOGU5NWRjZTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMy0yNyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxl LmNvbT4KKworICAgICAgICBBVkF1ZGlvU2Vzc2lvblJvdXRlU2hhcmluZ1BvbGljeUxvbmdGb3Jt IGhhcyBiZWVuIGRlcHJlY2F0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NjMwMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkyODY4MzM+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9hdWRpby9pb3MvQXVkaW9TZXNzaW9uSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9T ZXNzaW9uOjpzZXRDYXRlZ29yeSk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1Nlc3Npb246OnJv dXRlU2hhcmluZ1BvbGljeSBjb25zdCk6CisKIDIwMTktMDMtMjUgIFJvYiBCdWlzICA8cmJ1aXNA aWdhbGlhLmNvbT4KIAogICAgICAgICBSZWZsZWN0IEhUTUxMaW5rRWxlbWVudC5hcyBhY2NvcmRp bmcgdG8gdGhlIHNwZWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L2lvcy9BdWRpb1Nlc3Npb25JT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9p b3MvQXVkaW9TZXNzaW9uSU9TLm1tCmluZGV4IGRkNjVkYWU4NjAyLi4xMzBlNTBmNDZiMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9zL0F1ZGlvU2Vzc2lvbklP Uy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9pb3MvQXVkaW9TZXNzaW9u SU9TLm1tCkBAIC0xMjMsNyArMTIzLDkgQEAgdm9pZCBBdWRpb1Nlc3Npb246OnNldENhdGVnb3J5 KENhdGVnb3J5VHlwZSBuZXdDYXRlZ29yeSkKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBNZWRp YVBsYXliYWNrOgogICAgICAgICBjYXRlZ29yeVN0cmluZyA9IEFWQXVkaW9TZXNzaW9uQ2F0ZWdv cnlQbGF5YmFjazsKK0FMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0JFR0lOCiAgICAgICAg IHBvbGljeSA9IEFWQXVkaW9TZXNzaW9uUm91dGVTaGFyaW5nUG9saWN5TG9uZ0Zvcm07CitBTExP V19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBS ZWNvcmRBdWRpbzoKICAgICAgICAgY2F0ZWdvcnlTdHJpbmcgPSBBVkF1ZGlvU2Vzc2lvbkNhdGVn b3J5UmVjb3JkOwpAQCAtMTY5LDcgKzE3MSw5IEBAIEF1ZGlvU2Vzc2lvbjo6Q2F0ZWdvcnlUeXBl IEF1ZGlvU2Vzc2lvbjo6Y2F0ZWdvcnkoKSBjb25zdAogUm91dGVTaGFyaW5nUG9saWN5IEF1ZGlv U2Vzc2lvbjo6cm91dGVTaGFyaW5nUG9saWN5KCkgY29uc3QKIHsKICAgICBzdGF0aWNfYXNzZXJ0 KHN0YXRpY19jYXN0PHNpemVfdD4oUm91dGVTaGFyaW5nUG9saWN5OjpEZWZhdWx0KSA9PSBzdGF0 aWNfY2FzdDxzaXplX3Q+KEFWQXVkaW9TZXNzaW9uUm91dGVTaGFyaW5nUG9saWN5RGVmYXVsdCks ICJSb3V0ZVNoYXJpbmdQb2xpY3k6OkRlZmF1bHQgaXMgbm90IEFWQXVkaW9TZXNzaW9uUm91dGVT aGFyaW5nUG9saWN5RGVmYXVsdCBhcyBleHBlY3RlZCIpOworQUxMT1dfREVQUkVDQVRFRF9ERUNM QVJBVElPTlNfQkVHSU4KICAgICBzdGF0aWNfYXNzZXJ0KHN0YXRpY19jYXN0PHNpemVfdD4oUm91 dGVTaGFyaW5nUG9saWN5OjpMb25nRm9ybSkgPT0gc3RhdGljX2Nhc3Q8c2l6ZV90PihBVkF1ZGlv U2Vzc2lvblJvdXRlU2hhcmluZ1BvbGljeUxvbmdGb3JtKSwgIlJvdXRlU2hhcmluZ1BvbGljeTo6 TG9uZ0Zvcm0gaXMgbm90IEFWQXVkaW9TZXNzaW9uUm91dGVTaGFyaW5nUG9saWN5TG9uZ0Zvcm0g YXMgZXhwZWN0ZWQiKTsKK0FMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAogICAgIHN0 YXRpY19hc3NlcnQoc3RhdGljX2Nhc3Q8c2l6ZV90PihSb3V0ZVNoYXJpbmdQb2xpY3k6OkluZGVw ZW5kZW50KSA9PSBzdGF0aWNfY2FzdDxzaXplX3Q+KEFWQXVkaW9TZXNzaW9uUm91dGVTaGFyaW5n UG9saWN5SW5kZXBlbmRlbnQpLCAiUm91dGVTaGFyaW5nUG9saWN5OjpJbmRlcGVuZGVudCBpcyBu b3QgQVZBdWRpb1Nlc3Npb25Sb3V0ZVNoYXJpbmdQb2xpY3lJbmRlcGVuZGVudCBhcyBleHBlY3Rl ZCIpOwogCiAgICAgQVZBdWRpb1Nlc3Npb25Sb3V0ZVNoYXJpbmdQb2xpY3kgcG9saWN5ID0gW1tB VkF1ZGlvU2Vzc2lvbiBzaGFyZWRJbnN0YW5jZV0gcm91dGVTaGFyaW5nUG9saWN5XTsK