196278 2019-03-26 16:36:27 -0700 [ContentChangeObserver] Always dispatch the synthetic click asynchronously 2019-03-27 12:41:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1521519 0 zalan 2019-03-26 16:36:27 -0700 unless content change observation is turned off. 1521520 1 webkit-bug-importer 2019-03-26 16:36:54 -0700 <rdar://problem/49299968> 1521525 2 366023 zalan 2019-03-26 16:49:35 -0700 Created attachment 366023 Patch 1521788 3 366023 commit-queue 2019-03-27 12:41:28 -0700 Comment on attachment 366023 Patch Clearing flags on attachment: 366023 Committed r243557: <https://trac.webkit.org/changeset/243557> 1521789 4 commit-queue 2019-03-27 12:41:30 -0700 All reviewed patches have been landed. Closing bug. 366023 2019-03-26 16:49:35 -0700 2019-03-27 12:41:28 -0700 Patch bug-196278-20190326164932.patch text/plain 6245 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlMGYzNjIyYzUyYjNlYWE5 NjI0NDIyOWIyNmUxMWJlYTE1N2I3NDYuLmNkYzNjNGQxY2RmOTgyMzgyYTY0ZDgzM2NiMGY3NWI2 ZDQwZjJjYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMjYgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29udGVudENoYW5nZU9ic2VydmVy XSBBbHdheXMgZGlzcGF0Y2ggdGhlIHN5bnRoZXRpYyBjbGljayBhc3luY2hyb25vdXNseQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2Mjc4CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80OTI5OTk2OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuc3VyZXMgdGhhdCBhbGwgY29tcGxl dGVTeW50aGV0aWNDbGljaygpIGNhbGxzIGhhcHBlbiBpbiBhbiBhc3luY2hyb25vdXMgbWFubmVy ICh1bmxlc3MgdGhlIGZlYXR1cmUgaXMgdHVybmVkIG9mZikuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OmRpc3BhdGNo U3ludGhldGljTW91c2VNb3ZlKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6aGFuZGxlU3lu dGhldGljQ2xpY2spOgorCiAyMDE5LTAzLTI2ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBhc3luYyBwYXN0ZSBtZXRob2Qgb24gVUlX S0ludGVyYWN0aW9uVmlld1Byb3RvY29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDBkZDUwOWRhOGFkYzM4Y2EyNzBkYTQ1 NTNjMzE0NGI4NTVhYTJhODcuLmRmOGRkYzkzM2U5Njk0NWEwOTAzNTc3OGVmN2VkY2UzYjU5NzFm N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCkBAIC01NjEsMTcgKzU2MSwyMiBAQCBzdGF0aWMgdm9pZCBkaXNwYXRjaFN5bnRo ZXRpY01vdXNlTW92ZShGcmFtZSYgbWFpbkZyYW1lLCBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaQog ICAgIGF1dG8gYWx0S2V5ID0gbW9kaWZpZXJzLmNvbnRhaW5zKFdlYkV2ZW50OjpNb2RpZmllcjo6 QWx0S2V5KTsKICAgICBhdXRvIG1ldGFLZXkgPSBtb2RpZmllcnMuY29udGFpbnMoV2ViRXZlbnQ6 Ok1vZGlmaWVyOjpNZXRhS2V5KTsKICAgICBhdXRvIG1vdXNlRXZlbnQgPSBQbGF0Zm9ybU1vdXNl RXZlbnQocm91bmRlZEFkanVzdGVkUG9pbnQsIHJvdW5kZWRBZGp1c3RlZFBvaW50LCBOb0J1dHRv biwgUGxhdGZvcm1FdmVudDo6TW91c2VNb3ZlZCwgMCwgc2hpZnRLZXksIGN0cmxLZXksIGFsdEtl eSwgbWV0YUtleSwgV2FsbFRpbWU6Om5vdygpLCBXZWJDb3JlOjpGb3JjZUF0Q2xpY2ssIFdlYkNv cmU6Ok5vVGFwKTsKKyAgICAvLyBGSVhNRTogUGFzcyBjYXBzIGxvY2sgc3RhdGUuCiAgICAgbWFp bkZyYW1lLmV2ZW50SGFuZGxlcigpLmRpc3BhdGNoU3ludGhldGljTW91c2VNb3ZlKG1vdXNlRXZl bnQpOwogfQogCiB2b2lkIFdlYlBhZ2U6OmhhbmRsZVN5bnRoZXRpY0NsaWNrKE5vZGUmIG5vZGVS ZXNwb25kaW5nVG9DbGljaywgY29uc3QgV2ViQ29yZTo6RmxvYXRQb2ludCYgbG9jYXRpb24sIE9w dGlvblNldDxXZWJFdmVudDo6TW9kaWZpZXI+IG1vZGlmaWVycykKIHsKKyAgICBpZiAoIW5vZGVS ZXNwb25kaW5nVG9DbGljay5kb2N1bWVudCgpLnNldHRpbmdzKCkuY29udGVudENoYW5nZU9ic2Vy dmVyRW5hYmxlZCgpKSB7CisgICAgICAgIGNvbXBsZXRlU3ludGhldGljQ2xpY2sobm9kZVJlc3Bv bmRpbmdUb0NsaWNrLCBsb2NhdGlvbiwgbW9kaWZpZXJzLCBXZWJDb3JlOjpPbmVGaW5nZXJUYXAp OworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgYXV0byYgcmVzcG9uZGluZ0RvY3VtZW50 ID0gbm9kZVJlc3BvbmRpbmdUb0NsaWNrLmRvY3VtZW50KCk7Ci0gICAgYXV0byYgbWFpbkZyYW1l ID0gbV9wYWdlLT5tYWluRnJhbWUoKTsKLSAgICAvLyBGSVhNRTogUGFzcyBjYXBzIGxvY2sgc3Rh dGUuCiAgICAgewogICAgICAgICBMT0dfV0lUSF9TVFJFQU0oQ29udGVudE9ic2VydmF0aW9uLCBz dHJlYW0gPDwgImhhbmRsZVN5bnRoZXRpY0NsaWNrOiBub2RlKCIgPDwgJm5vZGVSZXNwb25kaW5n VG9DbGljayA8PCAiKSAiIDw8IGxvY2F0aW9uKTsKICAgICAgICAgQ29udGVudENoYW5nZU9ic2Vy dmVyOjpNb3VzZU1vdmVkU2NvcGUgb2JzZXJ2aW5nU2NvcGUocmVzcG9uZGluZ0RvY3VtZW50KTsK KyAgICAgICAgYXV0byYgbWFpbkZyYW1lID0gbV9wYWdlLT5tYWluRnJhbWUoKTsKICAgICAgICAg ZGlzcGF0Y2hTeW50aGV0aWNNb3VzZU1vdmUobWFpbkZyYW1lLCBsb2NhdGlvbiwgbW9kaWZpZXJz KTsKICAgICAgICAgbWFpbkZyYW1lLmRvY3VtZW50KCktPnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsK ICAgICB9CkBAIC01NzksMzIgKzU4NCwzNCBAQCB2b2lkIFdlYlBhZ2U6OmhhbmRsZVN5bnRoZXRp Y0NsaWNrKE5vZGUmIG5vZGVSZXNwb25kaW5nVG9DbGljaywgY29uc3QgV2ViQ29yZTo6RgogICAg IGlmIChtX2lzQ2xvc2VkKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoaXM8SFRNTEZvcm1D b250cm9sRWxlbWVudD4obm9kZVJlc3BvbmRpbmdUb0NsaWNrKSkgewotICAgICAgICBMT0coQ29u dGVudE9ic2VydmF0aW9uLCAiaGFuZGxlU3ludGhldGljQ2xpY2s6IFRhcmdldCBub2RlIGlzIGEg Zm9ybSBjb250cm9sIC0+IGNsaWNrLiIpOwotICAgICAgICBjb21wbGV0ZVN5bnRoZXRpY0NsaWNr KG5vZGVSZXNwb25kaW5nVG9DbGljaywgbG9jYXRpb24sIG1vZGlmaWVycywgV2ViQ29yZTo6T25l RmluZ2VyVGFwKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KICAgICBhdXRvJiBjb250ZW50Q2hh bmdlT2JzZXJ2ZXIgPSByZXNwb25kaW5nRG9jdW1lbnQuY29udGVudENoYW5nZU9ic2VydmVyKCk7 CiAgICAgYXV0byBvYnNlcnZlZENvbnRlbnRDaGFuZ2UgPSBjb250ZW50Q2hhbmdlT2JzZXJ2ZXIu b2JzZXJ2ZWRDb250ZW50Q2hhbmdlKCk7Ci0gICAgaWYgKG9ic2VydmVkQ29udGVudENoYW5nZSA9 PSBXS0NvbnRlbnRWaXNpYmlsaXR5Q2hhbmdlKSB7Ci0gICAgICAgIC8vIFRoZSBtb3ZlIGV2ZW50 IGNhdXNlZCBuZXcgY29udGVudHMgdG8gYXBwZWFyLiBEb24ndCBzZW5kIHRoZSBjbGljayBldmVu dCwgYnV0IGp1c3QgZW5zdXJlIHRoYXQgdGhlIG1vdXNlIGlzIG9uIHRoZSBtb3N0IHJlY2VudCBj b250ZW50LgotICAgICAgICBkaXNwYXRjaFN5bnRoZXRpY01vdXNlTW92ZShtYWluRnJhbWUsIGxv Y2F0aW9uLCBtb2RpZmllcnMpOwotICAgICAgICBMT0coQ29udGVudE9ic2VydmF0aW9uLCAiaGFu ZGxlU3ludGhldGljQ2xpY2s6IE9ic2VydmVkIG1lYW5pbmdmdWwgdmlzaWJsZSBjaGFuZ2UgLT4g aG92ZXIuIik7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgY29uc3QgU2Vjb25kcyBvYnNl cnZhdGlvbkR1cmF0aW9uID0gMzJfbXM7Ci0gICAgY29udGVudENoYW5nZU9ic2VydmVyLnN0YXJ0 Q29udGVudE9ic2VydmF0aW9uRm9yRHVyYXRpb24ob2JzZXJ2YXRpb25EdXJhdGlvbik7Ci0gICAg aWYgKGNvbnRlbnRDaGFuZ2VPYnNlcnZlci5vYnNlcnZlZENvbnRlbnRDaGFuZ2UoKSA9PSBXS0Nv bnRlbnROb0NoYW5nZSkgewotICAgICAgICBBU1NFUlQoIXJlc3BvbmRpbmdEb2N1bWVudC5zZXR0 aW5ncygpLmNvbnRlbnRDaGFuZ2VPYnNlcnZlckVuYWJsZWQoKSk7Ci0gICAgICAgIGNvbXBsZXRl U3ludGhldGljQ2xpY2sobm9kZVJlc3BvbmRpbmdUb0NsaWNrLCBsb2NhdGlvbiwgbW9kaWZpZXJz LCBXZWJDb3JlOjpPbmVGaW5nZXJUYXApOworCisgICAgYXV0byBjb250aW51ZUNvbnRlbnRPYnNl cnZhdGlvbiA9ICEob2JzZXJ2ZWRDb250ZW50Q2hhbmdlID09IFdLQ29udGVudFZpc2liaWxpdHlD aGFuZ2UgfHwgaXM8SFRNTEZvcm1Db250cm9sRWxlbWVudD4obm9kZVJlc3BvbmRpbmdUb0NsaWNr KSk7CisgICAgaWYgKGNvbnRpbnVlQ29udGVudE9ic2VydmF0aW9uKSB7CisgICAgICAgIC8vIFdh aXQgZm9yIGNhbGxiYWNrIHRvIGNvbXBsZXRlUGVuZGluZ1N5bnRoZXRpY0NsaWNrRm9yQ29udGVu dENoYW5nZU9ic2VydmVyKCkgdG8gZGVjaWRlIHdoZXRoZXIgdG8gc2VuZCB0aGUgY2xpY2sgZXZl bnQuCisgICAgICAgIGNvbnN0IFNlY29uZHMgb2JzZXJ2YXRpb25EdXJhdGlvbiA9IDMyX21zOwor ICAgICAgICBjb250ZW50Q2hhbmdlT2JzZXJ2ZXIuc3RhcnRDb250ZW50T2JzZXJ2YXRpb25Gb3JE dXJhdGlvbihvYnNlcnZhdGlvbkR1cmF0aW9uKTsKKyAgICAgICAgTE9HKENvbnRlbnRPYnNlcnZh dGlvbiwgImhhbmRsZVN5bnRoZXRpY0NsaWNrOiBDYW4ndCBkZWNpZGUgaXQgeWV0IC0+IHdhaXQu Iik7CisgICAgICAgIG1fcGVuZGluZ1N5bnRoZXRpY0NsaWNrTm9kZSA9ICZub2RlUmVzcG9uZGlu Z1RvQ2xpY2s7CisgICAgICAgIG1fcGVuZGluZ1N5bnRoZXRpY0NsaWNrTG9jYXRpb24gPSBsb2Nh dGlvbjsKKyAgICAgICAgbV9wZW5kaW5nU3ludGhldGljQ2xpY2tNb2RpZmllcnMgPSBtb2RpZmll cnM7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBMT0coQ29udGVudE9ic2VydmF0aW9u LCAiaGFuZGxlU3ludGhldGljQ2xpY2s6IENhbid0IGRlY2lkZSBpdCB5ZXQgLT4gd2FpdC4iKTsK LSAgICAvLyBXYWl0IGZvciBjYWxsYmFjayB0byBjb21wbGV0ZVBlbmRpbmdTeW50aGV0aWNDbGlj a0ZvckNvbnRlbnRDaGFuZ2VPYnNlcnZlcigpIHRvIGRlY2lkZSB3aGV0aGVyIHRvIHNlbmQgdGhl IGNsaWNrIGV2ZW50LgotICAgIG1fcGVuZGluZ1N5bnRoZXRpY0NsaWNrTm9kZSA9ICZub2RlUmVz cG9uZGluZ1RvQ2xpY2s7Ci0gICAgbV9wZW5kaW5nU3ludGhldGljQ2xpY2tMb2NhdGlvbiA9IGxv Y2F0aW9uOwotICAgIG1fcGVuZGluZ1N5bnRoZXRpY0NsaWNrTW9kaWZpZXJzID0gbW9kaWZpZXJz OworICAgIGNhbGxPbk1haW5UaHJlYWQoW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmUHRyKHRoaXMp LCB0YXJnZXROb2RlID0gUmVmPE5vZGU+KG5vZGVSZXNwb25kaW5nVG9DbGljayksIGxvY2F0aW9u LCBtb2RpZmllcnMsIG9ic2VydmVkQ29udGVudENoYW5nZV0geworICAgICAgICBpZiAocHJvdGVj dGVkVGhpcy0+bV9pc0Nsb3NlZCB8fCAhcHJvdGVjdGVkVGhpcy0+Y29yZVBhZ2UoKSkKKyAgICAg ICAgICAgIHJldHVybjsKKworICAgICAgICBpZiAob2JzZXJ2ZWRDb250ZW50Q2hhbmdlID09IFdL Q29udGVudFZpc2liaWxpdHlDaGFuZ2UpIHsKKyAgICAgICAgICAgIC8vIFRoZSBtb3ZlIGV2ZW50 IGNhdXNlZCBuZXcgY29udGVudHMgdG8gYXBwZWFyLiBEb24ndCBzZW5kIHN5bnRoZXRpYyBjbGlj ayBldmVudCwgYnV0IGp1c3QgZW5zdXJlIHRoYXQgdGhlIG1vdXNlIGlzIG9uIHRoZSBtb3N0IHJl Y2VudCBjb250ZW50LgorICAgICAgICAgICAgZGlzcGF0Y2hTeW50aGV0aWNNb3VzZU1vdmUocHJv dGVjdGVkVGhpcy0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCksIGxvY2F0aW9uLCBtb2RpZmllcnMp OworICAgICAgICAgICAgTE9HKENvbnRlbnRPYnNlcnZhdGlvbiwgImhhbmRsZVN5bnRoZXRpY0Ns aWNrOiBPYnNlcnZlZCBtZWFuaW5nZnVsIHZpc2libGUgY2hhbmdlIC0+IGhvdmVyLiIpOworICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIExPRyhDb250ZW50T2JzZXJ2YXRp b24sICJoYW5kbGVTeW50aGV0aWNDbGljazogY2FsbGluZyBjb21wbGV0ZVN5bnRoZXRpY0NsaWNr IC0+IGNsaWNrLiIpOworICAgICAgICBwcm90ZWN0ZWRUaGlzLT5jb21wbGV0ZVN5bnRoZXRpY0Ns aWNrKHRhcmdldE5vZGUsIGxvY2F0aW9uLCBtb2RpZmllcnMsIFdlYkNvcmU6Ok9uZUZpbmdlclRh cCk7CisgICAgfSk7CiB9CiAKIHZvaWQgV2ViUGFnZTo6Y29tcGxldGVQZW5kaW5nU3ludGhldGlj Q2xpY2tGb3JDb250ZW50Q2hhbmdlT2JzZXJ2ZXIoKQo=