196271 2019-03-26 13:54:24 -0700 Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node 2019-04-01 15:35:57 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1521434 0 hi 2019-03-26 13:54:24 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Elements tab 3. select any node 4. go to the Console tab 5. log `{foo: $0}` 6. expand the resulting object 7. context menu click on the value of `foo` (e.g. the node) => "Copy as HTML", "Scroll Into View", and "Reveal in DOM Tree" all appear twice 1521439 1 webkit-bug-importer 2019-03-26 14:06:07 -0700 <rdar://problem/49290676> 1521441 2 365997 hi 2019-03-26 14:13:07 -0700 Created attachment 365997 Patch 1523099 3 365997 commit-queue 2019-04-01 15:35:56 -0700 Comment on attachment 365997 Patch Clearing flags on attachment: 365997 Committed r243717: <https://trac.webkit.org/changeset/243717> 1523100 4 commit-queue 2019-04-01 15:35:57 -0700 All reviewed patches have been landed. Closing bug. 365997 2019-03-26 14:13:07 -0700 2019-04-01 15:35:56 -0700 Patch 196271.diff text/plain 3089 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk3YzI3N2YwZjY0Li44MmU1ZDcyNWNhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDMtMjYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6ICJD b3B5IGFzIEhUTUwiIGFwcGVhcnMgdHdpY2Ugd2hlbiBzaG93aW5nIGEgY29udGV4dCBtZW51IGZv ciBhIGxvZ2dlZCBub2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTYyNzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MjkwNjc2PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV0kuT2JqZWN0 VHJlZUJhc2VUcmVlRWxlbWVudC5wcm90b3R5cGUuX2FwcGVuZE1lbnVzSXRlbXNGb3JPYmplY3Qp OgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz OgorCiAyMDE5LTAzLTI2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBTb3VyY2VzOiBmaXggdHlwbyBpbiBDU1Mgc2VsZWN0b3IgdG8g YWx3YXlzIHNob3cgYWRkIGJyZWFrcG9pbnQgYnV0dG9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3Ry aW5ncy5qcwppbmRleCA2ZTE1M2IxNWMwZS4uMDc1ODgyMDkzNDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3Mu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9j YWxpemVkU3RyaW5ncy5qcwpAQCAtMjgzLDcgKzI4Myw2IEBAIGxvY2FsaXplZFN0cmluZ3NbIkNv cHkgUGF0aCB0byBQcm9wZXJ0eSJdID0gIkNvcHkgUGF0aCB0byBQcm9wZXJ0eSI7CiBsb2NhbGl6 ZWRTdHJpbmdzWyJDb3B5IFJvdyJdID0gIkNvcHkgUm93IjsKIGxvY2FsaXplZFN0cmluZ3NbIkNv cHkgU2VsZWN0ZWQiXSA9ICJDb3B5IFNlbGVjdGVkIjsKIGxvY2FsaXplZFN0cmluZ3NbIkNvcHkg VGFibGUiXSA9ICJDb3B5IFRhYmxlIjsKLWxvY2FsaXplZFN0cmluZ3NbIkNvcHkgYXMgSFRNTCJd ID0gIkNvcHkgYXMgSFRNTCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDb3B5IGFzIGNVUkwiXSA9ICJD b3B5IGFzIGNVUkwiOwogbG9jYWxpemVkU3RyaW5nc1siQ291bGQgbm90IGZldGNoIHByb3BlcnRp ZXMuIE9iamVjdCBtYXkgbm8gbG9uZ2VyIGV4aXN0LiJdID0gIkNvdWxkIG5vdCBmZXRjaCBwcm9w ZXJ0aWVzLiBPYmplY3QgbWF5IG5vIGxvbmdlciBleGlzdC4iOwogbG9jYWxpemVkU3RyaW5nc1si Q291bnQiXSA9ICJDb3VudCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVu dC5qcwppbmRleCA3ZjkxZjRjNjQwNy4uYzM2ZDQ0ZjYyMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVCYXNlVHJlZUVsZW1l bnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2Jq ZWN0VHJlZUJhc2VUcmVlRWxlbWVudC5qcwpAQCAtMjQyLDI3ICsyNDIsNSBAQCBXSS5PYmplY3RU cmVlQmFzZVRyZWVFbGVtZW50ID0gY2xhc3MgT2JqZWN0VHJlZUJhc2VUcmVlRWxlbWVudCBleHRl bmRzIFdJLkdlbmVyYQogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICB9Ci0KLSAgICAgICAgaWYgKHJlc29sdmVkVmFsdWUuc3VidHlwZSA9PT0gIm5vZGUiKSB7Ci0g ICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJDb3B5IGFzIEhU TUwiKSwgZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAgcmVzb2x2ZWRWYWx1ZS5wdXNoTm9k ZVRvRnJvbnRlbmQoZnVuY3Rpb24obm9kZUlkKSB7Ci0gICAgICAgICAgICAgICAgICAgIFdJLmRv bU1hbmFnZXIubm9kZUZvcklkKG5vZGVJZCkuY29weU5vZGUoKTsKLSAgICAgICAgICAgICAgICB9 KTsKLSAgICAgICAgICAgIH0pOwotCi0gICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVt KFdJLlVJU3RyaW5nKCJTY3JvbGwgSW50byBWaWV3IiksIGZ1bmN0aW9uKCkgewotICAgICAgICAg ICAgICAgIGZ1bmN0aW9uIHNjcm9sbEludG9WaWV3KCkgeyB0aGlzLnNjcm9sbEludG9WaWV3SWZO ZWVkZWQodHJ1ZSk7IH0KLSAgICAgICAgICAgICAgICByZXNvbHZlZFZhbHVlLmNhbGxGdW5jdGlv bihzY3JvbGxJbnRvVmlldywgdW5kZWZpbmVkLCBmYWxzZSwgZnVuY3Rpb24oKSB7fSk7Ci0gICAg ICAgICAgICB9KTsKLQotICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7 Ci0KLSAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIlJldmVh bCBpbiBET00gVHJlZSIpLCBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICByZXNvbHZlZFZh bHVlLnB1c2hOb2RlVG9Gcm9udGVuZChmdW5jdGlvbihub2RlSWQpIHsKLSAgICAgICAgICAgICAg ICAgICAgV0kuZG9tTWFuYWdlci5pbnNwZWN0RWxlbWVudChub2RlSWQpOwotICAgICAgICAgICAg ICAgIH0pOwotICAgICAgICAgICAgfSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0K ICAgICB9CiB9Owo=