196268 2019-03-26 13:27:16 -0700 Inhibit CFNetwork logging in private sessions 2019-04-03 21:16:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist saam webkit-bug-importer oldest_to_newest 1521418 0 krollin 2019-03-26 13:27:16 -0700 Before performing any logging, the NetworkProcess checks to see if it's performing an operation associated with a private (ephemeral) browsing session. If so, it skips all logging. However, networking layers below the NetworkProcess don't know about private browsing, so they would still perform their own logging. CFNetwork now has a flag that lets us control that, so set it to False if private browsing. 1521419 1 krollin 2019-03-26 13:27:25 -0700 <rdar://problem/48210793> 1521421 2 365993 krollin 2019-03-26 13:29:31 -0700 Created attachment 365993 Patch 1521517 3 365993 commit-queue 2019-03-26 16:29:18 -0700 Comment on attachment 365993 Patch Clearing flags on attachment: 365993 Committed r243524: <https://trac.webkit.org/changeset/243524> 1521518 4 commit-queue 2019-03-26 16:29:20 -0700 All reviewed patches have been landed. Closing bug. 1521573 5 365993 ap 2019-03-26 18:12:52 -0700 Comment on attachment 365993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365993&action=review > Source/WTF/wtf/Platform.h:1529 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000) It should be PLATFORM(IOS) in the second clause, not IOS_FAMILY. 1521625 6 krollin 2019-03-26 22:51:09 -0700 Ugh. OK. So when should IOS vs. IOS_FAMILY be used? I was modeling my conditional on the one a few lines above: #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) #define HAVE_SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_PID 1 #endif 1523129 7 krollin 2019-04-01 16:40:57 -0700 Re-opened to address Alexey's comment. 1523132 8 366442 krollin 2019-04-01 16:44:42 -0700 Created attachment 366442 Patch 1523349 9 366442 commit-queue 2019-04-02 10:46:13 -0700 Comment on attachment 366442 Patch Clearing flags on attachment: 366442 Committed r243747: <https://trac.webkit.org/changeset/243747> 1523350 10 commit-queue 2019-04-02 10:46:14 -0700 All reviewed patches have been landed. Closing bug. 1524084 11 saam 2019-04-03 17:52:25 -0700 (In reply to Keith Rollin from comment #0) > Before performing any logging, the NetworkProcess checks to see if it's > performing an operation associated with a private (ephemeral) browsing > session. If so, it skips all logging. However, networking layers below the > NetworkProcess don't know about private browsing, so they would still > perform their own logging. CFNetwork now has a flag that lets us control > that, so set it to False if private browsing. Why just in private browsing? I think we should always turn this logging off. 1524157 12 krollin 2019-04-03 21:16:54 -0700 That logging is priceless in tracking down networking issues. Why do you think it should be removed unconditionally? 365993 2019-03-26 13:29:31 -0700 2019-04-01 16:44:40 -0700 Patch bug-196268-20190326132930.patch text/plain 3796 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZkMTJmZjYxNmUzYjg2NWJlMTM3ZDI2 ODVhMDEyYWRiN2E2MmFiNzcuLjUwZWE4MDM1ZjMxZTU3MzBiNmRjYmNlNmQ4NWE5ZmRmODY2NGE1 YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDMtMjYgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEluaGliaXQgQ0ZOZXR3b3JrIGxvZ2dpbmcgaW4gcHJp dmF0ZSBzZXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2MjY4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODIxMDc5Mz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZWZvcmUgcGVyZm9ybWlu ZyBhbnkgbG9nZ2luZywgdGhlIE5ldHdvcmtQcm9jZXNzIGNoZWNrcyB0byBzZWUgaWYKKyAgICAg ICAgaXQncyBwZXJmb3JtaW5nIGFuIG9wZXJhdGlvbiBhc3NvY2lhdGVkIHdpdGggYSBwcml2YXRl IChlcGhlbWVyYWwpCisgICAgICAgIGJyb3dzaW5nIHNlc3Npb24uIElmIHNvLCBpdCBza2lwcyB0 aGUgbG9nZ2luZy4gSG93ZXZlciwgbmV0d29ya2luZworICAgICAgICBsYXllcnMgYmVsb3cgdGhl IE5ldHdvcmtQcm9jZXNzIGRvbid0IGtub3cgYWJvdXQgcHJpdmF0ZSBicm93c2luZywgc28KKyAg ICAgICAgdGhleSB3b3VsZCBzdGlsbCBwZXJmb3JtIHRoZWlyIG93biBsb2dnaW5nLiBDRk5ldHdv cmsgbm93IGhhcyBhIGZsYWcKKyAgICAgICAgdGhhdCBsZXRzIHVzIGNvbnRyb2wgdGhhdCwgc28g c2V0IGl0IHRvIEZhbHNlIGlmIHByaXZhdGUgYnJvd3NpbmcuCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAxOS0wMy0yNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmb3Jnb3QgdG8gcmVmYWN0b3IgdmFyaWFibGUg bmFtZSBmb3Igd2luZG93cyBidWlsZCBpbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAwN2EyMWVkNTlmYzk0YjI1NmU1 NGZhMjYxNzMwOTU3ZGNlMTZkZDhiLi4wNDc0NmU4MWExNzU4Y2EwZmNkOWViNDk2OTU3MzAyMTEx NzgyMzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAzLTI2ICBLZWl0aCBSb2xs aW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBJbmhpYml0IENGTmV0d29yayBsb2dn aW5nIGluIHByaXZhdGUgc2Vzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NjI2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDgyMTA3OTM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3Jl IHBlcmZvcm1pbmcgYW55IGxvZ2dpbmcsIHRoZSBOZXR3b3JrUHJvY2VzcyBjaGVja3MgdG8gc2Vl IGlmCisgICAgICAgIGl0J3MgcGVyZm9ybWluZyBhbiBvcGVyYXRpb24gYXNzb2NpYXRlZCB3aXRo IGEgcHJpdmF0ZSAoZXBoZW1lcmFsKQorICAgICAgICBicm93c2luZyBzZXNzaW9uLiBJZiBzbywg aXQgc2tpcHMgdGhlIGxvZ2dpbmcuIEhvd2V2ZXIsIG5ldHdvcmtpbmcKKyAgICAgICAgbGF5ZXJz IGJlbG93IHRoZSBOZXR3b3JrUHJvY2VzcyBkb24ndCBrbm93IGFib3V0IHByaXZhdGUgYnJvd3Np bmcsIHNvCisgICAgICAgIHRoZXkgd291bGQgc3RpbGwgcGVyZm9ybSB0aGVpciBvd24gbG9nZ2lu Zy4gQ0ZOZXR3b3JrIG5vdyBoYXMgYSBmbGFnCisgICAgICAgIHRoYXQgbGV0cyB1cyBjb250cm9s IHRoYXQsIHNvIHNldCBpdCB0byBGYWxzZSBpZiBwcml2YXRlIGJyb3dzaW5nLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbToKKyAgICAgICAg KFdlYktpdDo6Y29uZmlndXJhdGlvbkZvclNlc3Npb25JRCk6CisKIDIwMTktMDMtMjUgIFBhdHJp Y2sgR3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBS ZW1vdmUgbmV0d29yayBhY2Nlc3MgZnJvbSB3ZWIgcHJvY2VzcyBzYW5kYm94CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApp bmRleCAzNmMwZjY3MDVkNzRlMzNlMmM5MjA4MzQzM2U2OWQ2YjE3ZDkyNDk3Li5iM2EyMzMwYTA3 NWQ4MmVlNmUyZmNiZDJhZjViNDhmZGIxNzU1ZjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTE1MjUsMyAr MTUyNSw3IEBACiAjaWYgUExBVEZPUk0oSU9TTUFDKQogI2RlZmluZSBFTkFCTEVfUExBVEZPUk1f RFJJVkVOX1RFWFRfQ0hFQ0tJTkcgMQogI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oTUFDKSAmJiBf X01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMCkgfHwgKFBMQVRGT1JNKElP U19GQU1JTFkpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDAwMCkg fHwgKFBMQVRGT1JNKFdBVENIT1MpICYmIF9fV0FUQ0hfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQg Pj0gNjAwMDApIHx8IChQTEFURk9STShBUFBMRVRWKSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEzMDAwMCkKKyNkZWZpbmUgSEFWRV9BTExPV1NfU0VOU0lUSVZFX0xPR0dJTkcg MQorI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29h L05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2Nv Y29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KaW5kZXggZjU3MzFmZTkxYjBjNzIwMWM4MTZhNTM0 ODVjNTg1NDY4MTdiMDJjZi4uYmYyZDA0NjExZDY1ZTBjM2I2MTc4YjFkNmE2ZmIyMWE0ZDlmM2Vi ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3Jr U2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAtODAwLDYgKzgwMCw5IEBAIHN0YXRpYyBOU1VSTFNl c3Npb25Db25maWd1cmF0aW9uICpjb25maWd1cmF0aW9uRm9yU2Vzc2lvbklEKGNvbnN0IFBBTDo6 U2Vzc2lvbklECiAgICAgaWYgKHNlc3Npb24uaXNFcGhlbWVyYWwoKSkgewogICAgICAgICBOU1VS TFNlc3Npb25Db25maWd1cmF0aW9uICpjb25maWd1cmF0aW9uID0gW05TVVJMU2Vzc2lvbkNvbmZp Z3VyYXRpb24gZXBoZW1lcmFsU2Vzc2lvbkNvbmZpZ3VyYXRpb25dOwogICAgICAgICBjb25maWd1 cmF0aW9uLl9zaG91bGRTa2lwUHJlZmVycmVkQ2xpZW50Q2VydGlmaWNhdGVMb29rdXAgPSBZRVM7 CisjaWYgSEFWRShBTExPV1NfU0VOU0lUSVZFX0xPR0dJTkcpCisgICAgICAgIGNvbmZpZ3VyYXRp b24uX2FsbG93c1NlbnNpdGl2ZUxvZ2dpbmcgPSBOTzsKKyNlbmRpZgogICAgICAgICByZXR1cm4g Y29uZmlndXJhdGlvbjsKICAgICB9CiAgICAgcmV0dXJuIFtOU1VSTFNlc3Npb25Db25maWd1cmF0 aW9uIGRlZmF1bHRTZXNzaW9uQ29uZmlndXJhdGlvbl07Cg== 366442 2019-04-01 16:44:42 -0700 2019-04-02 10:46:13 -0700 Patch bug-196268-20190401164441.patch text/plain 1724 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBkYzM1NzIwMmQ3ZTI3ODc0NjUxODli YjY1M2RjMWI0OTk2NmRiMzYuLmUyNWY4Yjc5NzM1ZjJiOTJiZTg2MjgyYmE2ODA5NTY0MDdhODg3 NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMDEgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEluaGliaXQgQ0ZOZXR3b3JrIGxvZ2dpbmcgaW4gcHJp dmF0ZSBzZXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2MjY4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODIxMDc5Mz4KKworICAgICAg ICBGaXggYSBjb25kaXRpb25hbCBpbiBQbGF0Zm9ybS5oIHdoZXJlIElPUyBzaG91bGQgaGF2ZSBi ZWVuIHVzZWQKKyAgICAgICAgaW5zdGVhZCBvZiBJT1NfRkFNSUxZLiBUaGUgbGF0dGVyIGhhcHBl bmVkIHRvIHdvcmssIGJ1dCB3ZSByZWFsbHkgd2FudAorICAgICAgICB0byBiZSB1c2luZyB0aGUg cHJvcGVyIHN5bWJvbCBoZXJlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTktMDQtMDEgIE1pY2hhZWwgQ2F0 YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFN0b3AgdHJ5aW5nIHRv IHN1cHBvcnQgYnVpbGRpbmcgSlNDIHdpdGggY2xhbmcgMy44CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBhN2Mz YTNhMzVlNjJhNWJhMTg2NTQwZTMwMWU1ODJhYjAwMWNlODUxLi5hNzAyYWI2NWI0ZDU3NDkyNzQ1 MDY5MGJlZTJlMmJkNzBjNmRlMjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTE1MjYsNiArMTUyNiw2IEBA CiAjZGVmaW5lIEVOQUJMRV9QTEFURk9STV9EUklWRU5fVEVYVF9DSEVDS0lORyAxCiAjZW5kaWYK IAotI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQg Pj0gMTAxNTAwKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8fCAoUExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRD SF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA2MDAwMCkgfHwgKFBMQVRGT1JNKEFQUExFVFYp ICYmIF9fVFZfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKQorI2lmIChQTEFURk9S TShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwKSB8fCAo UExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAw MDApIHx8IChQTEFURk9STShXQVRDSE9TKSAmJiBfX1dBVENIX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEID49IDYwMDAwKSB8fCAoUExBVEZPUk0oQVBQTEVUVikgJiYgX19UVl9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMzAwMDApCiAjZGVmaW5lIEhBVkVfQUxMT1dTX1NFTlNJVElWRV9MT0dH SU5HIDEKICNlbmRpZgo=