196260 2019-03-26 10:41:08 -0700 [ews] Reset simctl states on reboot 2019-03-26 16:22:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue lforschler webkit-bug-importer oldest_to_newest 1521346 0 jbedard 2019-03-26 10:41:08 -0700 It's possible for simctl to get in a pretty rotten state, especially if folks change infrastructure code in a patch. On reboot, we should do everything we can to reset simctl to a pristine state. 1521364 1 365976 jbedard 2019-03-26 11:23:45 -0700 Created attachment 365976 Patch 1521374 2 365976 aakash_jain 2019-03-26 11:46:45 -0700 Comment on attachment 365976 Patch rs=me 1521408 3 365990 jbedard 2019-03-26 13:01:24 -0700 Created attachment 365990 Patch for landing 1521426 4 365990 commit-queue 2019-03-26 13:42:04 -0700 Comment on attachment 365990 Patch for landing Clearing flags on attachment: 365990 Committed r243516: <https://trac.webkit.org/changeset/243516> 1521427 5 commit-queue 2019-03-26 13:42:06 -0700 All reviewed patches have been landed. Closing bug. 1521432 6 webkit-bug-importer 2019-03-26 13:51:09 -0700 <rdar://problem/49289644> 1521445 7 365990 ap 2019-03-26 14:17:55 -0700 Comment on attachment 365990 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=365990&action=review > Tools/EWSTools/start-queue-mac.sh:68 > +/usr/bin/sudo /usr/bin/killall -9 com.apple.CoreSimulator.CoreSimulatorServer > +/usr/bin/xcrun simctl delete unavailable How did you choose this order of operations? If CoreSimulatorServer is restarted automatically, then we would probably want to restart it after the state is clean, not before. Although there would be races either way I think. 1521509 8 365990 jbedard 2019-03-26 16:22:09 -0700 Comment on attachment 365990 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=365990&action=review >> Tools/EWSTools/start-queue-mac.sh:68 >> +/usr/bin/xcrun simctl delete unavailable > > How did you choose this order of operations? > > If CoreSimulatorServer is restarted automatically, then we would probably want to restart it after the state is clean, not before. Although there would be races either way I think. First we need to remove any corrupted devices (to do this, we remove all devices) Second, we need to force the CoreSimulatorServer to recognize our deletions (because it won't immediately) Last, we should remove any remaining devices that simctl thinks it has available, but aren't. This last step isn't strictly necessary to fix the problem which prompted this bug, but it's something we should have been doing in the first place. The trouble is, 'xcrun simctl delete unavailable' will fail if it tries to delete devices corrupted in a certain way. 365976 2019-03-26 11:23:45 -0700 2019-03-26 13:01:23 -0700 Patch bug-196260-20190326112345.patch text/plain 1161 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBSZXNldCBzaW1jdGwgc3RhdGVzIG9uIHJlYm9vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MjYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBFV1NUb29scy9zdGFy dC1xdWV1ZS1tYWMuc2g6CisKIDIwMTktMDMtMjYgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYnVpbGRdIFVzZSBQb3N0Z3JlU1FMIGZvciBld3Mt YnVpbGQgZGF0YWJhc2UKSW5kZXg6IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLW1hYy5zaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS1tYWMuc2gJKHJldmlzaW9u IDI0MzUwOCkKKysrIFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLW1hYy5zaAkod29ya2luZyBj b3B5KQpAQCAtNjEsNiArNjEsMTIgQEAgaWYgWyAtcyAkUVVFVUVfTkFNRS5sb2cgXTsgdGhlbgog ICAgICAgICBtdiAtZiAkUVVFVUVfTkFNRS5sb2cgJHtRVUVVRV9OQU1FfV8kKGRhdGUgKyVZLSVt LSVkXyVILSVtKS5sb2cKICAgICBmaQogZmkKKworIyBGaXgtdXAgcm90dGVuIFNpbXVsYXRvciBz dGF0ZQorL2Jpbi9ybSAtcmYgfi9MaWJyYXJ5L0RldmVsb3Blci9Db3JlU2ltdWxhdG9yL0Rldmlj ZXMvKgorL3Vzci9iaW4vc3VkbyAvdXNyL2Jpbi9raWxsYWxsIC05IGNvbS5hcHBsZS5Db3JlU2lt dWxhdG9yLkNvcmVTaW11bGF0b3JTZXJ2ZXIKKy91c3IvYmluL3hjcnVuIHNpbWN0bCBkZWxldGUg dW5hdmFpbGFibGUKKwogY2QgJFdFQktJVF9IT01FCiAKICMgRGVsZXRlIFdlYktpdEJ1aWxkIHRv IGZvcmNlIGEgY2xlYW4gYnVpbGQK 365990 2019-03-26 13:01:24 -0700 2019-03-26 13:42:04 -0700 Patch for landing bug-196260-20190326130124.patch text/plain 1164 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBSZXNldCBzaW1jdGwgc3RhdGVzIG9uIHJlYm9vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MjYwCisKKyAgICAg ICAgUnViYmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBFV1NUb29scy9z dGFydC1xdWV1ZS1tYWMuc2g6CisKIDIwMTktMDMtMjYgIEFha2FzaCBKYWluICA8YWFrYXNoX2ph aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYnVpbGRdIFVzZSBQb3N0Z3JlU1FMIGZvciBl d3MtYnVpbGQgZGF0YWJhc2UKSW5kZXg6IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLW1hYy5z aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS1tYWMuc2gJKHJldmlz aW9uIDI0MzUwOCkKKysrIFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLW1hYy5zaAkod29ya2lu ZyBjb3B5KQpAQCAtNjEsNiArNjEsMTIgQEAgaWYgWyAtcyAkUVVFVUVfTkFNRS5sb2cgXTsgdGhl bgogICAgICAgICBtdiAtZiAkUVVFVUVfTkFNRS5sb2cgJHtRVUVVRV9OQU1FfV8kKGRhdGUgKyVZ LSVtLSVkXyVILSVtKS5sb2cKICAgICBmaQogZmkKKworIyBGaXgtdXAgcm90dGVuIFNpbXVsYXRv ciBzdGF0ZQorL2Jpbi9ybSAtcmYgfi9MaWJyYXJ5L0RldmVsb3Blci9Db3JlU2ltdWxhdG9yL0Rl dmljZXMvKgorL3Vzci9iaW4vc3VkbyAvdXNyL2Jpbi9raWxsYWxsIC05IGNvbS5hcHBsZS5Db3Jl U2ltdWxhdG9yLkNvcmVTaW11bGF0b3JTZXJ2ZXIKKy91c3IvYmluL3hjcnVuIHNpbWN0bCBkZWxl dGUgdW5hdmFpbGFibGUKKwogY2QgJFdFQktJVF9IT01FCiAKICMgRGVsZXRlIFdlYktpdEJ1aWxk IHRvIGZvcmNlIGEgY2xlYW4gYnVpbGQK