196259 2019-03-26 09:50:55 -0700 [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents" 2019-03-26 10:27:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue dino simon.fraser zalan oldest_to_newest 1521315 0 zalan 2019-03-26 09:50:55 -0700 they don't count. 1521316 1 zalan 2019-03-26 09:51:10 -0700 <rdar://problem/49240029> 1521317 2 365971 zalan 2019-03-26 09:55:10 -0700 Created attachment 365971 Patch 1521322 3 365971 dino 2019-03-26 10:00:44 -0700 Comment on attachment 365971 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365971&action=review > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32 > + let rect = tapthis.getBoundingClientRect(); > + let x = rect.left + rect.width / 2; > + let y = rect.top + rect.height / 2; can use const :) 1521325 4 zalan 2019-03-26 10:03:35 -0700 (In reply to Dean Jackson from comment #3) > Comment on attachment 365971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365971&action=review > > > LayoutTests/fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:32 > > + let rect = tapthis.getBoundingClientRect(); > > + let x = rect.left + rect.width / 2; > > + let y = rect.top + rect.height / 2; > > can use const :) Oh I didn't know about it! 1521342 5 365971 commit-queue 2019-03-26 10:27:11 -0700 Comment on attachment 365971 Patch Clearing flags on attachment: 365971 Committed r243503: <https://trac.webkit.org/changeset/243503> 1521343 6 commit-queue 2019-03-26 10:27:12 -0700 All reviewed patches have been landed. Closing bug. 365971 2019-03-26 09:55:10 -0700 2019-03-26 10:27:11 -0700 Patch bug-196259-20190326095510.patch text/plain 5022 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZmYjE5MzJmNTc2MDM3 NWE1ZTU1MzkzYzNhMjBkMDYwMjI2N2RhZS4uNjE5MGMwNzZhZTQ1MzNkZTg0OTNjMjI3ODljNzg4 NjdhMGZlN2FkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gU2tpcCBhbm9ueW1vdXMgcmVuZGVyZXJzIHdoZW4gY2hlY2tpbmcgZm9yICJ3aWxsUmVz cG9uZFRvTW91c2VDbGlja0V2ZW50cyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NjI1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkyNDAwMjk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW5vbnlt b3VzIHJlbmRlcmVycyBkb24ndCBoYXZlIGFzc29jaWF0ZWQgRE9NIG5vZGVzIHNvIHRoZXkgY2Fu J3QgaGF2ZSBldmVudCBsaXN0ZW5lcnMgZWl0aGVyLiBMZXQncyBza2lwIHRoZW0uCisKKyAgICAg ICAgVGVzdDogZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vY3Jhc2gt b24tYW5vbnltb3VzLXJlbmRlcmVyLmh0bWwKKworICAgICAgICAqIHBhZ2UvaW9zL0NvbnRlbnRD aGFuZ2VPYnNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50Q2hhbmdlT2JzZXJ2 ZXI6OlN0eWxlQ2hhbmdlU2NvcGU6OmlzQ29uc2lkZXJlZENsaWNrYWJsZSBjb25zdCk6CisKIDIw MTktMDMtMjYgIE1pa2UgR29yc2UgIDxtZ29yc2VAYWx1bS53cGkuZWR1PgogCiAgICAgICAgIEJ1 aWxkIGZhaWx1cmUgd2l0aCBnc3RyZWFtZXIgMS4xMi41IGlmIFVTRV9HU1RSRUFNRVJfR0wgaXMg ZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5n ZU9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNl cnZlci5jcHAKaW5kZXggMjQ3ZjA4ZGJkM2FmMjZmMzFkNjJkZTgyNjI4NmJlZWM1N2I1MGFmZi4u MWNkZGJjZDg3YzdlMDgyY2UzNWEyN2MyZDgyMmI5MDEyNWIxNTllMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCkBAIC01MDIsNiAr NTAyLDggQEAgYm9vbCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OlN0eWxlQ2hhbmdlU2NvcGU6Omlz Q29uc2lkZXJlZENsaWNrYWJsZSgpIGNvbnN0CiAgICAgLy8gSW4gY2FzZSB3aGVuIHRoZSB2aXNp YmxlIGNvbnRlbnQgYWxyZWFkeSBoYWQgcmVuZGVyZXJzIGl0J3Mgbm90IHN1ZmZpY2llbnQgdG8g Y2hlY2sgdGhlICJuZXdseSB2aXNpYmxlIiBlbGVtZW50IG9ubHkgc2luY2UgaXQgbWlnaHQganVz dCBiZSB0aGUgY29udGFpbmVyIGZvciB0aGUgY2xpY2thYmxlIGNvbnRlbnQuICAKICAgICBBU1NF UlQobV9lbGVtZW50LnJlbmRlcmVyKCkpOwogICAgIGZvciAoYXV0byYgZGVzY2VuZGFudCA6IGRl c2NlbmRhbnRzT2ZUeXBlPFJlbmRlckVsZW1lbnQ+KCplbGVtZW50LnJlbmRlcmVyKCkpKSB7Cisg ICAgICAgIGlmICghZGVzY2VuZGFudC5lbGVtZW50KCkpCisgICAgICAgICAgICBjb250aW51ZTsK ICAgICAgICAgaWYgKGRlc2NlbmRhbnQuZWxlbWVudCgpLT53aWxsUmVzcG9uZFRvTW91c2VDbGlj a0V2ZW50cygpKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGM1M2Rk Zjc3NmJhMDdjZjEyMDIxM2EyMzE1OTRlZWMzZWQ5ODFhMDIuLmVlNGYyYjQyOGFmODY5YmI3NDkx NGRjZGFjOGQ1NmUzMGYxZDFiODUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wMy0yNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb250ZW50Q2hhbmdl T2JzZXJ2ZXJdIFNraXAgYW5vbnltb3VzIHJlbmRlcmVycyB3aGVuIGNoZWNraW5nIGZvciAid2ls bFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyNTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MjQw MDI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vY3Jhc2gtb24tYW5vbnlt b3VzLXJlbmRlcmVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMv dG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vY3Jhc2gtb24tYW5vbnltb3VzLXJlbmRlcmVy Lmh0bWw6IEFkZGVkLgorCiAyMDE5LTAzLTI2ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBMYXlvdXQgVGVzdCBqcy9tYXRoLWNsejMyLmh0bWwgaXMgZmFp bGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NvbnRl bnQtb2JzZXJ2YXRpb24vY3Jhc2gtb24tYW5vbnltb3VzLXJlbmRlcmVyLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jb250ZW50LW9ic2VydmF0aW9uL2Ny YXNoLW9uLWFub255bW91cy1yZW5kZXJlci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTY0Yjcy YjY5MDgzNjUzODlkZWE3YjczNWE1M2U5MGIwYzEwMzdlOAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jb250ZW50LW9ic2VydmF0aW9uL2NyYXNo LW9uLWFub255bW91cy1yZW5kZXJlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitQQVNT IGlmIG5vIGNyYXNoLgoraW5saW5lIHRleHQgd2l0aAordGV4dCBpbnNpZGUgYmxvY2sKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jb250ZW50LW9ic2VydmF0 aW9uL2NyYXNoLW9uLWFub255bW91cy1yZW5kZXJlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvdG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vY3Jhc2gtb24tYW5vbnltb3VzLXJl bmRlcmVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDBjMDlhMWNhYTg1NGNjOTNmNzRiNDkzNDVlOWJlNmMw ZTNkZmQyNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNo L2lvcy9jb250ZW50LW9ic2VydmF0aW9uL2NyYXNoLW9uLWFub255bW91cy1yZW5kZXJlci5odG1s CkBAIC0wLDAgKzEsNTQgQEAKKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGhpcyB0ZXN0cyB0aGUg Y2FzZSB3aGVuIHZpc2libGUgY29udGVudCBoYXMgYW5vbnltb3VzIHJlbmRlcmVycy48L3RpdGxl PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uLy4uL3Jlc291cmNlcy9iYXNpYy1nZXN0dXJlcy5q cyI+PC9zY3JpcHQ+Cis8c3R5bGU+CisjdGFwdGhpcyB7CisgICAgd2lkdGg6IDQwMHB4OworICAg IGhlaWdodDogNDAwcHg7CisgICAgYm9yZGVyOiAxcHggc29saWQgZ3JlZW47Cit9CisKKyNiZWNv bWVzVmlzaWJsZSB7CisgICAgcG9zaXRpb246IGFic29sdXRlOworICAgIGxlZnQ6IC0xMDAwcHg7 CisgICAgd2lkdGg6IDEwMHB4OworICAgIGhlaWdodDogMTAwcHg7CisgICAgYmFja2dyb3VuZC1j b2xvcjogZ3JlZW47Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2FzeW5jIGZ1bmN0aW9uIHRlc3Qo KSB7CisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lciB8fCAhdGVzdFJ1bm5lci5ydW5VSVNjcmlw dCkKKyAgICAgICAgcmV0dXJuOworICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICBp bnRlcm5hbHMuc2V0dGluZ3Muc2V0Q29udGVudENoYW5nZU9ic2VydmVyRW5hYmxlZCh0cnVlKTsK KworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIHRlc3RSdW5uZXIuZHVtcEFz VGV4dCgpOworCisgICAgbGV0IHJlY3QgPSB0YXB0aGlzLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp OworICAgIGxldCB4ID0gcmVjdC5sZWZ0ICsgcmVjdC53aWR0aCAvIDI7CisgICAgbGV0IHkgPSBy ZWN0LnRvcCArIHJlY3QuaGVpZ2h0IC8gMjsKKworICAgIGF3YWl0IHRhcEF0UG9pbnQoeCwgeSk7 Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4KKzxkaXYgaWQ9 dGFwdGhpcz5QQVNTIGlmIG5vIGNyYXNoLjwvZGl2PgorPGRpdiBpZD1iZWNvbWVzVmlzaWJsZT5p bmxpbmUgdGV4dCB3aXRoIDxkaXY+dGV4dCBpbnNpZGUgYmxvY2s8L2Rpdj48L2Rpdj4KKzxzY3Jp cHQ+Cit0YXB0aGlzLmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlbW92ZSIsIGZ1bmN0aW9uKCBldmVu dCApIHsKKyAgICBiZWNvbWVzVmlzaWJsZS5zdHlsZS5sZWZ0ID0gIjEwMHB4IjsKKyAgICBkb2N1 bWVudC5ib2R5Lm9mZnNldEhlaWdodDsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAg ICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfSwgZmFsc2UpOworCit0YXB0aGlzLmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVuY3Rpb24oIGV2ZW50ICkgeyAgIAorICAgIHJlc3VsdC5p bm5lckhUTUwgPSAiY2xpY2tlZCI7Cit9LCBmYWxzZSk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4K