196252 2019-03-26 06:26:38 -0700 [ews-app] Set db_constraint to False for Foreign Keys 2019-03-26 10:15:05 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dean_johnson jbedard kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1521282 0 aakash_jain 2019-03-26 06:26:38 -0700 Steps table have a ForeignKey build_uid. Since the Build and step events from Buildbot can arrive out of order, we might get step data before build data. In that case, we still want to save the step data. For sqlite Django seems to allow this by default. However, after switching to PostgreSQL, Django is throwing below exception. We should set ForeignKey.db_constraint=False to allow this condition. Step(step_uid, build_uid, result, state_string, started_at, complete_at).save() File "/Library/Python/2.7/site-packages/django/db/models/base.py", line 808, in save force_update=force_update, update_fields=update_fields) File "/Library/Python/2.7/site-packages/django/db/models/base.py", line 838, in save_base updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields) File "/Library/Python/2.7/site-packages/django/db/transaction.py", line 223, in __exit__ connection.commit() File "/Library/Python/2.7/site-packages/django/db/backends/base/base.py", line 262, in commit self._commit() File "/Library/Python/2.7/site-packages/django/db/backends/base/base.py", line 236, in _commit return self.connection.commit() File "/Library/Python/2.7/site-packages/django/db/utils.py", line 94, in __exit__ six.reraise(dj_exc_type, dj_exc_value, traceback) File "/Library/Python/2.7/site-packages/django/db/backends/base/base.py", line 236, in _commit return self.connection.commit() IntegrityError: insert or update on table "ews_step" violates foreign key constraint "ews_step_build_uid_3e89afad_fk_ews_build_uid" DETAIL: Key (build_uid)=(1_336) is not present in table "ews_build". 1521283 1 365962 aakash_jain 2019-03-26 06:27:48 -0700 Created attachment 365962 Patch 1521337 2 365962 commit-queue 2019-03-26 10:13:35 -0700 Comment on attachment 365962 Patch Clearing flags on attachment: 365962 Committed r243502: <https://trac.webkit.org/changeset/243502> 1521338 3 commit-queue 2019-03-26 10:13:37 -0700 All reviewed patches have been landed. Closing bug. 1521339 4 webkit-bug-importer 2019-03-26 10:15:05 -0700 <rdar://problem/49278115> 365962 2019-03-26 06:27:48 -0700 2019-03-26 10:13:35 -0700 Patch bug-196252-20190326092825.patch text/plain 2025 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzQ5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU2V0IGRiX2NvbnN0cmFpbnQgdG8gRmFsc2UgZm9yIEZv cmVpZ24gS2V5cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2MjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQucHk6CisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHk6CisKIDIw MTktMDMtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEZpeCB0eXBvIGluIEdMaWIgZ2VvbG9jYXRpb24gQVBJIGFmdGVy IHIyNDMyODUuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2Rl bHMvYnVpbGQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3MvbW9kZWxzL2J1aWxkLnB5CShyZXZpc2lvbiAyNDM0OTQpCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQucHkJKHdvcmtpbmcgY29weSkKQEAg LTM0LDcgKzM0LDcgQEAgX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCiAKIGNs YXNzIEJ1aWxkKG1vZGVscy5Nb2RlbCk6Ci0gICAgcGF0Y2ggPSBtb2RlbHMuRm9yZWlnbktleShQ YXRjaCwgb25fZGVsZXRlPW1vZGVscy5DQVNDQURFKQorICAgIHBhdGNoID0gbW9kZWxzLkZvcmVp Z25LZXkoUGF0Y2gsIG9uX2RlbGV0ZT1tb2RlbHMuQ0FTQ0FERSwgZGJfY29uc3RyYWludD1GYWxz ZSkKICAgICB1aWQgPSBtb2RlbHMuVGV4dEZpZWxkKHByaW1hcnlfa2V5PVRydWUpCiAgICAgYnVp bGRlcl9pZCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQogICAgIGJ1aWxkZXJfbmFtZSA9IG1vZGVs cy5UZXh0RmllbGQoKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mv bW9kZWxzL3N0ZXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWFwcC9ld3MvbW9kZWxzL3N0ZXAucHkJKHJldmlzaW9uIDI0MzQ5NCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0zNSw3ICszNSw3IEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKIAogY2xh c3MgU3RlcChtb2RlbHMuTW9kZWwpOgogICAgIHVpZCA9IG1vZGVscy5UZXh0RmllbGQocHJpbWFy eV9rZXk9VHJ1ZSkKLSAgICBidWlsZF91aWQgPSBtb2RlbHMuRm9yZWlnbktleShCdWlsZCwgb25f ZGVsZXRlPW1vZGVscy5DQVNDQURFLCBkYl9jb2x1bW49J2J1aWxkX3VpZCcpCisgICAgYnVpbGRf dWlkID0gbW9kZWxzLkZvcmVpZ25LZXkoQnVpbGQsIG9uX2RlbGV0ZT1tb2RlbHMuQ0FTQ0FERSwg ZGJfY29sdW1uPSdidWlsZF91aWQnLCBkYl9jb25zdHJhaW50PUZhbHNlKQogICAgIHJlc3VsdCA9 IG1vZGVscy5JbnRlZ2VyRmllbGQobnVsbD1UcnVlLCBibGFuaz1UcnVlKQogICAgIHN0YXRlX3N0 cmluZyA9IG1vZGVscy5UZXh0RmllbGQoKQogICAgIHN0YXJ0ZWRfYXQgPSBtb2RlbHMuSW50ZWdl ckZpZWxkKG51bGw9VHJ1ZSwgYmxhbms9VHJ1ZSkK