196248 2019-03-26 04:48:48 -0700 [ews-build] is_test_mode_enabled should default to True 2021-02-01 07:43:06 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221208 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dean_johnson dewei_zhu jbedard kocsen_chung lforschler lingho ryanhaddad webkit-bug-importer oldest_to_newest 1521263 0 aakash_jain 2019-03-26 04:48:48 -0700 is_test_mode_enabled variable should default to True in order to avoid accidentally running production settings on a local/test instance. Currently we need to explicitly add an environment variable BUILDBOT_TESTING in order to indicate test instance. If someone forgets to set this environment variable on a local instance, he would run with production settings. Currently it's very easy to make this mistake. We should reverse the logic to make it harder to do such mistake. We should instead require to set an environment variable BUILDBOT_PRODUCTION on production server. It will be a one time configuration on the production server (by configuring environment variable in a manner that persist across reboots and various shell sessions). 1521264 1 365960 aakash_jain 2019-03-26 04:50:32 -0700 Created attachment 365960 Patch 1521265 2 webkit-bug-importer 2019-03-26 04:55:00 -0700 <rdar://problem/49263519> 1521335 3 365960 commit-queue 2019-03-26 10:12:28 -0700 Comment on attachment 365960 Patch Clearing flags on attachment: 365960 Committed r243501: <https://trac.webkit.org/changeset/243501> 1521336 4 commit-queue 2019-03-26 10:12:30 -0700 All reviewed patches have been landed. Closing bug. 365960 2019-03-26 04:50:32 -0700 2019-03-26 10:12:28 -0700 Patch bug-196248-20190326075109.patch text/plain 1133 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzQ5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBpc190ZXN0X21vZGVfZW5hYmxlZCBzaG91bGQgZGVm YXVsdCB0byBUcnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTYyNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnOiBSZXZlcnNlIHRo ZSBlbnZpcm9ubWVudCB2YXJpYWJsZSB1c2VkIHRvIGRlY2lkZSBpc190ZXN0X21vZGVfZW5hYmxl ZC4KKwogMjAxOS0wMy0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IHR5cG8gaW4gR0xpYiBnZW9sb2NhdGlvbiBB UEkgYWZ0ZXIgcjI0MzI4NS4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9tYXN0ZXIuY2ZnCShyZXZpc2lvbiAyNDM0OTEpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMyw3ICszLDcgQEAg aW1wb3J0IG9zCiBpbXBvcnQgbG9hZENvbmZpZwogZnJvbSBldmVudHMgaW1wb3J0IEV2ZW50cwog Ci1pc190ZXN0X21vZGVfZW5hYmxlZCA9IG9zLmdldGVudignQlVJTERCT1RfVEVTVElORycpIGlz IG5vdCBOb25lCitpc190ZXN0X21vZGVfZW5hYmxlZCA9IG9zLmdldGVudignQlVJTERCT1RfUFJP RFVDVElPTicpIGlzIE5vbmUKIAogYyA9IEJ1aWxkbWFzdGVyQ29uZmlnID0ge30KIAo=