196223 2019-03-25 15:54:35 -0700 [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES 2019-03-25 19:30:54 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 195889 1 aperez aperez cgarcia commit-queue dbates lforschler mcatanzaro pnormand svillar webkit-bug-importer oldest_to_newest 1521077 0 aperez 2019-03-25 15:54:35 -0700 Features that depend on ENABLE_EXPERIMENTAL_FEATURES ideally should be buildable from release tarballs. If a feature is in development (or *very* experimental) and we do not want to include the sources needed to build it in release tarballs, then it should not depend on ENABLE_EXPERIMENTAL_FEATURES. (Note that this would just remove the dependency, the feature would still be buildable from a WebKit checkout by explicitly enabling it, of course.) 1521136 1 365927 aperez 2019-03-25 17:27:42 -0700 Created attachment 365927 Patch 1521175 2 365927 commit-queue 2019-03-25 19:18:19 -0700 Comment on attachment 365927 Patch Clearing flags on attachment: 365927 Committed r243481: <https://trac.webkit.org/changeset/243481> 1521176 3 commit-queue 2019-03-25 19:18:21 -0700 All reviewed patches have been landed. Closing bug. 1521177 4 webkit-bug-importer 2019-03-25 19:30:54 -0700 <rdar://problem/49241316> 365927 2019-03-25 17:27:42 -0700 2019-03-25 19:18:19 -0700 Patch bug-196223-20190326022741.patch text/plain 2771 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGU2YzVm N2RmY2U3NzNhZWJjOGM1NTAwZDgyODJmZjBjMTlkY2UyODUuLjA3YjliN2ZkYjIzNTQ1NTFkOGU1 NDM3ZWMwYmMyNTY5Mzg3ODc3MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC04OSw3ICs4OSw3 IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9XT0ZGMiAiV2hldGhlciB0byBlbmFibGUgc3Vw cG9ydCBmb3IgV09GRjIgV2ViIEZvbnRzLiIKICMgUHJpdmF0ZSBvcHRpb25zIHNwZWNpZmljIHRv IHRoZSBHVEsrIHBvcnQuIENoYW5naW5nIHRoZXNlIG9wdGlvbnMgaXMKICMgY29tcGxldGVseSB1 bnN1cHBvcnRlZC4gVGhleSBhcmUgaW50ZW5kZWQgZm9yIHVzZSBvbmx5IGJ5IFdlYktpdCBkZXZl bG9wZXJzLgogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBPU0lURV9X SU5ET1cgIldoZXRoZXIgdG8gdXNlIGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRvdyBmb3Ig YWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaW4gWDExLiIgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJ T05fREVGSU5FKFVTRV9PUEVOVlIgIldoZXRoZXIgdG8gdXNlIE9wZW5WUiBhcyBXZWJWUiBiYWNr ZW5kLiIgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQorV0VCS0lUX09Q VElPTl9ERUZJTkUoVVNFX09QRU5WUiAiV2hldGhlciB0byB1c2UgT3BlblZSIGFzIFdlYlZSIGJh Y2tlbmQuIiBQUklWQVRFIE9GRikKIAogIyBGSVhNRTogQ2FuIHdlIHVzZSBjYWlyby1nbGVzdjIg dG8gYXZvaWQgdGhpcyBjb25mbGljdD8KIFdFQktJVF9PUFRJT05fQ09ORkxJQ1QoRU5BQkxFX0FD Q0VMRVJBVEVEXzJEX0NBTlZBUyBFTkFCTEVfR0xFUzIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h a2UvT3B0aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4 IDVkN2M5YjMzYzY1YjEwNmI3NDFlOWQ3NjAwOGZjNzE3ZWM3ZDUwZDEuLjVmN2YyZjYyZGNlMzJj NWUwYTVmMDM2NzJjODlhMDFkNmY3NWVmMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC02Nyw3 ICs2Nyw3IEBAIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9XT0ZGMiAiV2hldGhlciB0byBlbmFi bGUgc3VwcG9ydCBmb3IgV09GRjIgV2ViIEZvbnRzLiIKIFdFQktJVF9PUFRJT05fREVGSU5FKEVO QUJMRV9XUEVfUVRfQVBJICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciB0aGUgUXQ1L1FN TCBwbHVnaW4iIFBVQkxJQyBPRkYpCiAKICMgUHJpdmF0ZSBvcHRpb25zIHNwZWNpZmljIHRvIHRo ZSBXUEUgcG9ydC4KLVdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9PUEVOVlIgIldoZXRoZXIgdG8g dXNlIE9wZW5WUiBhcyBXZWJWUiBiYWNrZW5kLiIgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5U QUxfRkVBVFVSRVN9KQorV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX09QRU5WUiAiV2hldGhlciB0 byB1c2UgT3BlblZSIGFzIFdlYlZSIGJhY2tlbmQuIiBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJ T05fREVGSU5FKFVTRV9HU1RSRUFNRVJfSE9MRVBVTkNIICJXaGV0aGVyIHRvIGVuYWJsZSBHU3Ry ZWFtZXIgaG9sZXB1bmNoIiBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9F WFRFUk5BTF9IT0xFUFVOQ0ggIldoZXRoZXIgdG8gZW5hYmxlIGV4dGVybmFsIGhvbGVwdW5jaCIg UFJJVkFURSBPRkYpCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBj NDg1YjEyODgyMmY3ODdmODBlY2ExNWI0NjJlMWY5MzIxMDk2ZGI4Li43NWMzZGU5YzZlYjA0ZDY4 M2Y0YjExYjViZDAwZDRmM2JhY2MzZTRlIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMjUgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtdIE1ha2UgYnVpbGRp bmcgV2ViVlIgKHcvT3BlblZSKSBub3QgZGVwZW5kIG9uIEVOQUJMRV9FWFBFUklNRU5UQUxfRkVB VFVSRVMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NjIyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERp c2VudGFuZ2xlIFVTRV9PUEVOVlIgZnJvbSBFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTLCBt YWtpbmcgaXQKKyAgICAgICAgdW5uZWVkZWQgdG8gaW5jbHVkZSBUaGlyZFBhcnR5L29wZW52ci8g aW4gcmVsZWFzZSB0YXJiYWxscy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlOiBTZXQgVVNFX09QRU5WUiB0byBPRkYgYnkgZGVmYXVsdCwKKyAgICAgICAgaW5zdGVh ZCBvZiBtYWtpbmcgaXQgdXNlIHRoZSB2YWx1ZSBvZiBFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRV UkVTLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOiBEaXR0by4KKwog MjAxOS0wMy0yNSAgWGFuIEzDs3BleiAgPHhhbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXVEZd IEZpeCB0eXBvIHdoZW4gZm9yY2luZyBXVEZfQ1BVX1g4Ngo=