196216 2019-03-25 14:17:26 -0700 [ews-build] Gracefully handle missing patch_id in events 2019-03-25 15:08:11 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler webkit-bug-importer oldest_to_newest 1521013 0 aakash_jain 2019-03-25 14:17:26 -0700 If the patch_id is missing in a build, following exception is generated while generate events. We should handle it gracefully. 2019-03-25 14:10:02-0700 [-] while invoking <bound method Events.buildFinished of <events.Events object at 0x7fc1a2c8d210>> Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 393, in callback self._startRunCallbacks(result) File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 501, in _startRunCallbacks self._runCallbacks() File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 587, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 1241, in gotResult _inlineCallbacks(r, g, deferred) --- <exception caught here> --- File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 1185, in _inlineCallbacks result = g.send(result) File "events.py", line 148, in buildFinished "patch_id": self.getPatchID(build), File "events.py", line 106, in getPatchID return build.get('properties').get('patch_id')[0] exceptions.TypeError: 'NoneType' object has no attribute '__getitem__' 1521016 1 365899 aakash_jain 2019-03-25 14:21:09 -0700 Created attachment 365899 Patch 1521049 2 365899 commit-queue 2019-03-25 15:04:56 -0700 Comment on attachment 365899 Patch Clearing flags on attachment: 365899 Committed r243464: <https://trac.webkit.org/changeset/243464> 1521050 3 commit-queue 2019-03-25 15:04:57 -0700 All reviewed patches have been landed. Closing bug. 1521053 4 webkit-bug-importer 2019-03-25 15:08:11 -0700 <rdar://problem/49231513> 365899 2019-03-25 14:21:09 -0700 2019-03-25 15:04:56 -0700 Patch bug-196216-20190325172145.patch text/plain 1230 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzQ1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBHcmFjZWZ1bGx5IGhhbmRsZSBtaXNzaW5nIHBhdGNo X2lkIGluIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2MjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZXZlbnRzLnB5OgorCiAyMDE5LTAz LTI1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFRlc3QgZm9y OiAxOTYwOTUgSW5iYW5kIFRleHQgVHJhY2sgY3VlcyBpbnRlcnNwZXJzZWQgd2l0aCBEYXRhIGN1 ZXMgY2FuIGRpc3BsYXkgb3V0IG9mIG9yZGVyLgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL2V2ZW50cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvZXZlbnRzLnB5CShyZXZpc2lvbiAyNDM0NTgpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZXZlbnRzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMDAs NyArMTAwLDcgQEAgY2xhc3MgRXZlbnRzKHNlcnZpY2UuQnVpbGRib3RTZXJ2aWNlKToKICAgICAg ICAgcmV0dXJuIGJ1aWxkLmdldCgncHJvcGVydGllcycpLmdldCgnYnVpbGRlcm5hbWUnKVswXQog CiAgICAgZGVmIGdldFBhdGNoSUQoc2VsZiwgYnVpbGQpOgotICAgICAgICBpZiBub3QgKGJ1aWxk IGFuZCAncHJvcGVydGllcycgaW4gYnVpbGQpOgorICAgICAgICBpZiBub3QgKGJ1aWxkIGFuZCAn cHJvcGVydGllcycgaW4gYnVpbGQgYW5kICdwYXRjaF9pZCcgaW4gYnVpbGRbJ3Byb3BlcnRpZXMn XSk6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgICAgIHJldHVybiBidWlsZC5nZXQo J3Byb3BlcnRpZXMnKS5nZXQoJ3BhdGNoX2lkJylbMF0K