196212 2019-03-25 13:33:59 -0700 Pull some API testing helper methods out of TestWKWebView 2019-03-25 14:39:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue thorton webkit-bug-importer oldest_to_newest 1520980 0 wenson_hsieh 2019-03-25 13:33:59 -0700 Pull some API testing helper methods out of TestWKWebView 1520981 1 365892 wenson_hsieh 2019-03-25 13:35:14 -0700 Created attachment 365892 Patch 1521035 2 365892 commit-queue 2019-03-25 14:39:19 -0700 Comment on attachment 365892 Patch Clearing flags on attachment: 365892 Committed r243462: <https://trac.webkit.org/changeset/243462> 1521036 3 commit-queue 2019-03-25 14:39:20 -0700 All reviewed patches have been landed. Closing bug. 365892 2019-03-25 13:35:14 -0700 2019-03-25 14:39:19 -0700 Patch bug-196212-20190325133512.patch text/plain 5213 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTUxN2NjNDJiZmUwZWNlY2UzMGJhY2Y3MTBiMjE0Yzll ZTY5MmYwNS4uMmQ3YjIwZmZiY2E3MDg4ZDRjM2NjZTI1ZTY1NGM0YmRkZmQ0OTNhNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE5LTAzLTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFB1bGwgc29tZSBBUEkgdGVzdGluZyBoZWxwZXIgbWV0aG9kcyBvdXQgb2YgVGVz dFdLV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2MjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVmYWN0b3Igc29tZSBtb3JlIEFQSSB0ZXN0aW5nIHV0aWxpdHkgbWV0aG9kcywgc28gdGhh dCB0aGV5IGNhbiBiZSB1c2VkIGluCisgICAgICAgIHRlc3RzIHRoYXQgZG8gbm90IHVzZSBUZXN0 V0tXZWJWaWV3LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0V0tXZWJWaWV3 Lmg6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0V0tXZWJWaWV3Lm1tOgorICAg ICAgICAoLVtXS1dlYlZpZXcgbG9hZFRlc3RQYWdlTmFtZWQ6XSk6CisgICAgICAgICgtW1dLV2Vi VmlldyBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6YmFzZVVSTDpdKToKKyAgICAgICAgKC1b V0tXZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzpdKToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpdKToKKyAgICAgICAgKC1bVGVz dFdLV2ViVmlldyBsb2FkVGVzdFBhZ2VOYW1lZDpdKTogRGVsZXRlZC4KKyAgICAgICAgKC1bVGVz dFdLV2ViVmlldyBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6YmFzZVVSTDpdKTogRGVsZXRl ZC4KKyAgICAgICAgKC1bVGVzdFdLV2ViVmlldyBzeW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6 XSk6IERlbGV0ZWQuCisgICAgICAgICgtW1Rlc3RXS1dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRU ZXN0UGFnZU5hbWVkOl0pOiBEZWxldGVkLgorCiAyMDE5LTAzLTI1ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFB1bGwgSVBhZFVzZXJJbnRlcmZhY2VT d2l6emxlciBvdXQgaW50byBhIHNlcGFyYXRlIGhlYWRlciBmaWxlCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3RXS1dlYlZpZXcuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvY29jb2EvVGVzdFdLV2ViVmlldy5oCmluZGV4IGMxYjZkNDhjN2RjZWY4NDBkZDc3YTgwMmFh NDYwNjlmOGVlM2I1MDguLjhiYTY1MmUwYWViNjg4NmUyMjI4MDMyM2I3OTJkNzMxYmJmMTg0NDcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdFdLV2ViVmlldy5oCisr KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdFdLV2ViVmlldy5oCkBAIC00Nyw2ICs0 NywxMCBAQAogCiBAaW50ZXJmYWNlIFdLV2ViVmlldyAoVGVzdFdlYktpdEFQSSkKIEBwcm9wZXJ0 eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNBcnJheTxOU1N0cmluZyAqPiAqdGFnc0luQm9keTsK Ky0gKHZvaWQpbG9hZFRlc3RQYWdlTmFtZWQ6KE5TU3RyaW5nICopcGFnZU5hbWU7CistICh2b2lk KXN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzooTlNTdHJpbmcgKilodG1sOworLSAodm9pZClz eW5jaHJvbm91c2x5TG9hZEhUTUxTdHJpbmc6KE5TU3RyaW5nICopaHRtbCBiYXNlVVJMOihOU1VS TCAqKXVybDsKKy0gKHZvaWQpc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOihOU1N0cmlu ZyAqKXBhZ2VOYW1lOwogLSAoQk9PTClfc3luY2hyb25vdXNseUV4ZWN1dGVFZGl0Q29tbWFuZDoo TlNTdHJpbmcgKiljb21tYW5kIGFyZ3VtZW50OihOU1N0cmluZyAqKWFyZ3VtZW50OwogLSAodm9p ZClleHBlY3RFbGVtZW50VGFnc0luT3JkZXI6KE5TQXJyYXk8TlNTdHJpbmcgKj4gKil0YWdOYW1l czsKIC0gKHZvaWQpZXhwZWN0RWxlbWVudENvdW50OihOU0ludGVnZXIpY291bnQgcXVlcnlTZWxl Y3RvcjooTlNTdHJpbmcgKilxdWVyeVNlbGVjdG9yOwpAQCAtNjUsMTAgKzY5LDYgQEAKIC0gKGlu c3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUgY29uZmlndXJhdGlvbjooV0tX ZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYWRkVG9XaW5kb3c6KEJPT0wpYWRk VG9XaW5kb3c7CiAtICh2b2lkKWNsZWFyTWVzc2FnZUhhbmRsZXJzOihOU0FycmF5ICopbWVzc2Fn ZU5hbWVzOwogLSAodm9pZClwZXJmb3JtQWZ0ZXJSZWNlaXZpbmdNZXNzYWdlOihOU1N0cmluZyAq KW1lc3NhZ2UgYWN0aW9uOihkaXNwYXRjaF9ibG9ja190KWFjdGlvbjsKLS0gKHZvaWQpbG9hZFRl c3RQYWdlTmFtZWQ6KE5TU3RyaW5nICopcGFnZU5hbWU7Ci0tICh2b2lkKXN5bmNocm9ub3VzbHlM b2FkSFRNTFN0cmluZzooTlNTdHJpbmcgKilodG1sOwotLSAodm9pZClzeW5jaHJvbm91c2x5TG9h ZEhUTUxTdHJpbmc6KE5TU3RyaW5nICopaHRtbCBiYXNlVVJMOihOU1VSTCAqKXVybDsKLS0gKHZv aWQpc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOihOU1N0cmluZyAqKXBhZ2VOYW1lOwog LSAodm9pZCl3YWl0Rm9yTWVzc2FnZTooTlNTdHJpbmcgKiltZXNzYWdlOwogLSAodm9pZClwZXJm b3JtQWZ0ZXJMb2FkaW5nOihkaXNwYXRjaF9ibG9ja190KWFjdGlvbnM7CiAtICh2b2lkKXdhaXRG b3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlOwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9jb2NvYS9UZXN0V0tXZWJWaWV3Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0 V0tXZWJWaWV3Lm1tCmluZGV4IDA5ZWI3NWVkMjg0ZmU5ZTY2N2FmMTAzNTZhOGIwY2RlZGVkOTlh YmEuLjQxODdjZTNiMmFhNzVhOGI1MmU5ZTMzYjZlYjMxMTRmNzAxNTE2NjUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdFdLV2ViVmlldy5tbQorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3RXS1dlYlZpZXcubW0KQEAgLTY0LDYgKzY0LDI5IEBAIEBl bmQKIAogQGltcGxlbWVudGF0aW9uIFdLV2ViVmlldyAoVGVzdFdlYktpdEFQSSkKIAorLSAodm9p ZClsb2FkVGVzdFBhZ2VOYW1lZDooTlNTdHJpbmcgKilwYWdlTmFtZQoreworICAgIE5TVVJMUmVx dWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W1tOU0J1bmRsZSBt YWluQnVuZGxlXSBVUkxGb3JSZXNvdXJjZTpwYWdlTmFtZSB3aXRoRXh0ZW5zaW9uOkAiaHRtbCIg c3ViZGlyZWN0b3J5OkAiVGVzdFdlYktpdEFQSS5yZXNvdXJjZXMiXV07CisgICAgW3NlbGYgbG9h ZFJlcXVlc3Q6cmVxdWVzdF07Cit9CisKKy0gKHZvaWQpc3luY2hyb25vdXNseUxvYWRIVE1MU3Ry aW5nOihOU1N0cmluZyAqKWh0bWwgYmFzZVVSTDooTlNVUkwgKil1cmwKK3sKKyAgICBbc2VsZiBs b2FkSFRNTFN0cmluZzpodG1sIGJhc2VVUkw6dXJsXTsKKyAgICBbc2VsZiBfdGVzdF93YWl0Rm9y RGlkRmluaXNoTmF2aWdhdGlvbl07Cit9CisKKy0gKHZvaWQpc3luY2hyb25vdXNseUxvYWRIVE1M U3RyaW5nOihOU1N0cmluZyAqKWh0bWwKK3sKKyAgICBbc2VsZiBzeW5jaHJvbm91c2x5TG9hZEhU TUxTdHJpbmc6aHRtbCBiYXNlVVJMOltbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZVVSTF0g VVJMQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAiVGVzdFdlYktpdEFQSS5yZXNvdXJjZXMiXV07 Cit9CisKKy0gKHZvaWQpc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOihOU1N0cmluZyAq KXBhZ2VOYW1lCit7CisgICAgW3NlbGYgbG9hZFRlc3RQYWdlTmFtZWQ6cGFnZU5hbWVdOworICAg IFtzZWxmIF90ZXN0X3dhaXRGb3JEaWRGaW5pc2hOYXZpZ2F0aW9uXTsKK30KKwogLSAoQk9PTClf c3luY2hyb25vdXNseUV4ZWN1dGVFZGl0Q29tbWFuZDooTlNTdHJpbmcgKiljb21tYW5kIGFyZ3Vt ZW50OihOU1N0cmluZyAqKWFyZ3VtZW50CiB7CiAgICAgX19ibG9jayBib29sIGRvbmUgPSBmYWxz ZTsKQEAgLTM0MywyOSArMzY2LDYgQEAgLSAodm9pZClwZXJmb3JtQWZ0ZXJSZWNlaXZpbmdNZXNz YWdlOihOU1N0cmluZyAqKW1lc3NhZ2UgYWN0aW9uOihkaXNwYXRjaF9ibG9ja18KICAgICBbX3Rl c3RIYW5kbGVyIGFkZE1lc3NhZ2U6bWVzc2FnZSB3aXRoSGFuZGxlcjphY3Rpb25dOwogfQogCi0t ICh2b2lkKWxvYWRUZXN0UGFnZU5hbWVkOihOU1N0cmluZyAqKXBhZ2VOYW1lCi17Ci0gICAgTlNV UkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbW05TQnVu ZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291cmNlOnBhZ2VOYW1lIHdpdGhFeHRlbnNpb246QCJo dG1sIiBzdWJkaXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdXTsKLSAgICBbc2Vs ZiBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKLX0KLQotLSAodm9pZClzeW5jaHJvbm91c2x5TG9hZEhU TUxTdHJpbmc6KE5TU3RyaW5nICopaHRtbCBiYXNlVVJMOihOU1VSTCAqKXVybAotewotICAgIFtz ZWxmIGxvYWRIVE1MU3RyaW5nOmh0bWwgYmFzZVVSTDp1cmxdOwotICAgIFtzZWxmIF90ZXN0X3dh aXRGb3JEaWRGaW5pc2hOYXZpZ2F0aW9uXTsKLX0KLQotLSAodm9pZClzeW5jaHJvbm91c2x5TG9h ZEhUTUxTdHJpbmc6KE5TU3RyaW5nICopaHRtbAotewotICAgIFtzZWxmIHN5bmNocm9ub3VzbHlM b2FkSFRNTFN0cmluZzpodG1sIGJhc2VVUkw6W1tbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gYnVuZGxl VVJMXSBVUkxCeUFwcGVuZGluZ1BhdGhDb21wb25lbnQ6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNl cyJdXTsKLX0KLQotLSAodm9pZClzeW5jaHJvbm91c2x5TG9hZFRlc3RQYWdlTmFtZWQ6KE5TU3Ry aW5nICopcGFnZU5hbWUKLXsKLSAgICBbc2VsZiBsb2FkVGVzdFBhZ2VOYW1lZDpwYWdlTmFtZV07 Ci0gICAgW3NlbGYgX3Rlc3Rfd2FpdEZvckRpZEZpbmlzaE5hdmlnYXRpb25dOwotfQotCiAtICh2 b2lkKXdhaXRGb3JNZXNzYWdlOihOU1N0cmluZyAqKW1lc3NhZ2UKIHsKICAgICBfX2Jsb2NrIGJv b2wgaXNEb25lV2FpdGluZyA9IGZhbHNlOwo=