196210 2019-03-25 12:55:32 -0700 Get rid of WebPage::m_shouldResetDrawingAreaAfterSuspend flag 2019-03-25 14:28:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren koivisto rniwa thorton webkit-bug-importer oldest_to_newest 1520957 0 cdumez 2019-03-25 12:55:32 -0700 Get rid of WebPage::m_shouldResetDrawingAreaAfterSuspend flag and use the drawing area identifier instead to reset the DrawingArea in the WebProcess whenever the UIProcess did. This is less error-prone and guarantees that the WebProcess and the UIProcess can reliably communicate via DrawingArea IPC. 1520958 1 cdumez 2019-03-25 12:56:02 -0700 <rdar://problem/48681326> 1520961 2 365885 cdumez 2019-03-25 12:57:23 -0700 Created attachment 365885 Patch 1520965 3 thorton 2019-03-25 13:04:07 -0700 seems reasonable to me (but no r? ?) 1520968 4 cdumez 2019-03-25 13:08:29 -0700 (In reply to Tim Horton from comment #3) > seems reasonable to me (but no r? ?) Oops, it's Monday. 1520970 5 365885 ggaren 2019-03-25 13:12:42 -0700 Comment on attachment 365885 Patch r=me, since Tim didn't complain that numbers should always count up :P 1520996 6 365885 commit-queue 2019-03-25 13:55:50 -0700 Comment on attachment 365885 Patch Rejecting attachment 365885 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365885, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365885&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196210&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 365885 from bug 196210. Fetching: https://bugs.webkit.org/attachment.cgi?id=365885 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 73838d6a01ce16a312311b8329d4cd4cca5c638e and refs/remotes/origin/master differ, using rebase: :040000 040000 028b6442b4be5bac4e79bb6d348ab54c9e5aede9 0574addc16e1cee7c921acedf98913efa3c95281 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 73838d6a01ce16a312311b8329d4cd4cca5c638e and refs/remotes/origin/master differ, using rebase: :040000 040000 028b6442b4be5bac4e79bb6d348ab54c9e5aede9 0574addc16e1cee7c921acedf98913efa3c95281 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 1f7f7ee9f80..a9a2b47dd47 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 243451 = 1f7f7ee9f80f303efe0e23fd56a756a8f0ad4171 r243452 = 3403c502d4cb52c876200beb20cee9ff573df185 r243453 = a9a2b47dd4700634d2f40c33e1a612af8a5464df Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11663578 1521025 7 365885 commit-queue 2019-03-25 14:28:15 -0700 Comment on attachment 365885 Patch Clearing flags on attachment: 365885 Committed r243461: <https://trac.webkit.org/changeset/243461> 1521026 8 commit-queue 2019-03-25 14:28:17 -0700 All reviewed patches have been landed. Closing bug. 365885 2019-03-25 12:57:23 -0700 2019-03-25 14:28:15 -0700 Patch bug-196210-20190325125722.patch text/plain 3782 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiNTYwYzRmNzQ0ODdjZWUy MmUyZGJmOTk2YjRiZGU0YjU0NjUwZmUuLjBmMzM3M2VmYjliMTM0MGRkYjA2ZDRlNGFlZTZmODIx ZDE0OGI3YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDMtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBHZXQgcmlkIG9mIFdlYlBhZ2U6Om1f c2hvdWxkUmVzZXREcmF3aW5nQXJlYUFmdGVyU3VzcGVuZCBmbGFnCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyMTAKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ4NjgxMzI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEdldCByaWQgb2YgV2ViUGFnZTo6bV9zaG91bGRSZXNldERyYXdpbmdBcmVhQWZ0 ZXJTdXNwZW5kIGZsYWcgYW5kIHVzZSB0aGUgZHJhd2luZyBhcmVhIGlkZW50aWZpZXIKKyAgICAg ICAgaW5zdGVhZCB0byByZXNldCB0aGUgRHJhd2luZ0FyZWEgaW4gdGhlIFdlYlByb2Nlc3Mgd2hl bmV2ZXIgdGhlIFVJUHJvY2VzcyBkaWQuCisKKyAgICAgICAgVGhpcyBpcyBsZXNzIGVycm9yLXBy b25lIGFuZCBndWFyYW50ZWVzIHRoYXQgdGhlIFdlYlByb2Nlc3MgYW5kIHRoZSBVSVByb2Nlc3Mg Y2FuIHJlbGlhYmx5CisgICAgICAgIGNvbW11bmljYXRlIHZpYSBEcmF3aW5nQXJlYSBJUEMuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2U6OnJlaW5pdGlhbGl6ZVdlYlBhZ2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQ YWdlOjpzZXRJc1N1c3BlbmRlZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuaDoKKwogMjAxOS0wMy0yNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgW0FwcGxlIFBheV0gUmVtb3ZlIHRoZSBBdmFpbGFibGVQYXltZW50TmV0d29ya3Mgc3lu Y2hyb25vdXMgbWVzc2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAppbmRleCA3MWE2ZTcwMDAzY2RkOGMxOTVmNWY2Njc5Mjk5ZTllYTc5ZTgzMTFmLi5h N2NmMThlNmVlZGQxZGM3Mzc4Mjg2ZTBlM2MwMWQ2ZjBiYTUyODYzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtNzI0LDEwICs3MjQsMTAgQEAg dm9pZCBXZWJQYWdlOjpyZWluaXRpYWxpemVXZWJQYWdlKFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRl cnMmJiBwYXJhbWV0ZXJzKQogCiAgICAgc2V0U2l6ZShwYXJhbWV0ZXJzLnZpZXdTaXplKTsKIAot ICAgIGlmIChtX3Nob3VsZFJlc2V0RHJhd2luZ0FyZWFBZnRlclN1c3BlbmQpIHsKKyAgICAvLyBJ ZiB0aGUgVUlQcm9jZXNzIGNyZWF0ZWQgYSBuZXcgRHJhd2luZ0FyZWEsIHRoZW4gd2UgbmVlZCB0 byBkbyB0aGUgc2FtZS4KKyAgICBpZiAobV9kcmF3aW5nQXJlYS0+aWRlbnRpZmllcigpICE9IHBh cmFtZXRlcnMuZHJhd2luZ0FyZWFJZGVudGlmaWVyKSB7CiAgICAgICAgIGF1dG8gb2xkRHJhd2lu Z0FyZWEgPSBzdGQ6OmV4Y2hhbmdlKG1fZHJhd2luZ0FyZWEsIG51bGxwdHIpOwogICAgICAgICBv bGREcmF3aW5nQXJlYS0+cmVtb3ZlTWVzc2FnZVJlY2VpdmVySWZOZWVkZWQoKTsKLSAgICAgICAg bV9zaG91bGRSZXNldERyYXdpbmdBcmVhQWZ0ZXJTdXNwZW5kID0gZmFsc2U7CiAKICAgICAgICAg bV9kcmF3aW5nQXJlYSA9IERyYXdpbmdBcmVhOjpjcmVhdGUoKnRoaXMsIHBhcmFtZXRlcnMpOwog ICAgICAgICBtX2RyYXdpbmdBcmVhLT5zZXRQYWludGluZ0VuYWJsZWQoZmFsc2UpOwpAQCAtNzM5 LDcgKzczOSw2IEBAIHZvaWQgV2ViUGFnZTo6cmVpbml0aWFsaXplV2ViUGFnZShXZWJQYWdlQ3Jl YXRpb25QYXJhbWV0ZXJzJiYgcGFyYW1ldGVycykKIAogICAgICAgICB1bmZyZWV6ZUxheWVyVHJl ZShMYXllclRyZWVGcmVlemVSZWFzb246OlBhZ2VTdXNwZW5kZWQpOwogICAgIH0KLSAgICBSRUxF QVNFX0FTU0VSVChtX2RyYXdpbmdBcmVhLT5pZGVudGlmaWVyKCkgPT0gcGFyYW1ldGVycy5kcmF3 aW5nQXJlYUlkZW50aWZpZXIpOwogCiAgICAgc2V0Vmlld0xheW91dFNpemUocGFyYW1ldGVycy52 aWV3TGF5b3V0U2l6ZSk7CiAKQEAgLTYzMjEsMTUgKzYzMjAsMTUgQEAgdm9pZCBXZWJQYWdlOjpz ZXRJc1N1c3BlbmRlZChib29sIHN1c3BlbmRlZCkKIAogICAgIG1faXNTdXNwZW5kZWQgPSBzdXNw ZW5kZWQ7CiAKLSAgICBpZiAobV9pc1N1c3BlbmRlZCkgewotICAgICAgICAvLyBVbmZyb3plbiBv biBkcmF3aW5nIGFyZWEgcmVzZXQuCi0gICAgICAgIGZyZWV6ZUxheWVyVHJlZShMYXllclRyZWVG cmVlemVSZWFzb246OlBhZ2VTdXNwZW5kZWQpOworICAgIGlmICghc3VzcGVuZGVkKQorICAgICAg ICByZXR1cm47CiAKLSAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuc2VuZFByZXdhcm1J bmZvcm1hdGlvbihtYWluV2ViRnJhbWUoKS0+dXJsKCkpOworICAgIC8vIFVuZnJvemVuIG9uIGRy YXdpbmcgYXJlYSByZXNldC4KKyAgICBmcmVlemVMYXllclRyZWUoTGF5ZXJUcmVlRnJlZXplUmVh c29uOjpQYWdlU3VzcGVuZGVkKTsKIAotICAgICAgICBzdXNwZW5kRm9yUHJvY2Vzc1N3YXAoKTsK LSAgICB9IGVsc2UKLSAgICAgICAgbV9zaG91bGRSZXNldERyYXdpbmdBcmVhQWZ0ZXJTdXNwZW5k ID0gdHJ1ZTsKKyAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5zZW5kUHJld2FybUluZm9ybWF0 aW9uKG1haW5XZWJGcmFtZSgpLT51cmwoKSk7CisKKyAgICBzdXNwZW5kRm9yUHJvY2Vzc1N3YXAo KTsKIH0KIAogdm9pZCBXZWJQYWdlOjpmcmFtZUJlY2FtZVJlbW90ZSh1aW50NjRfdCBmcmFtZUlE LCBHbG9iYWxGcmFtZUlkZW50aWZpZXImJiByZW1vdGVGcmFtZUlkZW50aWZpZXIsIEdsb2JhbFdp bmRvd0lkZW50aWZpZXImJiByZW1vdGVXaW5kb3dJZGVudGlmaWVyKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IDcxN2M0OThmNWIzNzBlOGMyOWUyNDRj ZDQ3NTRhM2UxYTZiMDVmODcuLjgxYjY5MmM2ZmQ4OWFhN2I5Mzk3YmRmYjFiYTUxNTgxYWViZDYz ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu aAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTE1 NjEsNyArMTU2MSw2IEBAIHByaXZhdGU6CiAKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fdmlld1Np emU7CiAgICAgc3RkOjp1bmlxdWVfcHRyPERyYXdpbmdBcmVhPiBtX2RyYXdpbmdBcmVhOwotICAg IGJvb2wgbV9zaG91bGRSZXNldERyYXdpbmdBcmVhQWZ0ZXJTdXNwZW5kIHsgZmFsc2UgfTsKIAog ICAgIEhhc2hTZXQ8UGx1Z2luVmlldyo+IG1fcGx1Z2luVmlld3M7CiAgICAgYm9vbCBtX2hhc1Nl ZW5QbHVnaW4geyBmYWxzZSB9Owo=